From 93e6c30435443bad38414b745845fb1d3fa6963e Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Thu, 10 Aug 2023 09:12:04 -0400 Subject: [PATCH] fat: remove i_version handling from fat_update_time commit 6bb885ecd746 (fat: add functions to update and truncate timestamps appropriately") added an update_time routine for fat. That patch added a section for handling the S_VERSION bit, even though FAT doesn't enable SB_I_VERSION and the S_VERSION bit will never be set when calling it. Remove the section for handling S_VERSION since it's effectively dead code, and will be problematic vs. future changes. Cc: Frank Sorenson Signed-off-by: Jeff Layton Acked-by: OGAWA Hirofumi Reviewed-by: Jan Kara Reviewed-by: Frank Sorenson Message-Id: <20230810-ctime-fat-v1-1-327598fd1de8@kernel.org> Signed-off-by: Christian Brauner --- fs/fat/misc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/fat/misc.c b/fs/fat/misc.c index 67006ea08db6..620436777f98 100644 --- a/fs/fat/misc.c +++ b/fs/fat/misc.c @@ -354,9 +354,6 @@ int fat_update_time(struct inode *inode, struct timespec64 *now, int flags) dirty_flags |= I_DIRTY_SYNC; } - if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) - dirty_flags |= I_DIRTY_SYNC; - __mark_inode_dirty(inode, dirty_flags); return 0; }