From 258aa130f45a811b90f3329a2f27e4ba43a7f4ae Mon Sep 17 00:00:00 2001 From: Richard Shiue <71320345+richardshiue@users.noreply.github.com> Date: Tue, 8 Apr 2025 12:46:38 +0800 Subject: [PATCH] chore: use MentionType instead --- .../editor_plugins/base/insert_page_command.dart | 2 +- .../copy_and_paste/paste_from_block_link.dart | 2 +- .../mention/child_page_transaction_handler.dart | 2 +- .../presentation/editor_plugins/mention/mention_block.dart | 4 ++-- .../editor_plugins/mention/mention_page_block.dart | 6 +++--- .../lib/plugins/inline_actions/handlers/child_page.dart | 2 +- .../inline_actions/handlers/inline_page_reference.dart | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart index 9cf78b2e33..11aed036d2 100644 --- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart +++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart @@ -72,7 +72,7 @@ extension InsertDatabase on EditorState { 0, MentionBlockKeys.mentionChar, attributes: MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.page.name, + mentionType: MentionType.page, pageId: view.id, blockId: null, ), diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_block_link.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_block_link.dart index 0e6da45ecb..c47c0c967d 100644 --- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_block_link.dart +++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_block_link.dart @@ -44,7 +44,7 @@ extension PasteFromBlockLink on EditorState { selection.startIndex, MentionBlockKeys.mentionChar, attributes: MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.page.name, + mentionType: MentionType.page, pageId: pageId, blockId: blockId, ), diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart index aef0d67221..117e09e67f 100644 --- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart +++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart @@ -196,7 +196,7 @@ class ChildPageTransactionHandler extends MentionTransactionHandler { mentionIndex, MentionBlockKeys.mentionChar.length, MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.childPage.name, + mentionType: MentionType.childPage, pageId: newView.id, blockId: null, ), diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart index cd6d738271..79c9b31d20 100644 --- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart +++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart @@ -57,13 +57,13 @@ class MentionBlockKeys { static const mentionChar = '\$'; static Map buildMentionPageAttributes({ - required String mentionType, + required MentionType mentionType, required String pageId, required String? blockId, }) { return { MentionBlockKeys.mention: { - MentionBlockKeys.type: mentionType, + MentionBlockKeys.type: mentionType.name, MentionBlockKeys.pageId: pageId, if (blockId != null) MentionBlockKeys.blockId: blockId, }, diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart index 28231e919b..ede690eb30 100644 --- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart +++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart @@ -51,7 +51,7 @@ Node pageMentionNode(String viewId) { TextInsert( MentionBlockKeys.mentionChar, attributes: MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.page.name, + mentionType: MentionType.page, pageId: viewId, blockId: null, ), @@ -284,7 +284,7 @@ class _MentionSubPageBlockState extends State { widget.index, MentionBlockKeys.mentionChar.length, MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.page.name, + mentionType: MentionType.page, pageId: widget.pageId, blockId: null, ), @@ -395,7 +395,7 @@ Future _handleDoubleTap( index, 1, MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.page.name, + mentionType: MentionType.page, pageId: newView.id, blockId: null, ), diff --git a/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/child_page.dart b/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/child_page.dart index cfe0a0f9f3..665c284aea 100644 --- a/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/child_page.dart +++ b/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/child_page.dart @@ -72,7 +72,7 @@ class InlineChildPageService extends InlineActionsDelegate { replacement.$2, MentionBlockKeys.mentionChar, attributes: MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.childPage.name, + mentionType: MentionType.childPage, pageId: view.id, blockId: null, ), diff --git a/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart b/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart index d8e64fc965..ebc684327b 100644 --- a/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart +++ b/frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart @@ -222,7 +222,7 @@ class InlinePageReferenceService extends InlineActionsDelegate { replace.$2, MentionBlockKeys.mentionChar, attributes: MentionBlockKeys.buildMentionPageAttributes( - mentionType: MentionType.page.name, + mentionType: MentionType.page, pageId: view.id, blockId: null, ),