diff --git a/libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java b/libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java index b3200c756890..c7460d4a611f 100644 --- a/libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java +++ b/libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java @@ -43,14 +43,14 @@ public class EntitlementBootstrap { Function, PolicyManager.PolicyScope> scopeResolver, PathLookup pathLookup, Map sourcePaths, - Set> suppressFailureLogClasses + Set suppressFailureLogPackages ) { public BootstrapArgs { requireNonNull(pluginPolicies); requireNonNull(scopeResolver); requireNonNull(pathLookup); requireNonNull(sourcePaths); - requireNonNull(suppressFailureLogClasses); + requireNonNull(suppressFailureLogPackages); } } @@ -78,7 +78,7 @@ public class EntitlementBootstrap { * @param tempDir the temp directory for Elasticsearch * @param logsDir the log directory for Elasticsearch * @param pidFile path to a pid file for Elasticsearch, or {@code null} if one was not specified - * @param suppressFailureLogClasses classes for which we do not need or want to log Entitlements failures + * @param suppressFailureLogPackages packages for which we do not need or want to log Entitlements failures */ public static void bootstrap( Policy serverPolicyPatch, @@ -95,7 +95,7 @@ public class EntitlementBootstrap { Path logsDir, Path tempDir, Path pidFile, - Set> suppressFailureLogClasses + Set suppressFailureLogPackages ) { logger.debug("Loading entitlement agent"); if (EntitlementBootstrap.bootstrapArgs != null) { @@ -119,7 +119,7 @@ public class EntitlementBootstrap { settingResolver ), sourcePaths, - suppressFailureLogClasses + suppressFailureLogPackages ); exportInitializationToAgent(); loadAgent(findAgentJar()); diff --git a/libs/entitlement/src/main/java/org/elasticsearch/entitlement/initialization/EntitlementInitialization.java b/libs/entitlement/src/main/java/org/elasticsearch/entitlement/initialization/EntitlementInitialization.java index bd7c946fc164..867ee2cdcbc1 100644 --- a/libs/entitlement/src/main/java/org/elasticsearch/entitlement/initialization/EntitlementInitialization.java +++ b/libs/entitlement/src/main/java/org/elasticsearch/entitlement/initialization/EntitlementInitialization.java @@ -90,7 +90,7 @@ public class EntitlementInitialization { EntitlementBootstrap.bootstrapArgs().sourcePaths(), ENTITLEMENTS_MODULE, pathLookup, - bootstrapArgs.suppressFailureLogClasses() + bootstrapArgs.suppressFailureLogPackages() ); } diff --git a/libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java b/libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java index aa901e9900d1..053d257d814d 100644 --- a/libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java +++ b/libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java @@ -256,7 +256,7 @@ public class PolicyManager { private final Map>> pluginsEntitlements; private final Function, PolicyScope> scopeResolver; private final PathLookup pathLookup; - private final Set> mutedClasses; + private final Set suppressFailureLogPackages; public static final String ALL_UNNAMED = "ALL-UNNAMED"; @@ -311,7 +311,7 @@ public class PolicyManager { Map sourcePaths, Module entitlementsModule, PathLookup pathLookup, - Set> suppressFailureLogClasses + Set suppressFailureLogPackages ) { this.serverEntitlements = buildScopeEntitlementsMap(requireNonNull(serverPolicy)); this.apmAgentEntitlements = apmAgentEntitlements; @@ -322,7 +322,7 @@ public class PolicyManager { this.sourcePaths = sourcePaths; this.entitlementsModule = entitlementsModule; this.pathLookup = requireNonNull(pathLookup); - this.mutedClasses = suppressFailureLogClasses; + this.suppressFailureLogPackages = suppressFailureLogPackages; List exclusiveFileEntitlements = new ArrayList<>(); for (var e : serverEntitlements.entrySet()) { @@ -688,8 +688,8 @@ public class PolicyManager { private void notEntitled(String message, Class callerClass, ModuleEntitlements entitlements) { var exception = new NotEntitledException(message); - // Don't emit a log for muted classes, e.g. classes containing self tests - if (mutedClasses.contains(callerClass) == false) { + // Don't emit a log for suppressed packages, e.g. packages containing self tests + if (suppressFailureLogPackages.contains(callerClass.getPackage()) == false) { entitlements.logger().warn("Not entitled: {}", message, exception); } throw exception; diff --git a/server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java b/server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java index 8ad85d016834..715e5bd8e1bd 100644 --- a/server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java +++ b/server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java @@ -282,7 +282,7 @@ class Elasticsearch { nodeEnv.logsDir(), nodeEnv.tmpDir(), args.pidFile(), - Set.of(EntitlementSelfTester.class) + Set.of(EntitlementSelfTester.class.getPackage()) ); EntitlementSelfTester.entitlementSelfTest(); } else {