From 281c702988c3b74b07994fe7acf258dec57aa427 Mon Sep 17 00:00:00 2001 From: Dimitris Athanasiou Date: Wed, 14 Oct 2020 15:54:23 +0300 Subject: [PATCH] [ML] Remove unused method AutodetectParams.Builder.setFilters (#63662) --- .../job/process/autodetect/params/AutodetectParams.java | 8 +------- .../process/autodetect/AutodetectProcessManagerTests.java | 4 ---- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParams.java b/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParams.java index 7c56d9db1d08..4d84e1d8a614 100644 --- a/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParams.java +++ b/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/params/AutodetectParams.java @@ -110,14 +110,13 @@ public class AutodetectParams { private TimingStats timingStats; private ModelSnapshot modelSnapshot; private Quantiles quantiles; - private Set filters; + private final Set filters = new HashSet<>(); private List scheduledEvents; public Builder(String jobId) { dataCounts = new DataCounts(jobId); modelSizeStats = new ModelSizeStats.Builder(jobId).build(); timingStats = new TimingStats(jobId); - filters = new HashSet<>(); scheduledEvents = new ArrayList<>(); } @@ -160,11 +159,6 @@ public class AutodetectParams { return this; } - public Builder setFilters(Set filters) { - filters = Objects.requireNonNull(filters); - return this; - } - public AutodetectParams build() { return new AutodetectParams(dataCounts, modelSizeStats, timingStats, modelSnapshot, quantiles, filters, scheduledEvents); diff --git a/x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManagerTests.java b/x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManagerTests.java index 25f3762dd7fa..6c0f43273d3e 100644 --- a/x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManagerTests.java +++ b/x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManagerTests.java @@ -38,7 +38,6 @@ import org.elasticsearch.xpack.core.ml.job.config.Job; import org.elasticsearch.xpack.core.ml.job.config.JobState; import org.elasticsearch.xpack.core.ml.job.config.JobTaskState; import org.elasticsearch.xpack.core.ml.job.config.JobUpdate; -import org.elasticsearch.xpack.core.ml.job.config.MlFilter; import org.elasticsearch.xpack.core.ml.job.config.ModelPlotConfig; import org.elasticsearch.xpack.core.ml.job.persistence.AnomalyDetectorsIndex; import org.elasticsearch.xpack.core.ml.job.persistence.AnomalyDetectorsIndexFields; @@ -75,7 +74,6 @@ import java.util.Date; import java.util.HashSet; import java.util.List; import java.util.Optional; -import java.util.Set; import java.util.concurrent.Callable; import java.util.concurrent.CountDownLatch; import java.util.concurrent.ExecutorService; @@ -137,7 +135,6 @@ public class AutodetectProcessManagerTests extends ESTestCase { private ModelSizeStats modelSizeStats = new ModelSizeStats.Builder("foo").build(); private ModelSnapshot modelSnapshot = new ModelSnapshot.Builder("foo").build(); private Quantiles quantiles = new Quantiles("foo", new Date(), "state"); - private Set filters = new HashSet<>(); @Before public void setup() throws Exception { @@ -707,7 +704,6 @@ public class AutodetectProcessManagerTests extends ESTestCase { .setModelSizeStats(modelSizeStats) .setModelSnapshot(modelSnapshot) .setQuantiles(quantiles) - .setFilters(filters) .build(); }