diff --git a/docs/changelog/88462.yaml b/docs/changelog/88462.yaml new file mode 100644 index 000000000000..f391ee08822f --- /dev/null +++ b/docs/changelog/88462.yaml @@ -0,0 +1,5 @@ +pr: 88462 +summary: Update Tableau connector to use connection dialog v2 +area: SQL +type: enhancement +issues: [] diff --git a/x-pack/plugin/sql/connectors/tableau/connector/connection-dialog.tcd b/x-pack/plugin/sql/connectors/tableau/connector/connection-dialog.tcd deleted file mode 100644 index 48d147b1aaae..000000000000 --- a/x-pack/plugin/sql/connectors/tableau/connector/connection-dialog.tcd +++ /dev/null @@ -1,11 +0,0 @@ - - - - - - - - - - diff --git a/x-pack/plugin/sql/connectors/tableau/connector/connectionFields.xml b/x-pack/plugin/sql/connectors/tableau/connector/connectionFields.xml new file mode 100644 index 000000000000..a55edf92ee04 --- /dev/null +++ b/x-pack/plugin/sql/connectors/tableau/connector/connectionFields.xml @@ -0,0 +1,30 @@ + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/x-pack/plugin/sql/connectors/tableau/connector/connectionMetadata.xml b/x-pack/plugin/sql/connectors/tableau/connector/connectionMetadata.xml new file mode 100644 index 000000000000..d7bf1b3e73cb --- /dev/null +++ b/x-pack/plugin/sql/connectors/tableau/connector/connectionMetadata.xml @@ -0,0 +1,14 @@ + + + + + + + + + diff --git a/x-pack/plugin/sql/connectors/tableau/connector/connectionProperties.js b/x-pack/plugin/sql/connectors/tableau/connector/connectionProperties.js index c3defb2721aa..1bc75eb45c5b 100644 --- a/x-pack/plugin/sql/connectors/tableau/connector/connectionProperties.js +++ b/x-pack/plugin/sql/connectors/tableau/connector/connectionProperties.js @@ -4,7 +4,7 @@ props["user"] = attr["username"]; props["password"] = attr["password"]; - var extraProps = attr[connectionHelper.attributeWarehouse]; + var extraProps = attr[connectionHelper.attributeVendor1]; if (extraProps != null && extraProps.trim().length > 0) { // allow `&` and white-space as attribue-value pair delimiters var avps = extraProps.trim().split(/[\s&]/); diff --git a/x-pack/plugin/sql/connectors/tableau/connector/connectionResolver.tdr b/x-pack/plugin/sql/connectors/tableau/connector/connectionResolver.tdr index adb12135ffb3..ee125ac3532c 100644 --- a/x-pack/plugin/sql/connectors/tableau/connector/connectionResolver.tdr +++ b/x-pack/plugin/sql/connectors/tableau/connector/connectionResolver.tdr @@ -7,14 +7,13 @@ - class server port + authentication username password - dbname sslmode - warehouse + vendor1 diff --git a/x-pack/plugin/sql/connectors/tableau/connector/manifest.xml b/x-pack/plugin/sql/connectors/tableau/connector/manifest.xml index c87e6575b3fa..f3651c6f7dc0 100644 --- a/x-pack/plugin/sql/connectors/tableau/connector/manifest.xml +++ b/x-pack/plugin/sql/connectors/tableau/connector/manifest.xml @@ -32,7 +32,8 @@ - + + diff --git a/x-pack/plugin/sql/connectors/tableau/package.sh b/x-pack/plugin/sql/connectors/tableau/package.sh index 2e18baeeb4c2..2e936af4343b 100755 --- a/x-pack/plugin/sql/connectors/tableau/package.sh +++ b/x-pack/plugin/sql/connectors/tableau/package.sh @@ -12,7 +12,7 @@ set -e TSA_URL=http://timestamp.digicert.com TAB_SDK_REPO=https://github.com/tableau/connector-plugin-sdk -TAB_SDK_TAG="tdvt-2.1.9" +TAB_SDK_TAG="tdvt-2.6.1" MY_NAME="Packager for Elastic's Tableau connector to Elasticsearch" MY_FILE=$(basename $0) diff --git a/x-pack/plugin/sql/connectors/tableau/setup.py.diff b/x-pack/plugin/sql/connectors/tableau/setup.py.diff index 83153176c4fe..fef89c09cb4a 100644 --- a/x-pack/plugin/sql/connectors/tableau/setup.py.diff +++ b/x-pack/plugin/sql/connectors/tableau/setup.py.diff @@ -1,13 +1,13 @@ diff --git a/connector-packager/setup.py b/connector-packager/setup.py -index 1601492..eb1cc27 100644 +index e84c8a0..ceab20f 100644 --- a/connector-packager/setup.py +++ b/connector-packager/setup.py @@ -16,7 +16,7 @@ setup( description='A Python module for packaging a Tableau connector.', test_suite='tests', python_requires='>3.7', -- install_requires=['xmlschema', 'defusedxml'], -+ install_requires=['elementpath==2.4.0', 'xmlschema==1.9.2', 'defusedxml==0.7.1'], +- install_requires=['xmlschema', 'defusedxml', 'packaging'], ++ install_requires=['elementpath==3.0.0', 'xmlschema==2.0.1', 'defusedxml==0.7.1', 'packaging==21.3'], tests_require=['six'], include_package_data=True )