From c752fbab35b76e009ed2d9a24e0bb57511854d94 Mon Sep 17 00:00:00 2001 From: Simon Cooper Date: Wed, 26 Jun 2024 17:05:16 +0100 Subject: [PATCH] Don't run the JVM crash test on windows (#110194) --- muted-tests.yml | 3 --- .../java/org/elasticsearch/test/jvm_crash/JvmCrashIT.java | 7 +++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index 00965b1a8991..9ba6eaa46264 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -73,9 +73,6 @@ tests: - class: org.elasticsearch.xpack.transform.transforms.TransformIndexerTests method: testMaxPageSearchSizeIsResetToConfiguredValue issue: https://github.com/elastic/elasticsearch/issues/109844 -- class: "org.elasticsearch.test.jvm_crash.JvmCrashIT" - issue: "https://github.com/elastic/elasticsearch/issues/110052" - method: "testJvmCrash" # Examples: # diff --git a/test/external-modules/jvm-crash/src/javaRestTest/java/org/elasticsearch/test/jvm_crash/JvmCrashIT.java b/test/external-modules/jvm-crash/src/javaRestTest/java/org/elasticsearch/test/jvm_crash/JvmCrashIT.java index 3e73310ee824..517cb5b65a52 100644 --- a/test/external-modules/jvm-crash/src/javaRestTest/java/org/elasticsearch/test/jvm_crash/JvmCrashIT.java +++ b/test/external-modules/jvm-crash/src/javaRestTest/java/org/elasticsearch/test/jvm_crash/JvmCrashIT.java @@ -22,9 +22,11 @@ import org.elasticsearch.test.cluster.local.distribution.DistributionType; import org.elasticsearch.test.cluster.local.distribution.LocalDistributionResolver; import org.elasticsearch.test.cluster.local.distribution.ReleasedDistributionResolver; import org.elasticsearch.test.cluster.local.distribution.SnapshotDistributionResolver; +import org.elasticsearch.test.cluster.util.OS; import org.elasticsearch.test.rest.ESRestTestCase; import org.hamcrest.Matcher; import org.junit.AfterClass; +import org.junit.BeforeClass; import org.junit.ClassRule; import java.io.BufferedReader; @@ -46,6 +48,11 @@ import static org.hamcrest.Matchers.not; public class JvmCrashIT extends ESRestTestCase { + @BeforeClass + public static void dontRunWindows() { + assumeFalse("JVM crash log doesn't go to stdout on windows", OS.current() == OS.WINDOWS); + } + private static class StdOutCatchingClusterBuilder extends AbstractLocalClusterSpecBuilder { private StdOutCatchingClusterBuilder() {