From e535df64c5f08059f1605a8b9618cba78b2758fd Mon Sep 17 00:00:00 2001 From: Kiyoung's Noona Date: Thu, 12 Jan 2023 07:54:44 +0900 Subject: [PATCH] Fix typo in nori docs and tests (#92336) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit C샤프 in English is C#, not C++. (C++ in Korean is C플플, C쁠쁠 or C플러스플러스.) The translation doesn't make sense, so I changed C++ to C#. It might be true that the writer used C샤프 as just an independent example, regardless C++, but I think it is better to align them for better understanding. --- docs/plugins/analysis-nori.asciidoc | 4 ++-- docs/src/test/cluster/config/userdict_ko.txt | 4 ++-- .../elasticsearch/plugin/analysis/nori/NoriAnalysisTests.java | 4 ++-- .../org/elasticsearch/plugin/analysis/nori/user_dict.txt | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/plugins/analysis-nori.asciidoc b/docs/plugins/analysis-nori.asciidoc index 6a2e7c767bab..1f37a31496c0 100644 --- a/docs/plugins/analysis-nori.asciidoc +++ b/docs/plugins/analysis-nori.asciidoc @@ -82,7 +82,7 @@ dictionary to `$ES_HOME/config/userdict_ko.txt`: [source,txt] ----------------------- c++ <1> -C샤프 +C쁠쁠 세종 세종시 세종 시 <2> ----------------------- @@ -176,7 +176,7 @@ PUT nori_sample "nori_user_dict": { "type": "nori_tokenizer", "decompound_mode": "mixed", - "user_dictionary_rules": ["c++", "C샤프", "세종", "세종시 세종 시"] + "user_dictionary_rules": ["c++", "C쁠쁠", "세종", "세종시 세종 시"] } }, "analyzer": { diff --git a/docs/src/test/cluster/config/userdict_ko.txt b/docs/src/test/cluster/config/userdict_ko.txt index 63c1c3a1e224..b70fb43a0092 100644 --- a/docs/src/test/cluster/config/userdict_ko.txt +++ b/docs/src/test/cluster/config/userdict_ko.txt @@ -1,5 +1,5 @@ # Additional nouns c++ -C샤프 +C쁠쁠 세종 -세종시 세종 시 \ No newline at end of file +세종시 세종 시 diff --git a/plugins/analysis-nori/src/test/java/org/elasticsearch/plugin/analysis/nori/NoriAnalysisTests.java b/plugins/analysis-nori/src/test/java/org/elasticsearch/plugin/analysis/nori/NoriAnalysisTests.java index 994ebffb9af6..c9fbef0d20ad 100644 --- a/plugins/analysis-nori/src/test/java/org/elasticsearch/plugin/analysis/nori/NoriAnalysisTests.java +++ b/plugins/analysis-nori/src/test/java/org/elasticsearch/plugin/analysis/nori/NoriAnalysisTests.java @@ -75,7 +75,7 @@ public class NoriAnalysisTests extends ESTokenStreamTestCase { public void testNoriAnalyzerUserDict() throws Exception { Settings settings = Settings.builder() .put("index.analysis.analyzer.my_analyzer.type", "nori") - .putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C샤프", "세종", "세종시 세종 시") + .putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C쁠쁠", "세종", "세종시 세종 시") .build(); TestAnalysis analysis = createTestAnalysis(settings); Analyzer analyzer = analysis.indexAnalyzers.get("my_analyzer"); @@ -108,7 +108,7 @@ public class NoriAnalysisTests extends ESTokenStreamTestCase { Settings settings = Settings.builder() .put("index.analysis.analyzer.my_analyzer.type", "nori") .put("index.analysis.analyzer.my_analyzer.user_dictionary", "user_dict.txt") - .putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C샤프", "세종", "세종시 세종 시") + .putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C쁠쁠", "세종", "세종시 세종 시") .build(); IllegalArgumentException exc = expectThrows(IllegalArgumentException.class, () -> createTestAnalysis(settings)); assertThat( diff --git a/plugins/analysis-nori/src/test/resources/org/elasticsearch/plugin/analysis/nori/user_dict.txt b/plugins/analysis-nori/src/test/resources/org/elasticsearch/plugin/analysis/nori/user_dict.txt index 63c1c3a1e224..b70fb43a0092 100644 --- a/plugins/analysis-nori/src/test/resources/org/elasticsearch/plugin/analysis/nori/user_dict.txt +++ b/plugins/analysis-nori/src/test/resources/org/elasticsearch/plugin/analysis/nori/user_dict.txt @@ -1,5 +1,5 @@ # Additional nouns c++ -C샤프 +C쁠쁠 세종 -세종시 세종 시 \ No newline at end of file +세종시 세종 시