From fb19e49117e3d987c85b9af670adc8a910bd021d Mon Sep 17 00:00:00 2001
From: Kostas Krikellas <131142368+kkrik-es@users.noreply.github.com>
Date: Tue, 21 Nov 2023 16:17:09 +0200
Subject: [PATCH] Update expected test output (#102412)

A `having` bucket selector errors out when applied to a doc lacking the
expected value in the `buckets_path`. The existing yaml test didn't
reflect that but assumes that such docs don't affect results. Adding a
refresh in the bulk operation exposes this problem.

Fixes #102295
---
 .../rest-api-spec/test/aggregations/top_hits.yml       | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/modules/aggregations/src/yamlRestTest/resources/rest-api-spec/test/aggregations/top_hits.yml b/modules/aggregations/src/yamlRestTest/resources/rest-api-spec/test/aggregations/top_hits.yml
index 4d4848e8aebc..5cf0265374b0 100644
--- a/modules/aggregations/src/yamlRestTest/resources/rest-api-spec/test/aggregations/top_hits.yml
+++ b/modules/aggregations/src/yamlRestTest/resources/rest-api-spec/test/aggregations/top_hits.yml
@@ -600,10 +600,13 @@ synthetic _source:
   - do:
       bulk:
         index: test2
+        refresh: true
         body:
           - { index: { } }
           - { gender: 3 }
   - do:
+      # The script can't process a bucket without a salary value for gender '3'.
+      catch: /path not supported for \[top_salary_hits\]:\ \[_source.salary\]./
       search:
         index: test2
         size: 0
@@ -630,13 +633,6 @@ synthetic _source:
                       ts: top_salary_hits[_source.salary]
                     script: "params.ts < 8000"
 
-  # Empty bucket for gender '3' affects nothing.
-  - length: { aggregations.genders.buckets: 1}
-  - match: { aggregations.genders.buckets.0.top_salary_hits.hits.total.value: 4}
-  - match: { aggregations.genders.buckets.0.top_salary_hits.hits.hits.0._source.gender: 1}
-  - match: { aggregations.genders.buckets.0.top_salary_hits.hits.hits.0._source.salary: 4000}
-  - match: { aggregations.genders.buckets.0.top_salary_hits.hits.hits.0._source.birth_date: 1982}
-
   - do:
       catch: /path not supported for \[top_salary_hits\]:\ \[_source.nosuchfield\]./
       search: