From 15ab023e25469086988165ff49c8ef9b4c8bc81d Mon Sep 17 00:00:00 2001 From: Tom Roberts Date: Fri, 1 May 2020 10:41:04 +0100 Subject: [PATCH] [rtl] Stop regfile writeback for load errors - A data or PMP error should stop the register file from being updated - Fixes #832 Signed-off-by: Tom Roberts --- rtl/ibex_load_store_unit.sv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtl/ibex_load_store_unit.sv b/rtl/ibex_load_store_unit.sv index ec69a3a0..219dba5b 100644 --- a/rtl/ibex_load_store_unit.sv +++ b/rtl/ibex_load_store_unit.sv @@ -476,7 +476,7 @@ module ibex_load_store_unit assign data_or_pmp_err = lsu_err_q | data_err_i | pmp_err_q; assign lsu_resp_valid_o = (data_rvalid_i | pmp_err_q) & (ls_fsm_cs == IDLE); - assign lsu_rdata_valid_o = lsu_resp_valid_o & ~data_we_q; + assign lsu_rdata_valid_o = (ls_fsm_cs == IDLE) & data_rvalid_i & ~data_or_pmp_err & ~data_we_q; // output to register file assign lsu_rdata_o = data_rdata_ext;