From 2e2576fbf5815b35b2c402fde537e8327c7d8514 Mon Sep 17 00:00:00 2001 From: Dzmitry Lemechko Date: Thu, 26 Jun 2025 16:35:10 +0300 Subject: [PATCH] [ska][x-pack] relocate reporting tests (#225333) ## Summary Part of https://github.com/elastic/kibana-team/issues/1503 This PR is mostly about moving tests from x-pack/test/ Before: ``` x-pack/test/ | - reporting_api_integration/ | - reporting_functional/ ``` After: ``` x-pack/platform/test/ | - reporting_api_integration/ | - reporting_functional/ ``` Few page objects, required by functional tests, were relocated as well --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> --- .buildkite/ftr_platform_stateful_configs.yml | 8 ++++---- .github/CODEOWNERS | 8 ++++---- .../test/functional/page_objects/canvas_page.ts | 0 x-pack/platform/test/functional/page_objects/index.ts | 4 ++++ .../test/functional/page_objects/reporting_page.ts | 0 .../reporting_api_integration/ftr_provider_context.d.ts | 0 .../reporting_and_security.config.ts | 0 .../reporting_and_security/bwc_existing_indexes.ts | 0 .../reporting_and_security/csv/__snapshots__/csv_v2.snap | 0 .../csv/__snapshots__/csv_v2_esql.snap | 0 .../csv/__snapshots__/generate_csv_discover.snap | 0 .../reporting_and_security/csv/csv_v2.ts | 0 .../reporting_and_security/csv/csv_v2_esql.ts | 0 .../reporting_and_security/csv/generate_csv_discover.ts | 0 .../reporting_and_security/datastream.ts | 0 .../reporting_and_security/default_reporting_user_role.ts | 0 .../reporting_and_security/disable_scheduled_reports.ts | 0 .../reporting_and_security/ilm_migration_apis.ts | 0 .../reporting_and_security/index.ts | 0 .../reporting_and_security/list_jobs.ts | 0 .../reporting_and_security/list_scheduled_reports.ts | 0 .../reporting_and_security/screenshot/network_policy.ts | 0 .../reporting_and_security/screenshot/validation.ts | 0 .../reporting_and_security/security_roles_privileges.ts | 0 .../reporting_and_security/spaces.ts | 0 .../reporting_without_security.config.ts | 0 .../reporting_without_security/csv/job_apis_csv.ts | 0 .../reporting_without_security/index.ts | 0 .../reporting_without_security/schedule.ts | 0 .../test/reporting_api_integration/services/index.ts | 0 .../reporting_api_integration/services/index_timestamp.ts | 0 .../test/reporting_api_integration/services/scenarios.ts | 0 .../test/reporting_api_integration/services/usage.ts | 0 .../test/reporting_functional/ftr_provider_context.d.ts | 0 .../reporting_functional/reporting_and_security.config.ts | 2 +- .../reporting_and_security/download.ts | 0 .../reporting_functional/reporting_and_security/index.ts | 0 .../reporting_and_security/management.ts | 2 +- .../reporting_and_security/security_roles_privileges.ts | 0 .../reporting_without_security.config.ts | 0 .../reporting_without_security/index.ts | 0 .../reporting_without_security/management.ts | 0 .../test/reporting_functional/services/index.ts | 0 .../test/reporting_functional/services/scenarios.ts | 0 x-pack/platform/test/tsconfig.json | 7 +++++++ x-pack/test/functional/page_objects/index.ts | 4 ++-- x-pack/test/functional/services/index.ts | 2 +- x-pack/test/tsconfig.json | 4 ---- 48 files changed, 24 insertions(+), 17 deletions(-) rename x-pack/{ => platform}/test/functional/page_objects/canvas_page.ts (100%) rename x-pack/{ => platform}/test/functional/page_objects/reporting_page.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/ftr_provider_context.d.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security.config.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2.snap (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2_esql.snap (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/generate_csv_discover.snap (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/csv/csv_v2.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/csv/csv_v2_esql.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/csv/generate_csv_discover.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/datastream.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/default_reporting_user_role.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/disable_scheduled_reports.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/ilm_migration_apis.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/index.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/list_jobs.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/list_scheduled_reports.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/screenshot/network_policy.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/screenshot/validation.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/security_roles_privileges.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_and_security/spaces.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_without_security.config.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_without_security/csv/job_apis_csv.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_without_security/index.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/reporting_without_security/schedule.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/services/index.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/services/index_timestamp.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/services/scenarios.ts (100%) rename x-pack/{ => platform}/test/reporting_api_integration/services/usage.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/ftr_provider_context.d.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/reporting_and_security.config.ts (95%) rename x-pack/{ => platform}/test/reporting_functional/reporting_and_security/download.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/reporting_and_security/index.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/reporting_and_security/management.ts (97%) rename x-pack/{ => platform}/test/reporting_functional/reporting_and_security/security_roles_privileges.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/reporting_without_security.config.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/reporting_without_security/index.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/reporting_without_security/management.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/services/index.ts (100%) rename x-pack/{ => platform}/test/reporting_functional/services/scenarios.ts (100%) diff --git a/.buildkite/ftr_platform_stateful_configs.yml b/.buildkite/ftr_platform_stateful_configs.yml index 7a1aadf78453..314baaab3298 100644 --- a/.buildkite/ftr_platform_stateful_configs.yml +++ b/.buildkite/ftr_platform_stateful_configs.yml @@ -278,10 +278,10 @@ enabled: - x-pack/test/licensing_plugin/config.public.ts - x-pack/test/licensing_plugin/config.ts - x-pack/test/plugin_functional/config.ts - - x-pack/test/reporting_api_integration/reporting_and_security.config.ts - - x-pack/test/reporting_api_integration/reporting_without_security.config.ts - - x-pack/test/reporting_functional/reporting_and_security.config.ts - - x-pack/test/reporting_functional/reporting_without_security.config.ts + - x-pack/platform/test/reporting_api_integration/reporting_and_security.config.ts + - x-pack/platform/test/reporting_api_integration/reporting_without_security.config.ts + - x-pack/platform/test/reporting_functional/reporting_and_security.config.ts + - x-pack/platform/test/reporting_functional/reporting_without_security.config.ts - x-pack/test/rule_registry/security_and_spaces/config_basic.ts - x-pack/test/rule_registry/security_and_spaces/config_trial.ts - x-pack/test/rule_registry/spaces_only/config_basic.ts diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7030a6f085d0..0a06db9144d3 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1300,15 +1300,15 @@ src/platform/plugins/shared/discover/public/context_awareness/profile_providers/ /x-pack/test/functional/es_archives/lens/reporting/ @elastic/response-ops /x-pack/test/functional/es_archives/reporting/ @elastic/response-ops /x-pack/test/functional/fixtures/kbn_archiver/reporting/ @elastic/response-ops -/x-pack/test/reporting_api_integration/ @elastic/response-ops -/x-pack/test/reporting_functional/ @elastic/response-ops +/x-pack/platform/test/reporting_api_integration/ @elastic/response-ops +/x-pack/platform/test/reporting_functional/ @elastic/response-ops /x-pack/test/stack_functional_integration/apps/reporting/ @elastic/response-ops /docs/user/reporting @elastic/response-ops /docs/settings/reporting-settings.asciidoc @elastic/response-ops /docs/setup/configuring-reporting.asciidoc @elastic/response-ops /x-pack/test_serverless/**/test_suites/common/reporting/ @elastic/response-ops /x-pack/test/accessibility/apps/group3/reporting.ts @elastic/response-ops -/x-pack/test/functional/page_objects/reporting_page.ts @elastic/response-ops +/x-pack/platform/test/functional/page_objects/reporting_page.ts @elastic/response-ops /x-pack/test/upgrade/apps/reporting @elastic/response-ops /x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting @elastic/response-ops @@ -1583,7 +1583,7 @@ src/platform/plugins/shared/discover/public/context_awareness/profile_providers/ /src/platform/test/interpreter_functional/snapshots @elastic/kibana-presentation # Assigned per https://github.com/elastic/kibana/pull/54342 /src/platform/test/functional/services/inspector.ts @elastic/kibana-presentation /x-pack/test/functional/services/canvas_element.ts @elastic/kibana-presentation -/x-pack/test/functional/page_objects/canvas_page.ts @elastic/kibana-presentation +/x-pack/platform/test/functional/page_objects/canvas_page.ts @elastic/kibana-presentation /x-pack/test/accessibility/apps/group3/canvas.ts @elastic/kibana-presentation /x-pack/test/upgrade/apps/canvas @elastic/kibana-presentation /x-pack/test/upgrade/apps/dashboard @elastic/kibana-presentation diff --git a/x-pack/test/functional/page_objects/canvas_page.ts b/x-pack/platform/test/functional/page_objects/canvas_page.ts similarity index 100% rename from x-pack/test/functional/page_objects/canvas_page.ts rename to x-pack/platform/test/functional/page_objects/canvas_page.ts diff --git a/x-pack/platform/test/functional/page_objects/index.ts b/x-pack/platform/test/functional/page_objects/index.ts index 6a6d5bd2d675..db323d3265f6 100644 --- a/x-pack/platform/test/functional/page_objects/index.ts +++ b/x-pack/platform/test/functional/page_objects/index.ts @@ -12,6 +12,8 @@ import { SpaceSelectorPageObject } from './space_selector_page'; import { CopySavedObjectsToSpacePageProvider } from './copy_saved_objects_to_space_page'; import { MonitoringPageObject } from './monitoring_page'; import { AccountSettingsPageObject } from './account_settings_page'; +import { ReportingPageObject } from './reporting_page'; +import { CanvasPageProvider } from './canvas_page'; // just like services, PageObjects are defined as a map of // names to Providers. Merge in Kibana's or pick specific ones @@ -23,4 +25,6 @@ export const pageObjects = { copySavedObjectsToSpace: CopySavedObjectsToSpacePageProvider, monitoring: MonitoringPageObject, accountSetting: AccountSettingsPageObject, + reporting: ReportingPageObject, + canvas: CanvasPageProvider, }; diff --git a/x-pack/test/functional/page_objects/reporting_page.ts b/x-pack/platform/test/functional/page_objects/reporting_page.ts similarity index 100% rename from x-pack/test/functional/page_objects/reporting_page.ts rename to x-pack/platform/test/functional/page_objects/reporting_page.ts diff --git a/x-pack/test/reporting_api_integration/ftr_provider_context.d.ts b/x-pack/platform/test/reporting_api_integration/ftr_provider_context.d.ts similarity index 100% rename from x-pack/test/reporting_api_integration/ftr_provider_context.d.ts rename to x-pack/platform/test/reporting_api_integration/ftr_provider_context.d.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security.config.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security.config.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security.config.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security.config.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2.snap b/x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2.snap similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2.snap rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2.snap diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2_esql.snap b/x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2_esql.snap similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2_esql.snap rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/csv_v2_esql.snap diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/generate_csv_discover.snap b/x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/generate_csv_discover.snap similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/generate_csv_discover.snap rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/__snapshots__/generate_csv_discover.snap diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv/csv_v2.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/csv_v2.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/csv/csv_v2.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/csv_v2.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv/csv_v2_esql.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/csv_v2_esql.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/csv/csv_v2_esql.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/csv_v2_esql.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv/generate_csv_discover.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/generate_csv_discover.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/csv/generate_csv_discover.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/csv/generate_csv_discover.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/datastream.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/datastream.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/datastream.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/datastream.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/default_reporting_user_role.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/default_reporting_user_role.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/default_reporting_user_role.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/default_reporting_user_role.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/disable_scheduled_reports.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/disable_scheduled_reports.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/disable_scheduled_reports.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/disable_scheduled_reports.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/ilm_migration_apis.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/ilm_migration_apis.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/ilm_migration_apis.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/ilm_migration_apis.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/index.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/index.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/index.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/index.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/list_jobs.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/list_jobs.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/list_jobs.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/list_jobs.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/list_scheduled_reports.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/list_scheduled_reports.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/list_scheduled_reports.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/list_scheduled_reports.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/screenshot/network_policy.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/screenshot/network_policy.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/screenshot/network_policy.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/screenshot/network_policy.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/screenshot/validation.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/screenshot/validation.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/screenshot/validation.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/screenshot/validation.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/security_roles_privileges.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/security_roles_privileges.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/security_roles_privileges.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/security_roles_privileges.ts diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts b/x-pack/platform/test/reporting_api_integration/reporting_and_security/spaces.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts rename to x-pack/platform/test/reporting_api_integration/reporting_and_security/spaces.ts diff --git a/x-pack/test/reporting_api_integration/reporting_without_security.config.ts b/x-pack/platform/test/reporting_api_integration/reporting_without_security.config.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_without_security.config.ts rename to x-pack/platform/test/reporting_api_integration/reporting_without_security.config.ts diff --git a/x-pack/test/reporting_api_integration/reporting_without_security/csv/job_apis_csv.ts b/x-pack/platform/test/reporting_api_integration/reporting_without_security/csv/job_apis_csv.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_without_security/csv/job_apis_csv.ts rename to x-pack/platform/test/reporting_api_integration/reporting_without_security/csv/job_apis_csv.ts diff --git a/x-pack/test/reporting_api_integration/reporting_without_security/index.ts b/x-pack/platform/test/reporting_api_integration/reporting_without_security/index.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_without_security/index.ts rename to x-pack/platform/test/reporting_api_integration/reporting_without_security/index.ts diff --git a/x-pack/test/reporting_api_integration/reporting_without_security/schedule.ts b/x-pack/platform/test/reporting_api_integration/reporting_without_security/schedule.ts similarity index 100% rename from x-pack/test/reporting_api_integration/reporting_without_security/schedule.ts rename to x-pack/platform/test/reporting_api_integration/reporting_without_security/schedule.ts diff --git a/x-pack/test/reporting_api_integration/services/index.ts b/x-pack/platform/test/reporting_api_integration/services/index.ts similarity index 100% rename from x-pack/test/reporting_api_integration/services/index.ts rename to x-pack/platform/test/reporting_api_integration/services/index.ts diff --git a/x-pack/test/reporting_api_integration/services/index_timestamp.ts b/x-pack/platform/test/reporting_api_integration/services/index_timestamp.ts similarity index 100% rename from x-pack/test/reporting_api_integration/services/index_timestamp.ts rename to x-pack/platform/test/reporting_api_integration/services/index_timestamp.ts diff --git a/x-pack/test/reporting_api_integration/services/scenarios.ts b/x-pack/platform/test/reporting_api_integration/services/scenarios.ts similarity index 100% rename from x-pack/test/reporting_api_integration/services/scenarios.ts rename to x-pack/platform/test/reporting_api_integration/services/scenarios.ts diff --git a/x-pack/test/reporting_api_integration/services/usage.ts b/x-pack/platform/test/reporting_api_integration/services/usage.ts similarity index 100% rename from x-pack/test/reporting_api_integration/services/usage.ts rename to x-pack/platform/test/reporting_api_integration/services/usage.ts diff --git a/x-pack/test/reporting_functional/ftr_provider_context.d.ts b/x-pack/platform/test/reporting_functional/ftr_provider_context.d.ts similarity index 100% rename from x-pack/test/reporting_functional/ftr_provider_context.d.ts rename to x-pack/platform/test/reporting_functional/ftr_provider_context.d.ts diff --git a/x-pack/test/reporting_functional/reporting_and_security.config.ts b/x-pack/platform/test/reporting_functional/reporting_and_security.config.ts similarity index 95% rename from x-pack/test/reporting_functional/reporting_and_security.config.ts rename to x-pack/platform/test/reporting_functional/reporting_and_security.config.ts index 48096dbeb322..3db803eae539 100644 --- a/x-pack/test/reporting_functional/reporting_and_security.config.ts +++ b/x-pack/platform/test/reporting_functional/reporting_and_security.config.ts @@ -11,7 +11,7 @@ import { ReportingAPIProvider } from '../reporting_api_integration/services'; import { ReportingFunctionalProvider } from './services'; export default async function ({ readConfigFile }: FtrConfigProviderContext) { - const functionalConfig = await readConfigFile(require.resolve('../functional/config.base.js')); // Reporting API tests need a fully working UI + const functionalConfig = await readConfigFile(require.resolve('../functional/config.base.ts')); // Reporting API tests need a fully working UI const apiConfig = await readConfigFile(require.resolve('../api_integration/config')); return { diff --git a/x-pack/test/reporting_functional/reporting_and_security/download.ts b/x-pack/platform/test/reporting_functional/reporting_and_security/download.ts similarity index 100% rename from x-pack/test/reporting_functional/reporting_and_security/download.ts rename to x-pack/platform/test/reporting_functional/reporting_and_security/download.ts diff --git a/x-pack/test/reporting_functional/reporting_and_security/index.ts b/x-pack/platform/test/reporting_functional/reporting_and_security/index.ts similarity index 100% rename from x-pack/test/reporting_functional/reporting_and_security/index.ts rename to x-pack/platform/test/reporting_functional/reporting_and_security/index.ts diff --git a/x-pack/test/reporting_functional/reporting_and_security/management.ts b/x-pack/platform/test/reporting_functional/reporting_and_security/management.ts similarity index 97% rename from x-pack/test/reporting_functional/reporting_and_security/management.ts rename to x-pack/platform/test/reporting_functional/reporting_and_security/management.ts index d695ea69faf2..5302e9c752c1 100644 --- a/x-pack/test/reporting_functional/reporting_and_security/management.ts +++ b/x-pack/platform/test/reporting_functional/reporting_and_security/management.ts @@ -66,7 +66,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => { }); describe('Schedules', () => { - it('does allow user with reporting privileges o navigate to the Schedules tab', async () => { + it('does allow user with reporting privileges to navigate to the Schedules tab', async () => { await reportingFunctional.loginReportingUser(); await PageObjects.common.navigateToApp('reporting'); diff --git a/x-pack/test/reporting_functional/reporting_and_security/security_roles_privileges.ts b/x-pack/platform/test/reporting_functional/reporting_and_security/security_roles_privileges.ts similarity index 100% rename from x-pack/test/reporting_functional/reporting_and_security/security_roles_privileges.ts rename to x-pack/platform/test/reporting_functional/reporting_and_security/security_roles_privileges.ts diff --git a/x-pack/test/reporting_functional/reporting_without_security.config.ts b/x-pack/platform/test/reporting_functional/reporting_without_security.config.ts similarity index 100% rename from x-pack/test/reporting_functional/reporting_without_security.config.ts rename to x-pack/platform/test/reporting_functional/reporting_without_security.config.ts diff --git a/x-pack/test/reporting_functional/reporting_without_security/index.ts b/x-pack/platform/test/reporting_functional/reporting_without_security/index.ts similarity index 100% rename from x-pack/test/reporting_functional/reporting_without_security/index.ts rename to x-pack/platform/test/reporting_functional/reporting_without_security/index.ts diff --git a/x-pack/test/reporting_functional/reporting_without_security/management.ts b/x-pack/platform/test/reporting_functional/reporting_without_security/management.ts similarity index 100% rename from x-pack/test/reporting_functional/reporting_without_security/management.ts rename to x-pack/platform/test/reporting_functional/reporting_without_security/management.ts diff --git a/x-pack/test/reporting_functional/services/index.ts b/x-pack/platform/test/reporting_functional/services/index.ts similarity index 100% rename from x-pack/test/reporting_functional/services/index.ts rename to x-pack/platform/test/reporting_functional/services/index.ts diff --git a/x-pack/test/reporting_functional/services/scenarios.ts b/x-pack/platform/test/reporting_functional/services/scenarios.ts similarity index 100% rename from x-pack/test/reporting_functional/services/scenarios.ts rename to x-pack/platform/test/reporting_functional/services/scenarios.ts diff --git a/x-pack/platform/test/tsconfig.json b/x-pack/platform/test/tsconfig.json index 6931b88220fa..acc297990338 100644 --- a/x-pack/platform/test/tsconfig.json +++ b/x-pack/platform/test/tsconfig.json @@ -105,6 +105,13 @@ "@kbn/repo-info", "@kbn/dev-cli-errors", "@kbn/journeys", + "@kbn/reporting-common", + "@kbn/discover-plugin", + "@kbn/reporting-export-types-csv-common", + "@kbn/rison", + "@kbn/reporting-export-types-pdf-common", + "@kbn/reporting-export-types-png-common", + "@kbn/reporting-server", "@kbn/lens-plugin", ] } diff --git a/x-pack/test/functional/page_objects/index.ts b/x-pack/test/functional/page_objects/index.ts index bde45018a537..fffa76031d54 100644 --- a/x-pack/test/functional/page_objects/index.ts +++ b/x-pack/test/functional/page_objects/index.ts @@ -12,10 +12,11 @@ import { SecurityPageObject } from '@kbn/test-suites-xpack-platform/functional/p import { CopySavedObjectsToSpacePageProvider } from '@kbn/test-suites-xpack-platform/functional/page_objects/copy_saved_objects_to_space_page'; import { SpaceSelectorPageObject } from '@kbn/test-suites-xpack-platform/functional/page_objects/space_selector_page'; import { RoleMappingsPageProvider } from '@kbn/test-suites-xpack-platform/functional/page_objects/role_mappings_page'; +import { CanvasPageProvider } from '@kbn/test-suites-xpack-platform/functional/page_objects/canvas_page'; +import { ReportingPageObject } from '@kbn/test-suites-xpack-platform/functional/page_objects/reporting_page'; import { ApiKeysPageProvider } from './api_keys_page'; import { AssetDetailsProvider } from './asset_details'; import { BannersPageObject } from './banners_page'; -import { CanvasPageProvider } from './canvas_page'; import { CrossClusterReplicationPageProvider } from './cross_cluster_replication_page'; import { DetectionsPageObject } from '../../security_solution_ftr/page_objects/detections'; import { EmbeddedConsoleProvider } from './embedded_console'; @@ -41,7 +42,6 @@ import { DatasetQualityPageObject } from './dataset_quality'; import { ObservabilityPageProvider } from './observability_page'; import { AlertControlsProvider } from './alert_controls'; import { RemoteClustersPageProvider } from './remote_clusters_page'; -import { ReportingPageObject } from './reporting_page'; import { RollupPageObject } from './rollup_page'; import { SearchSessionsPageProvider } from './search_sessions_management_page'; import { ShareSavedObjectsToSpacePageProvider } from './share_saved_objects_to_space_page'; diff --git a/x-pack/test/functional/services/index.ts b/x-pack/test/functional/services/index.ts index 772ad13d8760..90f9684b35d1 100644 --- a/x-pack/test/functional/services/index.ts +++ b/x-pack/test/functional/services/index.ts @@ -10,9 +10,9 @@ import { services as kibanaApiIntegrationServices } from '@kbn/test-suites-src/a import { AceEditorProvider } from '@kbn/test-suites-xpack-platform/functional/services/ace_editor'; import { UserMenuProvider } from '@kbn/test-suites-xpack-platform/functional/services/user_menu'; import { SampleDataServiceProvider } from '@kbn/test-suites-xpack-platform/functional/services/sample_data'; +import { ReportingFunctionalProvider } from '@kbn/test-suites-xpack-platform/reporting_functional/services'; import { services as kibanaXPackApiIntegrationServices } from '../../api_integration/services'; import { services as commonServices } from '../../common/services'; -import { ReportingFunctionalProvider } from '../../reporting_functional/services'; import { MonitoringNoDataProvider, diff --git a/x-pack/test/tsconfig.json b/x-pack/test/tsconfig.json index 883f205ba4cc..da1d253dda57 100644 --- a/x-pack/test/tsconfig.json +++ b/x-pack/test/tsconfig.json @@ -107,9 +107,6 @@ "@kbn/es", "@kbn/metrics-data-access-plugin", "@kbn/dataset-quality-plugin", - "@kbn/reporting-export-types-csv-common", - "@kbn/reporting-export-types-pdf-common", - "@kbn/reporting-export-types-png-common", "@kbn/reporting-common", "@kbn/io-ts-utils", "@kbn/security-plugin-types-common", @@ -124,7 +121,6 @@ "@kbn/apm-data-view", "@kbn/search-types", "@kbn/alerting-comparators", - "@kbn/reporting-server", "@kbn/data-quality-plugin", "@kbn/observability-synthetics-test-data", "@kbn/openapi-common",