From 42c0e280363b6e3077ccd34a0ca50978ed6fd39f Mon Sep 17 00:00:00 2001 From: Jon Date: Thu, 22 Feb 2024 19:59:01 -0600 Subject: [PATCH] [npmrc] Fix puppeteer_skip_download configuration (#177673) This was a breaking change introduced in puppeteer 20 See https://github.com/puppeteer/puppeteer/commit/df4d60c187aa11c4ad783827242e9511f4ec2aab --- .buildkite/scripts/steps/bazel_cache/bootstrap_linux.sh | 1 - .buildkite/scripts/steps/bazel_cache/bootstrap_mac.sh | 1 - .npmrc | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.buildkite/scripts/steps/bazel_cache/bootstrap_linux.sh b/.buildkite/scripts/steps/bazel_cache/bootstrap_linux.sh index 95d80c0f1604..7798370bfbd3 100755 --- a/.buildkite/scripts/steps/bazel_cache/bootstrap_linux.sh +++ b/.buildkite/scripts/steps/bazel_cache/bootstrap_linux.sh @@ -6,7 +6,6 @@ source .buildkite/scripts/common/util.sh export BAZEL_CACHE_MODE=populate-local-gcs export DISABLE_BOOTSTRAP_VALIDATION=true -export PUPPETEER_SKIP_DOWNLOAD=true # Clear out bazel cache between runs to make sure that any artifacts that don't exist in the cache are uploaded rm -rf ~/.bazel-cache diff --git a/.buildkite/scripts/steps/bazel_cache/bootstrap_mac.sh b/.buildkite/scripts/steps/bazel_cache/bootstrap_mac.sh index 4065cc984aa0..91886c855402 100755 --- a/.buildkite/scripts/steps/bazel_cache/bootstrap_mac.sh +++ b/.buildkite/scripts/steps/bazel_cache/bootstrap_mac.sh @@ -6,7 +6,6 @@ source .buildkite/scripts/common/util.sh export BAZEL_CACHE_MODE=populate-local-gcs export DISABLE_BOOTSTRAP_VALIDATION=true -export PUPPETEER_SKIP_CHROME_DOWNLOAD=true # Because we're manually deleting node_modules and bazel directories in-between runs, we need to --force-install export BOOTSTRAP_ALWAYS_FORCE_INSTALL=true diff --git a/.npmrc b/.npmrc index 5c6ff9df9dd2..d2e4d49abc74 100644 --- a/.npmrc +++ b/.npmrc @@ -1 +1 @@ -puppeteer_skip_chromium_download=true +puppeteer_skip_download=true