From 6cea1b0b6ad079051c0558db81e9114e7a121da4 Mon Sep 17 00:00:00 2001
From: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Date: Thu, 26 Jun 2025 16:58:15 +0200
Subject: [PATCH] [Fleet] fix UI error when no tags filter is selected
 (#225413)

## Summary

Closes https://github.com/elastic/kibana/issues/224055

To verify:
- filter on `No Tags` or `not tags:*` in Agent list
- add tag to an agent
- expect that the agent disappears from view and there is no UI error



https://github.com/user-attachments/assets/77982bc9-13a8-4141-b0a0-e9198706691f
---
 .../agent_list_page/components/tags_add_remove.tsx    |  6 +++---
 .../fleet/sections/agents/agent_list_page/index.tsx   | 11 +++++++++--
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/tags_add_remove.tsx b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/tags_add_remove.tsx
index 8e539954e520..cd6934586ea9 100644
--- a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/tags_add_remove.tsx
+++ b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/tags_add_remove.tsx
@@ -40,7 +40,7 @@ interface Props {
   allTags: string[];
   selectedTags: string[];
   button: HTMLElement;
-  onTagsUpdated: () => void;
+  onTagsUpdated: (tagsToAdd: string[]) => void;
   onClosePopover: () => void;
 }
 
@@ -93,7 +93,7 @@ export const TagsAddRemove: React.FC<Props> = ({
     isRenameOrDelete = false
   ) => {
     if (hasCompleted) {
-      return onTagsUpdated();
+      return onTagsUpdated(tagsToAdd);
     }
     const selected = labels.filter((tag) => tag.checked === 'on').map((tag) => tag.label);
     const newSelectedTags = difference(selected, tagsToRemove).concat(tagsToAdd);
@@ -115,7 +115,7 @@ export const TagsAddRemove: React.FC<Props> = ({
       updateTagsHook.updateTags(
         agentId,
         newSelectedTags,
-        () => onTagsUpdated(),
+        () => onTagsUpdated(tagsToAdd),
         successMessage,
         errorMessage
       );
diff --git a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/index.tsx b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/index.tsx
index dc341086be59..f91b2c0c0eba 100644
--- a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/index.tsx
+++ b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/index.tsx
@@ -412,8 +412,15 @@ export const AgentListPage: React.FunctionComponent<{}> = () => {
           allTags={allTags ?? []}
           selectedTags={agentToAddRemoveTags?.tags ?? []}
           button={tagsPopoverButton!}
-          onTagsUpdated={() => {
-            refreshAgents();
+          onTagsUpdated={(tagsToAdd: string[]) => {
+            refreshAgents({ refreshTags: true });
+            // close popover if agent is going to disappear from view to prevent UI error
+            if (
+              tagsToAdd.length > 0 &&
+              (selectedTags[0] === 'No Tags' || kuery.includes('not tags:*'))
+            ) {
+              setShowTagsAddRemove(false);
+            }
           }}
           onClosePopover={() => {
             setShowTagsAddRemove(false);