From a12ee3fea9a45848f17c53e779bca3c40e73e405 Mon Sep 17 00:00:00 2001 From: Joe Fleming Date: Thu, 28 May 2015 13:57:27 -0700 Subject: [PATCH 1/4] add href to zoom-to-bounds pointer --- src/kibana/components/vislib/visualizations/tile_map.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kibana/components/vislib/visualizations/tile_map.js b/src/kibana/components/vislib/visualizations/tile_map.js index 78f84fec235d..04735fcaa0a5 100644 --- a/src/kibana/components/vislib/visualizations/tile_map.js +++ b/src/kibana/components/vislib/visualizations/tile_map.js @@ -179,7 +179,7 @@ define(function (require) { position: 'topleft' }, onAdd: function (map) { - $(fitContainer).html(''); + $(fitContainer).html(''); $(fitContainer).on('click', function () { self.fitBounds(map, mapData.features); }); From fc8eec0a77147f3a24dbbf045535ea1df4fcd523 Mon Sep 17 00:00:00 2001 From: Joe Fleming Date: Tue, 2 Jun 2015 10:35:09 -0700 Subject: [PATCH 2/4] add prevent default --- src/kibana/components/vislib/visualizations/tile_map.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/kibana/components/vislib/visualizations/tile_map.js b/src/kibana/components/vislib/visualizations/tile_map.js index 04735fcaa0a5..6c503cf111d7 100644 --- a/src/kibana/components/vislib/visualizations/tile_map.js +++ b/src/kibana/components/vislib/visualizations/tile_map.js @@ -180,7 +180,8 @@ define(function (require) { }, onAdd: function (map) { $(fitContainer).html(''); - $(fitContainer).on('click', function () { + $(fitContainer).on('click', function (e) { + e.preventDefault(); self.fitBounds(map, mapData.features); }); return fitContainer; From 84a47746a8f8e78f8f9b7a44c3c6f1e24ca2a9fd Mon Sep 17 00:00:00 2001 From: Joe Fleming Date: Tue, 2 Jun 2015 10:35:23 -0700 Subject: [PATCH 3/4] clean up the classes (no zoom here) --- src/kibana/components/vislib/visualizations/tile_map.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kibana/components/vislib/visualizations/tile_map.js b/src/kibana/components/vislib/visualizations/tile_map.js index 6c503cf111d7..47c9d8903974 100644 --- a/src/kibana/components/vislib/visualizations/tile_map.js +++ b/src/kibana/components/vislib/visualizations/tile_map.js @@ -171,7 +171,7 @@ define(function (require) { } if (mapData && mapData.features.length > 0) { - var fitContainer = L.DomUtil.create('div', 'leaflet-control leaflet-bar leaflet-control-zoom leaflet-control-fit'); + var fitContainer = L.DomUtil.create('div', 'leaflet-control leaflet-bar leaflet-control-fit'); // Add button to fit container to points var FitControl = L.Control.extend({ @@ -179,7 +179,7 @@ define(function (require) { position: 'topleft' }, onAdd: function (map) { - $(fitContainer).html(''); + $(fitContainer).html(''); $(fitContainer).on('click', function (e) { e.preventDefault(); self.fitBounds(map, mapData.features); From fd568ee18e5e0cc28450d485c73e12ebadfce4ab Mon Sep 17 00:00:00 2001 From: Joe Fleming Date: Tue, 2 Jun 2015 13:38:45 -0700 Subject: [PATCH 4/4] chain the container click handler --- src/kibana/components/vislib/visualizations/tile_map.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/kibana/components/vislib/visualizations/tile_map.js b/src/kibana/components/vislib/visualizations/tile_map.js index 47c9d8903974..1366db26c9a4 100644 --- a/src/kibana/components/vislib/visualizations/tile_map.js +++ b/src/kibana/components/vislib/visualizations/tile_map.js @@ -179,11 +179,12 @@ define(function (require) { position: 'topleft' }, onAdd: function (map) { - $(fitContainer).html(''); - $(fitContainer).on('click', function (e) { + $(fitContainer).html('') + .on('click', function (e) { e.preventDefault(); self.fitBounds(map, mapData.features); }); + return fitContainer; }, onRemove: function (map) {