From d213ed274cae60464f1a3e60d94f2d13254ba96b Mon Sep 17 00:00:00 2001 From: Thomas Watson Date: Fri, 28 Jul 2023 10:43:53 +0200 Subject: [PATCH] Upgrade ESLint React plugins (#162464) --- .eslintrc.js | 4 +- package.json | 6 +- .../src/views/fonts.tsx | 4 +- .../src/views/styles.tsx | 4 +- packages/kbn-eslint-config/react.js | 2 +- .../_hierarchical_tooltip_formatter.js | 82 --- .../public/vislib/components/tooltip/index.js | 1 - .../components/data_table/index.tsx | 1 + .../navigation/src/links.tsx | 1 + x-pack/plugins/canvas/.eslintrc.json | 12 + .../common/lib/kibana/kibana_react.mock.tsx | 4 +- .../cases/public/common/test_utils.tsx | 3 +- .../public/components/add_comment/index.tsx | 2 + .../use_cases_add_to_new_case_flyout.test.tsx | 2 - .../components/insert_timeline/index.tsx | 4 +- .../components/markdown_editor/editor.tsx | 3 - .../components/markdown_editor/eui_form.tsx | 2 + .../user_actions/comment/actions.tsx | 2 - .../comment/registered_attachments.tsx | 2 - .../components/user_actions/comment/user.tsx | 2 - .../public/components/user_actions/common.tsx | 1 - .../components/setup_guide/setup_guide.tsx | 2 +- .../components/setup_guide/setup_guide.tsx | 2 +- .../queries/ecs_mapping_editor_field.tsx | 1 + .../osquery_results/osquery_result.tsx | 1 + .../osquery_result_wrapper.tsx | 1 + .../template_wrapper/bottom_bar/index.tsx | 3 +- .../components/endpoint/link_to_app.tsx | 1 + .../common/components/events_viewer/index.tsx | 2 +- .../components/header_section/index.tsx | 4 +- .../components/markdown_editor/eui_form.tsx | 2 + .../public/common/components/top_n/top_n.tsx | 2 +- .../common/lib/kibana/kibana_react.mock.ts | 4 +- .../filters/multiselect_filter/index.tsx | 2 + .../components/rules/mitre/index.tsx | 1 + .../components/take_action_dropdown/index.tsx | 1 + .../detections/pages/alert_details/index.tsx | 1 + .../import_exceptions_list_flyout/index.tsx | 2 + .../paginated_content/paginated_content.tsx | 1 - .../view/components/blocklist_form.tsx | 1 + .../policy_artifacts_delete_modal.tsx | 1 + .../with_security_context.tsx | 1 + .../components/event_collection_card.tsx | 1 - .../simulator/mock_resolver.tsx | 3 +- .../public/resolver/view/edge_line.tsx | 3 +- .../public/resolver/view/generated_text.tsx | 3 +- .../public/resolver/view/graph_controls.tsx | 6 +- .../public/resolver/view/index.tsx | 3 +- .../public/resolver/view/limit_warnings.tsx | 4 +- .../resolver/view/panels/breadcrumbs.tsx | 3 +- .../view/panels/copyable_panel_field.tsx | 3 +- .../resolver/view/panels/cube_for_process.tsx | 1 + .../resolver/view/panels/event_detail.tsx | 4 +- .../public/resolver/view/panels/index.tsx | 3 +- .../resolver/view/panels/node_detail.tsx | 4 +- .../resolver/view/panels/node_events.tsx | 5 +- .../view/panels/node_events_of_type.tsx | 5 +- .../public/resolver/view/panels/node_list.tsx | 5 +- .../view/panels/panel_content_error.tsx | 1 + .../resolver/view/process_event_dot.tsx | 1 + .../view/resolver_without_providers.tsx | 2 - .../public/resolver/view/submenu.tsx | 3 +- .../resolver/view/symbol_definitions.tsx | 5 +- .../components/open_timeline/index.tsx | 1 + .../event_details/flyout/footer.tsx | 1 + .../side_panel/host_details/index.tsx | 3 +- .../side_panel/network_details/index.tsx | 3 +- .../data_providers/provider_item_actions.tsx | 2 +- .../timeline/query_bar/eql/index.tsx | 1 + .../components/timeline/query_bar/index.tsx | 1 + .../waterfall_flyout/waterfall_flyout.tsx | 2 +- .../translations/translations/fr-FR.json | 2 - .../translations/translations/ja-JP.json | 2 - .../translations/translations/zh-CN.json | 2 - .../waterfall/waterfall_flyout.tsx | 2 +- yarn.lock | 593 +++++++++++------- 76 files changed, 468 insertions(+), 395 deletions(-) delete mode 100644 src/plugins/vis_types/vislib/public/vislib/components/tooltip/_hierarchical_tooltip_formatter.js create mode 100644 x-pack/plugins/canvas/.eslintrc.json diff --git a/.eslintrc.js b/.eslintrc.js index 08eb498ca60c..d79e15843310 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1160,12 +1160,12 @@ module.exports = { 'react/no-unsafe': 'error', 'react/no-unused-prop-types': 'error', 'react/no-unused-state': 'error', + 'react/sort-default-props': 'error', 'react/void-dom-elements-no-children': 'error', 'react/jsx-no-comment-textnodes': 'error', 'react/jsx-no-literals': 'error', 'react/jsx-no-target-blank': 'error', 'react/jsx-fragments': 'error', - 'react/jsx-sort-default-props': 'error', 'require-atomic-updates': 'error', 'symbol-description': 'error', 'vars-on-top': 'error', @@ -1256,12 +1256,12 @@ module.exports = { 'react/no-unused-prop-types': 'error', 'react/no-unused-state': 'error', 'react/sort-comp': 'error', + 'react/sort-default-props': 'error', 'react/void-dom-elements-no-children': 'error', 'react/jsx-no-comment-textnodes': 'error', 'react/jsx-no-literals': 'error', 'react/jsx-no-target-blank': 'error', 'react/jsx-fragments': 'error', - 'react/jsx-sort-default-props': 'error', }, }, { diff --git a/package.json b/package.json index 58234e065655..07f2d08059cc 100644 --- a/package.json +++ b/package.json @@ -1426,9 +1426,9 @@ "eslint-plugin-no-unsanitized": "^3.1.5", "eslint-plugin-node": "^11.1.0", "eslint-plugin-prettier": "^4.0.0", - "eslint-plugin-react": "^7.26.1", - "eslint-plugin-react-hooks": "^4.2.0", - "eslint-plugin-react-perf": "^3.3.0", + "eslint-plugin-react": "^7.32.2", + "eslint-plugin-react-hooks": "^4.6.0", + "eslint-plugin-react-perf": "^3.3.1", "eslint-traverse": "^1.0.0", "exit-hook": "^2.2.0", "expect": "^29.6.1", diff --git a/packages/core/rendering/core-rendering-server-internal/src/views/fonts.tsx b/packages/core/rendering/core-rendering-server-internal/src/views/fonts.tsx index 44030620454e..d81b166c6026 100644 --- a/packages/core/rendering/core-rendering-server-internal/src/views/fonts.tsx +++ b/packages/core/rendering/core-rendering-server-internal/src/views/fonts.tsx @@ -6,8 +6,6 @@ * Side Public License, v 1. */ -/* eslint-disable react/no-danger */ - import React, { FunctionComponent } from 'react'; import { RenderingMetadata } from '../types'; @@ -223,6 +221,7 @@ export const Fonts: FunctionComponent = ({ url }) => { const sansFont = getInter(url); const codeFont = getRoboto(url); + /* eslint-disable react/no-danger */ return (