diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/attack_discovery_panel/panel_header/primary_interactions/badges/shared_badge/translations.ts b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/attack_discovery_panel/panel_header/primary_interactions/badges/shared_badge/translations.ts index dcda86b71977..57ab5853ee28 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/attack_discovery_panel/panel_header/primary_interactions/badges/shared_badge/translations.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/attack_discovery_panel/panel_header/primary_interactions/badges/shared_badge/translations.ts @@ -43,7 +43,7 @@ export const VISIBILITY = i18n.translate( ); export const VISIBLE_TO_YOUR_TEAM = i18n.translate( - 'xpack.securitySolution.attackDiscovery.results.attackDiscoveryPanel.panelHeader.badges.sharedBadge..visibleToYourTeamLabel', + 'xpack.securitySolution.attackDiscovery.results.attackDiscoveryPanel.panelHeader.badges.sharedBadge.visibleToYourTeamLabel', { defaultMessage: 'Visible to your team', } diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.test.tsx index 622e18a7ed92..140618501b1f 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.test.tsx @@ -81,7 +81,7 @@ describe('useScheduleView', () => { isLoading: false, } as unknown as jest.Mocked>); - const { result } = renderHook(() => useScheduleView(null)); + const { result } = renderHook(() => useScheduleView()); render({result.current.scheduleView}); @@ -94,7 +94,7 @@ describe('useScheduleView', () => { isLoading: false, } as unknown as jest.Mocked>); - const { result } = renderHook(() => useScheduleView(null)); + const { result } = renderHook(() => useScheduleView()); render({result.current.actionButtons}); @@ -102,7 +102,7 @@ describe('useScheduleView', () => { }); it('should return the `attack discovery schedules table` if there are existing schedules', () => { - const { result } = renderHook(() => useScheduleView(null)); + const { result } = renderHook(() => useScheduleView()); render({result.current.scheduleView}); @@ -110,7 +110,7 @@ describe('useScheduleView', () => { }); it('should return `create new schedule` action button if there are existing schedules', () => { - const { result } = renderHook(() => useScheduleView(null)); + const { result } = renderHook(() => useScheduleView()); render({result.current.actionButtons}); @@ -118,7 +118,7 @@ describe('useScheduleView', () => { }); it('should show create schedule flyout on `create new schedule` action button click', async () => { - const { result } = renderHook(() => useScheduleView(null)); + const { result } = renderHook(() => useScheduleView()); render({result.current.actionButtons}); diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.tsx index d343be634285..351518cdcbc0 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_schedule_view.tsx @@ -15,7 +15,6 @@ import { } from '@elastic/eui'; import { ATTACK_DISCOVERY_SCHEDULES_ENABLED_FEATURE_FLAG } from '@kbn/elastic-assistant-common'; -import type { AttackDiscoveryStats } from '@kbn/elastic-assistant-common'; import React, { useCallback, useMemo, useState } from 'react'; import * as i18n from './translations'; @@ -30,7 +29,7 @@ export interface UseScheduleView { actionButtons: React.ReactNode; } -export const useScheduleView = (stats: AttackDiscoveryStats | null): UseScheduleView => { +export const useScheduleView = (): UseScheduleView => { const { services: { featureFlags }, } = useKibana(); @@ -60,12 +59,12 @@ export const useScheduleView = (stats: AttackDiscoveryStats | null): UseSchedule } - loadedContent={!total ? : } + loadedContent={!total ? : } /> - {showFlyout && } + {showFlyout && } ); - }, [isDataLoading, onClose, showFlyout, stats, total]); + }, [isDataLoading, onClose, showFlyout, total]); const actionButtons = useMemo(() => { return total ? ( diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_tabs_view.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_tabs_view.tsx index 4d08dc9f40dd..9c464f6399b2 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_tabs_view.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/hooks/use_tabs_view.tsx @@ -66,7 +66,7 @@ export const useTabsView = ({ showConnectorSelector: true, stats, }); - const { scheduleView, actionButtons: scheduleTabButtons } = useScheduleView(stats); + const { scheduleView, actionButtons: scheduleTabButtons } = useScheduleView(); const settingsTab: EuiTabbedContentTab = useMemo( () => ({ diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.test.tsx index 00b7a96f91ac..c833bea46471 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.test.tsx @@ -51,7 +51,6 @@ const defaultProps = { connectorId: undefined, onConnectorIdSelected: jest.fn(), onClose: jest.fn(), - stats: null, }; const renderComponent = async () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.tsx index af709bf2b444..4c2853246d3f 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/create_flyout/index.tsx @@ -16,7 +16,6 @@ import { useGeneratedHtmlId, } from '@elastic/eui'; import { useAssistantContext, useLoadConnectors } from '@kbn/elastic-assistant'; -import type { AttackDiscoveryStats } from '@kbn/elastic-assistant-common'; import { useKibana } from '../../../../../common/lib/kibana'; import { useSourcererDataView } from '../../../../../sourcerer/containers'; @@ -30,10 +29,9 @@ import { convertFormDataInBaseSchedule } from '../utils/convert_form_data'; interface Props { onClose: () => void; - stats: AttackDiscoveryStats | null; } -export const CreateFlyout: React.FC = React.memo(({ onClose, stats }) => { +export const CreateFlyout: React.FC = React.memo(({ onClose }) => { const flyoutTitleId = useGeneratedHtmlId({ prefix: 'attackDiscoveryScheduleCreateFlyoutTitle', }); @@ -87,7 +85,6 @@ export const CreateFlyout: React.FC = React.memo(({ onClose, stats }) => isLoading: isLoadingConnectors || isLoadingQuery, onSave: onCreateSchedule, saveButtonTitle: i18n.SCHEDULE_CREATE_BUTTON_TITLE, - stats, }); return ( diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/details_flyout/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/details_flyout/index.tsx index 7ae43453d3f4..d037b97142b9 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/details_flyout/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/details_flyout/index.tsx @@ -127,7 +127,6 @@ export const DetailsFlyout: React.FC = React.memo(({ scheduleId, onClose isLoading, onSave: onUpdateSchedule, saveButtonTitle: i18n.SCHEDULE_SAVE_BUTTON_TITLE, - stats: null, }); const scheduleDetails = useMemo(() => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/edit_form.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/edit_form.tsx index ef8d2f2e30f5..070a40e0294a 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/edit_form.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/edit_form.tsx @@ -92,7 +92,7 @@ export const EditForm: React.FC = React.memo((props) => { onConnectorIdSelected, onSettingsChanged, settings, - showConnectorSelector: true, + showConnectorSelector: false, stats: null, }); diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/use_edit_form.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/use_edit_form.tsx index 27479f41a602..f191496998d6 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/use_edit_form.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/edit_form/use_edit_form.tsx @@ -18,7 +18,6 @@ import { import { css } from '@emotion/react'; import { DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS } from '@kbn/elastic-assistant'; -import type { AttackDiscoveryStats } from '@kbn/elastic-assistant-common'; import { DEFAULT_END, DEFAULT_START } from '@kbn/elastic-assistant-common'; import * as i18n from './translations'; import type { AttackDiscoveryScheduleSchema } from './types'; @@ -50,7 +49,6 @@ export interface UseEditFormProps { initialValue?: AttackDiscoveryScheduleSchema; onSave?: (scheduleData: AttackDiscoveryScheduleSchema) => void; saveButtonTitle?: string; - stats: AttackDiscoveryStats | null; } export const useEditForm = (props: UseEditFormProps): UseEditForm => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/empty_page/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/empty_page/index.tsx index 8f1cbd91b8b6..c7844d3c0b2b 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/empty_page/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/settings_flyout/schedule/empty_page/index.tsx @@ -16,7 +16,6 @@ import { EuiPanel, EuiText, } from '@elastic/eui'; -import type { AttackDiscoveryStats } from '@kbn/elastic-assistant-common'; import { css } from '@emotion/react'; import * as i18n from './translations'; @@ -24,11 +23,7 @@ import * as i18n from './translations'; import ScheduleIconSVG from '../icons/schedule.svg'; import { CreateFlyout } from '../create_flyout'; -interface Props { - stats: AttackDiscoveryStats | null; -} - -export const EmptyPage: React.FC = React.memo(({ stats }) => { +export const EmptyPage: React.FC = React.memo(() => { // showing / hiding the flyout: const [showFlyout, setShowFlyout] = useState(false); const openFlyout = useCallback(() => setShowFlyout(true), []); @@ -83,7 +78,7 @@ export const EmptyPage: React.FC = React.memo(({ stats }) => { - {showFlyout && } + {showFlyout && } ); });