From fb26c1c683453faa7f8218df094f90d9ad070a23 Mon Sep 17 00:00:00 2001 From: Gerard Soldevila Date: Tue, 28 Jan 2025 04:32:48 +0100 Subject: [PATCH] SKA: Update broken references and URLs (#206836) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Updates a number of broken file references and broken links. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro --- dev_docs/api_welcome.mdx | 5 +- dev_docs/contributing/best_practices.mdx | 2 +- dev_docs/contributing/documentation.mdx | 4 +- dev_docs/getting_started/add_data.mdx | 2 +- dev_docs/key_concepts/embeddables.mdx | 2 +- dev_docs/key_concepts/navigation.mdx | 24 +++---- .../case_study_async_too_early.mdx | 2 +- .../case_study_top_level_imports.mdx | 2 +- dev_docs/key_concepts/persistable_state.mdx | 8 +-- dev_docs/tutorials/data/search.mdx | 4 +- .../advanced/sharing-saved-objects.asciidoc | 10 +-- .../core/saved-objects-service.asciidoc | 18 ++--- .../interpreting-ci-failures.asciidoc | 4 +- docs/settings/cases-settings.asciidoc | 2 +- docs/upgrade-notes.asciidoc | 4 +- .../public/plugin.tsx | 2 +- examples/expressions_explorer/public/app.tsx | 2 +- .../expressions_explorer/public/plugin.tsx | 2 +- examples/locator_explorer/public/plugin.tsx | 2 +- examples/routing_example/public/app.tsx | 6 +- examples/routing_example/public/plugin.tsx | 4 +- .../search_examples/public/application.tsx | 2 +- .../ui_actions_explorer/public/overview.tsx | 2 +- .../ui_actions_explorer/public/plugin.tsx | 2 +- legacy_rfcs/text/0005_route_handler.md | 4 +- legacy_rfcs/text/0015_bazel.md | 2 +- legacy_rfcs/text/0016_ols_phase_1.md | 40 +++++++++++- legacy_rfcs/text/0020_nodejs_clustering.md | 51 +++++++++++++-- .../create_service_metrics_aggregator.ts | 2 +- ...eate_service_summary_metrics_aggregator.ts | 2 +- .../create_span_metrics_aggregator.ts | 2 +- .../create_transaction_metrics_aggregator.ts | 2 +- packages/kbn-dev-cli-runner/README.mdx | 2 +- packages/kbn-optimizer/README.mdx | 2 +- scripts/README.md | 8 +-- .../src/ui/header/screen_reader_a11y.tsx | 2 +- .../migration-server-internal/src/README.md | 2 +- .../server/docs/model_versions.md | 63 ++++++++++-------- .../docs/kib_core_deprecations_service.mdx | 2 +- .../page/kibana_no_data/impl/README.mdx | 2 +- .../shared/kbn-monaco/src/painless/README.md | 2 +- .../toolbar_button/toolbar_button.styles.ts | 2 +- src/platform/plugins/shared/console/README.md | 2 +- src/platform/plugins/shared/data/README.mdx | 2 +- .../shared/expressions/README.asciidoc | 19 +----- .../shared/guided_onboarding/README.md | 2 +- .../shared/usage_collection/README.mdx | 8 +-- x-pack/README.md | 6 +- x-pack/dev-tools/github_relabel.pl | 2 +- x-pack/dev-tools/xkb_release_notes.pl | 2 +- ..._ml_anomaly_detectors__job_id__schema.json | 2 +- ...t___ml_datafeeds__datafeed_id__schema.json | 2 +- .../plugins/private/canvas/PLUGINS.mdx | 8 +-- .../public/services/canvas_notify_service.ts | 2 +- .../public/app/services/routing.js | 2 +- .../form/configuration_context.tsx | 2 +- .../dev_docs/how_to/work_with_packages.md | 5 +- .../monitoring/dev_docs/reference/indices.md | 2 +- .../public/application/services/routing.ts | 2 +- .../public/crud_app/services/routing.js | 2 +- .../private/upgrade_assistant/README.md | 4 +- .../log_rate_analysis/item_filter_popover.tsx | 4 +- .../public/components/cases_context/index.tsx | 2 +- .../plugins/lens/use_lens_button_toggle.ts | 2 +- .../platform/plugins/shared/fleet/README.md | 2 +- .../shared/fleet/common/openapi/README.md | 2 +- .../shared/fleet/dev_docs/data_model.md | 4 +- .../shared/fleet/dev_docs/data_streams.md | 2 +- .../plugins/shared/fleet/package.json | 4 +- .../shared/integration_assistant/README.md | 10 +-- .../log_stream/log_stream.stories.mdx | 8 +-- .../components/log_stream/log_stream.tsx | 2 +- x-pack/platform/plugins/shared/ml/readme.md | 8 +-- .../plugins/shared/osquery/package.json | 6 +- .../alerts_client/classes/alertsclient.md | 65 +++++-------------- .../interfaces/bulkupdateoptions.md | 8 +-- .../interfaces/constructoroptions.md | 8 +-- .../alerts_client/interfaces/updateoptions.md | 8 +-- .../plugins/shared/task_manager/README.md | 4 +- .../shared/triggers_actions_ui/README.md | 16 ++--- .../plugins/apm/dev_docs/apm_queries.md | 12 ++-- .../plugins/apm/dev_docs/telemetry.md | 8 +-- .../plugins/apm/ftr_e2e/README.md | 2 +- .../shared/exploratory_view/README.md | 2 +- .../observability/dev_docs/feature_flags.md | 2 +- .../plugins/profiling/e2e/README.md | 2 +- .../react_router_helpers/link_for_eui.tsx | 2 +- .../react_router_helpers/link_for_eui.tsx | 2 +- .../public/applications/index.tsx | 2 +- .../shared/kibana_chrome/generate_title.ts | 2 +- .../shared/kibana_chrome/set_chrome.tsx | 2 +- .../generate_react_router_props.ts | 2 +- .../lib/enterprise_search_http_agent.ts | 1 - .../server/lib/route_config_helpers.ts | 2 +- .../use_field_value_autocomplete/index.ts | 2 +- .../index.ts | 1 - .../src/types.ts | 2 +- .../security/plugins/lists/README.md | 2 +- ...ng_of_timeline_associated_saved_objects.md | 4 +- .../prebuilt_rules_customization.md | 10 +-- .../public/resolver/documentation/schema.md | 2 +- .../public/sourcerer/components/readme.md | 10 +-- .../create_rule_execution_summary.ts | 2 +- .../components/common/field_label.tsx | 2 +- .../search_strategy/index_fields/index.ts | 4 +- .../plugins/security_solution/package.json | 4 +- 106 files changed, 336 insertions(+), 302 deletions(-) diff --git a/dev_docs/api_welcome.mdx b/dev_docs/api_welcome.mdx index 4295c4453ea5..c0ded69b737a 100644 --- a/dev_docs/api_welcome.mdx +++ b/dev_docs/api_welcome.mdx @@ -44,7 +44,7 @@ This documentation is being automatically generated using an There is one extra step required to have your API docs show up in the _navigation_ of the docs system. Follow the instructions to learn how to configure the navigation menu. The nav file you need to - edit is: [https://github.com/elastic/elastic-docs/blob/main/config/nav-kibana-dev.ts](https://github.com/elastic/elastic-docs/blob/main/config/nav-kibana-dev.ts) + edit is: [https://github.com/elastic/elastic-docs-prototype/blob/master/config/nav-kibana-dev.ts](https://github.com/elastic/elastic-docs-prototype/blob/master/config/nav-kibana-dev.ts) Your API docs will exist in the top level [`api_docs` folder](https://github.com/elastic/kibana/tree/main/api_docs) and will use a doc id of the pattern `kib${PluginName}PluginApi`. @@ -70,7 +70,7 @@ In the short term, the best thing you can do is avoid deeply nested API items. U adding `serviceFolders` in your kibana.jsonc. This will automatically split your docs up based on which APIs are defined within the service folders. They will get built into a doc with an id of `kib${PluginName}${ServiceName}PluginApi`. The data plugin does this, so you - can [check that out as an example](https://github.com/elastic/kibana/blob/main/src/plugins/data/kibana.json#L13). + can [check that out as an example](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/data/kibana.jsonc#L11-L15). If that isn't the case and you are still experiencing performance issues, please file an issue! @@ -78,4 +78,3 @@ They will get built into a doc with an id of If you have any questions or issues, please reach out to the Kibana Tech Leads or create an issue [here](https://github.com/elastic/kibana/issues) and use the label `APIDocs`. - diff --git a/dev_docs/contributing/best_practices.mdx b/dev_docs/contributing/best_practices.mdx index 4251ffb07407..0db949429400 100644 --- a/dev_docs/contributing/best_practices.mdx +++ b/dev_docs/contributing/best_practices.mdx @@ -42,7 +42,7 @@ all of our apps are accessible. ## Localization -Kibana is translated into other languages. Use our i18n utilities to ensure your public facing strings will be translated to ensure all Kibana apps are localized. Read and adhere to our [i18n guidelines](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/GUIDELINE.md) +Kibana is translated into other languages. Use our i18n utilities to ensure your public facing strings will be translated to ensure all Kibana apps are localized. Read and adhere to our [i18n guidelines](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/GUIDELINE.md) Elasticians, check out the #kibana-localization channel to ask questions and receive guidance. diff --git a/dev_docs/contributing/documentation.mdx b/dev_docs/contributing/documentation.mdx index 00254b2a7edc..f8422beb8eb1 100644 --- a/dev_docs/contributing/documentation.mdx +++ b/dev_docs/contributing/documentation.mdx @@ -35,7 +35,7 @@ Internal plugin details can be kept alongside the code it describes. Information -Only `mdx` files with the appropriate are rendered inside the Developer Guide. Read about the syntax . Edit [kibana/nav-kibana-dev.docnav.json](https://github.com/elastic/kibana/blob/main/nav-kibana-dev.docnav.json) to have a link to your document appear in the navigation menu. Read for more details on how to add new content and test locally. +Only `mdx` files with the appropriate are rendered inside the Developer Guide. Read about the syntax . Edit [kibana/nav-kibana-dev.docnav.json](https://github.com/elastic/kibana/blob/main/dev_docs/nav-kibana-dev.docnav.json) to have a link to your document appear in the navigation menu. Read for more details on how to add new content and test locally. @@ -171,7 +171,7 @@ There are three great ways to debug issues with the API infrastructure. 1. Write a test -[api_doc_suite.test.ts](https://github.com/elastic/kibana/blob/main/packages/kbn-docs-utils/src/tests/api_doc_suite.test.ts) is a pretty comprehensive test suite that builds the test docs inside the [**fixtures** folder](https://github.com/elastic/kibana/tree/main/packages/kbn-docs-utils/src/tests/__fixtures__/src). +[api_doc_suite.test.ts](https://github.com/elastic/kibana/blob/main/packages/kbn-docs-utils/src/integration_tests/api_doc_suite.test.ts) is a pretty comprehensive test suite that builds the test docs inside the [**fixtures** folder](https://github.com/elastic/kibana/tree/main/packages/kbn-docs-utils/src/integration_tests/__fixtures__/src). Edit the code inside `__fixtures__` to replicate the bug, write a test to track what should happen, then run `yarn jest api_doc_suite`. diff --git a/dev_docs/getting_started/add_data.mdx b/dev_docs/getting_started/add_data.mdx index a94ec511cda5..acb4432d9492 100644 --- a/dev_docs/getting_started/add_data.mdx +++ b/dev_docs/getting_started/add_data.mdx @@ -40,6 +40,6 @@ node scripts/makelogs --auth : -Security and Observability solution applications only work if data exists in particularly named indices, abiding by our [ECS format](https://www.elastic.co/guide/en/ecs/current/index.html). If you would like to use these applications with realistic data, check out the [oblt_cli tool](https://github.com/elastic/observability-test-environments/blob/master/tools/oblt_cli/README.md). This tool sets you up to connect to a remote Elasticsearch cluster that contains the appropriate data via CCS. +Security and Observability solution applications only work if data exists in particularly named indices, abiding by our [ECS format](https://www.elastic.co/guide/en/ecs/current/index.html). If you would like to use these applications with realistic data, check out the [oblt_cli tool](https://github.com/elastic/observability-test-environments/blob/main/docs/tools/oblt-cli/CONTRIBUTING.md). This tool sets you up to connect to a remote Elasticsearch cluster that contains the appropriate data via CCS. diff --git a/dev_docs/key_concepts/embeddables.mdx b/dev_docs/key_concepts/embeddables.mdx index cb091e82c1ad..8b778e12a227 100644 --- a/dev_docs/key_concepts/embeddables.mdx +++ b/dev_docs/key_concepts/embeddables.mdx @@ -7,4 +7,4 @@ date: 2024-05-09 tags: ['kibana', 'dev', 'contributor', 'api docs'] --- -Embeddable documentation available at [/src/plugins/embeddable/README.md](https://github.com/elastic/kibana/blob/main/src/plugins/embeddable/README.md) +Embeddable documentation available at [@kbn/embeddable-plugin/README.md](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/README.md) diff --git a/dev_docs/key_concepts/navigation.mdx b/dev_docs/key_concepts/navigation.mdx index 9232a8aa193b..5f94ca7cc728 100644 --- a/dev_docs/key_concepts/navigation.mdx +++ b/dev_docs/key_concepts/navigation.mdx @@ -30,7 +30,7 @@ Assuming you want to link from your app to *Discover*. When building such URL th ### Prepending a proper `basePath` -To prepend Kibana's `basePath` use the [core.http.basePath.prepend](https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.ibasepath.prepend.md) helper: +To prepend Kibana's `basePath` use the [core.http.basePath.prepend](https://github.com/elastic/kibana/blob/main/src/core/packages/http/browser-internal/src/base_path.ts) helper: ```tsx const discoverUrl = core.http.basePath.prepend(`/discover`); @@ -50,7 +50,7 @@ console.log(discoverUrl); // http://localhost:5601/bpr/s/space/app/discover const discoverUrlWithSomeState = core.http.basePath.prepend(`/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:'2020-09-10T11:39:50.203Z',to:'2020-09-10T11:40:20.249Z'))&_a=(columns:!(_source),filters:!(),index:'90943e30-9a47-11e8-b64d-95841ca0b247',interval:auto,query:(language:kuery,query:''),sort:!())`); ``` -Instead, each app should expose [a locator](https://github.com/elastic/kibana/blob/main/src/plugins/share/common/url_service/locators/README.md). +Instead, each app should expose [a locator](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/share/common/url_service/locators/README.md). Other apps should use those locators for navigation or URL creation. ```tsx @@ -60,7 +60,7 @@ const discoverUrl = await plugins.discover.locator.getUrl({filters, timeRange}); await plugins.discover.locator.navigate({filters, timeRange}); ``` -To get a better idea, take a look at *Discover* locator [implementation](https://github.com/elastic/kibana/blob/main/src/plugins/discover/public/locator.ts). +To get a better idea, take a look at *Discover* locator [implementation](src/platform/plugins/shared/discover/public/application/context/services/locator.ts). It allows specifying various **Discover** app state pieces like: index pattern, filters, query, time range and more. There are two ways to access locators of other apps: @@ -86,12 +86,12 @@ window.location.href = urlToADashboard; To navigate between different Kibana apps without a page reload there are APIs in `core`: -* [core.application.navigateToApp](https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.applicationstart.navigatetoapp.md) -* [core.application.navigateToUrl](https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.applicationstart.navigatetourl.md) +* [core.application.navigateToApp](https://github.com/elastic/kibana/blob/005a1121cc2b50bfd931838592456716e5eb0bff/docs/development/core/public/kibana-plugin-core-public.applicationstart.navigatetoapp.md) +* [core.application.navigateToUrl](https://github.com/elastic/kibana/blob/005a1121cc2b50bfd931838592456716e5eb0bff/docs/development/core/public/kibana-plugin-core-public.applicationstart.navigatetourl.md) Both methods offer customization such as opening the target in a new page, with an `options` parameter. All the options are optional be default. -* [core.application.navigateToApp options](https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.navigatetoappoptions.md) -* [core.application.navigateToUrl options](https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.navigatetourloptions.md) +* [core.application.navigateToApp options](https://github.com/elastic/kibana/blob/005a1121cc2b50bfd931838592456716e5eb0bff/docs/development/core/public/kibana-plugin-core-public.navigatetoappoptions.md) +* [core.application.navigateToUrl options](https://github.com/elastic/kibana/blob/005a1121cc2b50bfd931838592456716e5eb0bff/docs/development/core/public/kibana-plugin-core-public.navigatetourloptions.md) *Rendering a link to a different app on its own would also cause a full page reload:* @@ -156,9 +156,9 @@ Common rules to follow in this scenario: This is required to make sure `core` is aware of navigations triggered inside your app, so it could act accordingly when needed. -* `Core`'s [ScopedHistory](https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.scopedhistory.md) instance. -* [Example usage](https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.appmountparameters.history.md) -* [Example plugin](https://github.com/elastic/kibana/blob/main/test/plugin_functional/plugins/core_plugin_a/public/application.tsx#L120) +* `Core`'s [ScopedHistory](https://github.com/elastic/kibana/blob/005a1121cc2b50bfd931838592456716e5eb0bff/docs/development/core/public/kibana-plugin-core-public.scopedhistory.md) instance. +* [Example usage](https://github.com/elastic/kibana/blob/005a1121cc2b50bfd931838592456716e5eb0bff/docs/development/core/public/kibana-plugin-core-public.appmountparameters.history.md) +* [Example plugin](https://github.com/elastic/kibana/blob/005a1121cc2b50bfd931838592456716e5eb0bff/test/plugin_functional/plugins/core_plugin_a/public/application.tsx#L120) Relative links will be resolved relative to your app's route (e.g.: `http://localhost5601/app/{your-app-id}`) and setting up internal links in your app in SPA friendly way would look something like: @@ -212,7 +212,7 @@ There are utils to help you to implement such kind of state syncing. - Adding a query param flag or simple key/value to the URL. - Follow [these docs](https://github.com/elastic/kibana/blob/main/src/plugins/kibana_utils/docs/state_sync#state-syncing-utilities) to learn more. + Follow [these docs](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/kibana_utils/docs/state_sync/README.md) to learn more. ## Preserving state between navigations @@ -234,7 +234,7 @@ you'd notice that state is stored inside that link, and it also gets updated whe ![image](../assets/state_inside_the_link.png) This is where separation into `_a` and `_g` query params comes into play. What is considered a *global* state gets constantly updated in those navigation links. In the example above it was a time filter. -This is backed by [KbnUrlTracker](https://github.com/elastic/kibana/blob/main/src/plugins/kibana_utils/public/state_management/url/kbn_url_tracker.ts#L57) util. You can use it to achieve similar behavior. +This is backed by [KbnUrlTracker](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/kibana_utils/public/state_management/url/kbn_url_tracker.ts#L57) util. You can use it to achieve similar behavior. NOTE: After migrating to KP navigation works without page reloads and all plugins are loaded simultaneously. Hence, likely there are simpler ways to preserve state of your application, unless you want to do it through URL. diff --git a/dev_docs/key_concepts/performance/case_studies/case_study_async_too_early.mdx b/dev_docs/key_concepts/performance/case_studies/case_study_async_too_early.mdx index 6b3358476738..79c813018df3 100644 --- a/dev_docs/key_concepts/performance/case_studies/case_study_async_too_early.mdx +++ b/dev_docs/key_concepts/performance/case_studies/case_study_async_too_early.mdx @@ -35,7 +35,7 @@ By filtering the network tab in Chrome for `console`, I was able to see the chun The embedded console consisted of two parts, each being loaded asynchronously in React: the black bottom bar that expands upward to reveal the console, and the console itself: -[![Network tab of Chrome showing the console chunks](./assets/async_too_early_before.png)](./async_too_early_before.png) +[![Network tab of Chrome showing the console chunks](./assets/async_too_early_before.png)](./assets/async_too_early_before.png) The console portion was quite large-- `181k`-- and, given the conditional nature of showing that console, this was a sure sign that _a great deal of code_ was being loaded too early. diff --git a/dev_docs/key_concepts/performance/case_studies/case_study_top_level_imports.mdx b/dev_docs/key_concepts/performance/case_studies/case_study_top_level_imports.mdx index 9a84fb3bfea7..65322388402d 100644 --- a/dev_docs/key_concepts/performance/case_studies/case_study_top_level_imports.mdx +++ b/dev_docs/key_concepts/performance/case_studies/case_study_top_level_imports.mdx @@ -50,7 +50,7 @@ First, I looked at `ml.visualizer.html` in the `target/public` directory of the From there, we can see there's a great deal of `node_modules` being loaded, (the portions in green). While this visualization is useful in determining the size of a chunk relative to others, another visualization tool, [Statoscope](https://statoscope.tech/), is better at showing what as well as _why_ things are included in a chunk: -[![Statoscope showing the contents of the ml.chunk.23.js file](./assets/top_level_imports_stato_modules.png)](./assets/top_level_imports_stato_modules_.png) +[![Statoscope showing the contents of the ml.chunk.23.js file](./assets/top_level_imports_stato_modules.png)](./assets/top_level_imports_stato_modules.png) Knowing what and why the module is large, now we need to find why it's being loaded. diff --git a/dev_docs/key_concepts/persistable_state.mdx b/dev_docs/key_concepts/persistable_state.mdx index 75dae5447ffa..4a19dcdd324a 100644 --- a/dev_docs/key_concepts/persistable_state.mdx +++ b/dev_docs/key_concepts/persistable_state.mdx @@ -49,7 +49,7 @@ If the state your plugin is storing can be provided by other plugins (your plugi Any plugin that stores any persistable state as part of their saved object should make sure that its saved object migration and reference extraction and injection methods correctly use the matching `PersistableStateService` implementation for the state they are storing. -Take a look at [example saved object](https://github.com/elastic/kibana/blob/main/examples/embeddable_examples/server/searchable_list_saved_object.ts#L32) which stores an embeddable state. Note how the `migrations`, `extractReferences` and `injectReferences` are defined. +Take a look at [example saved object](https://github.com/elastic/kibana/blob/8.9/examples/embeddable_examples/server/searchable_list_saved_object.ts#L32) which stores an embeddable state. Note how the `migrations`, `extractReferences` and `injectReferences` are defined. ## Storing persistable state as part of URL @@ -71,7 +71,7 @@ To support persisting your state in saved objects owned by another plugin, the < text="Learn how to define Saved Object references" /> -[See example embeddable providing extract/inject functions](https://github.com/elastic/kibana/blob/main/examples/embeddable_examples/public/migrations/migrations_embeddable_factory.ts) +[See example embeddable providing extract/inject functions](https://github.com/elastic/kibana/blob/8.9/examples/embeddable_examples/public/migrations/migrations_embeddable_factory.ts) ### Migrations and Backward compatibility @@ -79,9 +79,9 @@ As your plugin evolves, you may need to change your state in a breaking way. If . -[See an example saved object storing embeddable state implementing saved object migration function](https://github.com/elastic/kibana/blob/main/examples/embeddable_examples/server/searchable_list_saved_object.ts) +[See an example saved object storing embeddable state implementing saved object migration function](https://github.com/elastic/kibana/blob/8.9/examples/embeddable_examples/server/searchable_list_saved_object.ts) -[See example embeddable providing migration functions](https://github.com/elastic/kibana/blob/main/examples/embeddable_examples/public/migrations/migrations_embeddable_factory.ts) +[See example embeddable providing migration functions](https://github.com/elastic/kibana/blob/8.9/examples/embeddable_examples/public/migrations/migrations_embeddable_factory.ts) ## Telemetry diff --git a/dev_docs/tutorials/data/search.mdx b/dev_docs/tutorials/data/search.mdx index 4c64dc0b0216..8fee76dccf79 100644 --- a/dev_docs/tutorials/data/search.mdx +++ b/dev_docs/tutorials/data/search.mdx @@ -19,7 +19,7 @@ Here is a basic example for using the `data.search` service from a custom plugin ```ts import { CoreStart, Plugin } from '@kbn/core/public'; -import { DataPublicPluginStart, isCompleteResponse, isErrorResponse } from import { DataPublicPluginStart, isCompleteResponse, isErrorResponse } from '../../src/plugins/data'; +import { DataPublicPluginStart, isCompleteResponse, isErrorResponse } from '@kbn/data-plugin/public'; export interface MyPluginStartDependencies { data: DataPublicPluginStart; @@ -103,7 +103,7 @@ data.search.search(req).subscribe({ The search service `search` method supports a second argument called `options`. One of these options provides an `abortSignal` to stop searches from running to completion, if the result is no longer needed. ```ts -import { AbortError } from '../../src/data/public'; +import { AbortError } from '@kbn/kibana-utils-plugin/common'; const abortController = new AbortController(); data.search diff --git a/docs/developer/advanced/sharing-saved-objects.asciidoc b/docs/developer/advanced/sharing-saved-objects.asciidoc index 2baae57b7e7d..78ab565d7abf 100644 --- a/docs/developer/advanced/sharing-saved-objects.asciidoc +++ b/docs/developer/advanced/sharing-saved-objects.asciidoc @@ -390,7 +390,7 @@ const warningMessage = ``` The <> in <> uses a -https://github.com/elastic/kibana/blob/{branch}/src/platform/plugins/shared/data_view_management/public/components/edit_index_pattern/edit_index_pattern.tsx[similar +{kib-repo}blob/{branch}/src/platform/plugins/shared/data_view_management/public/components/edit_index_pattern/edit_index_pattern.tsx[similar approach] to show a warning in its delete confirmation modal: image::images/sharing-saved-objects-step-7.png["Sharing Saved Objects deletion warning"] @@ -407,7 +407,7 @@ this in two ways, and many consumers will want to implement both: the spaces plugin, and you can use them in your own application. + First, make sure your page contents are wrapped in a -https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/spaces_context/types.ts[spaces context provider]: +{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/spaces/public/spaces_context/types.ts[spaces context provider]: + ```tsx const ContextWrapper = useMemo( @@ -425,11 +425,11 @@ return ( ); ``` + -Second, display a https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/space_list/types.ts[list of spaces] for an +Second, display a {kib-repo}blob/{branch}/x-pack/platform/plugins/shared/spaces/public/space_list/types.ts[list of spaces] for an object, and third, show a -https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/share_saved_objects_to_space/types.ts[flyout] for the user to +{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/spaces/public/share_saved_objects_to_space/types.ts[flyout] for the user to edit the object's assigned spaces. You may want to follow the example of the <> and -https://github.com/elastic/kibana/blob/{branch}/src/platform/plugins/shared/data_view_management/public/components/index_pattern_table/spaces_list.tsx[combine +{kib-repo}blob/{branch}/src/platform/plugins/shared/data_view_management/public/components/index_pattern_table/spaces_list.tsx[combine these into a single component] so that the space list can be clicked to show the flyout: + ```tsx diff --git a/docs/developer/architecture/core/saved-objects-service.asciidoc b/docs/developer/architecture/core/saved-objects-service.asciidoc index 4b1d36b52985..78418211cec7 100644 --- a/docs/developer/architecture/core/saved-objects-service.asciidoc +++ b/docs/developer/architecture/core/saved-objects-service.asciidoc @@ -100,7 +100,7 @@ by a type will be nested under a top-level field that matches the type name. For example, the mappings defined by the `search` Saved Object type: -https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/saved_search/server/saved_objects/search.ts#L19-L70[.src/platform/plugins/shared/saved_search/server/saved_objects/search.ts] +{kib-repo}blob/{branch}/src/platform/plugins/shared/saved_search/server/saved_objects/search.ts#L19-L70[search.ts] [source,typescript] ---- import { SavedObjectsType } from 'src/core/server'; @@ -166,19 +166,19 @@ Saved Objects support changes using `modelVersions``. The modelVersion API is a Model versions are decoupled from the stack version and satisfy the requirements for zero downtime and backward-compatibility. -Each Saved Object type may define model versions for its schema and are bound to a given https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L22-L27[savedObject type]. Changes to a saved object type are +Each Saved Object type may define model versions for its schema and are bound to a given {kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L22-L27[savedObject type]. Changes to a saved object type are specified by defining a new model. === Defining model versions As for old migrations, model versions are bound to a given -https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L22-L27[savedObject +{kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L22-L27[savedObject type] When registering a SO type, a new -https://github.com/elastic/kibana/blob/9a6a2ccdff619f827b31c40dd9ed30cb27203da7/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L138-L177[modelVersions] +{kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L138-L177[modelVersions] property is available. This attribute is a map of -https://github.com/elastic/kibana/blob/9a6a2ccdff619f827b31c40dd9ed30cb27203da7/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L12-L20[SavedObjectsModelVersion] +{kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L12-L20[SavedObjectsModelVersion] which is the top-level type/container to define model versions. This map follows a similar `{ [version number] => version definition }` @@ -223,7 +223,7 @@ const myType: SavedObjectsType = { === Structure of a model version -https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L12-L20[Model +{kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L12-L20[Model versions] are not just functions as the previous migrations were, but structured objects describing how the version behaves and what changed since the last one. @@ -289,7 +289,7 @@ It’s currently composed of two main properties: ==== changes -https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L21-L51[link +{kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L21-L51[link to the TS doc for `changes`] Describes the list of changes applied during this version. @@ -408,7 +408,7 @@ theoretically shouldn’t.* ==== schemas -https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/model_version/schemas.ts#L11-L16[link +{kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/model_version/schemas.ts#L11-L16[link to the TS doc for `schemas`] The schemas associated with this version. Schemas are used to validate @@ -477,7 +477,7 @@ inter-version compatibility themselves in their service layer instead._ ===== create This is a direct replacement for -https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L75-L82[the +{kib-repo}blob/{branch}/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L75-L82[the old SavedObjectType.schemas] definition, now directly included in the model version definition. diff --git a/docs/developer/contributing/interpreting-ci-failures.asciidoc b/docs/developer/contributing/interpreting-ci-failures.asciidoc index 976b3aded365..3f5e27687e98 100644 --- a/docs/developer/contributing/interpreting-ci-failures.asciidoc +++ b/docs/developer/contributing/interpreting-ci-failures.asciidoc @@ -33,8 +33,8 @@ image::images/test_results.png[Buildkite build screenshot] Looking at the failure, we first look at the Error and stack trace. In the example below, this test failed to find an element within the timeout; `Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createSpace"])` -We know the test file from the stack trace was on line 50 of `test/accessibility/apps/spaces.ts` (this test and the stack trace context is kibana/x-pack/ so the file is https://github.com/elastic/kibana/blob/main/x-pack/test/accessibility/apps/group1/spaces.ts#L50). -The function to click on the element was called from a page object method in `test/functional/page_objects/space_selector_page.ts` https://github.com/elastic/kibana/blob/main/x-pack/test/functional/page_objects/space_selector_page.ts#L58 +We know the test file from the stack trace was on line 50 of `test/accessibility/apps/spaces.ts` (this test and the stack trace context is kibana/x-pack/ so the file is {kib-repo}blob/{branch}/x-pack/test/accessibility/apps/group1/spaces.ts#L50). +The function to click on the element was called from a page object method in `test/functional/page_objects/space_selector_page.ts` {kib-repo}blob/{branch}/x-pack/test/functional/page_objects/space_selector_page.ts#L58 [00:03:36] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createSpace"]) diff --git a/docs/settings/cases-settings.asciidoc b/docs/settings/cases-settings.asciidoc index 77c1a514e1c0..cba3e6f9e940 100644 --- a/docs/settings/cases-settings.asciidoc +++ b/docs/settings/cases-settings.asciidoc @@ -9,7 +9,7 @@ To provide greater control over case features, you can configure the following s `xpack.cases.files.allowedMimeTypes`:: The MIME types that you can attach to a case, represented in an array of strings. For example: `['image/tiff','text/csv','application/zip'].` -The default MIME types are specified in https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/cases/common/constants/mime_types.ts[mime_types.ts]. +The default MIME types are specified in {kib-repo}blob/{branch}/x-pack/platform/plugins/shared/cases/common/constants/mime_types.ts[mime_types.ts]. `xpack.cases.files.maxSize`:: The size limit for files that you can attach to a case, represented as the number of bytes. By default, the limit is 10 MiB for images and 100 MiB for all other MIME types. If you specify a value for this setting, it affects all file types. diff --git a/docs/upgrade-notes.asciidoc b/docs/upgrade-notes.asciidoc index 422338396efb..d35a35ff686a 100644 --- a/docs/upgrade-notes.asciidoc +++ b/docs/upgrade-notes.asciidoc @@ -23,8 +23,8 @@ ADD INSTRUCTIONS FOR USERS LOOKING TO UPGRADE. HOW CAN THEY WORK AROUND THIS? 1. Copy and edit the template in the right section of this file. Most recent entries should be at the top of the section, search for sections using the text "[float]". 2. Edit the anchor ID [[REPO-PR]] of the template with proper values. 3. Don't hardcode the link to the new entry. Instead, make it available through the doc link service files: - - https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts - - https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-doc-links/src/types.ts + - {kib-repo}blob/{branch}/src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts + - {kib-repo}blob/{branch}/src/platform/packages/shared/kbn-doc-links/src/types.ts The entry in the main links file should look like this: diff --git a/examples/data_view_field_editor_example/public/plugin.tsx b/examples/data_view_field_editor_example/public/plugin.tsx index 8707d8f4f148..b352879072ee 100644 --- a/examples/data_view_field_editor_example/public/plugin.tsx +++ b/examples/data_view_field_editor_example/public/plugin.tsx @@ -41,7 +41,7 @@ export class DataViewFieldEditorPlugin implements Plugin here diff --git a/examples/expressions_explorer/public/plugin.tsx b/examples/expressions_explorer/public/plugin.tsx index d03008bb1653..be12008b01e0 100644 --- a/examples/expressions_explorer/public/plugin.tsx +++ b/examples/expressions_explorer/public/plugin.tsx @@ -75,7 +75,7 @@ export class ExpressionsExplorerPlugin implements Plugin { links: [ { label: 'IRouter', - href: 'https://github.com/elastic/kibana/blob/main/docs/development/core/server/kibana-plugin-core-server.irouter.md', + href: 'https://github.com/elastic/kibana/blob/8.3/docs/development/core/server/kibana-plugin-core-server.irouter.md', iconType: 'logoGithub', target: '_blank', size: 's', }, { label: 'HttpHandler (core.http.fetch)', - href: 'https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.httphandler.md', + href: 'https://github.com/elastic/kibana/blob/8.3/docs/development/core/public/kibana-plugin-core-public.httphandler.md', iconType: 'logoGithub', target: '_blank', size: 's', diff --git a/examples/search_examples/public/application.tsx b/examples/search_examples/public/application.tsx index 7ec714637041..d0ed25008192 100644 --- a/examples/search_examples/public/application.tsx +++ b/examples/search_examples/public/application.tsx @@ -35,7 +35,7 @@ const LINKS: ExampleLink[] = [ title: 'Search Sessions', }, { - path: 'https://github.com/elastic/kibana/blob/main/src/plugins/data/README.mdx', + path: 'https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/data/README.mdx', title: 'README (GitHub)', }, ]; diff --git a/examples/ui_actions_explorer/public/overview.tsx b/examples/ui_actions_explorer/public/overview.tsx index 9e563bb841cc..4c5fed37cfb1 100644 --- a/examples/ui_actions_explorer/public/overview.tsx +++ b/examples/ui_actions_explorer/public/overview.tsx @@ -28,7 +28,7 @@ export const Overview = () => {
  • Action is a{' '} class diff --git a/examples/ui_actions_explorer/public/plugin.tsx b/examples/ui_actions_explorer/public/plugin.tsx index 00c939f5ab61..c40a7cd0b8e6 100644 --- a/examples/ui_actions_explorer/public/plugin.tsx +++ b/examples/ui_actions_explorer/public/plugin.tsx @@ -81,7 +81,7 @@ export class UiActionsExplorerPlugin implements Plugin { ### 3.1.3 Saved Objects Client: Security wrapper -The [security wrapper](https://github.com/elastic/kibana/blob/701697cc4a34d07c0508c3bdf01dca6f9d40a636/x-pack/plugins/security/server/saved_objects/secure_saved_objects_client_wrapper.ts) authorizes and audits operations against saved objects. +The [security wrapper](https://github.com/elastic/kibana/blob/8.6/x-pack/plugins/security/server/saved_objects/secure_saved_objects_client_wrapper.ts) authorizes and audits operations against saved objects. There are two primary changes to this wrapper: @@ -170,7 +204,7 @@ This overhead does not impact deleting "public" objects. We only need to retriev ### `find` -The security wrapper will supply or augment a [KQL `filter`](https://github.com/elastic/kibana/blob/701697cc4a34d07c0508c3bdf01dca6f9d40a636/src/core/server/saved_objects/types.ts#L118) which describes the objects the current user is authorized to see. +The security wrapper will supply or augment a [KQL `filter`](https://github.com/elastic/kibana/blob/main/src/core/packages/saved-objects/api-server/src/apis/find.ts#L117) which describes the objects the current user is authorized to see. ```ts // Sample KQL filter diff --git a/legacy_rfcs/text/0020_nodejs_clustering.md b/legacy_rfcs/text/0020_nodejs_clustering.md index 99da77989bfc..5ed1e1c6b424 100644 --- a/legacy_rfcs/text/0020_nodejs_clustering.md +++ b/legacy_rfcs/text/0020_nodejs_clustering.md @@ -9,14 +9,57 @@ - [2. Motivation](#2-motivation) - [3. Architecture](#3-architecture) - [4. Testing](#4-testing) + - [4.1 Local testing](#41-local-testing) + - [4.1.1 Raw results](#411-raw-results) + - [Non-clustered mode](#non-clustered-mode) + - [Clustered mode, 2 workers](#clustered-mode-2-workers) + - [Clustered mode, 4 workers](#clustered-mode-4-workers) + - [4.1.2 Analysis](#412-analysis) + - [4.2 Testing against cloud](#42-testing-against-cloud) - [5. Detailed design](#5-detailed-design) + - [5.1 Enabling clustering mode](#51-enabling-clustering-mode) + - [5.2 Cross-worker communication](#52-cross-worker-communication) + - [5.3 Executing code on a single worker](#53-executing-code-on-a-single-worker) + - [5.4 The node service API](#54-the-node-service-api) + - [5.4.1 Example: Saved Object Migrations](#541-example-saved-object-migrations) + - [5.5 Sharing state between workers](#55-sharing-state-between-workers) - [6. Technical impact](#6-technical-impact) - - [6.1 Technical impact on Core](#6.1-technical-impact-on-core) - - [6.2 Technical impact on Plugins](#6.2-technical-impact-on-plugins) - - [6.3 Summary of breaking changes](#6.3-summary-of-breaking-changes) + - [6.1 Technical impact on Core](#61-technical-impact-on-core) + - [6.1.1 Handling multi-process logs](#611-handling-multi-process-logs) + - [Options we considered:](#options-we-considered) + - [Our recommended approach:](#our-recommended-approach) + - [6.1.2 The rolling-file appender](#612-the-rolling-file-appender) + - [Options we considered:](#options-we-considered-1) + - [Our recommended approach:](#our-recommended-approach-1) + - [6.1.3 The status API](#613-the-status-api) + - [6.1.4 The stats API \& metrics service](#614-the-stats-api--metrics-service) + - [Options we considered:](#options-we-considered-2) + - [Our recommended approach:](#our-recommended-approach-2) + - [6.1.5 PID file](#615-pid-file) + - [6.1.6 Saved Objects migration](#616-saved-objects-migration) + - [6.1.7 Memory consumption](#617-memory-consumption) + - [6.1.8 Workers error handling](#618-workers-error-handling) + - [6.1.9 Data folder](#619-data-folder) + - [6.1.10 instanceUUID](#6110-instanceuuid) + - [6.2 Technical impact on Plugins](#62-technical-impact-on-plugins) + - [6.2.1 What types of things could break?](#621-what-types-of-things-could-break) + - [Concurrent access to the same resources](#concurrent-access-to-the-same-resources) + - [Using instanceUUID as a unique Kibana process identifier](#using-instanceuuid-as-a-unique-kibana-process-identifier) + - [Things needing to run only once per Kibana instance](#things-needing-to-run-only-once-per-kibana-instance) + - [6.2.2 Identified required changes](#622-identified-required-changes) + - [Reporting](#reporting) + - [Telemetry](#telemetry) + - [Task Manager](#task-manager) + - [Alerting](#alerting) + - [6.3 Summary of breaking changes](#63-summary-of-breaking-changes) + - [6.3.1 `/stats` API \& metrics service](#631-stats-api--metrics-service) - [7. Drawbacks](#7-drawbacks) - [8. Alternatives](#8-alternatives) - [9. Adoption strategy](#9-adoption-strategy) + - [Phase 0](#phase-0) + - [Phase 1](#phase-1) + - [Phase 2](#phase-2) + - [Phase 3](#phase-3) - [10. How we teach this](#10-how-we-teach-this) - [11. Unresolved questions](#11-unresolved-questions) - [12. Resolved questions](#12-resolved-questions) @@ -571,7 +614,7 @@ Kibana instance, only one worker should have polling enabled. #### Reporting We will probably want to restrict to a single headless per Kibana instance. For that, we will have to change the logic -in [createQueueFactory](https://github.com/elastic/kibana/blob/4584a8b570402aa07832cf3e5b520e5d2cfa7166/x-pack/platform/plugins/private/reporting/server/lib/create_queue.ts#L60-L64) +in [createQueueFactory](https://github.com/elastic/kibana/blob/4584a8b570402aa07832cf3e5b520e5d2cfa7166/x-pack/plugins/reporting/server/lib/create_queue.ts#L60-L64) to only have the 'main' worker be polling for reporting tasks. #### Telemetry diff --git a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_metrics_aggregator.ts b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_metrics_aggregator.ts index e99b8439cc7e..e524a535ab6e 100644 --- a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_metrics_aggregator.ts +++ b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_metrics_aggregator.ts @@ -25,7 +25,7 @@ export function createServiceMetricsAggregator(flushInterval: string) { { filter: (event) => event['processor.event'] === 'transaction', getAggregateKey: (event) => { - // see https://github.com/elastic/apm-server/blob/main/x-pack/apm-server/aggregation/txmetrics/aggregator.go + // see https://github.com/elastic/apm-server/blob/8.10/x-pack/apm-server/aggregation/txmetrics/aggregator.go return hashKeysOf(event, KEY_FIELDS); }, flushInterval, diff --git a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_summary_metrics_aggregator.ts b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_summary_metrics_aggregator.ts index a9cc22b57ec7..32c4519f60b0 100644 --- a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_summary_metrics_aggregator.ts +++ b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_service_summary_metrics_aggregator.ts @@ -23,7 +23,7 @@ export function createServiceSummaryMetricsAggregator(flushInterval: string) { { filter: () => true, getAggregateKey: (event) => { - // see https://github.com/elastic/apm-server/blob/main/x-pack/apm-server/aggregation/txmetrics/aggregator.go + // see https://github.com/elastic/apm-server/blob/8.10/x-pack/apm-server/aggregation/txmetrics/aggregator.go return hashKeysOf(event, KEY_FIELDS); }, flushInterval, diff --git a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_span_metrics_aggregator.ts b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_span_metrics_aggregator.ts index a3a1e2633be5..73fa44bd3a85 100644 --- a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_span_metrics_aggregator.ts +++ b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_span_metrics_aggregator.ts @@ -28,7 +28,7 @@ export function createSpanMetricsAggregator(flushInterval: string) { filter: (event) => event['processor.event'] === 'span' && !!event['span.destination.service.resource'], getAggregateKey: (event) => { - // see https://github.com/elastic/apm-server/blob/main/x-pack/apm-server/aggregation/spanmetrics/aggregator.go + // see https://github.com/elastic/apm-server/blob/8.10/x-pack/apm-server/aggregation/spanmetrics/aggregator.go const key = hashKeysOf(event, KEY_FIELDS); return key; }, diff --git a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_transaction_metrics_aggregator.ts b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_transaction_metrics_aggregator.ts index 060e1197a7c3..978b06641f87 100644 --- a/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_transaction_metrics_aggregator.ts +++ b/packages/kbn-apm-synthtrace/src/lib/apm/aggregators/create_transaction_metrics_aggregator.ts @@ -57,7 +57,7 @@ export function createTransactionMetricsAggregator(flushInterval: string) { { filter: (event) => event['processor.event'] === 'transaction', getAggregateKey: (event) => { - // see https://github.com/elastic/apm-server/blob/main/x-pack/apm-server/aggregation/txmetrics/aggregator.go + // see https://github.com/elastic/apm-server/blob/8.10/x-pack/apm-server/aggregation/txmetrics/aggregator.go let key = hashKeysOf(event, KEY_FIELDS); key = appendHash(key, event['parent.id'] ? '1' : '0'); return key; diff --git a/packages/kbn-dev-cli-runner/README.mdx b/packages/kbn-dev-cli-runner/README.mdx index cb4582cc9e73..eb78b42b6cb5 100644 --- a/packages/kbn-dev-cli-runner/README.mdx +++ b/packages/kbn-dev-cli-runner/README.mdx @@ -79,7 +79,7 @@ $ node scripts/my_task Execte an async function, passing it the parsed flags and a tooling log that is configured to the requested logging level. If the returned promise is rejected with an error created by `createFailError(...)` or `createFlagError(...)` the process will exit as described by the error, otherwise the process will exit with code 1. **`fn` Params:** - - *[`log: ToolingLog`](../../../packages/kbn-dev-utils/src/tooling_log/tooling_log.js)*: + - *[`log: ToolingLog`](../../packages/kbn-tooling-log/src/tooling_log.ts)*: An instance of the `ToolingLog` that is configured with the standard flags: `--verbose`, `--quiet`, `--silent`, and `--debug` diff --git a/packages/kbn-optimizer/README.mdx b/packages/kbn-optimizer/README.mdx index 1aee75914599..d95b1b735ea5 100644 --- a/packages/kbn-optimizer/README.mdx +++ b/packages/kbn-optimizer/README.mdx @@ -142,4 +142,4 @@ For an example of how to handle these states checkout the [`logOptimizerState()` [OptimizerConfig]: https://github.com/elastic/kibana/blob/main/packages/kbn-optimizer/src/optimizer/optimizer_config.ts [LogOptimizerState]: https://github.com/elastic/kibana/blob/main/packages/kbn-optimizer/src/log_optimizer_state.ts [AssignBundlesToWorkers]: https://github.com/elastic/kibana/blob/main/packages/kbn-optimizer/src/optimizer/assign_bundles_to_workers.ts -[BuildTask]: https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/build_kibana_platform_plugins.js \ No newline at end of file +[BuildTask]: https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/build_kibana_platform_plugins.ts diff --git a/scripts/README.md b/scripts/README.md index a743ce5e1d53..7ddb6bffbcdb 100644 --- a/scripts/README.md +++ b/scripts/README.md @@ -19,11 +19,11 @@ This directory is excluded from the build and tools within it should help users **`node scripts/functional_tests [--config test/functional/config.base.js --config test/api_integration/config.js]`** -Runs all the functional tests: selenium tests and api integration tests. List configs with multiple `--config` arguments. Uses the [@kbn/test](../packages/kbn-test) library to run Elasticsearch and Kibana servers and tests against those servers, for multiple server+test setups. In particular, calls out to [`runTests()`](../packages/kbn-test/src/functional_tests/tasks.js). Can be run on a single config. +Runs all the functional tests: selenium tests and api integration tests. List configs with multiple `--config` arguments. Uses the [@kbn/test](../packages/kbn-test) library to run Elasticsearch and Kibana servers and tests against those servers, for multiple server+test setups. In particular, calls out to [`runTests()`](../packages/kbn-test/src/functional_tests/run_tests/run_tests.ts). Can be run on a single config. **`node scripts/functional_tests_server [--config test/functional/config.base.js]`** -Starts just the Elasticsearch and Kibana servers given a single config, i.e. via `--config test/functional/config.base.js` or `--config test/api_integration/config`. Allows the user to start just the servers with this script, and keep them running while running tests against these servers. The idea is that the same config file configures both Elasticsearch and Kibana servers. Uses the [`startServers()`](../packages/kbn-test/src/functional_tests/tasks.js#L52-L80) method from [@kbn/test](../packages/kbn-test) library. +Starts just the Elasticsearch and Kibana servers given a single config, i.e. via `--config test/functional/config.base.js` or `--config test/api_integration/config`. Allows the user to start just the servers with this script, and keep them running while running tests against these servers. The idea is that the same config file configures both Elasticsearch and Kibana servers. Uses the [`startServers()`](../packages/kbn-test/src/functional_tests/start_servers/start_servers.ts#L27-L89) method from [@kbn/test](../packages/kbn-test) library. Example. Start servers _and_ run tests, separately, but using the same config: @@ -39,7 +39,7 @@ In another terminal: node scripts/functional_test_runner --config path/to/config ``` -For details on how the internal methods work, [read this readme](../packages/kbn-test/README.md). +For details on how the internal methods work, [read this readme](../packages/kbn-test/README.mdx). ### ES archiver @@ -65,4 +65,4 @@ node scripts/es_archiver.js save [space separated ``` You may want to store the .kibana index separate from data. Since adding a lot of data will bloat our repo size, we have many tests that reuse the same -data indices but use their own `.kibana` index. +data indices but use their own `.kibana` index. \ No newline at end of file diff --git a/src/core/packages/chrome/browser-internal/src/ui/header/screen_reader_a11y.tsx b/src/core/packages/chrome/browser-internal/src/ui/header/screen_reader_a11y.tsx index 97c40ff2eaef..c86e6e2dcb40 100644 --- a/src/core/packages/chrome/browser-internal/src/ui/header/screen_reader_a11y.tsx +++ b/src/core/packages/chrome/browser-internal/src/ui/header/screen_reader_a11y.tsx @@ -15,7 +15,7 @@ import { i18n } from '@kbn/i18n'; import type { InternalApplicationStart } from '@kbn/core-application-browser-internal'; import type { HeaderProps } from './header'; -const DEFAULT_BRAND = 'Elastic'; // This may need to be DRYed out with https://github.com/elastic/kibana/blob/main/packages/core/rendering/core-rendering-server-internal/src/views/template.tsx#L34 +const DEFAULT_BRAND = 'Elastic'; // This may need to be DRYed out with https://github.com/elastic/kibana/blob/main/src/core/packages/rendering/server-internal/src/views/template.tsx#L35 const SEPARATOR = ' - '; export const ScreenReaderRouteAnnouncements: FC<{ diff --git a/src/core/packages/saved-objects/migration-server-internal/src/README.md b/src/core/packages/saved-objects/migration-server-internal/src/README.md index ebeea457bb62..862733a43943 100644 --- a/src/core/packages/saved-objects/migration-server-internal/src/README.md +++ b/src/core/packages/saved-objects/migration-server-internal/src/README.md @@ -144,7 +144,7 @@ able to successfully complete the migration once the cluster has enough heap. For more background information on the problem see the [saved object migrations -RFC](https://github.com/elastic/kibana/blob/main/rfcs/text/0013_saved_object_migrations.md). +RFC](https://github.com/elastic/kibana/blob/main/legacy_rfcs/text/0013_saved_object_migrations.md). # Algorithm steps diff --git a/src/core/packages/saved-objects/server/docs/model_versions.md b/src/core/packages/saved-objects/server/docs/model_versions.md index 098f399686b7..f3d67d6d299d 100644 --- a/src/core/packages/saved-objects/server/docs/model_versions.md +++ b/src/core/packages/saved-objects/server/docs/model_versions.md @@ -2,25 +2,36 @@ ## Table of contents -- [Introduction](#introduction) -- [What are model versions trying to solve?](#what-are-model-versions-trying-to-solve) -- [Defining model versions](#defining-model-versions) -- [Structure of a model version](#structure-of-a-model-version) - - [changes](#changes) - - [schemas](#schemas) -- [Examples](#use-case-examples) - - [Adding a non-indexed field without default value](#adding-a-non-indexed-field-without-default-value) - - [Adding an indexed field without default value](#adding-an-indexed-field-without-default-value) - - [Adding an indexed field with a default value](#adding-an-indexed-field-with-a-default-value) - - [Removing an existing field](#removing-an-existing-field) -- [Testing model versions](#testing-model-versions) - - [Tooling for unit tests](#tooling-for-unit-tests) - - [Model version test migrator](#model-version-test-migrator) - - [Tooling for integration tests](#tooling-for-integration-tests) - - [Model version test bed](#model-version-test-bed) -- [Limitations and edge cases in serverless environments](#limitations-and-edge-cases-in-serverless-environments) - - [Using the fields option of the find api](#using-the-fields-option-of-the-find-savedobjects-api) - - [Using update with dynamically backfilled fields](#using-update-with-dynamically-backfilled-fields) +- [savedObjects: Model Version API](#savedobjects-model-version-api) + - [Table of contents](#table-of-contents) + - [Introduction](#introduction) + - [What are model versions trying to solve?](#what-are-model-versions-trying-to-solve) + - [1. SO type versioning was tightly coupled to stack versioning](#1-so-type-versioning-was-tightly-coupled-to-stack-versioning) + - [2. The current migrations API is unsafe for the zero-downtime and backward-compatible requirements](#2-the-current-migrations-api-is-unsafe-for-the-zero-downtime-and-backward-compatible-requirements) + - [Defining model versions](#defining-model-versions) + - [Structure of a model version](#structure-of-a-model-version) + - [changes](#changes) + - [- mappings\_addition](#--mappings_addition) + - [- mappings\_deprecation](#--mappings_deprecation) + - [- data\_backfill](#--data_backfill) + - [- data\_removal](#--data_removal) + - [- unsafe\_transform](#--unsafe_transform) + - [schemas](#schemas) + - [forwardCompatibility](#forwardcompatibility) + - [create](#create) + - [Use-case examples](#use-case-examples) + - [Adding a non-indexed field without default value](#adding-a-non-indexed-field-without-default-value) + - [Adding an indexed field without default value](#adding-an-indexed-field-without-default-value) + - [Adding an indexed field with a default value](#adding-an-indexed-field-with-a-default-value) + - [Removing an existing field](#removing-an-existing-field) + - [Testing model versions](#testing-model-versions) + - [Tooling for unit tests](#tooling-for-unit-tests) + - [Model version test migrator](#model-version-test-migrator) + - [Tooling for integration tests](#tooling-for-integration-tests) + - [Model version test bed](#model-version-test-bed) + - [Limitations and edge cases in serverless environments](#limitations-and-edge-cases-in-serverless-environments) + - [Using the `fields` option of the `find` savedObjects API](#using-the-fields-option-of-the-find-savedobjects-api) + - [Using `bulkUpdate` for fields with large `json` blobs](#using-bulkupdate-for-fields-with-large-json-blobs) ## Introduction @@ -70,10 +81,10 @@ unsafe given our backward compatibility requirements. ## Defining model versions -As for old migrations, model versions are bound to a given [savedObject type](https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L22-L27) +As for old migrations, model versions are bound to a given [savedObject type](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L23-L27) -When registering a SO type, a new [modelVersions](https://github.com/elastic/kibana/blob/9a6a2ccdff619f827b31c40dd9ed30cb27203da7/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L138-L177) -property is available. This attribute is a map of [SavedObjectsModelVersion](https://github.com/elastic/kibana/blob/9a6a2ccdff619f827b31c40dd9ed30cb27203da7/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L12-L20) +When registering a SO type, a new [modelVersions](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L149-L188) +property is available. This attribute is a map of [SavedObjectsModelVersion](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L13-L21) which is the top-level type/container to define model versions. This map follows a similar `{ [version number] => version definition }` format as the old migration map, however @@ -113,7 +124,7 @@ const myType: SavedObjectsType = { ## Structure of a model version -[Model versions](https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L12-L20) +[Model versions](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L13-L21) are not just functions as the previous migrations were, but structured objects describing how the version behaves and what changed since the last one. *A base example of what a model version can look like:* @@ -175,7 +186,7 @@ It's currently composed of two main properties: ### changes -[link to the TS doc for `changes`](https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L21-L51) +[link to the TS doc for `changes`](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/src/core/packages/saved-objects/server/src/model_version/model_version.ts#L22-L73) Describes the list of changes applied during this version. @@ -281,7 +292,7 @@ let change: SavedObjectsModelUnsafeTransformChange = { ### schemas -[link to the TS doc for `schemas`](https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/model_version/schemas.ts#L11-L16) +[link to the TS doc for `schemas`](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/src/core/packages/saved-objects/server/src/model_version/schemas.ts#L13-L18) The schemas associated with this version. Schemas are used to validate or convert SO documents at various stages of their lifecycle. @@ -335,7 +346,7 @@ const versionSchema: SavedObjectModelVersionEvictionFn = (attributes) => { #### create -This is a direct replacement for [the old SavedObjectType.schemas](https://github.com/elastic/kibana/blob/9b330e493216e8dde3166451e4714966f63f5ab7/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L75-L82) +This is a direct replacement for [the old SavedObjectType.schemas](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/src/core/packages/saved-objects/server/src/saved_objects_type.ts#L85-L93) definition, now directly included in the model version definition. As a refresher the `create` schema is a `@kbn/config-schema` object-type schema, and is used to validate the properties of the document diff --git a/src/core/server/docs/kib_core_deprecations_service.mdx b/src/core/server/docs/kib_core_deprecations_service.mdx index 1cf5fd50869f..812ba92be23f 100644 --- a/src/core/server/docs/kib_core_deprecations_service.mdx +++ b/src/core/server/docs/kib_core_deprecations_service.mdx @@ -40,7 +40,7 @@ optional parameter to customize the deprecation details. To read more about the deprecation functions check `/kibana-dev-docs/corePluginApi` in the new doc system under `core.ConfigDeprecationFactory`. You can also check the `ConfigDeprecationFactory` -[interface docs](../../../../../packages/kbn-config/src/deprecation/types.ts). +[interface docs](../../../../src/platform/packages/shared/kbn-config/src/deprecation/types.ts). ### Example ```ts diff --git a/src/platform/packages/private/shared-ux/page/kibana_no_data/impl/README.mdx b/src/platform/packages/private/shared-ux/page/kibana_no_data/impl/README.mdx index f74adf2465e3..42081240fd42 100644 --- a/src/platform/packages/private/shared-ux/page/kibana_no_data/impl/README.mdx +++ b/src/platform/packages/private/shared-ux/page/kibana_no_data/impl/README.mdx @@ -14,7 +14,7 @@ The `KibanaNoDataPage` connected component uses: - `hasUserDataView` and `hasData` API from the `HasData` service in the `data_views` plugin to check for existence of data an data views. - `onDataViewCreated` callback once a data view has been created. -- (noDataConfig)[https://github.com/elastic/kibana/blob/main/packages/shared-ux/page/no_data/types/index.d.ts] as configuration for the page in case of no data. +- (noDataConfig)[https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/shared-ux/page/no_data/types/index.d.ts] as configuration for the page in case of no data. ## API diff --git a/src/platform/packages/shared/kbn-monaco/src/painless/README.md b/src/platform/packages/shared/kbn-monaco/src/painless/README.md index a862db636cf0..d4ccc3e00993 100644 --- a/src/platform/packages/shared/kbn-monaco/src/painless/README.md +++ b/src/platform/packages/shared/kbn-monaco/src/painless/README.md @@ -45,7 +45,7 @@ This directory contains the Painless lexer and grammar rules, as well as the gen ``` import { PainlessLang, PainlessContext } from '@kbn/monaco'; -import { CodeEditor } from '../src/platform/plugins/shared/kibana_react/public'; +import { CodeEditor } from '@kbn/kibana-react-plugin/public'; // Fields are optional and only applicable in certain contexts const fields = [ diff --git a/src/platform/packages/shared/shared-ux/button_toolbar/src/buttons/toolbar_button/toolbar_button.styles.ts b/src/platform/packages/shared/shared-ux/button_toolbar/src/buttons/toolbar_button/toolbar_button.styles.ts index 2763e3eedc4a..b70993ed8b02 100644 --- a/src/platform/packages/shared/shared-ux/button_toolbar/src/buttons/toolbar_button/toolbar_button.styles.ts +++ b/src/platform/packages/shared/shared-ux/button_toolbar/src/buttons/toolbar_button/toolbar_button.styles.ts @@ -17,7 +17,7 @@ export const fontWeightDefinitions = (euiTheme: UseEuiTheme['euiTheme']) => ({ export const ToolbarButtonStyles = ({ euiTheme }: UseEuiTheme) => { return { default: { - // style declaration carried over from https://github.com/elastic/kibana/blob/v8.10.4/src/platform/plugins/shared/kibana_react/public/toolbar_button/toolbar_button.scss + // style declaration carried over from https://github.com/elastic/kibana/blob/v8.10.4/src/plugins/kibana_react/public/toolbar_button/toolbar_button.scss // informed by issue https://github.com/elastic/eui/issues/4730 borderStyle: 'solid', border: euiTheme.border.thin, diff --git a/src/platform/plugins/shared/console/README.md b/src/platform/plugins/shared/console/README.md index 778493f9a69a..46e1db2925dc 100644 --- a/src/platform/plugins/shared/console/README.md +++ b/src/platform/plugins/shared/console/README.md @@ -312,7 +312,7 @@ One of the main changes in architecture is refactoring the retrieval of autocomp To address these issues, we created a specific [route](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/console/server/routes/api/console/autocomplete_entities/index.ts) in the Kibana server to retrieve all autocomplete entities in one request and send it to the client. The response for mappings capped to 10MB to avoid sending a huge payload. The client-side code was refactored to use the new response format. For more details, see [#130633](https://github.com/elastic/kibana/pull/130633). -Another change is replacing jQuery with the core http client to communicate with the Kibana server. Console used a custom jQuery ajax [function](https://github.com/elastic/kibana/blob/8.0/src/platform/plugins/shared/console/public/lib/es/es.ts) to send requests to the Kibana server to have lower-level control over the requests, specifically controls like `crossDomain: true`. This is no longer needed since we are using the core http client. For more details, see [#127867](https://github.com/elastic/kibana/pull/127867). +Another change is replacing jQuery with the core http client to communicate with the Kibana server. Console used a custom jQuery ajax [function](https://github.com/elastic/kibana/blob/8.0/src/plugins/console/public/lib/es/es.ts) to send requests to the Kibana server to have lower-level control over the requests, specifically controls like `crossDomain: true`. This is no longer needed since we are using the core http client. For more details, see [#127867](https://github.com/elastic/kibana/pull/127867). ### Outstanding issues #### Autocomplete suggestions for Kibana API endpoints diff --git a/src/platform/plugins/shared/data/README.mdx b/src/platform/plugins/shared/data/README.mdx index 5e188553a355..a5bb7c3e4e6a 100644 --- a/src/platform/plugins/shared/data/README.mdx +++ b/src/platform/plugins/shared/data/README.mdx @@ -158,7 +158,7 @@ The `SearchSource` API is a convenient way to construct and run an Elasticsearch One benefit of using the low-level search API, is partial response support, allowing for a better and more responsive user experience. ```.ts - import { isRunningResponse } from '../plugins/data/public'; + import { isRunningResponse } from '@kbn/data-plugin/public'; const search$ = data.search.search(request) .subscribe({ diff --git a/src/platform/plugins/shared/expressions/README.asciidoc b/src/platform/plugins/shared/expressions/README.asciidoc index 71319a2cb45d..629fbd4ff7b9 100644 --- a/src/platform/plugins/shared/expressions/README.asciidoc +++ b/src/platform/plugins/shared/expressions/README.asciidoc @@ -42,21 +42,4 @@ filters [/source] [role="screenshot"] -image::https://user-images.githubusercontent.com/9773803/74162514-3250a880-4c21-11ea-9e68-86f66862a183.png[] - -//// -// Commenting out due to broken links -=== API documentation - -==== Server API -https://github.com/elastic/kibana/blob/main/docs/development/platform/plugins/shared/expressions/server/kibana-plugin-plugins-expressions-server.expressionsserversetup.md[Server Setup contract] -https://github.com/elastic/kibana/blob/main/docs/development/platform/plugins/shared/expressions/server/kibana-plugin-plugins-expressions-server.expressionsserverstart.md[Server Start contract] - -==== Browser API -https://github.com/elastic/kibana/blob/main/docs/development/platform/plugins/shared/expressions/public/kibana-plugin-plugins-expressions-public.expressionsservicesetup.md[Browser Setup contract] -https://github.com/elastic/kibana/blob/main/docs/development/platform/plugins/shared/expressions/public/kibana-plugin-plugins-expressions-public.expressionsstart.md[Browser Start contract] - - -==== Other documentation -https://www.elastic.co/guide/en/kibana/current/canvas-function-arguments.html[See Canvas documentation about expressions] -//// +image::https://user-images.githubusercontent.com/9773803/74162514-3250a880-4c21-11ea-9e68-86f66862a183.png[] \ No newline at end of file diff --git a/src/platform/plugins/shared/guided_onboarding/README.md b/src/platform/plugins/shared/guided_onboarding/README.md index c669f5e70f5c..219959a6585d 100755 --- a/src/platform/plugins/shared/guided_onboarding/README.md +++ b/src/platform/plugins/shared/guided_onboarding/README.md @@ -135,6 +135,6 @@ Follow these simple steps to add a new guide to the guided onboarding framework. 1. Declare the `guidedOnboarding` plugin as an optional dependency in your plugin's `kibana.json` file. Add the guided onboarding plugin's client-side start contract to your plugin's client-side start dependencies and the guided onboarding plugin's server-side setup contract to your plugin's server-side dependencies. 2. Define the configuration for your guide. At a high level, this includes a title, description, and list of steps. See this [example config](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-guided-onboarding/src/common/test_guide_config.ts) or consult the `GuideConfig` interface. 3. Register your guide during your plugin's server-side setup by calling a function exposed by the guided onboarding plugin: `registerGuideConfig(guideId: GuideId, guideConfig: GuideConfig)`. For an example, see this [example plugin](https://github.com/elastic/kibana/blob/main/examples/guided_onboarding_example/server/plugin.ts). -4. Update the cards on the landing page to include your guide in the use case selection. Make sure that the card doesn't have the property `navigateTo` because that is only used for cards that redirect to Kibana pages and don't start a guide. Also add the same value to the property `guideId` as used in the guide config. Landing page cards are configured in this [kbn-guided-onboarding package](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-guided-onboarding/src/components/landing_page/guide_cards.constants.tsx). +4. Update the cards on the landing page to include your guide in the use case selection. Make sure that the card doesn't have the property `navigateTo` because that is only used for cards that redirect to Kibana pages and don't start a guide. Also add the same value to the property `guideId` as used in the guide config. Landing page cards are configured in this [kbn-guided-onboarding package](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-guided-onboarding/src/components/landing_page/guide/guide_cards.constants.tsx). 5. Integrate the new guide into your Kibana pages by using the guided onboarding client-side API service. Make sure your Kibana pages correctly display UI elements depending on the active guide step and the UI flow is straight forward to complete the guide. See existing guides for an example and read more about the API service in this file, the section "Client-side: API service". 6. Optionally, update the example plugin's [form](https://github.com/elastic/kibana/blob/main/examples/guided_onboarding_example/public/components/main.tsx#L38) to be able to start your guide from that page and activate any step in your guide (useful to test your guide steps). diff --git a/src/platform/plugins/shared/usage_collection/README.mdx b/src/platform/plugins/shared/usage_collection/README.mdx index 4c32228f0bd7..08ec26dce34a 100644 --- a/src/platform/plugins/shared/usage_collection/README.mdx +++ b/src/platform/plugins/shared/usage_collection/README.mdx @@ -37,7 +37,7 @@ The APIs exposed in the `public` context aim to collect the _aggregate_ number o #### Application Usage -Kibana automatically tracks the number of minutes the users spend on each application, as well as the number of general clicks in the same app. There is no need for plugins to opt-in. However, if a plugin needs to collect the same metric for specific sections of the app (i.e.: tabs, flyouts, or any component that may be shown in specific situations), it can use the React component `TrackApplicationView`. For more info about the app-level and sub-views tracking, please read [this collector's README](../kibana_usage_collection/server/collectors/application_usage/README.md). +Kibana automatically tracks the number of minutes the users spend on each application, as well as the number of general clicks in the same app. There is no need for plugins to opt-in. However, if a plugin needs to collect the same metric for specific sections of the app (i.e.: tabs, flyouts, or any component that may be shown in specific situations), it can use the React component `TrackApplicationView`. For more info about the app-level and sub-views tracking, please read [this collector's README](../../../../../src/platform/plugins/private/kibana_usage_collection/server/collectors/application_usage/README.md). #### UI Counters @@ -52,7 +52,7 @@ To track a user interaction, use the API `usageCollection.reportUiCounter` as fo ```ts // public/plugin.ts import { METRIC_TYPE } from '@kbn/analytics'; -import { Plugin, CoreStart } from '../../../../../core/public'; +import { Plugin, CoreStart } from '@kbn/core/public'; export class MyPlugin implements Plugin { public start( @@ -133,8 +133,8 @@ To create a usage counter for your plugin, use the API `usageCollection.createUs ```ts // server/plugin.ts -import type { Plugin, CoreStart } from '../../../../../core/server'; -import type { UsageCollectionSetup, UsageCounter } from '../../../../../plugins/usage_collection/server'; +import type { Plugin, CoreStart } from '@kbn/core/server'; +import type { UsageCollectionSetup, UsageCounter } from '@kbn/usage-collection-plugin/server'; export class MyPlugin implements Plugin { private usageCounter?: UsageCounter; diff --git a/x-pack/README.md b/x-pack/README.md index 0afb180dab1f..2d6d6db127b4 100644 --- a/x-pack/README.md +++ b/x-pack/README.md @@ -64,7 +64,7 @@ For both of the above commands, it's crucial that you pass in `--config` to spec Read more about how the scripts work [here](../scripts/README.md). -For a deeper dive, read more about the way functional tests and servers work [here](../packages/kbn-test/README.md). +For a deeper dive, read more about the way functional tests and servers work [here](../packages/kbn-test/README.mdx). #### Running API integration tests @@ -96,8 +96,8 @@ yarn test:jest_integration #### Running Reporting functional tests -See [here](./test/functional/apps/dashboard/reporting/README.md) for more information on running reporting tests. +See [here](./test/functional/apps/dashboard/group3/reporting/README.mdx) for more information on running reporting tests. #### Running Security Solution Cypress E2E/integration tests -See [here](./solutions/security/plugins/security_solution/cypress/README.md) for information on running this test suite. +See [here](./solutions/security/plugins/security_solution//public/management/cypress/README.md) for information on running this test suite. diff --git a/x-pack/dev-tools/github_relabel.pl b/x-pack/dev-tools/github_relabel.pl index 9c060cb6d786..a0b4ac3f1512 100755 --- a/x-pack/dev-tools/github_relabel.pl +++ b/x-pack/dev-tools/github_relabel.pl @@ -104,7 +104,7 @@ sub load_github_key { my ($file) = glob("~/.github_auth"); unless ( -e $file ) { warn "File ~/.github_auth doesn't exist - using anonymous API. " - . "Generate a Personal Access Token at https://github.com/settings/applications\n"; + . "Generate a Personal Access Token https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens \n"; return ''; } open my $fh, $file or die "Couldn't open $file: $!"; diff --git a/x-pack/dev-tools/xkb_release_notes.pl b/x-pack/dev-tools/xkb_release_notes.pl index 4fa9a6b4c49f..e84b7f9067a4 100755 --- a/x-pack/dev-tools/xkb_release_notes.pl +++ b/x-pack/dev-tools/xkb_release_notes.pl @@ -216,7 +216,7 @@ sub load_github_key { my ($file) = glob("~/.github_auth"); unless ( -e $file ) { warn "File ~/.github_auth doesn't exist - using anonymous API. " - . "Generate a personal access token that has repo scope. See https://github.com/elastic/dev/blob/master/shared/development_process.md \n"; + . "Generate a personal access token that has repo scope. See https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens \n"; return ''; } open my $fh, $file or die "Couldn't open $file: $!"; diff --git a/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_anomaly_detectors__job_id__schema.json b/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_anomaly_detectors__job_id__schema.json index 3d64eb50188d..0509d95171c6 100644 --- a/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_anomaly_detectors__job_id__schema.json +++ b/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_anomaly_detectors__job_id__schema.json @@ -10832,4 +10832,4 @@ } } } -} \ No newline at end of file +} diff --git a/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_datafeeds__datafeed_id__schema.json b/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_datafeeds__datafeed_id__schema.json index 40d7d94445ce..d1a9d3eef5fe 100644 --- a/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_datafeeds__datafeed_id__schema.json +++ b/x-pack/platform/packages/private/ml/json_schemas/src/put___ml_datafeeds__datafeed_id__schema.json @@ -7803,4 +7803,4 @@ } } } -} \ No newline at end of file +} diff --git a/x-pack/platform/plugins/private/canvas/PLUGINS.mdx b/x-pack/platform/plugins/private/canvas/PLUGINS.mdx index a639b5876019..34c558aecee4 100644 --- a/x-pack/platform/plugins/private/canvas/PLUGINS.mdx +++ b/x-pack/platform/plugins/private/canvas/PLUGINS.mdx @@ -60,8 +60,8 @@ In your plugin folder, create a new folder `public` and an `index.ts` file withi This `index.ts` will need export a Kibana Plugin. You can use this as a starting point for your plugin. ```typescript -import { Plugin, CoreSetup, CoreStart } from '../../../../../src/core/public'; -import { CanvasSetup } from '../../../../../x-pack/plugins/canvas/public'; +import { Plugin, CoreSetup, CoreStart } from '@kbn/core/public'; +import { CanvasSetup } from '@kbn/canvas-plugin/public'; interface CanvasExampleSetupPlugins { canvas: CanvasSetup; @@ -171,8 +171,8 @@ Now, much like we made the client plugin, we'll make a server plugin. Start by making the `server` directory and an `index.ts` file with a shell for your server plugin: ```typescript -import { Plugin, CoreSetup, CoreStart } from '../../../../../src/core/server'; -import { ExpressionsServerSetup } from '../../../../../src/plugins/expressions/server'; +import { Plugin, CoreSetup, CoreStart } from '@kbn/core/server'; +import { ExpressionsServerSetup } from '@kbn/expressions-plugin/server'; interface CanvasExamplePluginsSetup { expressions: ExpressionsServerSetup; diff --git a/x-pack/platform/plugins/private/canvas/public/services/canvas_notify_service.ts b/x-pack/platform/plugins/private/canvas/public/services/canvas_notify_service.ts index 1f00190f3fff..9bc579022659 100644 --- a/x-pack/platform/plugins/private/canvas/public/services/canvas_notify_service.ts +++ b/x-pack/platform/plugins/private/canvas/public/services/canvas_notify_service.ts @@ -42,7 +42,7 @@ export const getCanvasNotifyService = (): CanvasNotifyService => { return { /* * @param {(string | Object)} err: message or Error object - * @param {Object} opts: option to override toast title or icon, see https://github.com/elastic/kibana/blob/main/src/legacy/ui/public/notify/toasts/TOAST_NOTIFICATIONS.md + * @param {Object} opts: option to override toast title or icon, see https://github.com/elastic/eui/blob/main/packages/eui/src/components/toast/toast.tsx#L26 */ error(err, opts) { toasts.addDanger(getToast(err, opts)); diff --git a/x-pack/platform/plugins/private/cross_cluster_replication/public/app/services/routing.js b/x-pack/platform/plugins/private/cross_cluster_replication/public/app/services/routing.js index 293ad6dc38f4..77b8ed6c5812 100644 --- a/x-pack/platform/plugins/private/cross_cluster_replication/public/app/services/routing.js +++ b/x-pack/platform/plugins/private/cross_cluster_replication/public/app/services/routing.js @@ -6,7 +6,7 @@ */ /** - * This file based on guidance from https://github.com/elastic/eui/blob/master/wiki/react-router.md + * This file based on guidance from https://github.com/elastic/eui/blob/main/wiki/consuming-eui/react-router.md */ import { stringify } from 'query-string'; diff --git a/x-pack/platform/plugins/private/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx b/x-pack/platform/plugins/private/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx index 76463a627f99..2db181c8aa8c 100644 --- a/x-pack/platform/plugins/private/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx +++ b/x-pack/platform/plugins/private/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx @@ -26,7 +26,7 @@ export interface Configuration { * If this value is true, phases after hot cannot set shrink, forcemerge or * searchable_snapshot actions. * - * See https://github.com/elastic/elasticsearch/blob/master/docs/reference/ilm/actions/ilm-searchable-snapshot.asciidoc. + * See https://github.com/elastic/elasticsearch/blob/main/docs/reference/ilm/actions/ilm-searchable-snapshot.asciidoc */ isUsingSearchableSnapshotInHotPhase: boolean; isUsingSearchableSnapshotInColdPhase: boolean; diff --git a/x-pack/platform/plugins/private/monitoring/dev_docs/how_to/work_with_packages.md b/x-pack/platform/plugins/private/monitoring/dev_docs/how_to/work_with_packages.md index 4ab2349c332d..d273c938942e 100644 --- a/x-pack/platform/plugins/private/monitoring/dev_docs/how_to/work_with_packages.md +++ b/x-pack/platform/plugins/private/monitoring/dev_docs/how_to/work_with_packages.md @@ -97,7 +97,7 @@ LOCALlogs-.->|"mount[1]"|STagentlogs LOCALlogs-.->|"mount[2]"|SEelasticsearchlogs SElogsscript-.->|http requests to trigger logs|elasticsearch ``` -[1] https://github.com/elastic/elastic-package/blob/main/internal/profile/_static/docker-compose-stack.yml#L133-L135 +[1] https://github.com/elastic/elastic-package/blob/main/internal/stack/_static/docker-compose-stack.yml.tmpl [2] https://github.com/elastic/integrations/blob/main/packages/elasticsearch/_dev/deploy/docker/docker-compose.yml#L39 This is a simplified version as there is some gymnastics involved to work around permissions, but the workflow remains the same @@ -177,5 +177,4 @@ If you need to look at the raw filebeat/metrics logs they are stored under `/usr **Additional resources:** - [v2 diagram](https://github.com/elastic/elastic-agent-shipper/issues/3) - [Agent onboarding (internal)](https://ela.st/agent-onboarding-doc) -- [Elastic Agent architecture v2 (internal)](https://ela.st/agent-v2-archicture-doc) - +- [Elastic Agent architecture v2 (internal)](https://ela.st/agent-v2-archicture-doc) \ No newline at end of file diff --git a/x-pack/platform/plugins/private/monitoring/dev_docs/reference/indices.md b/x-pack/platform/plugins/private/monitoring/dev_docs/reference/indices.md index 1993d31d157f..9b02d4ebf6a8 100644 --- a/x-pack/platform/plugins/private/monitoring/dev_docs/reference/indices.md +++ b/x-pack/platform/plugins/private/monitoring/dev_docs/reference/indices.md @@ -42,7 +42,7 @@ The best place to reference information for each field is in the metricbeat modu - [Elasticsearch](https://github.com/elastic/beats/blob/main/metricbeat/module/elasticsearch/_meta/README.md) - [Kibana](https://github.com/elastic/beats/blob/main/metricbeat/module/kibana/_meta/README.md) - [Logstash](https://github.com/elastic/beats/blob/main/metricbeat/module/logstash/_meta/README.md) -- [Beat](https://github.com/elastic/beats/blob/main/metricbeat/module/beat/_meta/README.md) (\*beat, apm-server, fleet server) +- [Beat](https://github.com/elastic/beats/blob/main/metricbeat/module/beat/_meta/) (\*beat, apm-server, fleet server) - [Enterprise Search](https://github.com/elastic/beats/tree/main/x-pack/metricbeat/module/enterprisesearch/_meta/README.md) ## Aliasing diff --git a/x-pack/platform/plugins/private/remote_clusters/public/application/services/routing.ts b/x-pack/platform/plugins/private/remote_clusters/public/application/services/routing.ts index 25136cd3f73b..404b654822eb 100644 --- a/x-pack/platform/plugins/private/remote_clusters/public/application/services/routing.ts +++ b/x-pack/platform/plugins/private/remote_clusters/public/application/services/routing.ts @@ -8,7 +8,7 @@ import { ScopedHistory } from '@kbn/core/public'; /** - * This file based on guidance from https://github.com/elastic/eui/blob/master/wiki/react-router.md + * This file based on guidance from https://github.com/elastic/eui/blob/main/wiki/consuming-eui/react-router.md */ let _userHasLeftApp = false; diff --git a/x-pack/platform/plugins/private/rollup/public/crud_app/services/routing.js b/x-pack/platform/plugins/private/rollup/public/crud_app/services/routing.js index 4e45fd84115d..fafe9dd3e542 100644 --- a/x-pack/platform/plugins/private/rollup/public/crud_app/services/routing.js +++ b/x-pack/platform/plugins/private/rollup/public/crud_app/services/routing.js @@ -6,7 +6,7 @@ */ /** - * This file based on guidance from https://github.com/elastic/eui/blob/master/wiki/react-router.md + * This file based on guidance from https://github.com/elastic/eui/blob/main/wiki/consuming-eui/react-router.md */ import { createLocation } from 'history'; diff --git a/x-pack/platform/plugins/private/upgrade_assistant/README.md b/x-pack/platform/plugins/private/upgrade_assistant/README.md index 477404881d27..0272a958659f 100644 --- a/x-pack/platform/plugins/private/upgrade_assistant/README.md +++ b/x-pack/platform/plugins/private/upgrade_assistant/README.md @@ -336,8 +336,8 @@ For a complete list of Kibana deprecations, refer to the [8.0 Kibana deprecation This is a non-exhaustive list of different error scenarios in Upgrade Assistant. It's recommended to use the [tweak browser extension](https://chrome.google.com/webstore/detail/tweak-mock-api-calls/feahianecghpnipmhphmfgmpdodhcapi?hl=en), or something similar, to mock the API calls. -- **Error loading deprecation logging status.** Mock a `404` status code to `GET /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/5c13e901ac1bf01bcbcca1d4103c43438ee8f6e6/x-pack/platform/plugins/private/upgrade_assistant/public/application/lib/api.ts#L71) locally and replace `deprecation_logging` with `fake_deprecation_logging`. -- **Error updating deprecation logging status.** Mock a `404` status code to `PUT /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/545c1420c285af8f5eee56f414bd6eca735aea11/x-pack/platform/plugins/private/upgrade_assistant/public/application/lib/api.ts#L77) locally and replace `deprecation_logging` with `fake_deprecation_logging`. +- **Error loading deprecation logging status.** Mock a `404` status code to `GET /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/dd6376d3be3d2916bae334cd50a56ca558d1ed4b/x-pack/platform/plugins/private/upgrade_assistant/public/application/lib/api.ts#L151) locally and replace `deprecation_logging` with `fake_deprecation_logging`. +- **Error updating deprecation logging status.** Mock a `404` status code to `PUT /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/dd6376d3be3d2916bae334cd50a56ca558d1ed4b/x-pack/platform/plugins/private/upgrade_assistant/public/application/lib/api.ts#L141) locally and replace `deprecation_logging` with `fake_deprecation_logging`. - **Unauthorized error fetching ES deprecations.** Mock a `403` status code to `GET /api/upgrade_assistant/es_deprecations` with the response payload: `{ "statusCode": 403 }` - **Partially upgraded error fetching ES deprecations.** Mock a `426` status code to `GET /api/upgrade_assistant/es_deprecations` with the response payload: `{ "statusCode": 426, "attributes": { "allNodesUpgraded": false } }` - **Upgraded error fetching ES deprecations.** Mock a `426` status code to `GET /api/upgrade_assistant/es_deprecations` with the response payload: `{ "statusCode": 426, "attributes": { "allNodesUpgraded": true } }` diff --git a/x-pack/platform/plugins/shared/aiops/public/components/log_rate_analysis/item_filter_popover.tsx b/x-pack/platform/plugins/shared/aiops/public/components/log_rate_analysis/item_filter_popover.tsx index f88e0f29aee8..e270e682e4fd 100644 --- a/x-pack/platform/plugins/shared/aiops/public/components/log_rate_analysis/item_filter_popover.tsx +++ b/x-pack/platform/plugins/shared/aiops/public/components/log_rate_analysis/item_filter_popover.tsx @@ -44,7 +44,7 @@ interface ItemFilterPopoverProps { } // This component is mostly inspired by EUI's Data Grid Column Selector -// https://github.com/elastic/eui/blob/main/src/components/datagrid/controls/column_selector.tsx +// https://github.com/elastic/eui/blob/main/packages/eui/src/components/datagrid/controls/column_selector.tsx export const ItemFilterPopover: FC = ({ dataTestSubj, disabled, @@ -59,7 +59,7 @@ export const ItemFilterPopover: FC = ({ onChange, }) => { const euiThemeContext = useEuiTheme(); - // Inspired by https://github.com/elastic/eui/blob/main/src/components/datagrid/controls/_data_grid_column_selector.scss + // Inspired by https://github.com/elastic/eui/blob/v94.0.0/src/components/datagrid/controls/_data_grid_column_selector.scss const itemSelectPopover = useMemo( () => css` ${euiYScrollWithShadows(euiThemeContext, {})} diff --git a/x-pack/platform/plugins/shared/cases/public/components/cases_context/index.tsx b/x-pack/platform/plugins/shared/cases/public/components/cases_context/index.tsx index 77aee6551ac0..19b0199d2e9d 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/cases_context/index.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/cases_context/index.tsx @@ -148,7 +148,7 @@ export const CasesProvider: FC< ); } else { throw new Error( - 'Invalid owner provided to cases context. See https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/README.md#casescontext-setup' + 'Invalid owner provided to cases context. See https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/cases/README.md#casescontext-setup' ); } }, diff --git a/x-pack/platform/plugins/shared/cases/public/components/markdown_editor/plugins/lens/use_lens_button_toggle.ts b/x-pack/platform/plugins/shared/cases/public/components/markdown_editor/plugins/lens/use_lens_button_toggle.ts index 4431261bdfaa..e2df79232222 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/markdown_editor/plugins/lens/use_lens_button_toggle.ts +++ b/x-pack/platform/plugins/shared/cases/public/components/markdown_editor/plugins/lens/use_lens_button_toggle.ts @@ -89,7 +89,7 @@ export const useLensButtonToggle = ({ [value, lensNodeSelected] ); - // Copied from https://github.com/elastic/eui/blob/master/src/components/markdown_editor/markdown_editor.tsx#L279 + // Copied from https://github.com/elastic/eui/blob/main/packages/eui/src/components/markdown_editor/markdown_editor.tsx#L286 useEffect(() => { if ( editorRef?.current?.textarea == null || diff --git a/x-pack/platform/plugins/shared/fleet/README.md b/x-pack/platform/plugins/shared/fleet/README.md index 94a28952885d..0c8e9dbe4547 100644 --- a/x-pack/platform/plugins/shared/fleet/README.md +++ b/x-pack/platform/plugins/shared/fleet/README.md @@ -255,7 +255,7 @@ The projects below are dependent on Fleet, most using Fleet API as well. In case Fleet supports shipping integrations as `.zip` archives with Kibana's source code through a concept referred to as _bundled packages_. This allows integrations like APM, which is enabled by default in Cloud, to reliably provide upgrade paths without internet access, and generally improves stability around Fleet's installation/setup processes for several common integrations. -The set of bundled packages included with Kibana is dictated by a top-level `fleet_packages.json` file in the Kibana repo. This file includes a list of packages with a pinned version that Kibana will consider bundled. When the Kibana distributable is built, a [build task](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/bundle_fleet_packages.ts) will resolve these packages from the Elastic Package Registry, download the appropriate version as a `.zip` archive, and place it in a directory configurable by a `xpack.fleet.bundledPackageLocation` value in `kibana.yml`. By default, these archives are stored in `x-pack/platform/plugins/shared/fleet/.target/bundled_packages/`. In CI/CD, we [override](https://github.com/elastic/kibana/blob/main/x-pack/test/fleet_api_integration/config.ts#L20) this default with `/tmp/fleet_bundled_packages`. +The set of bundled packages included with Kibana is dictated by a top-level `fleet_packages.json` file in the Kibana repo. This file includes a list of packages with a pinned version that Kibana will consider bundled. When the Kibana distributable is built, a [build task](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/bundle_fleet_packages.ts) will resolve these packages from the Elastic Package Registry, download the appropriate version as a `.zip` archive, and place it in a directory configurable by a `xpack.fleet.bundledPackageLocation` value in `kibana.yml`. By default, these archives are stored in `x-pack/platform/plugins/shared/fleet/.target/bundled_packages/`. In CI/CD, we [override](https://github.com/elastic/kibana/blob/main/x-pack/test/fleet_api_integration/config.base.ts#L19) this default with `/tmp/fleet_bundled_packages`. Until further automation is added, this `fleet_packages.json` file should be updated as part of the release process to ensure the latest compatible version of each bundled package is included with that Kibana version. **This must be done before the final BC for a release is built.** Tracking issues should be opened and tracked by the Fleet UI team. See https://github.com/elastic/kibana/issues/129309 as an example. diff --git a/x-pack/platform/plugins/shared/fleet/common/openapi/README.md b/x-pack/platform/plugins/shared/fleet/common/openapi/README.md index c3d02d42c77f..42ae8a783a0c 100644 --- a/x-pack/platform/plugins/shared/fleet/common/openapi/README.md +++ b/x-pack/platform/plugins/shared/fleet/common/openapi/README.md @@ -3,7 +3,7 @@ There is a new way to generate openapi docs from the route definition in code. When adding a new route/modifying request/response parameters, make sure to add/update schema definitions when registering the route. -[Example](https://github.com/elastic/kibana/blob/5ea1ab0b8a21764aa54a5ef9650a0d8046f3f0a8/x-pack/platform/plugins/shared/fleet/server/routes/agent/index.ts#L96-L123) +[Example](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/server/routes/agent/index.ts#L96-L123) Read more: https://docs.elastic.dev/kibana-dev-docs/genereating-oas-for-http-apis diff --git a/x-pack/platform/plugins/shared/fleet/dev_docs/data_model.md b/x-pack/platform/plugins/shared/fleet/dev_docs/data_model.md index 6f4477da61f1..a815fedaa955 100644 --- a/x-pack/platform/plugins/shared/fleet/dev_docs/data_model.md +++ b/x-pack/platform/plugins/shared/fleet/dev_docs/data_model.md @@ -65,12 +65,12 @@ The total schema for actions is represented by the `FleetServerAgentAction` type ### `.fleet-enrollment-api-keys` - Cleanup model: Deleteable via Fleet UI/API, deleted when an agent policy is deleted -- [Source](https://github.com/elastic/kibana/blob/7a35748cb43f2c73623ffda6fa02b91c3cb4c689/x-pack/platform/plugins/shared/fleet/server/services/api_keys/enrollment_api_key.ts#L102) +- [Source](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/server/services/api_keys/enrollment_api_key.ts#L102) ### `.fleet-policies` - Cleanup model: Deleted when a corresponding agent policy is deleted in the Fleet UI or API -- [Source](https://github.com/elastic/kibana/blob/976b1b2331371f4a1325f6947d38d1f4de7a7254/x-pack/platform/plugins/shared/fleet/server/services/agent_policy.ts#L699-L701) +- [Source](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/server/services/agent_policy.ts#L699-L701) ### `.fleet-policies-leader` diff --git a/x-pack/platform/plugins/shared/fleet/dev_docs/data_streams.md b/x-pack/platform/plugins/shared/fleet/dev_docs/data_streams.md index e0fd14984fe6..80cf0ad067e3 100644 --- a/x-pack/platform/plugins/shared/fleet/dev_docs/data_streams.md +++ b/x-pack/platform/plugins/shared/fleet/dev_docs/data_streams.md @@ -41,7 +41,7 @@ example: ## Making Changes to Template Structure -When making changes to the template structure (e.g [#124013](https://github.com/elastic/kibana/pull/124013)), this will need to be applied to all installed packages on upgrade to retain consistency. On startup we have [a check](https://github.com/elastic/kibana/blob/a52ba7cefe1a04ef6eafa32d5e410a3a901169b2/x-pack/platform/plugins/shared/fleet/server/services/setup.ts#L151) to see if any of the global assets have changed. If they have changed then we attempt to reinstall every package. This will in most cases cause a rollover of all datastreams so shouldn't be treated lightly. +When making changes to the template structure (e.g [#124013](https://github.com/elastic/kibana/pull/124013)), this will need to be applied to all installed packages on upgrade to retain consistency. On startup we have [a check](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/server/services/setup.ts#L151) to see if any of the global assets have changed. If they have changed then we attempt to reinstall every package. This will in most cases cause a rollover of all datastreams so shouldn't be treated lightly. ## Pre 8.2 Template Structure diff --git a/x-pack/platform/plugins/shared/fleet/package.json b/x-pack/platform/plugins/shared/fleet/package.json index fb9e7bfdf365..bf91a6f0443c 100644 --- a/x-pack/platform/plugins/shared/fleet/package.json +++ b/x-pack/platform/plugins/shared/fleet/package.json @@ -5,11 +5,11 @@ "private": true, "license": "Elastic License 2.0", "scripts": { - "cypress_space_awareness": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../platform/plugins/shared/fleet/cypress.config.space_awareness.ts --ftr-config-file ../../../../../x-pack/test/fleet_cypress/cli_config.space_awareness", + "cypress_space_awareness": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../../x-pack/solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../../x-pack/platform/plugins/shared/fleet/cypress.config.space_awareness.ts --ftr-config-file ../../../../../x-pack/test/fleet_cypress/cli_config.space_awareness", "cypress_space_awareness:open": "yarn cypress_space_awareness open", "cypress_space_awareness:run": "yarn cypress_space_awareness run", "cypress_space_awareness:run:reporter": "yarn cypress_space_awareness run --reporter ../../../../../node_modules/cypress-multi-reporters --reporter-options configFile=cypress/reporter_config.json", - "cypress": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../platform/plugins/shared/fleet/cypress.config.ts --ftr-config-file ../../../../../x-pack/test/fleet_cypress/cli_config", + "cypress": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../../x-pack/solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../../x-pack/platform/plugins/shared/fleet/cypress.config.ts --ftr-config-file ../../../../../x-pack/test/fleet_cypress/cli_config", "cypress:open": "yarn cypress open", "cypress:run": "yarn cypress run", "cypress:run:reporter": "yarn cypress run --reporter ../../../../../node_modules/cypress-multi-reporters --reporter-options configFile=cypress/reporter_config.json", diff --git a/x-pack/platform/plugins/shared/integration_assistant/README.md b/x-pack/platform/plugins/shared/integration_assistant/README.md index 1b380bc2af8d..3300776c763a 100644 --- a/x-pack/platform/plugins/shared/integration_assistant/README.md +++ b/x-pack/platform/plugins/shared/integration_assistant/README.md @@ -61,23 +61,23 @@ Generated by running `yarn draw-graphs` inside the root of the plugin folder. **First graph:** **Log Format Detection:** -![!LogFormatDetectionGraph](./docs/img/log_detection_graph.png) +![!LogFormatDetectionGraph](./docs/imgs/log_detection_graph.png) **Second graph, main:** **ECS Main:** -![ECSMappingGraph](./docs/img/ecs_graph.png) +![ECSMappingGraph](./docs/imgs/ecs_graph.png) **Second graph, sub:** **ECS Sub:** -![ECSMappingSubGraph](./docs/img/ecs_subgraph.png) +![ECSMappingSubGraph](./docs/imgs/ecs_subgraph.png) **Third graph:** **Categorization:** -![CategorizationGraph](./docs/img/categorization_graph.png) +![CategorizationGraph](./docs/imgs/categorization_graph.png) **Fourth graph:** **Related:** -![RelatedGraph](./docs/img/related_graph.png) +![RelatedGraph](./docs/imgs/related_graph.png) ## Tests diff --git a/x-pack/platform/plugins/shared/logs_shared/public/components/log_stream/log_stream.stories.mdx b/x-pack/platform/plugins/shared/logs_shared/public/components/log_stream/log_stream.stories.mdx index 64a6e1d9919a..28275ba066ee 100644 --- a/x-pack/platform/plugins/shared/logs_shared/public/components/log_stream/log_stream.stories.mdx +++ b/x-pack/platform/plugins/shared/logs_shared/public/components/log_stream/log_stream.stories.mdx @@ -18,9 +18,9 @@ import { LogStream } from '../../../../../../../logs_shared/public'; To use the component your plugin needs to follow certain criteria: - Ensure `"logsShared"` and `"data"` are specified as a `requiredPlugins` in your plugin's `kibana.json`. -- Ensure the `` component is mounted inside the hierachy of a [`kibana-react` provider](https://github.com/elastic/kibana/blob/b2d0aa7b7fae1c89c8f9e8854ae73e71be64e765/src/plugins/kibana_react/README.md#L45). At a minimum, the kibana-react provider must pass `http` (from core start services) and `data` (from core plugin start dependencies). -- Ensure the `` component is mounted inside the hierachy of a [`KibanaThemeProvider`](https://github.com/elastic/kibana/blob/31d2db035c905fb5819fa6dc2354f3be795a34cf/src/plugins/kibana_react/public/theme/kibana_theme_provider.tsx#L27). -- Ensure the `` component is mounted inside the hierachy of a [`EuiThemeProvider`](https://github.com/elastic/kibana/blob/main/src/plugins/kibana_react/common/eui_styled_components.tsx). This is not the same as the provider exported by EUI. It bridges the gap between EUI and styled components and predates the css-in-js support in EUI. +- Ensure the `` component is mounted inside the hierachy of a [`kibana-react` provider](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/kibana_react/README.md). At a minimum, the kibana-react provider must pass `http` (from core start services) and `data` (from core plugin start dependencies). +- Ensure the `` component is mounted inside the hierachy of a [`KibanaThemeProvider`](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/kibana_utils/public/theme/kibana_theme_provider.tsx#L26). +- Ensure the `` component is mounted inside the hierachy of a [`EuiThemeProvider`](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/kibana_react/common/eui_styled_components.tsx). This is not the same as the provider exported by EUI. It bridges the gap between EUI and styled components and predates the css-in-js support in EUI. ## Usage @@ -80,7 +80,7 @@ The component also has a `filters` prop that accepts valid es-query `filters`. T ## Center the view on a specific entry -By default the component will load at the bottom of the list, showing the newest entries. You can change the rendering point with the `center` prop. The prop takes a [`LogEntriesCursor`](https://github.com/elastic/kibana/blob/0a6c748cc837c016901f69ff05d81395aa2d41c8/x-pack/plugins/observability_solution/logs_shared/common/http_api/log_entries/common.ts#L9-L13). +By default the component will load at the bottom of the list, showing the newest entries. You can change the rendering point with the `center` prop. The prop takes a [`LogEntriesCursor`](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/logs_shared/public/components/log_stream/log_stream.tsx). ```tsx cannot access kibana core services. Ensure the component is mounted within kibana-react's hierarchy. -Read more at https://github.com/elastic/kibana/blob/main/src/plugins/kibana_react/README.md" +Read more at https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/kibana_react/README.md" ` ); } diff --git a/x-pack/platform/plugins/shared/ml/readme.md b/x-pack/platform/plugins/shared/ml/readme.md index 2c99bd37ff4c..bb4a7e93aa52 100644 --- a/x-pack/platform/plugins/shared/ml/readme.md +++ b/x-pack/platform/plugins/shared/ml/readme.md @@ -173,23 +173,23 @@ Note: We are in the process of moving shared code to packages, for example `@kbn You can find the ML shared functions in the following files in GitHub: ``` -https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/public/shared.ts +https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/public/index.ts ``` ``` -https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/shared.ts +https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/index.ts ``` These functions are shared from the root of the ML plugin, you can import them with an import statement. For example: ``` -import { MlPluginSetup } from '../../../../../../ml/server'; +import { MlPluginSetup } from '@kbn/ml-plugin/server'; ``` or ``` -import { ML_ANOMALY_SEVERITY } from '../../../../ml/common'; +import { ML_ANOMALY_SEVERITY } from '@kbn/ml-plugin/common'; ``` Functions are shared from the following directories: diff --git a/x-pack/platform/plugins/shared/osquery/package.json b/x-pack/platform/plugins/shared/osquery/package.json index 83bbba643432..bccc1894467f 100644 --- a/x-pack/platform/plugins/shared/osquery/package.json +++ b/x-pack/platform/plugins/shared/osquery/package.json @@ -7,13 +7,13 @@ "scripts": { "cypress:burn": "yarn cypress:run --env burn=2 --headed", "cypress:changed-specs-only": "yarn cypress:run --changed-specs-only --env burn=2", - "cypress": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../platform/plugins/shared/osquery/cypress/cypress.config.ts --ftr-config-file ../../../../../x-pack/test/osquery_cypress/cli_config", + "cypress": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../../x-pack/platform/plugins/shared/osquery/cypress/cypress.config.ts --ftr-config-file ../../../../../x-pack/test/osquery_cypress/cli_config", "cypress:open": "yarn cypress open", "cypress:run": "yarn cypress run", - "cypress:serverless": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../platform/plugins/shared/osquery/cypress/serverless_cypress.config.ts --ftr-config-file ../../../../../x-pack/test/osquery_cypress/serverless_cli_config", + "cypress:serverless": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel --config-file ../../../x-pack/platform/plugins/shared/osquery/cypress/serverless_cypress.config.ts --ftr-config-file ../../../../../x-pack/test/osquery_cypress/serverless_cli_config", "cypress:serverless:open": "yarn cypress:serverless open", "cypress:serverless:run": "yarn cypress:serverless run", - "cypress:qa:serverless": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel_serverless --config-file ../../platform/plugins/shared/osquery/cypress/serverless_cypress_qa.config.ts --onBeforeHook ../../../../test/osquery_cypress/runner_qa.ts", + "cypress:qa:serverless": "NODE_OPTIONS=--openssl-legacy-provider node ../../../../solutions/security/plugins/security_solution/scripts/start_cypress_parallel_serverless --config-file ../../../x-pack/platform/plugins/shared/osquery/cypress/serverless_cypress_qa.config.ts --onBeforeHook ../../../../test/osquery_cypress/runner_qa.ts", "cypress:qa:serverless:run": "yarn cypress:qa:serverless run", "nyc": "../../../../../node_modules/.bin/nyc report --reporter=text-summary", "junit:merge": "../../../../../node_modules/.bin/mochawesome-merge ../../../../../target/kibana-osquery/cypress/results/mochawesome*.json > ../../../../../target/kibana-osquery/cypress/results/output.json && ../../../../../node_modules/.bin/marge ../../../../../target/kibana-osquery/cypress/results/output.json --reportDir ../../../../../target/kibana-osquery/cypress/results && yarn junit:transform && mkdir -p ../../../../../target/junit && cp ../../../../../target/kibana-osquery/cypress/results/*.xml ../../../../../target/junit/", diff --git a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/classes/alertsclient.md b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/classes/alertsclient.md index e8b17b8c8554..eade7cebf500 100644 --- a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/classes/alertsclient.md +++ b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/classes/alertsclient.md @@ -49,7 +49,7 @@ on alerts as data. #### Defined in -[alerts_client.ts:117](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L117) +[alerts_client.ts:88](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L88-L97) ## Properties @@ -59,7 +59,7 @@ on alerts as data. #### Defined in -[alerts_client.ts:114](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L114) +[alerts_client.ts:91](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L91) ___ @@ -69,7 +69,7 @@ ___ #### Defined in -[alerts_client.ts:115](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L115) +[alerts_client.ts:90](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L90) ___ @@ -79,7 +79,7 @@ ___ #### Defined in -[alerts_client.ts:116](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L116) +[alerts_client.ts:92](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L92) ___ @@ -89,17 +89,7 @@ ___ #### Defined in -[alerts_client.ts:113](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L113) - -___ - -### spaceId - -• `Private` `Readonly` **spaceId**: `undefined` \| `string` - -#### Defined in - -[alerts_client.ts:117](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L117) +[alerts_client.ts:89](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L89) ## Methods @@ -123,7 +113,7 @@ ___ #### Defined in -[alerts_client.ts:367](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L367) +[alerts_client.ts:456](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L456) ___ @@ -149,7 +139,7 @@ ___ #### Defined in -[alerts_client.ts:570](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L570) +[alerts_client.ts:802](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L802) ___ @@ -172,7 +162,7 @@ Accepts an array of ES documents and executes ensureAuthorized for the given ope #### Defined in -[alerts_client.ts:152](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L152) +[alerts_client.ts:223](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L223) ___ @@ -204,7 +194,7 @@ ___ #### Defined in -[alerts_client.ts:628](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L628) +[alerts_client.ts:986](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L986) ___ @@ -224,7 +214,7 @@ ___ #### Defined in -[alerts_client.ts:491](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L491) +[alerts_client.ts:618](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L618) ___ @@ -245,7 +235,7 @@ ___ #### Defined in -[alerts_client.ts:137](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L137) +[alerts_client.ts:197](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L197) ___ @@ -265,7 +255,7 @@ ___ #### Defined in -[alerts_client.ts:674](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L674) +[alerts_client.ts:1184](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L1184) ___ @@ -289,7 +279,7 @@ ___ #### Defined in -[alerts_client.ts:129](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L129) +[alerts_client.ts:189](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L189) ___ @@ -315,7 +305,7 @@ When an update by ids is requested, do a multi-get, ensure authz and audit alert #### Defined in -[alerts_client.ts:308](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L308) +[alerts_client.ts:386](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L386) ___ @@ -340,30 +330,7 @@ executes a search after to find alerts with query (+ authz filter) #### Defined in -[alerts_client.ts:423](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L423) - -___ - -### singleSearchAfterAndAudit - -▸ `Private` **singleSearchAfterAndAudit**(`__namedParameters`): `Promise`\>\>\> - -This will be used as a part of the "find" api -In the future we will add an "aggs" param - -#### Parameters - -| Name | Type | -| :------ | :------ | -| `__namedParameters` | `SingleSearchAfterAndAudit` | - -#### Returns - -`Promise`\>\>\> - -#### Defined in - -[alerts_client.ts:220](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L220) +[alerts_client.ts:509](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L509) ___ @@ -389,4 +356,4 @@ ___ #### Defined in -[alerts_client.ts:520](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L520) +[alerts_client.ts:758](https://github.com/elastic/kibana/blob/938f4717813d9fda2562cecf451c1de3215c327b/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L758) diff --git a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/bulkupdateoptions.md b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/bulkupdateoptions.md index 4bb9ffda28bf..a7871a0affb7 100644 --- a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/bulkupdateoptions.md +++ b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/bulkupdateoptions.md @@ -25,7 +25,7 @@ #### Defined in -[alerts_client.ts:84](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L84) +[alerts_client.ts:84](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L84) ___ @@ -35,7 +35,7 @@ ___ #### Defined in -[alerts_client.ts:86](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L86) +[alerts_client.ts:86](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L86) ___ @@ -45,7 +45,7 @@ ___ #### Defined in -[alerts_client.ts:87](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L87) +[alerts_client.ts:87](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L87) ___ @@ -55,4 +55,4 @@ ___ #### Defined in -[alerts_client.ts:85](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L85) +[alerts_client.ts:85](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L85) diff --git a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/constructoroptions.md b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/constructoroptions.md index d3019b047c38..92dc21dd5e06 100644 --- a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/constructoroptions.md +++ b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/constructoroptions.md @@ -19,7 +19,7 @@ #### Defined in -[alerts_client.ts:72](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L72) +[alerts_client.ts:72](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L72) ___ @@ -29,7 +29,7 @@ ___ #### Defined in -[alerts_client.ts:71](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L71) +[alerts_client.ts:71](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L71) ___ @@ -39,7 +39,7 @@ ___ #### Defined in -[alerts_client.ts:73](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L73) +[alerts_client.ts:73](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L73) ___ @@ -49,4 +49,4 @@ ___ #### Defined in -[alerts_client.ts:70](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L70) +[alerts_client.ts:70](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L70) diff --git a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/updateoptions.md b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/updateoptions.md index f734d4da4231..04b61614510e 100644 --- a/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/updateoptions.md +++ b/x-pack/platform/plugins/shared/rule_registry/docs/alerts_client/interfaces/updateoptions.md @@ -25,7 +25,7 @@ #### Defined in -[alerts_client.ts:79](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L79) +[alerts_client.ts:79](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L79) ___ @@ -35,7 +35,7 @@ ___ #### Defined in -[alerts_client.ts:77](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L77) +[alerts_client.ts:77](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L77) ___ @@ -45,7 +45,7 @@ ___ #### Defined in -[alerts_client.ts:80](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L80) +[alerts_client.ts:80](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L80) ___ @@ -55,4 +55,4 @@ ___ #### Defined in -[alerts_client.ts:78](https://github.com/elastic/kibana/blob/42f5a948210/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L78) +[alerts_client.ts:78](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/rule_registry/server/alert_data_client/alerts_client.ts#L78) diff --git a/x-pack/platform/plugins/shared/task_manager/README.md b/x-pack/platform/plugins/shared/task_manager/README.md index 29fed72f3347..654d3263c1d0 100644 --- a/x-pack/platform/plugins/shared/task_manager/README.md +++ b/x-pack/platform/plugins/shared/task_manager/README.md @@ -61,7 +61,7 @@ The task_manager can be configured via `taskManager` config options (e.g. `taskM Plugins define tasks by calling the `registerTaskDefinitions` method on the `server.plugins.task_manager` object. -A sample task can be found in the [x-pack/test/plugin_api_integration/platform/plugins/shared/task_manager](../../../../test/plugin_api_integration/platform/plugins/shared/task_manager/index.js) folder. +A sample task can be found in the [x-pack/test/plugin_api_integration/plugins/sample_task_plugin/](../../../../../x-pack/test/plugin_api_integration/plugins/sample_task_plugin/server/plugin.ts) folder. ```js export class Plugin { @@ -88,7 +88,7 @@ export class Plugin { maxAttempts: 5, // The maximum number tasks of this type that can be run concurrently per Kibana instance. - // Setting this value will force Task Manager to poll for this task type seperatly from other task types which + // Setting this value will force Task Manager to poll for this task type seperatly from other task types which // can add significant load to the ES cluster, so please use this configuration only when absolutly necesery. maxConcurrency: 1, diff --git a/x-pack/platform/plugins/shared/triggers_actions_ui/README.md b/x-pack/platform/plugins/shared/triggers_actions_ui/README.md index cffd2bc9c393..a48061701092 100644 --- a/x-pack/platform/plugins/shared/triggers_actions_ui/README.md +++ b/x-pack/platform/plugins/shared/triggers_actions_ui/README.md @@ -305,7 +305,7 @@ Alert type UI is expected to be defined as `RuleTypeModel` object. Below is a list of steps that should be done to build and register a new alert type with the name `Example Alert Type`: -1. At any suitable place in Kibana, create a file, which will expose an object implementing interface [RuleTypeModel](https://github.com/elastic/kibana/blob/55b7905fb5265b73806006e7265739545d7521d0/x-pack/legacy/platform/plugins/shared/triggers_actions_ui/np_ready/public/types.ts#L83). Example: +1. At any suitable place in Kibana, create a file, which will expose an object implementing interface [RuleTypeModel](https://github.com/elastic/kibana/blob/55b7905fb5265b73806006e7265739545d7521d0/x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/types.ts#L83). Example: ``` import { lazy } from 'react'; @@ -1401,7 +1401,7 @@ Follow the instructions bellow to embed the Alert Actions form within any Kibana import { TriggersAndActionsUIPublicPluginSetup, TriggersAndActionsUIPublicPluginStart, - } from '../../../../../../../x-pack/platform/plugins/shared/triggers_actions_ui/public'; + } from '@kbn/triggers-actions-ui-plugin/public'; triggersActionsUi: TriggersAndActionsUIPublicPluginSetup; ... @@ -1415,8 +1415,8 @@ Then this dependencies will be used to embed Actions form or register your own a ``` import React, { useCallback } from 'react'; -import { ActionForm } from '../../../../../../../../../../../platform/plugins/shared/triggers_actions_ui/public'; -import { RuleAction } from '../../../../../../../../../../../platform/plugins/shared/triggers_actions_ui/public/types'; +import { ActionForm } from '@kbn/triggers-actions-ui-plugin/public'; +import { RuleAction } from '@kbn/triggers-actions-ui-plugin/public/types'; export const ComponentWithActionsForm: () => { const { http, triggersActionsUi, notifications } = useKibana().services; @@ -1531,7 +1531,7 @@ Follow the instructions bellow to embed the Create Connector flyout within any K import { TriggersAndActionsUIPublicPluginSetup, TriggersAndActionsUIPublicPluginStart, - } from '../../../../../../../x-pack/platform/plugins/shared/triggers_actions_ui/public'; + } from '@kbn/triggers-actions-ui-plugin/public'; triggersActionsUi: TriggersAndActionsUIPublicPluginSetup; ... @@ -1545,7 +1545,7 @@ Then this dependency will be used to embed Create Connector flyout or register n ``` // import section -import { ActionsConnectorsContextProvider, CreateConnectorFlyout } from '../../../../../../../../../triggers_actions_ui/public'; +import { ActionsConnectorsContextProvider, CreateConnectorFlyout } from '@kbn/triggers-actions-ui-plugin/public'; // in the component state definition section const [addFlyoutVisible, setAddFlyoutVisibility] = useState(false); @@ -1615,7 +1615,7 @@ Follow the instructions bellow to embed the Edit Connector flyout within any Kib import { TriggersAndActionsUIPublicPluginSetup, TriggersAndActionsUIPublicPluginStart, - } from '../../../../../../../x-pack/platform/plugins/shared/triggers_actions_ui/public'; + } from '@kbn/triggers-actions-ui-plugin/public'; triggersActionsUi: TriggersAndActionsUIPublicPluginSetup; ... @@ -1629,7 +1629,7 @@ Then this dependency will be used to embed Edit Connector flyout. ``` // import section -import { ActionsConnectorsContextProvider, EditConnectorFlyout } from '../../../../../../../../../triggers_actions_ui/public'; +import { ActionsConnectorsContextProvider, EditConnectorFlyout } from '@kbn/triggers-actions-ui-plugin/public'; // in the component state definition section const [editFlyoutVisible, setEditFlyoutVisibility] = useState(false); diff --git a/x-pack/solutions/observability/plugins/apm/dev_docs/apm_queries.md b/x-pack/solutions/observability/plugins/apm/dev_docs/apm_queries.md index bb72d76552f4..a3bc17abf7c1 100644 --- a/x-pack/solutions/observability/plugins/apm/dev_docs/apm_queries.md +++ b/x-pack/solutions/observability/plugins/apm/dev_docs/apm_queries.md @@ -56,7 +56,7 @@ A pre-aggregated document where `_doc_count` is the number of transaction events You can find all the APM transaction fields [here](https://www.elastic.co/guide/en/apm/server/current/exported-fields-apm-transaction.html). -The decision to use aggregated transactions or not is determined in [`getSearchTransactionsEvents`](https://github.com/elastic/kibana/blob/a2ac439f56313b7a3fc4708f54a4deebf2615136/x-pack/solutions/observability/plugins/apm/server/lib/helpers/aggregated_transactions/index.ts#L53-L79) and then used to specify [the transaction index](https://github.com/elastic/kibana/blob/a2ac439f56313b7a3fc4708f54a4deebf2615136/x-pack/solutions/observability/plugins/apm/server/lib/suggestions/get_suggestions.ts#L30-L32) and [the latency field](https://github.com/elastic/kibana/blob/a2ac439f56313b7a3fc4708f54a4deebf2615136/x-pack/solutions/observability/plugins/apm/server/lib/alerts/chart_preview/get_transaction_duration.ts#L62-L65) +The decision to use aggregated transactions or not is determined in [`getSearchTransactionsEvents`](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/helpers/aggregated_transactions/index.ts#L53-L79) and then used to specify [the transaction index](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/suggestions/get_suggestions.ts#L30-L32) and [the latency field](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/alerts/chart_preview/get_transaction_duration.ts#L62-L65) ### Latency @@ -101,7 +101,7 @@ GET apm-*-metric-*,metrics-apm*/_search?terminate_after=1000 } ``` -Please note: `metricset.name: transaction` was only recently introduced. To retain backwards compatability we still use the old filter `{ "exists": { "field": "transaction.duration.histogram" }}` when filtering for aggregated transactions ([see example](https://github.com/elastic/kibana/blob/2c8686770e64b82cf8e1db5a22327d40d5f8ce45/x-pack/solutions/observability/plugins/apm/server/lib/helpers/aggregated_transactions/index.ts#L89-L95)). +Please note: `metricset.name: transaction` was only recently introduced. To retain backwards compatability we still use the old filter `{ "exists": { "field": "transaction.duration.histogram" }}` when filtering for aggregated transactions ([see example](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/helpers/aggregated_transactions/index.ts#L89-L95)). ### Throughput @@ -291,7 +291,7 @@ System metrics are captured periodically (every 60 seconds by default). You can ![image](https://user-images.githubusercontent.com/209966/135990500-f85bd8d9-b5a5-4b7c-b9e1-0759eefb8a29.png) -Used in: [Metrics section](https://github.com/elastic/kibana/blob/00bb59713ed115343eb70d4e39059476edafbade/x-pack/solutions/observability/plugins/apm/server/lib/metrics/by_agent/shared/cpu/index.ts#L83) +Used in: [Metrics section](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/metrics/by_agent/shared/cpu/index.ts#L83) Noteworthy fields: `system.cpu.total.norm.pct`, `system.process.cpu.total.norm.pct` @@ -377,7 +377,7 @@ GET apm-*-metric-*,metrics-apm*/_search?terminate_after=1000 } ``` -The above example is overly simplified. In reality [we do a bit more](https://github.com/elastic/kibana/blob/fe9b5332e157fd456f81aecfd4ffa78d9e511a66/x-pack/solutions/observability/plugins/apm/server/lib/metrics/by_agent/shared/memory/index.ts#L51-L71) to properly calculate memory usage inside containers. Please note that an [Exists Query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-exists-query.html) is used in the filter context in the query to ensure that the memory fields exist. +The above example is overly simplified. In reality [we do a bit more](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/metrics/by_agent/shared/memory/index.ts#L51-L71) to properly calculate memory usage inside containers. Please note that an [Exists Query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-exists-query.html) is used in the filter context in the query to ensure that the memory fields exist. # Span breakdown metrics @@ -387,7 +387,7 @@ Span breakdown metrics are used to power the "Time spent by span type" graph. Ag ![image](https://user-images.githubusercontent.com/209966/135990865-9077ae3e-a7a4-4b5d-bdce-41dc832689ea.png) -Used in: ["Time spent by span type" chart](https://github.com/elastic/kibana/blob/723370ab23573e50b3524a62c6b9998f2042423d/x-pack/solutions/observability/plugins/apm/server/lib/transactions/breakdown/index.ts#L48-L87) +Used in: ["Time spent by span type" chart](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/transactions/breakdown/index.ts#L48-L87) Noteworthy fields: `transaction.name`, `transaction.type`, `span.type`, `span.subtype`, `span.self_time.*` @@ -447,7 +447,7 @@ These metrics measure the count and total duration of requests from one service ![image](https://user-images.githubusercontent.com/209966/135990117-170070da-2fc5-4014-a597-0dda0970854c.png) -Used in: [Dependencies (latency)](https://github.com/elastic/kibana/blob/00bb59713ed115343eb70d4e39059476edafbade/x-pack/solutions/observability/plugins/apm/server/lib/backends/get_latency_charts_for_backend.ts#L68-L79), [Dependencies (throughput)](https://github.com/elastic/kibana/blob/00bb59713ed115343eb70d4e39059476edafbade/x-pack/solutions/observability/plugins/apm/server/lib/backends/get_throughput_charts_for_backend.ts#L67-L74) and [Service Map](https://github.com/elastic/kibana/blob/00bb59713ed115343eb70d4e39059476edafbade/x-pack/solutions/observability/plugins/apm/server/lib/service_map/get_service_map_backend_node_info.ts#L57-L67) +Used in: [Dependencies (latency)](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/backends/get_latency_charts_for_backend.ts#L68-L79), [Dependencies (throughput)](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/backends/get_throughput_charts_for_backend.ts#L67-L74) and [Service Map](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/service_map/get_service_map_backend_node_info.ts#L57-L67) Noteworthy fields: `span.destination.service.*` diff --git a/x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md b/x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md index 8b47080fcd2c..6531bf9f837e 100644 --- a/x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md +++ b/x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md @@ -31,7 +31,7 @@ Once uploaded to the telemetry cluster, the data telemetry is stored in In order to collect a new telemetry field you need to add a task which performs the query that collects the data from the cluster. -All the available tasks are [here](https://github.com/elastic/kibana/blob/ba84602455671f0f6175bbc0fd2e8f302c60bbe6/x-pack/solutions/observability/plugins/apm/server/lib/apm_telemetry/collect_data_telemetry/tasks.ts) +All the available tasks are [here](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/lib/apm_telemetry/collect_data_telemetry/tasks.ts) ### Debug telemetry @@ -45,7 +45,7 @@ GET /internal/apm/debug-telemetry In order for fields to be searchable on the telemetry cluster, they need to be added to the cluster's mapping. The mapping is defined in -[the telemetry repository's xpack-phone-home template](https://github.com/elastic/telemetry/blob/master/config/templates/xpack-phone-home.json). +[the telemetry repository's xpack-phone-home template](https://github.com/elastic/telemetry/blob/main/legacy/config/templates/xpack-phone-home.json). The mapping for the telemetry data is here under `stack_stats.kibana.plugins.apm`. @@ -78,8 +78,8 @@ EBT is part of the core analytics service in Kibana and the `TelemetryService` p #### Collect a new event type -1. You need to define the event type in the [telemetry_events.ts](https://github.com/elastic/kibana/blob/4283802c195231f710be0d9870615fbc31382a31/x-pack/solutions/observability/plugins/apm/public/services/telemetry/telemetry_events.ts#L36) -2. Define the tracking method in the [telemetry_client.ts](https://github.com/elastic/kibana/blob/4283802c195231f710be0d9870615fbc31382a31/x-pack/solutions/observability/plugins/apm/public/services/telemetry/telemetry_client.ts#L18) +1. You need to define the event type in the [telemetry_events.ts](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/public/services/telemetry/telemetry_events.ts#L36) +2. Define the tracking method in the [telemetry_client.ts](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/public/services/telemetry/telemetry_client.ts#L18) 3. Use the tracking method with the telemetry client (`telemetry.reportSearchQuerySumbitted({property: test})`) In addition to the custom properties, analytics module automatically sends context properties. The list of the properties can be found [here](https://docs.elastic.dev/telemetry/collection/event-based-telemetry-context#browser-context) diff --git a/x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md b/x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md index cfa8f188d456..649a9a69dcc4 100644 --- a/x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md +++ b/x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md @@ -71,7 +71,7 @@ it('calls the dependencies API', () => { ### Prefer `cy.visitKibana` instead of `cy.visit` -In most cases we should use [`cy.visitKibana`](https://github.com/elastic/kibana/blob/50821db39c07d5d35d510c8082d5c608c4e2fd4e/x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/support/commands.ts#L51-L56) instead of `cy.visit`. +In most cases we should use [`cy.visitKibana`](https://github.com/elastic/kibana/blob/f0eb5d695745f1f3a19ae6392618d1826ce29ce2/x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/support/commands.ts#L96-L108) instead of `cy.visit`. `cy.visitKibana` will wait for Kibana to have successfully loaded before moving on. This will reduce the risk of timing out later in the test because we split up the wait time in two parts: Kibana load time, and APM load time thus a time budget for each (by default 40 seconds). ### Clean data before and after each test diff --git a/x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/README.md b/x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/README.md index 23d370cd2702..de7d4a2be028 100644 --- a/x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/README.md +++ b/x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/README.md @@ -33,7 +33,7 @@ After the dataView is created we also set field formats to promote human-readabi ### Visualization Configuration -Each data type may have one or more visualization configurations. The data type to visualization configuration can be found in [`exploratory_view/obs_exploratory_view`](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability/public/components/shared/exploratory_view/obsv_exploratory_view.tsx#L86) +Each data type may have one or more visualization configurations. The data type to visualization configuration can be found in [`exploratory_view/obs_exploratory_view`](https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/obsv_exploratory_view.tsx#L84) Each visualization configuration is mapped to a single report type. diff --git a/x-pack/solutions/observability/plugins/observability/dev_docs/feature_flags.md b/x-pack/solutions/observability/plugins/observability/dev_docs/feature_flags.md index 6ae8bc537a9f..d7665170e618 100644 --- a/x-pack/solutions/observability/plugins/observability/dev_docs/feature_flags.md +++ b/x-pack/solutions/observability/plugins/observability/dev_docs/feature_flags.md @@ -11,6 +11,6 @@ if (core.uiSettings.get(myFeatureEnabled)) { } ``` -In order for telemetry to be collected, the keys and types need to be added in [src/platform/plugins/private/kibana_usage_collection/server/collectors/management/schema.ts](../../../../../src/platform/plugins/private/kibana_usage_collection/server/collectors/management/schema.ts) and [src/platform/plugins/private/kibana_usage_collection/server/collectors/management/types.ts](../../../../src/platform/plugins/private/kibana_usage_collection/server/collectors/management/types.ts). +In order for telemetry to be collected, the keys and types need to be added in [src/platform/plugins/private/kibana_usage_collection/server/collectors/management/schema.ts](../../../../../../src/platform/plugins/private/kibana_usage_collection/server/collectors/management/schema.ts) and [src/platform/plugins/private/kibana_usage_collection/server/collectors/management/types.ts](../../../../../../src/platform/plugins/private/kibana_usage_collection/server/collectors/management/types.ts). Settings can be managed in Kibana under Stack Management > Advanced Settings > Observability. diff --git a/x-pack/solutions/observability/plugins/profiling/e2e/README.md b/x-pack/solutions/observability/plugins/profiling/e2e/README.md index dfc1639db6bc..535803ad529e 100644 --- a/x-pack/solutions/observability/plugins/profiling/e2e/README.md +++ b/x-pack/solutions/observability/plugins/profiling/e2e/README.md @@ -1,6 +1,6 @@ # Profiling E2E tests -Profiling uses [FTR](../../../../../packages/kbn-test/README.md) (functional test runner) and [Cypress](https://www.cypress.io/) to run the e2e tests. The tests are located at `kibana/x-pack/solutions/observability/plugins/profiling/e2e/cypress/e2e`. +Profiling uses [FTR](../../../../../../packages/kbn-test/README.mdx) (functional test runner) and [Cypress](https://www.cypress.io/) to run the e2e tests. The tests are located at `kibana/x-pack/solutions/observability/plugins/profiling/e2e/cypress/e2e`. ## E2E Tests (Cypress) diff --git a/x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/common/react_router_helpers/link_for_eui.tsx b/x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/common/react_router_helpers/link_for_eui.tsx index e15534d66310..982fc2e5d272 100644 --- a/x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/common/react_router_helpers/link_for_eui.tsx +++ b/x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/common/react_router_helpers/link_for_eui.tsx @@ -22,7 +22,7 @@ import { letBrowserHandleEvent } from './link_events'; * Generates either an EuiLink or EuiButton with a React-Router-ified link * * Based off of EUI's recommendations for handling React Router: - * https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51 + * https://github.com/elastic/eui/blob/main/wiki/consuming-eui/react-router.md#react-router-51 */ interface IEuiReactRouterProps { diff --git a/x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/react_router_helpers/link_for_eui.tsx b/x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/react_router_helpers/link_for_eui.tsx index 9378099ce4e8..00d5351570d0 100644 --- a/x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/react_router_helpers/link_for_eui.tsx +++ b/x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/react_router_helpers/link_for_eui.tsx @@ -22,7 +22,7 @@ import { letBrowserHandleEvent } from './link_events'; * Generates either an EuiLink or EuiButton with a React-Router-ified link * * Based off of EUI's recommendations for handling React Router: - * https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51 + * https://github.com/elastic/eui/blob/main/wiki/consuming-eui/react-router.md#react-router-51 */ type IEuiReactRouterProps = PropsWithChildren<{ diff --git a/x-pack/solutions/search/plugins/enterprise_search/public/applications/index.tsx b/x-pack/solutions/search/plugins/enterprise_search/public/applications/index.tsx index 5cc27ba577d3..9b941f396a40 100644 --- a/x-pack/solutions/search/plugins/enterprise_search/public/applications/index.tsx +++ b/x-pack/solutions/search/plugins/enterprise_search/public/applications/index.tsx @@ -169,7 +169,7 @@ export const renderApp = ( * Render function for Kibana's header action menu chrome - * reusable by any Enterprise Search plugin simply by passing in * a custom HeaderActions component (e.g., WorkplaceSearchHeaderActions) - * @see https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.appmountparameters.setheaderactionmenu.md + * @see https://github.com/elastic/kibana/blob/8.0/docs/development/core/public/kibana-plugin-core-public.appmountparameters.setheaderactionmenu.md */ export const renderHeaderActions = ( diff --git a/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/generate_title.ts b/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/generate_title.ts index 42bc9be087bd..6be53c3e2f36 100644 --- a/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/generate_title.ts +++ b/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/generate_title.ts @@ -19,7 +19,7 @@ import { /** * Generate a document title that generally follows our breadcrumb trails - * https://github.com/elastic/kibana/blob/main/docs/development/core/public/kibana-plugin-core-public.chromedoctitle.md + * https://github.com/elastic/kibana/blob/8.0/docs/development/core/public/kibana-plugin-core-public.chromedoctitle.md */ type Title = string[]; diff --git a/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/set_chrome.tsx b/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/set_chrome.tsx index 34664d16503d..21247ab26b51 100644 --- a/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/set_chrome.tsx +++ b/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/kibana_chrome/set_chrome.tsx @@ -40,7 +40,7 @@ import { /** * Helpers for setting Kibana chrome (breadcrumbs, doc titles) on React view mount - * @see https://github.com/elastic/kibana/blob/main/src/core/public/chrome/chrome_service.tsx + * @see https://github.com/elastic/kibana/blob/main/src/core/packages/chrome/browser-internal/src/chrome_service.tsx * * Example usage (don't forget to i18n.translate() page titles!): * diff --git a/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/react_router_helpers/generate_react_router_props.ts b/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/react_router_helpers/generate_react_router_props.ts index 89219362e5be..d27105297e02 100644 --- a/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/react_router_helpers/generate_react_router_props.ts +++ b/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/react_router_helpers/generate_react_router_props.ts @@ -19,7 +19,7 @@ import { letBrowserHandleEvent, createHref } from '.'; * Generates the `href` and `onClick` props for React-Router-friendly links * * Based off of EUI's recommendations for handling React Router: - * https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51 + * https://github.com/elastic/eui/blob/main/wiki/consuming-eui/react-router.md#react-router-51 * * but separated out from EuiLink portion as we use this for multiple EUI components */ diff --git a/x-pack/solutions/search/plugins/enterprise_search/server/lib/enterprise_search_http_agent.ts b/x-pack/solutions/search/plugins/enterprise_search/server/lib/enterprise_search_http_agent.ts index d97daefe881a..405f6ef246a3 100644 --- a/x-pack/solutions/search/plugins/enterprise_search/server/lib/enterprise_search_http_agent.ts +++ b/x-pack/solutions/search/plugins/enterprise_search/server/lib/enterprise_search_http_agent.ts @@ -59,7 +59,6 @@ class EnterpriseSearchHttpAgent { /* * Convert verificationMode to rejectUnauthorized for more consistent config settings * with the rest of Kibana - * @see https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/actions/server/builtin_action_types/lib/get_node_tls_options.ts */ getAgentOptions(verificationMode: 'full' | 'certificate' | 'none') { const agentOptions: AgentOptions = {}; diff --git a/x-pack/solutions/search/plugins/enterprise_search/server/lib/route_config_helpers.ts b/x-pack/solutions/search/plugins/enterprise_search/server/lib/route_config_helpers.ts index cf78420af7f1..4adb306ac0bd 100644 --- a/x-pack/solutions/search/plugins/enterprise_search/server/lib/route_config_helpers.ts +++ b/x-pack/solutions/search/plugins/enterprise_search/server/lib/route_config_helpers.ts @@ -32,7 +32,7 @@ interface ConfigWithoutBodyOptions * The will pass a String Buffer to the route handler. The proper way to validate this when validation * is enabled to to use `body: schema.buffer()`. * - * @see https://github.com/elastic/kibana/blob/main/docs/development/core/server/kibana-plugin-core-server.routeconfigoptionsbody.md + * @see https://github.com/elastic/kibana/blob/8.0/docs/development/core/server/kibana-plugin-core-server.routeconfigoptionsbody.md * @see https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-config-schema/README.md#schemabuffer * * Example: diff --git a/x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.ts b/x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.ts index b8de79b8c729..17934e2b6f0f 100644 --- a/x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.ts +++ b/x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.ts @@ -11,7 +11,7 @@ import { ListOperatorTypeEnum as OperatorTypeEnum } from '@kbn/securitysolution- import { DataViewBase, DataViewFieldBase, getDataViewFieldSubtypeNested } from '@kbn/es-query'; // TODO: I have to use any here for now, but once this is available below, we should use the correct types, https://github.com/elastic/kibana/issues/100715 -// import { AutocompleteStart } from '../../../../../../../../../../../src/platform/plugins/shared/unified_search/public'; +// import { AutocompleteStart } from '@kbn/unified-search-plugin/public'; // eslint-disable-next-line @typescript-eslint/no-explicit-any type AutocompleteStart = any; diff --git a/x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/index.ts b/x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/index.ts index 40277892f1f7..b6e3cf97c731 100644 --- a/x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/index.ts +++ b/x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/index.ts @@ -8,7 +8,6 @@ export * from './src/search_bar'; export * from './src/empty_viewer_state'; export * from './src/pagination/pagination'; -// export * from './src/exceptions_utility/exceptions_utility'; export * from './src/exception_items'; export * from './src/exception_item_card'; export * from './src/value_with_space_warning'; diff --git a/x-pack/solutions/security/packages/kbn-securitysolution-list-api/src/types.ts b/x-pack/solutions/security/packages/kbn-securitysolution-list-api/src/types.ts index 54aa89936d73..9ec8c61fa083 100644 --- a/x-pack/solutions/security/packages/kbn-securitysolution-list-api/src/types.ts +++ b/x-pack/solutions/security/packages/kbn-securitysolution-list-api/src/types.ts @@ -15,7 +15,7 @@ import type { // TODO: Replace these with kbn packaged versions once we have those available to us // These originally came from this location below before moving them to this hacked "any" types: -// import { HttpStart, NotificationsStart } from '../../../../../../../../src/core/public'; +// import { HttpStart, NotificationsStart } from '@kbn/core/public'; interface HttpStart { // eslint-disable-next-line @typescript-eslint/no-explicit-any fetch: (...args: any) => any; diff --git a/x-pack/solutions/security/plugins/lists/README.md b/x-pack/solutions/security/plugins/lists/README.md index b04d7097ddc6..471228b32344 100644 --- a/x-pack/solutions/security/plugins/lists/README.md +++ b/x-pack/solutions/security/plugins/lists/README.md @@ -42,7 +42,7 @@ xpack.lists.listItemIndex: '.items-your-name' Restart Kibana and ensure that you are using `--no-base-path` as changing the base path is a feature but will get in the way of the CURL scripts written as is. -Go to the scripts folder `cd kibana/x-pack/solutions/security/plugins/lists/server/scripts` and run: +Go to the scripts folder `cd x-pack/solutions/security/plugins/lists/server/scripts` and run: ```sh ./hard_reset.sh diff --git a/x-pack/solutions/security/plugins/security_solution/docs/adrs/threat_hunting/0001_saving_of_timeline_associated_saved_objects.md b/x-pack/solutions/security/plugins/security_solution/docs/adrs/threat_hunting/0001_saving_of_timeline_associated_saved_objects.md index 8f6ddf150c9d..a2d98fcb750e 100644 --- a/x-pack/solutions/security/plugins/security_solution/docs/adrs/threat_hunting/0001_saving_of_timeline_associated_saved_objects.md +++ b/x-pack/solutions/security/plugins/security_solution/docs/adrs/threat_hunting/0001_saving_of_timeline_associated_saved_objects.md @@ -13,11 +13,11 @@ When commenting on an unsaved timeline or an event in a timeline or when pinning What's causing this bug is that the associated saved objects have a field `timelineId` that connects them to the timeline. When a (pin/note) save request comes in, the server checks for that field and if it doesn't exist, it will create a new timeline on the fly and return its `timelineId` and `timelineVersion` as part of the saved object's response. -https://github.com/elastic/kibana/blob/2df44b9f7f76f3d03f6e32be7f2a39034f97c22e/x-pack/solutions/security/plugins/security_solution/server/lib/timeline/saved_object/notes/saved_object.ts#L138-L148 +https://github.com/elastic/kibana/blob/2df44b9f7f76f3d03f6e32be7f2a39034f97c22e/x-pack/plugins/security_solution/server/lib/timeline/saved_object/notes/saved_object.ts#L138-L148 These two fields are currently not used in the timeline middleware: -https://github.com/elastic/kibana/blob/2df44b9f7f76f3d03f6e32be7f2a39034f97c22e/x-pack/solutions/security/plugins/security_solution/public/timelines/store/middlewares/timeline_note.ts#L60 +https://github.com/elastic/kibana/blob/2df44b9f7f76f3d03f6e32be7f2a39034f97c22e/x-pack/plugins/security_solution/public/timelines/store/middlewares/timeline_note.ts#L60 This gives the false impression that the associated saved object has been stored but it actually has been associated to a different timeline. Subsequent saves of the active timeline (which is not the associated timeline) will then create a new `timelineId`. When the page is reloaded, the associated saved objects will be gone from that timeline. diff --git a/x-pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md b/x-pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md index 388d80191bb2..2a86bcff7832 100644 --- a/x-pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md +++ b/x-pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md @@ -403,9 +403,9 @@ Since the migration of rules will be performed as the user calls the pertinent e All endpoints belonging to Detection Rules Management that create and update -including upgrade of prebuilt rules to new version- use three CRUD methods under the hood: -- [`createRules`](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/logic/crud/create_rules.ts) -- [`patchRules`](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/logic/crud/patch_rules.ts) -- [`updateRules`](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/logic/crud/update_rules.ts) +- [`createRules`](https://github.com/elastic/kibana/blob/8.0/x-pack/plugins/security_solution/server/lib/detection_engine/rules/create_rules.ts) +- [`patchRules`](https://github.com/elastic/kibana/blob/8.0/x-pack/plugins/security_solution/server/lib/detection_engine/rules/patch_rules.ts) +- [`updateRules`](https://github.com/elastic/kibana/blob/8.0/x-pack/plugins/security_solution/server/lib/detection_engine/rules/update_rules.ts) This "overuse" of these 3 methods for a variety of user actions makes their logic tightly coupled and creates a considerable amount of complexity to CRUD functions that should remain logically simple. @@ -464,7 +464,7 @@ The **normalization on read** will be carried out by a new `normalizeRuleSourceS Inside this method, we will use `normalizeRuleSourceSchemaOnRuleRead` to calculate the normalized values of `rule_source` and `immutable`. -_Source: [x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/normalization/rule_converters.ts](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/normalization/rule_converters.ts)_ +_Source: [rule_converters.ts](https://github.com/elastic/kibana/blob/8.0/x-pack/plugins/security_solution/server/lib/detection_engine/schemas/rule_converters.ts)_ ```ts export const internalRuleToAPIResponse = (rule) => { @@ -948,7 +948,7 @@ export const convertPrebuiltRuleAssetToRuleResponse = ( - [**Perform Rule Installation** - `POST /prebuilt_rules/installation/_install` (Internal)](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/perform_rule_installation/perform_rule_installation_route.ts) -To install a new prebuilt rule, this endpoint uses the [`createPrebuiltRules` method](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/rule_objects/create_prebuilt_rules.ts), which in turn calls the [`createRules` method](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/logic/crud/create_rules.ts). +To install a new prebuilt rule, this endpoint uses the [`createPrebuiltRules` method](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/rule_objects/create_prebuilt_rules.ts), which in turn calls the [`createRules` method](https://github.com/elastic/kibana/blob/8.0/x-pack/plugins/security_solution/server/lib/detection_engine/rules/create_rules.ts). This endpoint also suffers from the issue of tightly coupled logic explained above: using th `createRules` method for creating, importing and upgrading -in some cases- rules. We need to create a new CRUD method specifically for installing prebuilt rules, that extracts that responsibility out of the `createRules` method. diff --git a/x-pack/solutions/security/plugins/security_solution/public/resolver/documentation/schema.md b/x-pack/solutions/security/plugins/security_solution/public/resolver/documentation/schema.md index 30149ec218f9..23f419d3b806 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/resolver/documentation/schema.md +++ b/x-pack/solutions/security/plugins/security_solution/public/resolver/documentation/schema.md @@ -12,7 +12,7 @@ for the elastic endpoint and winlogbeat's sysmon data. ## Schema Format -The predefined schemas are located here +The predefined schemas are located here ```typescript const supportedSchemas: SupportedSchema[] = [ diff --git a/x-pack/solutions/security/plugins/security_solution/public/sourcerer/components/readme.md b/x-pack/solutions/security/plugins/security_solution/public/sourcerer/components/readme.md index 9e0b1f27050d..f26ffe0ff169 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/sourcerer/components/readme.md +++ b/x-pack/solutions/security/plugins/security_solution/public/sourcerer/components/readme.md @@ -6,17 +6,17 @@ - The scope of a sourcerer component will be default unless the path is added to the `detectionsPaths` array, in which case the scope can be detections in `../sourcerer/containers/index.tsx` ## Default Sourcerer -![](../../images/default.png) +![](../../common/images/default.png) - The data view is shown in the dropdown. All index aliases that have existing indices are selected by default. Index aliases that do NOT have existing indices are shown in the dropdown as deactivated ## Detections Sourcerer -![](../../images/alerts.png) +![](../../common/images/alerts.png) - The detections sourcerer is locked to the signals index, and has an "Alerts" flag ## Timeline Sourcerer -![](../../images/timeline.png) +![](../../common/images/timeline.png) - The timeline sourcerer is almost exactly like the default sourcerer, but it has a checkbox to "Show only detection alerts" which will automatically select the default data view with the alerts index locked in: -![](../../images/timeline-alerts.png) +![](../../common/images/timeline-alerts.png) ## Sourcerer Quirks - Signals index is not always defined yet, so we `pollForSignalIndex` on mount of detections sourcerer and timeline sourcerer @@ -24,7 +24,7 @@ - When `selectedPatterns` changes, we updated the `onUpdateDetectionAlertsChecked` boolean - Reset button sets to the active `patternList` on the default security data view - The "Modified" label gets applied when the data view `selectedPatterns` diverge from the `patternList`. It does not appear when changing data views and using that data views patternList in full. It does not appear until Save is pressed! - ![](../../images/timeline_alerts.png) + ![](../../common/images/timeline_alerts.png) ## Legacy Timeline Sourcerer - "Update available" workflow for pre-8.0 timelines and timelines that have indices that got deleted from the default data view diff --git a/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/create_rule_execution_summary.ts b/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/create_rule_execution_summary.ts index 486d2bffccc6..192c9012fa3a 100644 --- a/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/create_rule_execution_summary.ts +++ b/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/create_rule_execution_summary.ts @@ -23,7 +23,7 @@ export const createRuleExecutionSummary = ( // In the rule type the monitoring object is optional because in some cases rules client returns a rule without it. // For instance, when we call RulesClient.create(). Despite the fact that it's always in the rule saved object, // even when it was just created: - // https://github.com/elastic/kibana/blob/26eddec70844ffb65e5d3521a7adb52e643c4534/x-pack/platform/plugins/shared/alerting/server/rules_client/methods/create.ts#L155 + // https://github.com/elastic/kibana/blob/8.9/x-pack/plugins/alerting/server/rules_client/methods/create.ts#L158 return null; } diff --git a/x-pack/solutions/security/plugins/threat_intelligence/public/modules/indicators/components/common/field_label.tsx b/x-pack/solutions/security/plugins/threat_intelligence/public/modules/indicators/components/common/field_label.tsx index b270f561cee6..6e248fcb8c6d 100644 --- a/x-pack/solutions/security/plugins/threat_intelligence/public/modules/indicators/components/common/field_label.tsx +++ b/x-pack/solutions/security/plugins/threat_intelligence/public/modules/indicators/components/common/field_label.tsx @@ -32,7 +32,7 @@ export const IndicatorFieldLabel: VFC = ({ field }) => /** This translates the field name using kbn-i18n */ export const translateFieldLabel = (field: string) => { // This switch is necessary as i18n id cannot be dynamic, see: - // https://github.com/elastic/kibana/blob/main/src/dev/i18n/README.md + // https://github.com/elastic/kibana/blob/main/src/dev/i18n_tools/README.md switch (field) { case RawIndicatorFieldId.TimeStamp: { return TIMESTAMP; diff --git a/x-pack/solutions/security/plugins/timelines/common/search_strategy/index_fields/index.ts b/x-pack/solutions/security/plugins/timelines/common/search_strategy/index_fields/index.ts index c2294aae0925..359eb48b6670 100644 --- a/x-pack/solutions/security/plugins/timelines/common/search_strategy/index_fields/index.ts +++ b/x-pack/solutions/security/plugins/timelines/common/search_strategy/index_fields/index.ts @@ -50,14 +50,14 @@ export interface IndexFieldsStrategyRequestById extends IEsSearchRequest { } /** - * @deprecated use kibana data views api https://github.com/elastic/kibana/blob/83f1fb4f26219f32cab43706db78d544c7bc2f6d/src/platform/plugins/shared/data_views/common/data_views/data_views.ts#L294 + * @deprecated use kibana data views api https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/data_views/common/data_views/data_views.ts#L139 */ export type IndexFieldsStrategyRequest = T extends 'dataView' ? IndexFieldsStrategyRequestById : IndexFieldsStrategyRequestByIndices; /** - * @deprecated use kibana data views api https://github.com/elastic/kibana/blob/83f1fb4f26219f32cab43706db78d544c7bc2f6d/src/platform/plugins/shared/data_views/common/data_views/data_views.ts#L294 + * @deprecated use kibana data views api https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/data_views/common/data_views/data_views.ts#L139 */ export interface IndexFieldsStrategyResponse extends IEsSearchResponse { indexFields: IndexField[]; diff --git a/x-pack/test/cases_api_integration/common/plugins/security_solution/package.json b/x-pack/test/cases_api_integration/common/plugins/security_solution/package.json index cfbc3c48c377..49d2e2e54e29 100644 --- a/x-pack/test/cases_api_integration/common/plugins/security_solution/package.json +++ b/x-pack/test/cases_api_integration/common/plugins/security_solution/package.json @@ -7,8 +7,8 @@ }, "main": "target/test/plugin_api_integration/plugins/security_solution_fixtures", "scripts": { - "kbn": "node ../../../../../../../scripts/kbn.js", - "build": "rm -rf './target' && ../../../../../../../node_modules/.bin/tsc" + "kbn": "node ../../../../../../scripts/kbn.js", + "build": "rm -rf './target' && ../../../../../../node_modules/.bin/tsc" }, "license": "Elastic License 2.0" } \ No newline at end of file