From 2957c8f150cd7836179869d84cbb98b1afd1eb99 Mon Sep 17 00:00:00 2001 From: Jordan Sissel Date: Sun, 5 Feb 2017 00:39:56 -0800 Subject: [PATCH] Do not show the configuration content anymore. Plugin validation errors and other config problems are more specifically logged before we get to this point, and showing the full config can too easily obscure a more actional 'you used an invalid setting' kind of error. Fixes #6654 --- logstash-core/lib/logstash/agent.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/logstash-core/lib/logstash/agent.rb b/logstash-core/lib/logstash/agent.rb index 60e95463a..86406007c 100644 --- a/logstash-core/lib/logstash/agent.rb +++ b/logstash-core/lib/logstash/agent.rb @@ -237,9 +237,9 @@ class LogStash::Agent n.gauge(:last_failure_timestamp, LogStash::Timestamp.now) end if @logger.debug? - @logger.error("fetched an invalid config", :config => config, :reason => exception.message, :backtrace => exception.backtrace) + @logger.error("Cannot load an invalid configuration.", :reason => exception.message, :backtrace => exception.backtrace) else - @logger.error("fetched an invalid config", :config => config, :reason => exception.message) + @logger.error("Cannot load an invalid configuration.", :reason => exception.message) end end