From 9c23cf7b0911b7e9bc77ee24fb77b18d848ac823 Mon Sep 17 00:00:00 2001 From: Andrew Cholakian Date: Wed, 17 Jun 2015 11:01:11 -0500 Subject: [PATCH] Expand out some combined test cases Fixes #3452 --- spec/util/java_version_spec.rb | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/spec/util/java_version_spec.rb b/spec/util/java_version_spec.rb index 1dc29bd71..aa6be1689 100644 --- a/spec/util/java_version_spec.rb +++ b/spec/util/java_version_spec.rb @@ -10,13 +10,19 @@ describe "LogStash::Util::JavaVersion" do end end - it "should mark a bad java version as bad" do + it "should mark a bad beta version as bad" do expect(mod.bad_java_version?("1.7.0_45-beta")).to be_truthy + end + + it "should mark a bad standard version as bad" do expect(mod.bad_java_version?("1.6.0")).to be_truthy end - it "should mark a good java version as good" do + it "should mark a good standard java version as good" do expect(mod.bad_java_version?("1.7.0_51")).to be_falsey + end + + it "should mark a good beta version as good" do expect(mod.bad_java_version?("1.8.0-beta")).to be_falsey end