From dc200a94c42f89db50c3fce370c38d48554ce8ef Mon Sep 17 00:00:00 2001 From: Jordan Sissel Date: Wed, 7 Nov 2012 16:50:48 -0800 Subject: [PATCH] - Add "unsupported" plugin status - Mark both amqp plugins as 'unsupported'. Seeking a maintainer for both the code and the community support for these plugins. --- docs/plugin-status.md | 7 +++++++ lib/logstash/config/mixin.rb | 2 ++ lib/logstash/inputs/amqp.rb | 2 +- lib/logstash/outputs/amqp.rb | 2 +- 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/plugin-status.md b/docs/plugin-status.md index 1e4717c64..f125c70fa 100644 --- a/docs/plugin-status.md +++ b/docs/plugin-status.md @@ -15,6 +15,13 @@ while conveying to the end-user a set of expectations about that plugin. This allows you to make more informed decisions about when and where to use the functionality provided by the new plugin. +## Unsupported + +This plugin is not supported. It should work, but if you have any problems with +it you are unlikely to find any help due to lack of experience in the community. + +Additionally, this label may mean that a plugin has no active maintainer. + ## Experimental When a plugin is in the `experimental` state, it is essentially untested. This diff --git a/lib/logstash/config/mixin.rb b/lib/logstash/config/mixin.rb index 960f6644f..2233506e1 100644 --- a/lib/logstash/config/mixin.rb +++ b/lib/logstash/config/mixin.rb @@ -172,6 +172,8 @@ module LogStash::Config::Mixin def validate_plugin_status docmsg = "For more information about plugin statuses, see http://logstash.net/docs/#{LOGSTASH_VERSION}/plugin-status " case @plugin_status + when "unsupported" + @logger.warn("Using unsupported plugin '#{@config_name}'. This plugin isn't well supported by the community and likely has no maintainer. #{docmsg}") when "experimental" @logger.warn("Using experimental plugin '#{@config_name}'. This plugin is untested and may change in the future. #{docmsg}") when "beta" diff --git a/lib/logstash/inputs/amqp.rb b/lib/logstash/inputs/amqp.rb index 1d1567c36..ff55d0de9 100644 --- a/lib/logstash/inputs/amqp.rb +++ b/lib/logstash/inputs/amqp.rb @@ -17,7 +17,7 @@ require "logstash/namespace" class LogStash::Inputs::Amqp < LogStash::Inputs::Threadable config_name "amqp" - plugin_status "beta" + plugin_status "unsupported" # Your amqp broker's custom arguments. For mirrored queues in RabbitMQ: [ "x-ha-policy", "all" ] config :arguments, :validate => :array, :default => [] diff --git a/lib/logstash/outputs/amqp.rb b/lib/logstash/outputs/amqp.rb index 1b3f46dd4..a7b610a7f 100644 --- a/lib/logstash/outputs/amqp.rb +++ b/lib/logstash/outputs/amqp.rb @@ -15,7 +15,7 @@ class LogStash::Outputs::Amqp < LogStash::Outputs::Base MQTYPES = [ "fanout", "direct", "topic" ] config_name "amqp" - plugin_status "beta" + plugin_status "unsupported" # Your amqp server address config :host, :validate => :string, :required => true