From e670cbf2d16d802e966bbdbc244512ae647a423d Mon Sep 17 00:00:00 2001 From: Joao Duarte Date: Wed, 15 Jul 2020 10:29:07 +0100 Subject: [PATCH] don't call runIntegrationTests from check gradle task This is a temporary fix. Currently the check task depends on the integrationt tests task, which means all dependant tasks will be resolved even if they're just registered instead of created. This resolution is a problem because the downloadES task will fail if, for the version we're building, Elasticsearch doesn't yet have a build we can download. So for now we'll remove this to unblock builds, but finding a way to compartimentalize failures is needed going forward --- build.gradle | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index a7d54324c..6f3fdd25e 100644 --- a/build.gradle +++ b/build.gradle @@ -503,7 +503,13 @@ tasks.register("generatePluginsVersion") { } bootstrap.dependsOn assemblyDeps -check.dependsOn runIntegrationTests +// FIXME: adding the integration tests task to check will mean +// that any registered task will be evaluated. This creates an issue +// where the downloadES task may throw an error on versions where +// Elasticsearch doesn't yet have a build we can fetch +// So for now we'll remove this to unblock builds, but finding a way +// to compartimentalize failures is needed going forward +//check.dependsOn runIntegrationTests Boolean oss = System.getenv('OSS').equals('true')