bianbu-repo-mirror/bianbu-linux-6.6
1
0
Fork 0
mirror of https://gitee.com/bianbu-linux/linux-6.6 synced 2025-04-26 14:17:26 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fs: stop using bdev->bd_super in mark_buffer_write_io_error

Browse source 
bdev->bd_super is a somewhat awkward backpointer from a block device to
an owning file system with unclear rules.

For the buffer_head code we already have a good backpointer for the
inode that the buffer_head is associated with, even if it lives on the
block device mapping: b_assoc_map. It is used track dirty buffers
associated with an inode but living on the block device mapping like
directory buffers in ext4.

mark_buffer_write_io_error already uses it for the call to
mapping_set_error, and should be doing the same for the per-sb error
sequence.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Message-Id: <20230807112625.652089-2-hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Christoph Hellwig 2023-08-07 12:26:22 +01:00 • committed by Christian Brauner
parent 06c2afb862
commit 4b2201dad2
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
fs/buffer.c
View file

@ -1225,19 +1225,14 @@ EXPORT_SYMBOL(mark_buffer_dirty);
void mark_buffer_write_io_error(struct buffer_head *bh) void mark_buffer_write_io_error(struct buffer_head *bh)
{ {
struct super_block *sb;
set_buffer_write_io_error(bh); set_buffer_write_io_error(bh);
/* FIXME: do we need to set this in both places? */ /* FIXME: do we need to set this in both places? */
if (bh->b_folio && bh->b_folio->mapping) if (bh->b_folio && bh->b_folio->mapping)
mapping_set_error(bh->b_folio->mapping, -EIO); mapping_set_error(bh->b_folio->mapping, -EIO);
if (bh->b_assoc_map) if (bh->b_assoc_map) {
mapping_set_error(bh->b_assoc_map, -EIO); mapping_set_error(bh->b_assoc_map, -EIO);
rcu_read_lock(); errseq_set(&bh->b_assoc_map->host->i_sb->s_wb_err, -EIO);
sb = READ_ONCE(bh->b_bdev->bd_super); }
if (sb)
errseq_set(&sb->s_wb_err, -EIO);
rcu_read_unlock();
} }
EXPORT_SYMBOL(mark_buffer_write_io_error); EXPORT_SYMBOL(mark_buffer_write_io_error);