bianbu-repo-mirror/bianbu-linux-6.6
1
0
Fork 0
mirror of https://gitee.com/bianbu-linux/linux-6.6 synced 2025-04-24 14:07:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ARM: OMAP2+: Fix -Warray-bounds warning in _pwrdm_state_switch()

Browse source 
If function pwrdm_read_prev_pwrst() returns -EINVAL, we will end
up accessing array pwrdm->state_counter through negative index
-22. This is wrong and the compiler is legitimately warning us
about this potential problem.

Fix this by sanity checking the value stored in variable _prev_
before accessing array pwrdm->state_counter.

Address the following -Warray-bounds warning:
arch/arm/mach-omap2/powerdomain.c:178:45: warning: array subscript -22 is below array bounds of 'unsigned int[4]' [-Warray-bounds]

Link: https://github.com/KSPP/linux/issues/307
Fixes: ba20bb1269 ("OMAP: PM counter infrastructure.")
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/20230607050639.LzbPn%25lkp@intel.com/
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Message-ID: <ZIFVGwImU3kpaGeH@work>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
This commit is contained in:
Gustavo A. R. Silva 2023-06-07 22:12:11 -06:00 • committed by Tony Lindgren
parent c63f5b4548
commit 847fb80cc0
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
arch/arm/mach-omap2/powerdomain.c
View file

@ -174,7 +174,7 @@ static int _pwrdm_state_switch(struct powerdomain *pwrdm, int flag)
break; break;
case PWRDM_STATE_PREV: case PWRDM_STATE_PREV:
prev = pwrdm_read_prev_pwrst(pwrdm); prev = pwrdm_read_prev_pwrst(pwrdm);
if (pwrdm->state != prev) if (prev >= 0 && pwrdm->state != prev)
pwrdm->state_counter[prev]++; pwrdm->state_counter[prev]++;
if (prev == PWRDM_POWER_RET) if (prev == PWRDM_POWER_RET)
_update_logic_membank_counters(pwrdm); _update_logic_membank_counters(pwrdm);