bianbu-repo-mirror/bianbu-linux-6.6
1
0
Fork 0
mirror of https://gitee.com/bianbu-linux/linux-6.6 synced 2025-04-24 14:07:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu

Browse source 
Pull m68knommu updates from Greg Ungerer:
 "This series is all about Nicolas flat format support for MMU systems.

  Traditional m68k no-MMU flat format binaries can now be run on m68k
  MMU enabled systems too.  The series includes some nice cleanups of
  the binfmt_flat code and converts it to using proper user space
  accessor functions.

  With all this in place you can boot and run a complete no-MMU flat
  format based user space on an MMU enabled system"

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu:
  m68k: enable binfmt_flat on systems with an MMU
  binfmt_flat: allow compressed flat binary format to work on MMU systems
  binfmt_flat: add MMU-specific support
  binfmt_flat: update libraries' data segment pointer with userspace accessors
  binfmt_flat: use clear_user() rather than memset() to clear .bss
  binfmt_flat: use proper user space accessors with old relocs code
  binfmt_flat: use proper user space accessors with relocs processing code
  binfmt_flat: clean up create_flat_tables() and stack accesses
  binfmt_flat: use generic transfer_args_to_stack()
  elf_fdpic_transfer_args_to_stack(): make it generic
  binfmt_flat: prevent kernel dammage from corrupted executable headers
  binfmt_flat: convert printk invocations to their modern form
  binfmt_flat: assorted cleanups
  m68k: use same start_thread() on MMU and no-MMU
  m68k: fix file path comment
  m68k: fix bFLT executable running on MMU enabled systems
This commit is contained in:
Linus Torvalds 2016-08-04 18:04:44 -04:00
commit 8e7106a607
7 changed files with 340 additions and 281 deletions
Download patch file Download diff file Expand all files Collapse all files

13
arch/m68k/include/asm/flat.h
View file

@ -1,5 +1,5 @@
/* /*
* include/asm-m68knommu/flat.h -- uClinux flat-format executables * flat.h -- uClinux flat-format executables
*/ */
#ifndef __M68KNOMMU_FLAT_H__ #ifndef __M68KNOMMU_FLAT_H__
@ -8,8 +8,9 @@
#define flat_argvp_envp_on_stack() 1 #define flat_argvp_envp_on_stack() 1
#define flat_old_ram_flag(flags) (flags) #define flat_old_ram_flag(flags) (flags)
#define flat_reloc_valid(reloc, size) ((reloc) <= (size)) #define flat_reloc_valid(reloc, size) ((reloc) <= (size))
#define flat_get_addr_from_rp(rp, relval, flags, p) get_unaligned(rp) #define flat_get_addr_from_rp(rp, relval, flags, p) \
#define flat_put_addr_at_rp(rp, val, relval) put_unaligned(val,rp) ({ unsigned long __val; __get_user_unaligned(__val, rp); __val; })
#define flat_put_addr_at_rp(rp, val, relval) __put_user_unaligned(val, rp)
#define flat_get_relocate_addr(rel) (rel) #define flat_get_relocate_addr(rel) (rel)
static inline int flat_set_persistent(unsigned long relval, static inline int flat_set_persistent(unsigned long relval,
@ -18,4 +19,10 @@ static inline int flat_set_persistent(unsigned long relval,
return 0; return 0;
} }
#define FLAT_PLAT_INIT(regs) \
do { \
if (current->mm) \
(regs)->d5 = current->mm->start_data; \
} while (0)
#endif /* __M68KNOMMU_FLAT_H__ */ #endif /* __M68KNOMMU_FLAT_H__ */

15
arch/m68k/include/asm/processor.h
View file

@ -110,7 +110,6 @@ struct thread_struct {
#define setframeformat(_regs) do { } while (0) #define setframeformat(_regs) do { } while (0)
#endif #endif
#ifdef CONFIG_MMU
/* /*
* Do necessary setup to start up a newly executed thread. * Do necessary setup to start up a newly executed thread.
*/ */
@ -123,26 +122,14 @@ static inline void start_thread(struct pt_regs * regs, unsigned long pc,
wrusp(usp); wrusp(usp);
} }
#ifdef CONFIG_MMU
extern int handle_kernel_fault(struct pt_regs *regs); extern int handle_kernel_fault(struct pt_regs *regs);
#else #else
#define start_thread(_regs, _pc, _usp) \
do { \
(_regs)->pc = (_pc); \
setframeformat(_regs); \
if (current->mm) \
(_regs)->d5 = current->mm->start_data; \
(_regs)->sr &= ~0x2000; \
wrusp(_usp); \
} while(0)
static inline int handle_kernel_fault(struct pt_regs *regs) static inline int handle_kernel_fault(struct pt_regs *regs)
{ {
/* Any fault in kernel is fatal on non-mmu */ /* Any fault in kernel is fatal on non-mmu */
return 0; return 0;
} }
#endif #endif
/* Forward declaration, a strange C thing */ /* Forward declaration, a strange C thing */

3
fs/Kconfig.binfmt
View file

@ -89,7 +89,8 @@ config BINFMT_SCRIPT
config BINFMT_FLAT config BINFMT_FLAT
bool "Kernel support for flat binaries" bool "Kernel support for flat binaries"
depends on !MMU && (!FRV || BROKEN) depends on !MMU || M68K
depends on !FRV || BROKEN
help help
Support uClinux FLAT format binaries. Support uClinux FLAT format binaries.

38
fs/binfmt_elf_fdpic.c
View file

@ -67,8 +67,6 @@ static int create_elf_fdpic_tables(struct linux_binprm *, struct mm_struct *,
struct elf_fdpic_params *); struct elf_fdpic_params *);
#ifndef CONFIG_MMU #ifndef CONFIG_MMU
static int elf_fdpic_transfer_args_to_stack(struct linux_binprm *,
unsigned long *);
static int elf_fdpic_map_file_constdisp_on_uclinux(struct elf_fdpic_params *, static int elf_fdpic_map_file_constdisp_on_uclinux(struct elf_fdpic_params *,
struct file *, struct file *,
struct mm_struct *); struct mm_struct *);
@ -515,8 +513,9 @@ static int create_elf_fdpic_tables(struct linux_binprm *bprm,
sp = mm->start_stack; sp = mm->start_stack;
/* stack the program arguments and environment */ /* stack the program arguments and environment */
if (elf_fdpic_transfer_args_to_stack(bprm, &sp) < 0) if (transfer_args_to_stack(bprm, &sp) < 0)
return -EFAULT; return -EFAULT;
sp &= ~15;
#endif #endif
/* /*
@ -709,39 +708,6 @@ static int create_elf_fdpic_tables(struct linux_binprm *bprm,
return 0; return 0;
} }
/*****************************************************************************/
/*
* transfer the program arguments and environment from the holding pages onto
* the stack
*/
#ifndef CONFIG_MMU
static int elf_fdpic_transfer_args_to_stack(struct linux_binprm *bprm,
unsigned long *_sp)
{
unsigned long index, stop, sp;
char *src;
int ret = 0;
stop = bprm->p >> PAGE_SHIFT;
sp = *_sp;
for (index = MAX_ARG_PAGES - 1; index >= stop; index--) {
src = kmap(bprm->page[index]);
sp -= PAGE_SIZE;
if (copy_to_user((void *) sp, src, PAGE_SIZE) != 0)
ret = -EFAULT;
kunmap(bprm->page[index]);
if (ret < 0)
goto out;
}
*_sp = (*_sp - (MAX_ARG_PAGES * PAGE_SIZE - bprm->p)) & ~15;
out:
return ret;
}
#endif
/*****************************************************************************/ /*****************************************************************************/
/* /*
* load the appropriate binary image (executable or interpreter) into memory * load the appropriate binary image (executable or interpreter) into memory

517
fs/binfmt_flat.c
View file

@ -15,7 +15,8 @@
* JAN/99 -- coded full program relocation (gerg@snapgear.com) * JAN/99 -- coded full program relocation (gerg@snapgear.com)
*/ */
#include <linux/export.h> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/sched.h> #include <linux/sched.h>
#include <linux/mm.h> #include <linux/mm.h>
@ -25,8 +26,6 @@
#include <linux/string.h> #include <linux/string.h>
#include <linux/fs.h> #include <linux/fs.h>
#include <linux/file.h> #include <linux/file.h>
#include <linux/stat.h>
#include <linux/fcntl.h>
#include <linux/ptrace.h> #include <linux/ptrace.h>
#include <linux/user.h> #include <linux/user.h>
#include <linux/slab.h> #include <linux/slab.h>
@ -34,26 +33,16 @@
#include <linux/personality.h> #include <linux/personality.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/flat.h> #include <linux/flat.h>
#include <linux/syscalls.h> #include <linux/uaccess.h>
#include <linux/vmalloc.h>
#include <asm/byteorder.h> #include <asm/byteorder.h>
#include <asm/uaccess.h>
#include <asm/unaligned.h> #include <asm/unaligned.h>
#include <asm/cacheflush.h> #include <asm/cacheflush.h>
#include <asm/page.h> #include <asm/page.h>
/****************************************************************************/ /****************************************************************************/
#if 0
#define DEBUG 1
#endif
#ifdef DEBUG
#define DBG_FLT(a...) printk(a)
#else
#define DBG_FLT(a...)
#endif
/* /*
* User data (data section and bss) needs to be aligned. * User data (data section and bss) needs to be aligned.
* We pick 0x20 here because it is the max value elf2flt has always * We pick 0x20 here because it is the max value elf2flt has always
@ -80,7 +69,7 @@ struct lib_info {
unsigned long text_len; /* Length of text segment */ unsigned long text_len; /* Length of text segment */
unsigned long entry; /* Start address for this module */ unsigned long entry; /* Start address for this module */
unsigned long build_date; /* When this one was compiled */ unsigned long build_date; /* When this one was compiled */
short loaded; /* Has this library been loaded? */ bool loaded; /* Has this library been loaded? */
} lib_list[MAX_SHARED_LIBS]; } lib_list[MAX_SHARED_LIBS];
}; };
@ -106,59 +95,67 @@ static struct linux_binfmt flat_format = {
static int flat_core_dump(struct coredump_params *cprm) static int flat_core_dump(struct coredump_params *cprm)
{ {
printk("Process %s:%d received signr %d and should have core dumped\n", pr_warn("Process %s:%d received signr %d and should have core dumped\n",
current->comm, current->pid, (int) cprm->siginfo->si_signo); current->comm, current->pid, cprm->siginfo->si_signo);
return(1); return 1;
} }
/****************************************************************************/ /****************************************************************************/
/* /*
* create_flat_tables() parses the env- and arg-strings in new user * create_flat_tables() parses the env- and arg-strings in new user
* memory and creates the pointer tables from them, and puts their * memory and creates the pointer tables from them, and puts their
* addresses on the "stack", returning the new stack pointer value. * addresses on the "stack", recording the new stack pointer value.
*/ */
static unsigned long create_flat_tables( static int create_flat_tables(struct linux_binprm *bprm, unsigned long arg_start)
unsigned long pp,
struct linux_binprm * bprm)
{ {
unsigned long *argv,*envp; char __user *p;
unsigned long * sp; unsigned long __user *sp;
char * p = (char*)pp; long i, len;
int argc = bprm->argc;
int envc = bprm->envc;
char uninitialized_var(dummy);
sp = (unsigned long *)p; p = (char __user *)arg_start;
sp -= (envc + argc + 2) + 1 + (flat_argvp_envp_on_stack() ? 2 : 0); sp = (unsigned long __user *)current->mm->start_stack;
sp = (unsigned long *) ((unsigned long)sp & -FLAT_STACK_ALIGN);
argv = sp + 1 + (flat_argvp_envp_on_stack() ? 2 : 0);
envp = argv + (argc + 1);
sp -= bprm->envc + 1;
sp -= bprm->argc + 1;
sp -= flat_argvp_envp_on_stack() ? 2 : 0;
sp -= 1; /* &argc */
current->mm->start_stack = (unsigned long)sp & -FLAT_STACK_ALIGN;
sp = (unsigned long __user *)current->mm->start_stack;
__put_user(bprm->argc, sp++);
if (flat_argvp_envp_on_stack()) { if (flat_argvp_envp_on_stack()) {
put_user((unsigned long) envp, sp + 2); unsigned long argv, envp;
put_user((unsigned long) argv, sp + 1); argv = (unsigned long)(sp + 2);
envp = (unsigned long)(sp + 2 + bprm->argc + 1);
__put_user(argv, sp++);
__put_user(envp, sp++);
} }
put_user(argc, sp); current->mm->arg_start = (unsigned long)p;
current->mm->arg_start = (unsigned long) p; for (i = bprm->argc; i > 0; i--) {
while (argc-->0) { __put_user((unsigned long)p, sp++);
put_user((unsigned long) p, argv++); len = strnlen_user(p, MAX_ARG_STRLEN);
do { if (!len || len > MAX_ARG_STRLEN)
get_user(dummy, p); p++; return -EINVAL;
} while (dummy); p += len;
} }
put_user((unsigned long) NULL, argv); __put_user(0, sp++);
current->mm->arg_end = current->mm->env_start = (unsigned long) p; current->mm->arg_end = (unsigned long)p;
while (envc-->0) {
put_user((unsigned long)p, envp); envp++; current->mm->env_start = (unsigned long) p;
do { for (i = bprm->envc; i > 0; i--) {
get_user(dummy, p); p++; __put_user((unsigned long)p, sp++);
} while (dummy); len = strnlen_user(p, MAX_ARG_STRLEN);
if (!len || len > MAX_ARG_STRLEN)
return -EINVAL;
p += len;
} }
put_user((unsigned long) NULL, envp); __put_user(0, sp++);
current->mm->env_end = (unsigned long) p; current->mm->env_end = (unsigned long)p;
return (unsigned long)sp;
return 0;
} }
/****************************************************************************/ /****************************************************************************/
@ -190,17 +187,17 @@ static int decompress_exec(
loff_t fpos; loff_t fpos;
int ret, retval; int ret, retval;
DBG_FLT("decompress_exec(offset=%x,buf=%x,len=%x)\n",(int)offset, (int)dst, (int)len); pr_debug("decompress_exec(offset=%lx,buf=%p,len=%lx)\n", offset, dst, len);
memset(&strm, 0, sizeof(strm)); memset(&strm, 0, sizeof(strm));
strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL); strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL);
if (strm.workspace == NULL) { if (strm.workspace == NULL) {
DBG_FLT("binfmt_flat: no memory for decompress workspace\n"); pr_debug("no memory for decompress workspace\n");
return -ENOMEM; return -ENOMEM;
} }
buf = kmalloc(LBUFSIZE, GFP_KERNEL); buf = kmalloc(LBUFSIZE, GFP_KERNEL);
if (buf == NULL) { if (buf == NULL) {
DBG_FLT("binfmt_flat: no memory for read buffer\n"); pr_debug("no memory for read buffer\n");
retval = -ENOMEM; retval = -ENOMEM;
goto out_free; goto out_free;
} }
@ -218,49 +215,49 @@ static int decompress_exec(
/* Check minimum size -- gzip header */ /* Check minimum size -- gzip header */
if (ret < 10) { if (ret < 10) {
DBG_FLT("binfmt_flat: file too small?\n"); pr_debug("file too small?\n");
goto out_free_buf; goto out_free_buf;
} }
/* Check gzip magic number */ /* Check gzip magic number */
if ((buf[0] != 037) || ((buf[1] != 0213) && (buf[1] != 0236))) { if ((buf[0] != 037) || ((buf[1] != 0213) && (buf[1] != 0236))) {
DBG_FLT("binfmt_flat: unknown compression magic?\n"); pr_debug("unknown compression magic?\n");
goto out_free_buf; goto out_free_buf;
} }
/* Check gzip method */ /* Check gzip method */
if (buf[2] != 8) { if (buf[2] != 8) {
DBG_FLT("binfmt_flat: unknown compression method?\n"); pr_debug("unknown compression method?\n");
goto out_free_buf; goto out_free_buf;
} }
/* Check gzip flags */ /* Check gzip flags */
if ((buf[3] & ENCRYPTED) || (buf[3] & CONTINUATION) || if ((buf[3] & ENCRYPTED) || (buf[3] & CONTINUATION) ||
(buf[3] & RESERVED)) { (buf[3] & RESERVED)) {
DBG_FLT("binfmt_flat: unknown flags?\n"); pr_debug("unknown flags?\n");
goto out_free_buf; goto out_free_buf;
} }
ret = 10; ret = 10;
if (buf[3] & EXTRA_FIELD) { if (buf[3] & EXTRA_FIELD) {
ret += 2 + buf[10] + (buf[11] << 8); ret += 2 + buf[10] + (buf[11] << 8);
if (unlikely(LBUFSIZE <= ret)) { if (unlikely(ret >= LBUFSIZE)) {
DBG_FLT("binfmt_flat: buffer overflow (EXTRA)?\n"); pr_debug("buffer overflow (EXTRA)?\n");
goto out_free_buf; goto out_free_buf;
} }
} }
if (buf[3] & ORIG_NAME) { if (buf[3] & ORIG_NAME) {
while (ret < LBUFSIZE && buf[ret++] != 0) while (ret < LBUFSIZE && buf[ret++] != 0)
; ;
if (unlikely(LBUFSIZE == ret)) { if (unlikely(ret == LBUFSIZE)) {
DBG_FLT("binfmt_flat: buffer overflow (ORIG_NAME)?\n"); pr_debug("buffer overflow (ORIG_NAME)?\n");
goto out_free_buf; goto out_free_buf;
} }
} }
if (buf[3] & COMMENT) { if (buf[3] & COMMENT) {
while (ret < LBUFSIZE && buf[ret++] != 0) while (ret < LBUFSIZE && buf[ret++] != 0)
; ;
if (unlikely(LBUFSIZE == ret)) { if (unlikely(ret == LBUFSIZE)) {
DBG_FLT("binfmt_flat: buffer overflow (COMMENT)?\n"); pr_debug("buffer overflow (COMMENT)?\n");
goto out_free_buf; goto out_free_buf;
} }
} }
@ -273,7 +270,7 @@ static int decompress_exec(
strm.total_out = 0; strm.total_out = 0;
if (zlib_inflateInit2(&strm, -MAX_WBITS) != Z_OK) { if (zlib_inflateInit2(&strm, -MAX_WBITS) != Z_OK) {
DBG_FLT("binfmt_flat: zlib init failed?\n"); pr_debug("zlib init failed?\n");
goto out_free_buf; goto out_free_buf;
} }
@ -290,7 +287,7 @@ static int decompress_exec(
} }
if (ret < 0) { if (ret < 0) {
DBG_FLT("binfmt_flat: decompression failed (%d), %s\n", pr_debug("decompression failed (%d), %s\n",
ret, strm.msg); ret, strm.msg);
goto out_zlib; goto out_zlib;
} }
@ -327,24 +324,23 @@ calc_reloc(unsigned long r, struct lib_info *p, int curid, int internalp)
r &= 0x00ffffff; /* Trim ID off here */ r &= 0x00ffffff; /* Trim ID off here */
} }
if (id >= MAX_SHARED_LIBS) { if (id >= MAX_SHARED_LIBS) {
printk("BINFMT_FLAT: reference 0x%x to shared library %d", pr_err("reference 0x%lx to shared library %d", r, id);
(unsigned) r, id);
goto failed; goto failed;
} }
if (curid != id) { if (curid != id) {
if (internalp) { if (internalp) {
printk("BINFMT_FLAT: reloc address 0x%x not in same module " pr_err("reloc address 0x%lx not in same module "
"(%d != %d)", (unsigned) r, curid, id); "(%d != %d)", r, curid, id);
goto failed; goto failed;
} else if ( ! p->lib_list[id].loaded && } else if (!p->lib_list[id].loaded &&
load_flat_shared_library(id, p) < 0) { load_flat_shared_library(id, p) < 0) {
printk("BINFMT_FLAT: failed to load library %d", id); pr_err("failed to load library %d", id);
goto failed; goto failed;
} }
/* Check versioning information (i.e. time stamps) */ /* Check versioning information (i.e. time stamps) */
if (p->lib_list[id].build_date && p->lib_list[curid].build_date && if (p->lib_list[id].build_date && p->lib_list[curid].build_date &&
p->lib_list[curid].build_date < p->lib_list[id].build_date) { p->lib_list[curid].build_date < p->lib_list[id].build_date) {
printk("BINFMT_FLAT: library %d is younger than %d", id, curid); pr_err("library %d is younger than %d", id, curid);
goto failed; goto failed;
} }
} }
@ -358,8 +354,8 @@ calc_reloc(unsigned long r, struct lib_info *p, int curid, int internalp)
text_len = p->lib_list[id].text_len; text_len = p->lib_list[id].text_len;
if (!flat_reloc_valid(r, start_brk - start_data + text_len)) { if (!flat_reloc_valid(r, start_brk - start_data + text_len)) {
printk("BINFMT_FLAT: reloc outside program 0x%x (0 - 0x%x/0x%x)", pr_err("reloc outside program 0x%lx (0 - 0x%lx/0x%lx)",
(int) r,(int)(start_brk-start_data+text_len),(int)text_len); r, start_brk-start_data+text_len, text_len);
goto failed; goto failed;
} }
@ -369,10 +365,10 @@ calc_reloc(unsigned long r, struct lib_info *p, int curid, int internalp)
addr = r - text_len + start_data; addr = r - text_len + start_data;
/* Range checked already above so doing the range tests is redundant...*/ /* Range checked already above so doing the range tests is redundant...*/
return(addr); return addr;
failed: failed:
printk(", killing %s!\n", current->comm); pr_cont(", killing %s!\n", current->comm);
send_sig(SIGSEGV, current, 0); send_sig(SIGSEGV, current, 0);
return RELOC_FAILED; return RELOC_FAILED;
@ -382,62 +378,57 @@ failed:
static void old_reloc(unsigned long rl) static void old_reloc(unsigned long rl)
{ {
#ifdef DEBUG static const char *segment[] = { "TEXT", "DATA", "BSS", "*UNKNOWN*" };
char *segment[] = { "TEXT", "DATA", "BSS", "*UNKNOWN*" };
#endif
flat_v2_reloc_t r; flat_v2_reloc_t r;
unsigned long *ptr; unsigned long __user *ptr;
unsigned long val;
r.value = rl; r.value = rl;
#if defined(CONFIG_COLDFIRE) #if defined(CONFIG_COLDFIRE)
ptr = (unsigned long *) (current->mm->start_code + r.reloc.offset); ptr = (unsigned long __user *)(current->mm->start_code + r.reloc.offset);
#else #else
ptr = (unsigned long *) (current->mm->start_data + r.reloc.offset); ptr = (unsigned long __user *)(current->mm->start_data + r.reloc.offset);
#endif #endif
get_user(val, ptr);
pr_debug("Relocation of variable at DATASEG+%x "
"(address %p, currently %lx) into segment %s\n",
r.reloc.offset, ptr, val, segment[r.reloc.type]);
#ifdef DEBUG
printk("Relocation of variable at DATASEG+%x "
"(address %p, currently %x) into segment %s\n",
r.reloc.offset, ptr, (int)*ptr, segment[r.reloc.type]);
#endif
switch (r.reloc.type) { switch (r.reloc.type) {
case OLD_FLAT_RELOC_TYPE_TEXT: case OLD_FLAT_RELOC_TYPE_TEXT:
*ptr += current->mm->start_code; val += current->mm->start_code;
break; break;
case OLD_FLAT_RELOC_TYPE_DATA: case OLD_FLAT_RELOC_TYPE_DATA:
*ptr += current->mm->start_data; val += current->mm->start_data;
break; break;
case OLD_FLAT_RELOC_TYPE_BSS: case OLD_FLAT_RELOC_TYPE_BSS:
*ptr += current->mm->end_data; val += current->mm->end_data;
break; break;
default: default:
printk("BINFMT_FLAT: Unknown relocation type=%x\n", r.reloc.type); pr_err("Unknown relocation type=%x\n", r.reloc.type);
break; break;
} }
put_user(val, ptr);
#ifdef DEBUG pr_debug("Relocation became %lx\n", val);
printk("Relocation became %x\n", (int)*ptr); }
#endif
}
/****************************************************************************/ /****************************************************************************/
static int load_flat_file(struct linux_binprm * bprm, static int load_flat_file(struct linux_binprm *bprm,
struct lib_info *libinfo, int id, unsigned long *extra_stack) struct lib_info *libinfo, int id, unsigned long *extra_stack)
{ {
struct flat_hdr * hdr; struct flat_hdr *hdr;
unsigned long textpos = 0, datapos = 0, result; unsigned long textpos, datapos, realdatastart;
unsigned long realdatastart = 0; unsigned long text_len, data_len, bss_len, stack_len, full_data, flags;
unsigned long text_len, data_len, bss_len, stack_len, flags; unsigned long len, memp, memp_size, extra, rlim;
unsigned long full_data; unsigned long __user *reloc, *rp;
unsigned long len, memp = 0;
unsigned long memp_size, extra, rlim;
unsigned long *reloc = 0, *rp;
struct inode *inode; struct inode *inode;
int i, rev, relocs = 0; int i, rev, relocs;
loff_t fpos; loff_t fpos;
unsigned long start_code, end_code; unsigned long start_code, end_code;
ssize_t result;
int ret; int ret;
hdr = ((struct flat_hdr *) bprm->buf); /* exec-header */ hdr = ((struct flat_hdr *) bprm->buf); /* exec-header */
@ -469,20 +460,30 @@ static int load_flat_file(struct linux_binprm * bprm,
} }
if (flags & FLAT_FLAG_KTRACE) if (flags & FLAT_FLAG_KTRACE)
printk("BINFMT_FLAT: Loading file: %s\n", bprm->filename); pr_info("Loading file: %s\n", bprm->filename);
if (rev != FLAT_VERSION && rev != OLD_FLAT_VERSION) { if (rev != FLAT_VERSION && rev != OLD_FLAT_VERSION) {
printk("BINFMT_FLAT: bad flat file version 0x%x (supported " pr_err("bad flat file version 0x%x (supported 0x%lx and 0x%lx)\n",
"0x%lx and 0x%lx)\n", rev, FLAT_VERSION, OLD_FLAT_VERSION);
rev, FLAT_VERSION, OLD_FLAT_VERSION);
ret = -ENOEXEC; ret = -ENOEXEC;
goto err; goto err;
} }
/* Don't allow old format executables to use shared libraries */ /* Don't allow old format executables to use shared libraries */
if (rev == OLD_FLAT_VERSION && id != 0) { if (rev == OLD_FLAT_VERSION && id != 0) {
printk("BINFMT_FLAT: shared libraries are not available before rev 0x%x\n", pr_err("shared libraries are not available before rev 0x%lx\n",
(int) FLAT_VERSION); FLAT_VERSION);
ret = -ENOEXEC;
goto err;
}
/*
* Make sure the header params are sane.
* 28 bits (256 MB) is way more than reasonable in this case.
* If some top bits are set we have probable binary corruption.
*/
if ((text_len | data_len | bss_len | stack_len | full_data) >> 28) {
pr_err("bad header\n");
ret = -ENOEXEC; ret = -ENOEXEC;
goto err; goto err;
} }
@ -496,7 +497,7 @@ static int load_flat_file(struct linux_binprm * bprm,
#ifndef CONFIG_BINFMT_ZFLAT #ifndef CONFIG_BINFMT_ZFLAT
if (flags & (FLAT_FLAG_GZIP|FLAT_FLAG_GZDATA)) { if (flags & (FLAT_FLAG_GZIP|FLAT_FLAG_GZDATA)) {
printk("Support for ZFLAT executables is not enabled.\n"); pr_err("Support for ZFLAT executables is not enabled.\n");
ret = -ENOEXEC; ret = -ENOEXEC;
goto err; goto err;
} }
@ -517,11 +518,9 @@ static int load_flat_file(struct linux_binprm * bprm,
/* Flush all traces of the currently running executable */ /* Flush all traces of the currently running executable */
if (id == 0) { if (id == 0) {
result = flush_old_exec(bprm); ret = flush_old_exec(bprm);
if (result) { if (ret)
ret = result;
goto err; goto err;
}
/* OK, This is the point of no return */ /* OK, This is the point of no return */
set_personality(PER_LINUX_32BIT); set_personality(PER_LINUX_32BIT);
@ -539,48 +538,48 @@ static int load_flat_file(struct linux_binprm * bprm,
* case, and then the fully copied to RAM case which lumps * case, and then the fully copied to RAM case which lumps
* it all together. * it all together.
*/ */
if ((flags & (FLAT_FLAG_RAM|FLAT_FLAG_GZIP)) == 0) { if (!IS_ENABLED(CONFIG_MMU) && !(flags & (FLAT_FLAG_RAM|FLAT_FLAG_GZIP))) {
/* /*
* this should give us a ROM ptr, but if it doesn't we don't * this should give us a ROM ptr, but if it doesn't we don't
* really care * really care
*/ */
DBG_FLT("BINFMT_FLAT: ROM mapping of file (we hope)\n"); pr_debug("ROM mapping of file (we hope)\n");
textpos = vm_mmap(bprm->file, 0, text_len, PROT_READ|PROT_EXEC, textpos = vm_mmap(bprm->file, 0, text_len, PROT_READ|PROT_EXEC,
MAP_PRIVATE|MAP_EXECUTABLE, 0); MAP_PRIVATE|MAP_EXECUTABLE, 0);
if (!textpos || IS_ERR_VALUE(textpos)) { if (!textpos || IS_ERR_VALUE(textpos)) {
if (!textpos)
textpos = (unsigned long) -ENOMEM;
printk("Unable to mmap process text, errno %d\n", (int)-textpos);
ret = textpos; ret = textpos;
if (!textpos)
ret = -ENOMEM;
pr_err("Unable to mmap process text, errno %d\n", ret);
goto err; goto err;
} }
len = data_len + extra + MAX_SHARED_LIBS * sizeof(unsigned long); len = data_len + extra + MAX_SHARED_LIBS * sizeof(unsigned long);
len = PAGE_ALIGN(len); len = PAGE_ALIGN(len);
realdatastart = vm_mmap(0, 0, len, realdatastart = vm_mmap(NULL, 0, len,
PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE, 0); PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE, 0);
if (realdatastart == 0 || IS_ERR_VALUE(realdatastart)) { if (realdatastart == 0 || IS_ERR_VALUE(realdatastart)) {
if (!realdatastart)
realdatastart = (unsigned long) -ENOMEM;
printk("Unable to allocate RAM for process data, errno %d\n",
(int)-realdatastart);
vm_munmap(textpos, text_len);
ret = realdatastart; ret = realdatastart;
if (!realdatastart)
ret = -ENOMEM;
pr_err("Unable to allocate RAM for process data, "
"errno %d\n", ret);
vm_munmap(textpos, text_len);
goto err; goto err;
} }
datapos = ALIGN(realdatastart + datapos = ALIGN(realdatastart +
MAX_SHARED_LIBS * sizeof(unsigned long), MAX_SHARED_LIBS * sizeof(unsigned long),
FLAT_DATA_ALIGN); FLAT_DATA_ALIGN);
DBG_FLT("BINFMT_FLAT: Allocated data+bss+stack (%d bytes): %x\n", pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n",
(int)(data_len + bss_len + stack_len), (int)datapos); data_len + bss_len + stack_len, datapos);
fpos = ntohl(hdr->data_start); fpos = ntohl(hdr->data_start);
#ifdef CONFIG_BINFMT_ZFLAT #ifdef CONFIG_BINFMT_ZFLAT
if (flags & FLAT_FLAG_GZDATA) { if (flags & FLAT_FLAG_GZDATA) {
result = decompress_exec(bprm, fpos, (char *) datapos, result = decompress_exec(bprm, fpos, (char *)datapos,
full_data, 0); full_data, 0);
} else } else
#endif #endif
@ -589,29 +588,30 @@ static int load_flat_file(struct linux_binprm * bprm,
full_data); full_data);
} }
if (IS_ERR_VALUE(result)) { if (IS_ERR_VALUE(result)) {
printk("Unable to read data+bss, errno %d\n", (int)-result); ret = result;
pr_err("Unable to read data+bss, errno %d\n", ret);
vm_munmap(textpos, text_len); vm_munmap(textpos, text_len);
vm_munmap(realdatastart, len); vm_munmap(realdatastart, len);
ret = result;
goto err; goto err;
} }
reloc = (unsigned long *) (datapos+(ntohl(hdr->reloc_start)-text_len)); reloc = (unsigned long __user *)
(datapos + (ntohl(hdr->reloc_start) - text_len));
memp = realdatastart; memp = realdatastart;
memp_size = len; memp_size = len;
} else { } else {
len = text_len + data_len + extra + MAX_SHARED_LIBS * sizeof(unsigned long); len = text_len + data_len + extra + MAX_SHARED_LIBS * sizeof(unsigned long);
len = PAGE_ALIGN(len); len = PAGE_ALIGN(len);
textpos = vm_mmap(0, 0, len, textpos = vm_mmap(NULL, 0, len,
PROT_READ | PROT_EXEC | PROT_WRITE, MAP_PRIVATE, 0); PROT_READ | PROT_EXEC | PROT_WRITE, MAP_PRIVATE, 0);
if (!textpos || IS_ERR_VALUE(textpos)) { if (!textpos || IS_ERR_VALUE(textpos)) {
if (!textpos)
textpos = (unsigned long) -ENOMEM;
printk("Unable to allocate RAM for process text/data, errno %d\n",
(int)-textpos);
ret = textpos; ret = textpos;
if (!textpos)
ret = -ENOMEM;
pr_err("Unable to allocate RAM for process text/data, "
"errno %d\n", ret);
goto err; goto err;
} }
@ -620,7 +620,7 @@ static int load_flat_file(struct linux_binprm * bprm,
MAX_SHARED_LIBS * sizeof(unsigned long), MAX_SHARED_LIBS * sizeof(unsigned long),
FLAT_DATA_ALIGN); FLAT_DATA_ALIGN);
reloc = (unsigned long *) reloc = (unsigned long __user *)
(datapos + (ntohl(hdr->reloc_start) - text_len)); (datapos + (ntohl(hdr->reloc_start) - text_len));
memp = textpos; memp = textpos;
memp_size = len; memp_size = len;
@ -629,21 +629,59 @@ static int load_flat_file(struct linux_binprm * bprm,
* load it all in and treat it like a RAM load from now on * load it all in and treat it like a RAM load from now on
*/ */
if (flags & FLAT_FLAG_GZIP) { if (flags & FLAT_FLAG_GZIP) {
result = decompress_exec(bprm, sizeof (struct flat_hdr), #ifndef CONFIG_MMU
(((char *) textpos) + sizeof (struct flat_hdr)), result = decompress_exec(bprm, sizeof(struct flat_hdr),
(((char *)textpos) + sizeof(struct flat_hdr)),
(text_len + full_data (text_len + full_data
- sizeof (struct flat_hdr)), - sizeof(struct flat_hdr)),
0); 0);
memmove((void *) datapos, (void *) realdatastart, memmove((void *) datapos, (void *) realdatastart,
full_data); full_data);
#else
/*
* This is used on MMU systems mainly for testing.
* Let's use a kernel buffer to simplify things.
*/
long unz_text_len = text_len - sizeof(struct flat_hdr);
long unz_len = unz_text_len + full_data;
char *unz_data = vmalloc(unz_len);
if (!unz_data) {
result = -ENOMEM;
} else {
result = decompress_exec(bprm, sizeof(struct flat_hdr),
unz_data, unz_len, 0);
if (result == 0 &&
(copy_to_user((void __user *)textpos + sizeof(struct flat_hdr),
unz_data, unz_text_len) ||
copy_to_user((void __user *)datapos,
unz_data + unz_text_len, full_data)))
result = -EFAULT;
vfree(unz_data);
}
#endif
} else if (flags & FLAT_FLAG_GZDATA) { } else if (flags & FLAT_FLAG_GZDATA) {
result = read_code(bprm->file, textpos, 0, text_len); result = read_code(bprm->file, textpos, 0, text_len);
if (!IS_ERR_VALUE(result)) if (!IS_ERR_VALUE(result)) {
#ifndef CONFIG_MMU
result = decompress_exec(bprm, text_len, (char *) datapos, result = decompress_exec(bprm, text_len, (char *) datapos,
full_data, 0); full_data, 0);
} #else
else char *unz_data = vmalloc(full_data);
if (!unz_data) {
result = -ENOMEM;
} else {
result = decompress_exec(bprm, text_len,
unz_data, full_data, 0);
if (result == 0 &&
copy_to_user((void __user *)datapos,
unz_data, full_data))
result = -EFAULT;
vfree(unz_data);
}
#endif #endif
}
} else
#endif /* CONFIG_BINFMT_ZFLAT */
{ {
result = read_code(bprm->file, textpos, 0, text_len); result = read_code(bprm->file, textpos, 0, text_len);
if (!IS_ERR_VALUE(result)) if (!IS_ERR_VALUE(result))
@ -652,21 +690,19 @@ static int load_flat_file(struct linux_binprm * bprm,
full_data); full_data);
} }
if (IS_ERR_VALUE(result)) { if (IS_ERR_VALUE(result)) {
printk("Unable to read code+data+bss, errno %d\n",(int)-result); ret = result;
pr_err("Unable to read code+data+bss, errno %d\n", ret);
vm_munmap(textpos, text_len + data_len + extra + vm_munmap(textpos, text_len + data_len + extra +
MAX_SHARED_LIBS * sizeof(unsigned long)); MAX_SHARED_LIBS * sizeof(unsigned long));
ret = result;
goto err; goto err;
} }
} }
if (flags & FLAT_FLAG_KTRACE) start_code = textpos + sizeof(struct flat_hdr);
printk("Mapping is %x, Entry point is %x, data_start is %x\n", end_code = textpos + text_len;
(int)textpos, 0x00ffffff&ntohl(hdr->entry), ntohl(hdr->data_start)); text_len -= sizeof(struct flat_hdr); /* the real code len */
/* The main program needs a little extra setup in the task structure */ /* The main program needs a little extra setup in the task structure */
start_code = textpos + sizeof (struct flat_hdr);
end_code = textpos + text_len;
if (id == 0) { if (id == 0) {
current->mm->start_code = start_code; current->mm->start_code = start_code;
current->mm->end_code = end_code; current->mm->end_code = end_code;
@ -681,19 +717,19 @@ static int load_flat_file(struct linux_binprm * bprm,
*/ */
current->mm->start_brk = datapos + data_len + bss_len; current->mm->start_brk = datapos + data_len + bss_len;
current->mm->brk = (current->mm->start_brk + 3) & ~3; current->mm->brk = (current->mm->start_brk + 3) & ~3;
#ifndef CONFIG_MMU
current->mm->context.end_brk = memp + memp_size - stack_len; current->mm->context.end_brk = memp + memp_size - stack_len;
#endif
} }
if (flags & FLAT_FLAG_KTRACE) if (flags & FLAT_FLAG_KTRACE) {
printk("%s %s: TEXT=%x-%x DATA=%x-%x BSS=%x-%x\n", pr_info("Mapping is %lx, Entry point is %x, data_start is %x\n",
textpos, 0x00ffffff&ntohl(hdr->entry), ntohl(hdr->data_start));
pr_info("%s %s: TEXT=%lx-%lx DATA=%lx-%lx BSS=%lx-%lx\n",
id ? "Lib" : "Load", bprm->filename, id ? "Lib" : "Load", bprm->filename,
(int) start_code, (int) end_code, start_code, end_code, datapos, datapos + data_len,
(int) datapos, datapos + data_len, (datapos + data_len + bss_len + 3) & ~3);
(int) (datapos + data_len), }
(int) (datapos + data_len),
(int) (((datapos + data_len + bss_len) + 3) & ~3));
text_len -= sizeof(struct flat_hdr); /* the real code len */
/* Store the current module values into the global library structure */ /* Store the current module values into the global library structure */
libinfo->lib_list[id].start_code = start_code; libinfo->lib_list[id].start_code = start_code;
@ -703,7 +739,7 @@ static int load_flat_file(struct linux_binprm * bprm,
libinfo->lib_list[id].loaded = 1; libinfo->lib_list[id].loaded = 1;
libinfo->lib_list[id].entry = (0x00ffffff & ntohl(hdr->entry)) + textpos; libinfo->lib_list[id].entry = (0x00ffffff & ntohl(hdr->entry)) + textpos;
libinfo->lib_list[id].build_date = ntohl(hdr->build_date); libinfo->lib_list[id].build_date = ntohl(hdr->build_date);
/* /*
* We just load the allocations into some temporary memory to * We just load the allocations into some temporary memory to
* help simplify all this mumbo jumbo * help simplify all this mumbo jumbo
@ -717,15 +753,20 @@ static int load_flat_file(struct linux_binprm * bprm,
* image. * image.
*/ */
if (flags & FLAT_FLAG_GOTPIC) { if (flags & FLAT_FLAG_GOTPIC) {
for (rp = (unsigned long *)datapos; *rp != 0xffffffff; rp++) { for (rp = (unsigned long __user *)datapos; ; rp++) {
unsigned long addr; unsigned long addr, rp_val;
if (*rp) { if (get_user(rp_val, rp))
addr = calc_reloc(*rp, libinfo, id, 0); return -EFAULT;
if (rp_val == 0xffffffff)
break;
if (rp_val) {
addr = calc_reloc(rp_val, libinfo, id, 0);
if (addr == RELOC_FAILED) { if (addr == RELOC_FAILED) {
ret = -ENOEXEC; ret = -ENOEXEC;
goto err; goto err;
} }
*rp = addr; if (put_user(addr, rp))
return -EFAULT;
} }
} }
} }
@ -742,19 +783,23 @@ static int load_flat_file(struct linux_binprm * bprm,
* __start to address 4 so that is okay). * __start to address 4 so that is okay).
*/ */
if (rev > OLD_FLAT_VERSION) { if (rev > OLD_FLAT_VERSION) {
unsigned long persistent = 0; unsigned long __maybe_unused persistent = 0;
for (i=0; i < relocs; i++) { for (i = 0; i < relocs; i++) {
unsigned long addr, relval; unsigned long addr, relval;
/* Get the address of the pointer to be /*
relocated (of course, the address has to be * Get the address of the pointer to be
relocated first). */ * relocated (of course, the address has to be
relval = ntohl(reloc[i]); * relocated first).
if (flat_set_persistent (relval, &persistent)) */
if (get_user(relval, reloc + i))
return -EFAULT;
relval = ntohl(relval);
if (flat_set_persistent(relval, &persistent))
continue; continue;
addr = flat_get_relocate_addr(relval); addr = flat_get_relocate_addr(relval);
rp = (unsigned long *) calc_reloc(addr, libinfo, id, 1); rp = (unsigned long __user *)calc_reloc(addr, libinfo, id, 1);
if (rp == (unsigned long *)RELOC_FAILED) { if (rp == (unsigned long __user *)RELOC_FAILED) {
ret = -ENOEXEC; ret = -ENOEXEC;
goto err; goto err;
} }
@ -780,17 +825,23 @@ static int load_flat_file(struct linux_binprm * bprm,
} }
} }
} else { } else {
for (i=0; i < relocs; i++) for (i = 0; i < relocs; i++) {
old_reloc(ntohl(reloc[i])); unsigned long relval;
if (get_user(relval, reloc + i))
return -EFAULT;
relval = ntohl(relval);
old_reloc(relval);
}
} }
flush_icache_range(start_code, end_code); flush_icache_range(start_code, end_code);
/* zero the BSS, BRK and stack areas */ /* zero the BSS, BRK and stack areas */
memset((void*)(datapos + data_len), 0, bss_len + if (clear_user((void __user *)(datapos + data_len), bss_len +
(memp + memp_size - stack_len - /* end brk */ (memp + memp_size - stack_len - /* end brk */
libinfo->lib_list[id].start_brk) + /* start brk */ libinfo->lib_list[id].start_brk) + /* start brk */
stack_len); stack_len))
return -EFAULT;
return 0; return 0;
err: err:
@ -846,7 +897,7 @@ out:
allow_write_access(bprm.file); allow_write_access(bprm.file);
fput(bprm.file); fput(bprm.file);
return(res); return res;
} }
#endif /* CONFIG_BINFMT_SHARED_FLAT */ #endif /* CONFIG_BINFMT_SHARED_FLAT */
@ -857,18 +908,17 @@ out:
* libraries. There is no binary dependent code anywhere else. * libraries. There is no binary dependent code anywhere else.
*/ */
static int load_flat_binary(struct linux_binprm * bprm) static int load_flat_binary(struct linux_binprm *bprm)
{ {
struct lib_info libinfo; struct lib_info libinfo;
struct pt_regs *regs = current_pt_regs(); struct pt_regs *regs = current_pt_regs();
unsigned long p = bprm->p; unsigned long stack_len = 0;
unsigned long stack_len;
unsigned long start_addr; unsigned long start_addr;
unsigned long *sp;
int res; int res;
int i, j; int i, j;
memset(&libinfo, 0, sizeof(libinfo)); memset(&libinfo, 0, sizeof(libinfo));
/* /*
* We have to add the size of our arguments to our stack size * We have to add the size of our arguments to our stack size
* otherwise it's too easy for users to create stack overflows * otherwise it's too easy for users to create stack overflows
@ -876,38 +926,54 @@ static int load_flat_binary(struct linux_binprm * bprm)
* pedantic and include space for the argv/envp array as it may have * pedantic and include space for the argv/envp array as it may have
* a lot of entries. * a lot of entries.
*/ */
#define TOP_OF_ARGS (PAGE_SIZE * MAX_ARG_PAGES - sizeof(void *)) #ifndef CONFIG_MMU
stack_len = TOP_OF_ARGS - bprm->p; /* the strings */ stack_len += PAGE_SIZE * MAX_ARG_PAGES - bprm->p; /* the strings */
stack_len += (bprm->argc + 1) * sizeof(char *); /* the argv array */ #endif
stack_len += (bprm->envc + 1) * sizeof(char *); /* the envp array */ stack_len += (bprm->argc + 1) * sizeof(char *); /* the argv array */
stack_len += FLAT_STACK_ALIGN - 1; /* reserve for upcoming alignment */ stack_len += (bprm->envc + 1) * sizeof(char *); /* the envp array */
stack_len = ALIGN(stack_len, FLAT_STACK_ALIGN);
res = load_flat_file(bprm, &libinfo, 0, &stack_len); res = load_flat_file(bprm, &libinfo, 0, &stack_len);
if (res < 0) if (res < 0)
return res; return res;
/* Update data segment pointers for all libraries */ /* Update data segment pointers for all libraries */
for (i=0; i<MAX_SHARED_LIBS; i++) for (i = 0; i < MAX_SHARED_LIBS; i++) {
if (libinfo.lib_list[i].loaded) if (!libinfo.lib_list[i].loaded)
for (j=0; j<MAX_SHARED_LIBS; j++) continue;
(-(j+1))[(unsigned long *)(libinfo.lib_list[i].start_data)] = for (j = 0; j < MAX_SHARED_LIBS; j++) {
(libinfo.lib_list[j].loaded)? unsigned long val = libinfo.lib_list[j].loaded ?
libinfo.lib_list[j].start_data:UNLOADED_LIB; libinfo.lib_list[j].start_data : UNLOADED_LIB;
unsigned long __user *p = (unsigned long __user *)
libinfo.lib_list[i].start_data;
p -= j + 1;
if (put_user(val, p))
return -EFAULT;
}
}
install_exec_creds(bprm); install_exec_creds(bprm);
set_binfmt(&flat_format); set_binfmt(&flat_format);
p = ((current->mm->context.end_brk + stack_len + 3) & ~3) - 4; #ifdef CONFIG_MMU
DBG_FLT("p=%x\n", (int)p); res = setup_arg_pages(bprm, STACK_TOP, EXSTACK_DEFAULT);
if (!res)
res = create_flat_tables(bprm, bprm->p);
#else
/* Stash our initial stack pointer into the mm structure */
current->mm->start_stack =
((current->mm->context.end_brk + stack_len + 3) & ~3) - 4;
pr_debug("sp=%lx\n", current->mm->start_stack);
/* copy the arg pages onto the stack, this could be more efficient :-) */ /* copy the arg pages onto the stack */
for (i = TOP_OF_ARGS - 1; i >= bprm->p; i--) res = transfer_args_to_stack(bprm, &current->mm->start_stack);
* (char *) --p = if (!res)
((char *) page_address(bprm->page[i/PAGE_SIZE]))[i % PAGE_SIZE]; res = create_flat_tables(bprm, current->mm->start_stack);
#endif
if (res)
return res;
sp = (unsigned long *) create_flat_tables(p, bprm);
/* Fake some return addresses to ensure the call chain will /* Fake some return addresses to ensure the call chain will
* initialise library in order for us. We are required to call * initialise library in order for us. We are required to call
* lib 1 first, then 2, ... and finally the main program (id 0). * lib 1 first, then 2, ... and finally the main program (id 0).
@ -915,24 +981,24 @@ static int load_flat_binary(struct linux_binprm * bprm)
start_addr = libinfo.lib_list[0].entry; start_addr = libinfo.lib_list[0].entry;
#ifdef CONFIG_BINFMT_SHARED_FLAT #ifdef CONFIG_BINFMT_SHARED_FLAT
for (i = MAX_SHARED_LIBS-1; i>0; i--) { for (i = MAX_SHARED_LIBS-1; i > 0; i--) {
if (libinfo.lib_list[i].loaded) { if (libinfo.lib_list[i].loaded) {
/* Push previos first to call address */ /* Push previos first to call address */
--sp; put_user(start_addr, sp); unsigned long __user *sp;
current->mm->start_stack -= sizeof(unsigned long);
sp = (unsigned long __user *)current->mm->start_stack;
__put_user(start_addr, sp);
start_addr = libinfo.lib_list[i].entry; start_addr = libinfo.lib_list[i].entry;
} }
} }
#endif #endif
/* Stash our initial stack pointer into the mm structure */
current->mm->start_stack = (unsigned long )sp;
#ifdef FLAT_PLAT_INIT #ifdef FLAT_PLAT_INIT
FLAT_PLAT_INIT(regs); FLAT_PLAT_INIT(regs);
#endif #endif
DBG_FLT("start_thread(regs=0x%x, entry=0x%x, start_stack=0x%x)\n",
(int)regs, (int)start_addr, (int)current->mm->start_stack); pr_debug("start_thread(regs=0x%p, entry=0x%lx, start_stack=0x%lx)\n",
regs, start_addr, current->mm->start_stack);
start_thread(regs, start_addr, current->mm->start_stack); start_thread(regs, start_addr, current->mm->start_stack);
return 0; return 0;
@ -945,9 +1011,6 @@ static int __init init_flat_binfmt(void)
register_binfmt(&flat_format); register_binfmt(&flat_format);
return 0; return 0;
} }
/****************************************************************************/
core_initcall(init_flat_binfmt); core_initcall(init_flat_binfmt);
/****************************************************************************/ /****************************************************************************/

33
fs/exec.c
View file

@ -762,6 +762,39 @@ out_unlock:
} }
EXPORT_SYMBOL(setup_arg_pages); EXPORT_SYMBOL(setup_arg_pages);
#else
/*
* Transfer the program arguments and environment from the holding pages
* onto the stack. The provided stack pointer is adjusted accordingly.
*/
int transfer_args_to_stack(struct linux_binprm *bprm,
unsigned long *sp_location)
{
unsigned long index, stop, sp;
int ret = 0;
stop = bprm->p >> PAGE_SHIFT;
sp = *sp_location;
for (index = MAX_ARG_PAGES - 1; index >= stop; index--) {
unsigned int offset = index == stop ? bprm->p & ~PAGE_MASK : 0;
char *src = kmap(bprm->page[index]) + offset;
sp -= PAGE_SIZE - offset;
if (copy_to_user((void *) sp, src, PAGE_SIZE - offset) != 0)
ret = -EFAULT;
kunmap(bprm->page[index]);
if (ret)
goto out;
}
*sp_location = sp;
out:
return ret;
}
EXPORT_SYMBOL(transfer_args_to_stack);
#endif /* CONFIG_MMU */ #endif /* CONFIG_MMU */
static struct file *do_open_execat(int fd, struct filename *name, int flags) static struct file *do_open_execat(int fd, struct filename *name, int flags)

2
include/linux/binfmts.h
View file

@ -113,6 +113,8 @@ extern int suid_dumpable;
extern int setup_arg_pages(struct linux_binprm * bprm, extern int setup_arg_pages(struct linux_binprm * bprm,
unsigned long stack_top, unsigned long stack_top,
int executable_stack); int executable_stack);
extern int transfer_args_to_stack(struct linux_binprm *bprm,
unsigned long *sp_location);
extern int bprm_change_interp(char *interp, struct linux_binprm *bprm); extern int bprm_change_interp(char *interp, struct linux_binprm *bprm);
extern int copy_strings_kernel(int argc, const char *const *argv, extern int copy_strings_kernel(int argc, const char *const *argv,
struct linux_binprm *bprm); struct linux_binprm *bprm);