bianbu-repo-mirror/bianbu-linux-6.6
1
0
Fork 0
mirror of https://gitee.com/bianbu-linux/linux-6.6 synced 2025-04-24 14:07:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

timers: Get rid of del_singleshot_timer_sync()

Browse source 
del_singleshot_timer_sync() used to be an optimization for deleting timers
which are not rearmed from the timer callback function.

This optimization turned out to be broken and got mapped to
del_timer_sync() about 17 years ago.

Get rid of the undocumented indirection and use del_timer_sync() directly.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Link: https://lore.kernel.org/r/20221123201624.706987932@linutronix.de
This commit is contained in:
Thomas Gleixner 2022-11-23 21:18:37 +01:00
parent 6e1fc2591f
commit 9a5a305686
6 changed files with 9 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/char/tpm/tpm-dev-common.c
View file

@ -155,7 +155,7 @@ ssize_t tpm_common_read(struct file *file, char __user *buf,
out: out:
if (!priv->response_length) { if (!priv->response_length) {
*off = 0; *off = 0;
del_singleshot_timer_sync(&priv->user_read_timer); del_timer_sync(&priv->user_read_timer);
flush_work(&priv->timeout_work); flush_work(&priv->timeout_work);
} }
mutex_unlock(&priv->buffer_mutex); mutex_unlock(&priv->buffer_mutex);
@ -262,7 +262,7 @@ __poll_t tpm_common_poll(struct file *file, poll_table *wait)
void tpm_common_release(struct file *file, struct file_priv *priv) void tpm_common_release(struct file *file, struct file_priv *priv)
{ {
flush_work(&priv->async_work); flush_work(&priv->async_work);
del_singleshot_timer_sync(&priv->user_read_timer); del_timer_sync(&priv->user_read_timer);
flush_work(&priv->timeout_work); flush_work(&priv->timeout_work);
file->private_data = NULL; file->private_data = NULL;
priv->response_length = 0; priv->response_length = 0;

4
drivers/staging/wlan-ng/hfa384x_usb.c
View file

@ -1116,8 +1116,8 @@ cleanup:
if (ctlx == get_active_ctlx(hw)) { if (ctlx == get_active_ctlx(hw)) {
spin_unlock_irqrestore(&hw->ctlxq.lock, flags); spin_unlock_irqrestore(&hw->ctlxq.lock, flags);
del_singleshot_timer_sync(&hw->reqtimer); del_timer_sync(&hw->reqtimer);
del_singleshot_timer_sync(&hw->resptimer); del_timer_sync(&hw->resptimer);
hw->req_timer_done = 1; hw->req_timer_done = 1;
hw->resp_timer_done = 1; hw->resp_timer_done = 1;
usb_kill_urb(&hw->ctlx_urb); usb_kill_urb(&hw->ctlx_urb);

6
drivers/staging/wlan-ng/prism2usb.c
View file

@ -170,9 +170,9 @@ static void prism2sta_disconnect_usb(struct usb_interface *interface)
*/ */
prism2sta_ifstate(wlandev, P80211ENUM_ifstate_disable); prism2sta_ifstate(wlandev, P80211ENUM_ifstate_disable);
del_singleshot_timer_sync(&hw->throttle); del_timer_sync(&hw->throttle);
del_singleshot_timer_sync(&hw->reqtimer); del_timer_sync(&hw->reqtimer);
del_singleshot_timer_sync(&hw->resptimer); del_timer_sync(&hw->resptimer);
/* Unlink all the URBs. This "removes the wheels" /* Unlink all the URBs. This "removes the wheels"
* from the entire CTLX handling mechanism. * from the entire CTLX handling mechanism.

2
include/linux/timer.h
View file

@ -190,8 +190,6 @@ extern int try_to_del_timer_sync(struct timer_list *timer);
# define del_timer_sync(t) del_timer(t) # define del_timer_sync(t) del_timer(t)
#endif #endif
#define del_singleshot_timer_sync(t) del_timer_sync(t)
extern void init_timers(void); extern void init_timers(void);
struct hrtimer; struct hrtimer;
extern enum hrtimer_restart it_real_fn(struct hrtimer *); extern enum hrtimer_restart it_real_fn(struct hrtimer *);

2
kernel/time/timer.c
View file

@ -1933,7 +1933,7 @@ signed long __sched schedule_timeout(signed long timeout)
timer_setup_on_stack(&timer.timer, process_timeout, 0); timer_setup_on_stack(&timer.timer, process_timeout, 0);
__mod_timer(&timer.timer, expire, MOD_TIMER_NOTPENDING); __mod_timer(&timer.timer, expire, MOD_TIMER_NOTPENDING);
schedule(); schedule();
del_singleshot_timer_sync(&timer.timer); del_timer_sync(&timer.timer);
/* Remove the timer from the object tracker */ /* Remove the timer from the object tracker */
destroy_timer_on_stack(&timer.timer); destroy_timer_on_stack(&timer.timer);

2
net/sunrpc/xprt.c
View file

@ -1164,7 +1164,7 @@ xprt_request_enqueue_receive(struct rpc_task *task)
spin_unlock(&xprt->queue_lock); spin_unlock(&xprt->queue_lock);
/* Turn off autodisconnect */ /* Turn off autodisconnect */
del_singleshot_timer_sync(&xprt->timer); del_timer_sync(&xprt->timer);
return 0; return 0;
} }