bianbu-repo-mirror/bianbu-linux-6.6
1
0
Fork 0
mirror of https://gitee.com/bianbu-linux/linux-6.6 synced 2025-04-24 14:07:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

m68knommu: fix ucsimm sparse warnings

Browse source 
Sparse reports the following warnings:

  arch/m68k/68000/ucsimm.c:19:15: sparse: sparse: symbol 'cs8900a_hwaddr' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:22:1: sparse: sparse: symbol 'getserialnum' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:23:1: sparse: sparse: symbol 'gethwaddr' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:24:1: sparse: sparse: symbol 'getbenv' was not declared. Should it be static?

'cs8900a_hwaddr' is not used anywhere else in the kernel, so it can be
removed.

All of 'getserialnum', 'gethwaddr' and 'getbenv' are only used in this
file, so they can all be made static. It turns out that these also cause
compiler warnings like this too:

  arch/m68k/68000/ucsimm.c:22:15: warning: no previous prototype for 'getserialnum' [-Wmissing-prototypes]

Also fixed by making them all static.

Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
Reported-by: kernel test robot <lkp@intel.com>
This commit is contained in:
Greg Ungerer 2022-01-17 17:53:51 +10:00
parent 5fb4d4690b
commit ffe74a6dc9
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
arch/m68k/68000/ucsimm.c
View file

@ -16,19 +16,18 @@
#include "m68328.h" #include "m68328.h"
unsigned char *cs8900a_hwaddr;
static int errno; static int errno;
_bsc0(char *, getserialnum) static _bsc0(char *, getserialnum)
_bsc1(unsigned char *, gethwaddr, int, a) static _bsc1(unsigned char *, gethwaddr, int, a)
_bsc1(char *, getbenv, char *, a) static _bsc1(char *, getbenv, char *, a)
void __init init_ucsimm(char *command, int size) void __init init_ucsimm(char *command, int size)
{ {
char *p; char *p;
pr_info("uCsimm/uCdimm serial string [%s]\n", getserialnum()); pr_info("uCsimm/uCdimm serial string [%s]\n", getserialnum());
p = cs8900a_hwaddr = gethwaddr(0); p = gethwaddr(0);
pr_info("uCsimm/uCdimm hwaddr %pM\n", p); pr_info("uCsimm/uCdimm hwaddr %pM\n", p);
p = getbenv("APPEND"); p = getbenv("APPEND");
if (p) if (p)