bianbu-linux-6.6/net/mptcp
Matthieu Baerts (NGI0) 01db518468 mptcp: pm: remove mptcp_pm_remove_subflow()
commit f448451aa62d54be16acb0034223c17e0d12bc69 upstream.

This helper is confusing. It is in pm.c, but it is specific to the
in-kernel PM and it cannot be used by the userspace one. Also, it simply
calls one in-kernel specific function with the PM lock, while the
similar mptcp_pm_remove_addr() helper requires the PM lock.

What's left is the pr_debug(), which is not that useful, because a
similar one is present in the only function called by this helper:

  mptcp_pm_nl_rm_subflow_received()

After these modifications, this helper can be marked as 'static', and
the lock can be taken only once in mptcp_pm_flush_addrs_and_subflows().

Note that it is not a bug fix, but it will help backporting the
following commits.

Fixes: 0ee4261a36 ("mptcp: implement mptcp_pm_remove_subflow")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20240819-net-mptcp-pm-reusing-id-v1-7-38035d40de5b@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-08-29 17:33:55 +02:00
..
bpf.c bpf: Add update_socket_protocol hook 2023-08-16 10:22:16 -07:00
crypto.c kunit: mptcp: adhere to KUNIT formatting standard 2021-04-16 17:10:40 -07:00
crypto_test.c mptcp: move crypto test to KUNIT 2020-06-26 16:21:39 -07:00
ctrl.c mptcp: only allow set existing scheduler for net.mptcp.scheduler 2024-05-17 12:02:30 +02:00
diag.c mptcp: correct MPTCP_SUBFLOW_ATTR_SSN_OFFSET reserved size 2024-08-29 17:33:19 +02:00
fastopen.c mptcp: corner case locking for rx path fields initialization 2024-03-01 13:34:57 +01:00
Kconfig kunit: mptcp: adhere to KUNIT formatting standard 2021-04-16 17:10:40 -07:00
Makefile mptcp: add struct mptcp_sched_ops 2023-08-22 17:31:18 -07:00
mib.c mptcp: mib: count MPJ with backup flag 2024-08-11 12:47:27 +02:00
mib.h mptcp: mib: count MPJ with backup flag 2024-08-11 12:47:27 +02:00
mptcp_diag.c tcp: Access &tcp_hashinfo via net. 2022-09-20 10:21:49 -07:00
options.c mptcp: fully established after ADD_ADDR echo on MPJ 2024-08-14 13:59:01 +02:00
pm.c mptcp: pm: remove mptcp_pm_remove_subflow() 2024-08-29 17:33:55 +02:00
pm_netlink.c mptcp: pm: remove mptcp_pm_remove_subflow() 2024-08-29 17:33:55 +02:00
pm_userspace.c mptcp: pm: fix backup support in signal endpoints 2024-08-14 13:59:01 +02:00
protocol.c mptcp: fix bad RCVPRUNED mib accounting 2024-08-11 12:47:27 +02:00
protocol.h mptcp: pm: remove mptcp_pm_remove_subflow() 2024-08-29 17:33:55 +02:00
sched.c mptcp: register default scheduler 2023-08-22 17:31:19 -07:00
sockopt.c mptcp: prevent BPF accessing lowat from a subflow socket. 2024-08-11 12:47:28 +02:00
subflow.c mptcp: pm: fix backup support in signal endpoints 2024-08-14 13:59:01 +02:00
syncookies.c mptcp: don't return sockets in foreign netns 2021-09-24 10:51:36 +01:00
token.c mptcp: add statistics for mptcp socket in use 2023-01-09 07:30:50 +00:00
token_test.c mptcp: init sk->sk_prot in build_msk() 2023-01-09 07:30:50 +00:00