Chris Wilson 280ffdb6dd drm/i915/gt: Free stale request on destroying the virtual engine ... Since preempt-to-busy, we may unsubmit a request while it is still on the HW and completes asynchronously. That means it may be retired and in the process destroy the virtual engine (as the user has closed their context), but that engine may still be holding onto the unsubmitted compelted request. Therefore we need to potentially cleanup the old request on destroying the virtual engine. We also have to keep the virtual_engine alive until after the sibling's execlists_dequeue() have finished peeking into the virtual engines, for which we serialise with RCU. v2: Be paranoid and flush the tasklet as well. v3: And flush the tasklet before the engines, as the tasklet may re-attach an rb_node after our removal from the siblings. Fixes: 6d06779e86 ("drm/i915: Load balancing across a virtual engine") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201123113717.20500-4-chris@chris-wilson.co.uk (cherry picked from commit 46eecfccb4) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>		2020-11-24 09:30:57 -08:00
..
selftests	drm/i915: Serialise i915_active_fence_set() with itself	2019-11-27 17:02:14 +00:00
shaders	drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c	2020-06-29 11:29:12 +03:00
uc	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
debugfs_engines.c	drm/i915/gt: allow setting generic data pointer	2020-03-26 21:20:51 +00:00
debugfs_engines.h	drm/i915/gt: Move pm debug files into a gt aware debugfs	2019-12-22 15:25:10 +00:00
debugfs_gt.c	drm/i915: Move sseu debugfs under gt/	2020-07-08 21:40:15 +01:00
debugfs_gt.h	drm/i915/gt: allow setting generic data pointer	2020-03-26 21:20:51 +00:00
debugfs_gt_pm.c	drm/i915/gt: Move rps.enabled/active to flags	2020-04-30 00:57:35 +01:00
debugfs_gt_pm.h	drm/i915/gt: Move pm debug files into a gt aware debugfs	2019-12-22 15:25:10 +00:00
gen2_engine_cs.c	drm/i915/gt: Flush gen3 relocs harder, again	2020-06-13 10:30:01 +01:00
gen2_engine_cs.h	drm/i915/gt: Split low level gen2-7 CS emitters	2020-06-02 10:42:00 +01:00
gen6_engine_cs.c	drm/i915/gt: Split low level gen2-7 CS emitters	2020-06-02 10:42:00 +01:00
gen6_engine_cs.h	drm/i915/gt: Split low level gen2-7 CS emitters	2020-06-02 10:42:00 +01:00
gen6_ppgtt.c	drm/i915/gt: Onion unwind for scratch page allocation failure	2020-10-21 08:32:25 -04:00
gen6_ppgtt.h	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
gen6_renderstate.c
gen7_renderclear.c	drm/i915: Release shortlived maps of longlived objects	2020-07-08 22:05:50 +01:00
gen7_renderclear.h	drm/i915/gen7: Clear all EU/L3 residual contexts	2020-03-06 08:59:06 +00:00
gen7_renderstate.c
gen8_ppgtt.c	drm/i915/gt: Onion unwind for scratch page allocation failure	2020-10-21 08:32:25 -04:00
gen8_ppgtt.h	drm/i915/gtt: split up i915_gem_gtt	2020-01-07 19:27:36 +00:00
gen8_renderstate.c
gen9_renderstate.c
hsw_clear_kernel.c	drm/i915/gen7: Clear all EU/L3 residual contexts	2020-03-06 08:59:06 +00:00
intel_breadcrumbs.c	drm/i915/gt: Don't cancel the interrupt shadow too early	2020-11-24 09:30:56 -08:00
intel_breadcrumbs.h	drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs	2020-09-07 14:23:55 +03:00
intel_breadcrumbs_types.h	drm/i915/gt: Track signaled breadcrumbs outside of the breadcrumb spinlock	2020-11-24 09:30:56 -08:00
intel_context.c	drm/i915: Fix uninitialised variable in intel_context_create_request.	2020-09-30 14:24:32 -04:00
intel_context.h	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
intel_context_param.c	drm/i915: Allow userspace to specify ringsize on construction	2020-02-25 19:23:19 +00:00
intel_context_param.h	drm/i915: Allow userspace to specify ringsize on construction	2020-02-25 19:23:19 +00:00
intel_context_sseu.c	drm/i915/sseu: Move sseu_info under gt_info	2020-07-08 21:13:09 +01:00
intel_context_types.h	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
intel_engine.h	drm/i915/gt: Expose more parameters for emitting writes into the ring	2020-11-03 19:21:42 -05:00
intel_engine_cs.c	drm/i915: Correctly set SFC capability for video engines	2020-11-12 19:47:30 -05:00
intel_engine_heartbeat.c	drm/i915/gt: Always send a pulse down the engine after disabling heartbeat	2020-09-30 14:24:48 -04:00
intel_engine_heartbeat.h
intel_engine_pm.c	drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs	2020-09-07 14:23:55 +03:00
intel_engine_pm.h	drm/i915: Extend intel_wakeref to support delayed puts	2020-03-23 12:51:05 +00:00
intel_engine_types.h	drm/i915/gt: Widen CSB pointer to u64 for the parsers	2020-10-19 14:31:59 -04:00
intel_engine_user.c	drm/i915: Reboot CI if we get wedged during driver init	2020-07-06 19:21:07 +01:00
intel_engine_user.h
intel_ggtt.c	Merge tag 'drm-intel-gt-next-2020-09-07' of git://anongit.freedesktop.org/drm/drm-intel into drm-next	2020-09-09 07:55:22 +10:00
intel_ggtt_fencing.c	drm/i915/gt: Make fence revocation unequivocal	2020-04-01 23:34:17 +01:00
intel_ggtt_fencing.h	drm/i915/gt: Store the fence details on the fence	2020-04-01 23:34:16 +01:00
intel_gpu_commands.h	drm/i915/gen12: Fix HDC pipeline flush	2020-05-07 07:44:41 +01:00
intel_gt.c	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
intel_gt.h	drm/i915: Introduce gt_init_mmio	2020-07-08 21:07:13 +01:00
intel_gt_buffer_pool.c	drm/i915/gt: Clear the buffer pool age before use	2020-09-30 14:24:23 -04:00
intel_gt_buffer_pool.h	drm/i915/gt: Move the batch buffer pool from the engine to the gt	2020-04-30 19:12:02 +01:00
intel_gt_buffer_pool_types.h	drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool	2020-09-07 13:14:07 +03:00
intel_gt_clock_utils.c	drm/i915/gt: Fix up clock frequency	2020-04-27 17:34:33 +01:00
intel_gt_clock_utils.h	drm/i915/gt: Use the RPM config register to determine clk frequencies	2020-04-24 19:10:17 +01:00
intel_gt_irq.c	drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs	2020-09-07 14:23:55 +03:00
intel_gt_irq.h	drm/i915/gt: Reorganise gen8+ interrupt handler	2020-01-28 12:30:00 +00:00
intel_gt_pm.c	drm/i915: Reboot CI if we get wedged during driver init	2020-07-06 19:21:07 +01:00
intel_gt_pm.h	drm/i915/gt: Apply sanitiization just before resume	2019-12-26 12:37:30 +00:00
intel_gt_pm_irq.c
intel_gt_pm_irq.h
intel_gt_requests.c	drm/i915/gem: Unpin idle contexts from kswapd reclaim	2020-07-08 22:05:49 +01:00
intel_gt_requests.h	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 16:39:07 +02:00
intel_gt_types.h	drm/i915/sseu: Move sseu_info under gt_info	2020-07-08 21:13:09 +01:00
intel_gtt.c	drm/i915/gt: Switch to object allocations for page directories	2020-09-07 14:24:08 +03:00
intel_gtt.h	drm/i915/gt: Shrink i915_page_directory's slab bucket	2020-09-07 14:24:23 +03:00
intel_llc.c	drm/i915/gt: Do not attempt to reprogram IA/ring frequencies for dgfx	2020-02-19 22:27:10 +00:00
intel_llc.h
intel_llc_types.h
intel_lrc.c	drm/i915/gt: Free stale request on destroying the virtual engine	2020-11-24 09:30:57 -08:00
intel_lrc.h	drm/i915: Make define for lrc state offset	2020-04-24 00:52:14 +01:00
intel_lrc_reg.h	drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed	2020-04-24 00:36:13 +01:00
intel_mocs.c	drm/i915/gt: Fixup tgl mocs for PTE tracking	2020-11-19 15:10:49 -05:00
intel_mocs.h
intel_ppgtt.c	drm/i915/gt: Shrink i915_page_directory's slab bucket	2020-09-07 14:24:23 +03:00
intel_rc6.c	drm/i915/tgl: Fix Media power gate sequence.	2020-11-16 18:06:21 -05:00
intel_rc6.h	drm/i915/gt: Simplify rc6 w/a application	2019-12-02 21:57:22 +00:00
intel_rc6_types.h	drm/i915/gt: Only ignore rc6 parking for PCU on byt/bsw	2019-12-12 08:35:48 +00:00
intel_renderstate.c	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
intel_renderstate.h	drm/i915: Use ww locking in intel_renderstate.	2020-09-07 14:30:31 +03:00
intel_reset.c	drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs	2020-09-07 14:23:55 +03:00
intel_reset.h	drm/i915: Reboot CI if we get wedged during driver init	2020-07-06 19:21:07 +01:00
intel_reset_types.h	drm/i915: Reboot CI if we get wedged during driver init	2020-07-06 19:21:07 +01:00
intel_ring.c	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
intel_ring.h	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
intel_ring_submission.c	Merge tag 'drm-intel-gt-next-2020-09-07' of git://anongit.freedesktop.org/drm/drm-intel into drm-next	2020-09-09 07:55:22 +10:00
intel_ring_types.h	drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex	2020-02-11 12:03:22 +00:00
intel_rps.c	drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs	2020-09-07 14:23:55 +03:00
intel_rps.h	drm/i915/gt: Sanitize RPS interrupts upon resume	2020-05-03 08:24:36 +01:00
intel_rps_types.h	drm/i915/gt: Switch to manual evaluation of RPS	2020-04-30 00:57:37 +01:00
intel_sseu.c	drm/i915/sseu: Move sseu_info under gt_info	2020-07-08 21:13:09 +01:00
intel_sseu.h	drm/i915/sseu: Move sseu_info under gt_info	2020-07-08 21:13:09 +01:00
intel_sseu_debugfs.c	drm/i915: Move sseu debugfs under gt/	2020-07-08 21:40:15 +01:00
intel_sseu_debugfs.h	drm/i915: Move sseu debugfs under gt/	2020-07-08 21:40:15 +01:00
intel_timeline.c	drm/i915/gt: Use the local HWSP offset during submission	2020-11-03 19:14:08 -05:00
intel_timeline.h	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
intel_timeline_types.h	drm/i915/gt: Use the local HWSP offset during submission	2020-11-03 19:14:08 -05:00
intel_workarounds.c	drm/i915: Avoid memory leak with more than 16 workarounds on a list	2020-11-16 18:06:23 -05:00
intel_workarounds.h
intel_workarounds_types.h	drm/i915/gt: Skip rmw for masked registers	2020-02-01 09:21:57 +00:00
ivb_clear_kernel.c	drm/i915/gen7: Clear all EU/L3 residual contexts	2020-03-06 08:59:06 +00:00
mock_engine.c	drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin.	2020-09-07 14:31:13 +03:00
mock_engine.h
selftest_context.c	drm/i915/selftests: Flush the active barriers before asserting	2020-09-07 13:14:15 +03:00
selftest_engine.c
selftest_engine.h
selftest_engine_cs.c	drm/i915: Drop i915_request.i915 backpointer	2020-06-03 13:53:39 +01:00
selftest_engine_heartbeat.c	drm/i915: Add a couple of missing i915_active_fini()	2020-08-17 16:16:34 -04:00
selftest_engine_heartbeat.h	drm/i915/selftests: Enable selftesting of busy-stats	2020-06-18 09:26:53 +01:00
selftest_engine_pm.c	drm/i915/gt: Always report the sample time for busy-stats	2020-06-18 09:26:54 +01:00
selftest_gt_pm.c	drm/i915/selftests: Measure CS_TIMESTAMP	2020-05-21 09:30:16 +01:00
selftest_hangcheck.c	drm/i915/selftests: Enable selftesting of busy-stats	2020-06-18 09:26:53 +01:00
selftest_llc.c	drm/i915/gt: Do not attempt to reprogram IA/ring frequencies for dgfx	2020-02-19 22:27:10 +00:00
selftest_llc.h
selftest_lrc.c	drm/i915/selftests: Fix locking inversion in lrc selftest.	2020-09-07 14:31:50 +03:00
selftest_mocs.c	drm/i915/gt: Incrementally check for rewinding	2020-06-16 11:34:23 +03:00
selftest_rc6.c	drm/i915: Print caller when tainting for CI	2020-07-06 19:21:07 +01:00
selftest_rc6.h	drm/i915/gt: Manual rc6 entry upon parking	2019-11-27 12:53:27 +00:00
selftest_reset.c	drm/i915: Exclude low pages (128KiB) of stolen from use	2020-10-21 08:32:28 -04:00
selftest_ring.c	drm/i915/gt: Incrementally check for rewinding	2020-06-16 11:34:23 +03:00
selftest_ring_submission.c	drm/i915/selftests: Always flush before unpining after writing	2020-05-11 16:50:04 +01:00
selftest_rps.c	drm/i915: Move i915_vma_lock in the selftests to avoid lock inversion, v3.	2020-09-07 14:32:06 +03:00
selftest_rps.h	drm/i915/gt: Fix up clock frequency	2020-04-27 17:34:33 +01:00
selftest_timeline.c	drm/i915/selftest: Create mock_destroy_device	2020-09-21 10:36:24 +02:00
selftest_workarounds.c	drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.	2020-09-07 14:29:44 +03:00
shmem_utils.c	drm/i915: use vmap in shmem_pin_map	2020-10-18 09:27:10 -07:00
shmem_utils.h	drm/i915/gt: Keep a no-frills swappable copy of the default context state	2020-04-29 19:02:37 +01:00
st_shmem_utils.c	drm/i915/gt: Keep a no-frills swappable copy of the default context state	2020-04-29 19:02:37 +01:00
sysfs_engines.c	drm/i915: Show per-engine default property values in sysfs	2020-05-14 08:25:05 +01:00
sysfs_engines.h	drm/i915/gt: Expose engine properties via sysfs	2020-02-28 22:03:19 +00:00