mirror of
https://gitee.com/bianbu-linux/linux-6.6
synced 2025-04-24 14:07:52 -04:00
94dfc73e7c
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
This code was transformed with the help of Coccinelle:
(linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
@@
identifier S, member, array;
type T1, T2;
@@
struct S {
...
T1 member;
T2 array[
- 0
];
};
-fstrict-flex-arrays=3 is coming and we need to land these changes
to prevent issues like these in the short future:
../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
but the source string has length 2 (including NUL byte) [-Wfortify-source]
strcpy(de3->name, ".");
^
Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
this breaks anything, we can use a union with a new member name.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Build-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/
Acked-by: Dan Williams <dan.j.williams@intel.com> # For ndctl.h
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
79 lines
2.3 KiB
C
79 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
|
|
#ifndef LINUX_MMC_IOCTL_H
|
|
#define LINUX_MMC_IOCTL_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/major.h>
|
|
|
|
struct mmc_ioc_cmd {
|
|
/*
|
|
* Direction of data: nonzero = write, zero = read.
|
|
* Bit 31 selects 'Reliable Write' for RPMB.
|
|
*/
|
|
int write_flag;
|
|
|
|
/* Application-specific command. true = precede with CMD55 */
|
|
int is_acmd;
|
|
|
|
__u32 opcode;
|
|
__u32 arg;
|
|
__u32 response[4]; /* CMD response */
|
|
unsigned int flags;
|
|
unsigned int blksz;
|
|
unsigned int blocks;
|
|
|
|
/*
|
|
* Sleep at least postsleep_min_us useconds, and at most
|
|
* postsleep_max_us useconds *after* issuing command. Needed for
|
|
* some read commands for which cards have no other way of indicating
|
|
* they're ready for the next command (i.e. there is no equivalent of
|
|
* a "busy" indicator for read operations).
|
|
*/
|
|
unsigned int postsleep_min_us;
|
|
unsigned int postsleep_max_us;
|
|
|
|
/*
|
|
* Override driver-computed timeouts. Note the difference in units!
|
|
*/
|
|
unsigned int data_timeout_ns;
|
|
unsigned int cmd_timeout_ms;
|
|
|
|
/*
|
|
* For 64-bit machines, the next member, ``__u64 data_ptr``, wants to
|
|
* be 8-byte aligned. Make sure this struct is the same size when
|
|
* built for 32-bit.
|
|
*/
|
|
__u32 __pad;
|
|
|
|
/* DAT buffer */
|
|
__u64 data_ptr;
|
|
};
|
|
#define mmc_ioc_cmd_set_data(ic, ptr) ic.data_ptr = (__u64)(unsigned long) ptr
|
|
|
|
/**
|
|
* struct mmc_ioc_multi_cmd - multi command information
|
|
* @num_of_cmds: Number of commands to send. Must be equal to or less than
|
|
* MMC_IOC_MAX_CMDS.
|
|
* @cmds: Array of commands with length equal to 'num_of_cmds'
|
|
*/
|
|
struct mmc_ioc_multi_cmd {
|
|
__u64 num_of_cmds;
|
|
struct mmc_ioc_cmd cmds[];
|
|
};
|
|
|
|
#define MMC_IOC_CMD _IOWR(MMC_BLOCK_MAJOR, 0, struct mmc_ioc_cmd)
|
|
/*
|
|
* MMC_IOC_MULTI_CMD: Used to send an array of MMC commands described by
|
|
* the structure mmc_ioc_multi_cmd. The MMC driver will issue all
|
|
* commands in array in sequence to card.
|
|
*/
|
|
#define MMC_IOC_MULTI_CMD _IOWR(MMC_BLOCK_MAJOR, 1, struct mmc_ioc_multi_cmd)
|
|
/*
|
|
* Since this ioctl is only meant to enhance (and not replace) normal access
|
|
* to the mmc bus device, an upper data transfer limit of MMC_IOC_MAX_BYTES
|
|
* is enforced per ioctl call. For larger data transfers, use the normal
|
|
* block device operations.
|
|
*/
|
|
#define MMC_IOC_MAX_BYTES (512L * 1024)
|
|
#define MMC_IOC_MAX_CMDS 255
|
|
#endif /* LINUX_MMC_IOCTL_H */
|