bianbu-linux-6.6/drivers/net/wireless/ath
Douglas Anderson a48cb9c6ad wifi: ath10k: Don't touch the CE interrupt registers after power up
[ Upstream commit 170c75d43a77dc937c58f07ecf847ba1b42ab74e ]

As talked about in commit d66d24ac30 ("ath10k: Keep track of which
interrupts fired, don't poll them"), if we access the copy engine
register at a bad time then ath10k can go boom. However, it's not
necessarily easy to know when it's safe to access them.

The ChromeOS test labs saw a crash that looked like this at
shutdown/reboot time (on a chromeos-5.15 kernel, but likely the
problem could also reproduce upstream):

Internal error: synchronous external abort: 96000010 [#1] PREEMPT SMP
...
CPU: 4 PID: 6168 Comm: reboot Not tainted 5.15.111-lockdep-19350-g1d624fe6758f #1 010b9b233ab055c27c6dc88efb0be2f4e9e86f51
Hardware name: Google Kingoftown (DT)
...
pc : ath10k_snoc_read32+0x50/0x74 [ath10k_snoc]
lr : ath10k_snoc_read32+0x24/0x74 [ath10k_snoc]
...
Call trace:
ath10k_snoc_read32+0x50/0x74 [ath10k_snoc ...]
ath10k_ce_disable_interrupt+0x190/0x65c [ath10k_core ...]
ath10k_ce_disable_interrupts+0x8c/0x120 [ath10k_core ...]
ath10k_snoc_hif_stop+0x78/0x660 [ath10k_snoc ...]
ath10k_core_stop+0x13c/0x1ec [ath10k_core ...]
ath10k_halt+0x398/0x5b0 [ath10k_core ...]
ath10k_stop+0xfc/0x1a8 [ath10k_core ...]
drv_stop+0x148/0x6b4 [mac80211 ...]
ieee80211_stop_device+0x70/0x80 [mac80211 ...]
ieee80211_do_stop+0x10d8/0x15b0 [mac80211 ...]
ieee80211_stop+0x144/0x1a0 [mac80211 ...]
__dev_close_many+0x1e8/0x2c0
dev_close_many+0x198/0x33c
dev_close+0x140/0x210
cfg80211_shutdown_all_interfaces+0xc8/0x1e0 [cfg80211 ...]
ieee80211_remove_interfaces+0x118/0x5c4 [mac80211 ...]
ieee80211_unregister_hw+0x64/0x1f4 [mac80211 ...]
ath10k_mac_unregister+0x4c/0xf0 [ath10k_core ...]
ath10k_core_unregister+0x80/0xb0 [ath10k_core ...]
ath10k_snoc_free_resources+0xb8/0x1ec [ath10k_snoc ...]
ath10k_snoc_shutdown+0x98/0xd0 [ath10k_snoc ...]
platform_shutdown+0x7c/0xa0
device_shutdown+0x3e0/0x58c
kernel_restart_prepare+0x68/0xa0
kernel_restart+0x28/0x7c

Though there's no known way to reproduce the problem, it makes sense
that it would be the same issue where we're trying to access copy
engine registers when it's not allowed.

Let's fix this by changing how we "disable" the interrupts. Instead of
tweaking the copy engine registers we'll just use disable_irq() and
enable_irq(). Then we'll configure the interrupts once at power up
time.

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2.c10-00754-QCAHLSWMTPL-1

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230630151842.1.If764ede23c4e09a43a842771c2ddf99608f25f8e@changeid
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-11-28 17:19:38 +00:00
..
ar5523 Merge ath-next from git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git 2022-10-29 08:25:50 +03:00
ath5k wifi: ath5k: ath5k_hw_get_median_noise_floor(): use swap() 2023-08-23 17:16:14 +03:00
ath6kl wireless-next patches for v6.6 2023-08-04 18:34:25 -07:00
ath9k wifi: ath9k: fix clang-specific fortify warnings 2023-11-28 17:19:37 +00:00
ath10k wifi: ath10k: Don't touch the CE interrupt registers after power up 2023-11-28 17:19:38 +00:00
ath11k wifi: ath11k: fix Tx power value during active CAC 2023-11-20 11:59:00 +01:00
ath12k wifi: ath12k: mhi: fix potential memory leak in ath12k_mhi_register() 2023-11-28 17:19:38 +00:00
carl9170 wifi: carl9170: Replace fake flex-array with flexible-array member 2023-03-24 16:54:01 +02:00
wcn36xx wifi: drivers: Explicitly include correct DT includes 2023-08-01 17:48:38 +03:00
wil6210 wifi: wil6210: fix fortify warnings 2023-07-27 19:12:49 +03:00
ath.h wifi: ath: Silence memcpy run-time false positive warning 2023-02-17 18:24:16 +02:00
debug.c
dfs_pattern_detector.c wifi: ath: dfs_pattern_detector: Fix a memory initialization issue 2023-11-20 11:58:59 +01:00
dfs_pattern_detector.h
dfs_pri_detector.c
dfs_pri_detector.h
hw.c wifi: ath: fix repeated words in comments 2022-07-18 13:04:50 +03:00
Kconfig wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices 2022-11-29 12:49:06 +02:00
key.c wifi: ath: Use is_multicast_ether_addr() to check multicast Ether address 2023-08-25 10:39:28 +03:00
main.c
Makefile wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices 2022-11-29 12:49:06 +02:00
reg.h
regd.c Revert "ath: add support for special 0x0 regulatory domain" 2022-03-07 19:45:08 +02:00
regd.h ath: regdom: extend South Korea regulatory domain support 2021-12-08 10:37:38 +02:00
regd_common.h ath: regdom: extend South Korea regulatory domain support 2021-12-08 10:37:38 +02:00
spectral_common.h ath: Replace zero-length arrays with flexible-array members 2022-02-21 12:26:28 +02:00
trace.c
trace.h tracing/ath: Use the new __vstring() helper 2022-07-15 17:44:40 -04:00