SeongJae Park 6bfed8babc mm/damon/core: handle zero {aggregation,ops_update} intervals ... [ Upstream commit 3488af0970445ff5532c7e8dc5e6456b877aee5e ] Patch series "mm/damon/core: fix handling of zero non-sampling intervals". DAMON's internal intervals accounting logic is not correctly handling non-sampling intervals of zero values for a wrong assumption. This could cause unexpected monitoring behavior, and even result in infinite hang of DAMON sysfs interface user threads in case of zero aggregation interval. Fix those by updating the intervals accounting logic. For details of the root case and solutions, please refer to commit messages of fixes. This patch (of 2): DAMON's logics to determine if this is the time to do aggregation and ops update assumes next_{aggregation,ops_update}_sis are always set larger than current passed_sample_intervals. And therefore it further assumes continuously incrementing passed_sample_intervals every sampling interval will make it reaches to the next_{aggregation,ops_update}_sis in future. The logic therefore make the action and update next_{aggregation,ops_updaste}_sis only if passed_sample_intervals is same to the counts, respectively. If Aggregation interval or Ops update interval are zero, however, next_aggregation_sis or next_ops_update_sis are set same to current passed_sample_intervals, respectively. And passed_sample_intervals is incremented before doing the next_{aggregation,ops_update}_sis check. Hence, passed_sample_intervals becomes larger than next_{aggregation,ops_update}_sis, and the logic says it is not the time to do the action and update next_{aggregation,ops_update}_sis forever, until an overflow happens. In other words, DAMON stops doing aggregations or ops updates effectively forever, and users cannot get monitoring results. Based on the documents and the common sense, a reasonable behavior for such inputs is doing an aggregation and an ops update for every sampling interval. Handle the case by removing the assumption. Note that this could incur particular real issue for DAMON sysfs interface users, in case of zero Aggregation interval. When user starts DAMON with zero Aggregation interval and asks online DAMON parameter tuning via DAMON sysfs interface, the request is handled by the aggregation callback. Until the callback finishes the work, the user who requested the online tuning just waits. Hence, the user will be stuck until the passed_sample_intervals overflows. Link: https://lkml.kernel.org/r/20241031183757.49610-1-sj@kernel.org Link: https://lkml.kernel.org/r/20241031183757.49610-2-sj@kernel.org Fixes: 4472edf63d66 ("mm/damon/core: use number of passed access sampling as a timer") Signed-off-by: SeongJae Park <sj@kernel.org> Cc: <stable@vger.kernel.org> [6.7.x] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-11-22 15:38:35 +01:00
..
damon	mm/damon/core: handle zero {aggregation,ops_update} intervals	2024-11-22 15:38:35 +01:00
kasan	kasan: remove vmalloc_percpu test	2024-11-08 16:28:26 +01:00
kfence	LoongArch changes for v6.6	2023-09-08 12:16:52 -07:00
kmsan	kmsan: do not wipe out origin when doing partial unpoisoning	2024-06-16 13:47:41 +02:00
backing-dev.c	blk-wbt: Fix detection of dirty-throttled tasks	2024-02-23 09:25:16 +01:00
balloon_compaction.c	mm: Convert all PageMovable users to movable_operations	2022-08-02 12:34:03 -04:00
bootmem_info.c	bootmem: remove the vmemmap pages from kmemleak in put_page_bootmem	2022-08-28 14:02:45 -07:00
cma.c	mm/cma: drop incorrect alignment check in cma_init_reserved_mem	2024-06-16 13:47:42 +02:00
cma.h	mm/cma: provide option to opt out from exposing pages on activation failure	2022-03-22 15:57:09 -07:00
cma_debug.c	mm/cma_debug: show complete cma name in debugfs directories	2022-09-11 20:25:50 -07:00
cma_sysfs.c	mm: cma: make kobj_type structure constant	2023-03-28 16:20:06 -07:00
compaction.c	mm, treewide: introduce NR_PAGE_ORDERS	2024-05-02 16:32:41 +02:00
debug.c	mm: update validate_mm() to use vma iterator	2023-06-09 16:25:31 -07:00
debug_page_alloc.c	mm: page_alloc: split out DEBUG_PAGEALLOC	2023-06-09 16:25:23 -07:00
debug_page_ref.c
debug_vm_pgtable.c	mm/debug_vm_pgtable: drop RANDOM_ORVALUE trick	2024-08-19 06:04:31 +02:00
dmapool.c	dmapool: create/destroy cleanup	2023-06-09 16:25:17 -07:00
dmapool_test.c	dmapool: add alloc/free performance test	2023-04-05 19:42:38 -07:00
early_ioremap.c	mm/early_ioremap.c: improve the execution efficiency of early_ioremap_setup()	2023-06-09 16:25:56 -07:00
fadvise.c	mm: remove unnecessary pagevec includes	2023-06-23 16:59:31 -07:00
fail_page_alloc.c	mm: page_alloc: split out FAIL_PAGE_ALLOC	2023-06-09 16:25:23 -07:00
failslab.c	mm: fix unexpected changes to {failslab|fail_page_alloc}.attr	2022-11-22 18:50:44 -08:00
filemap.c	mm: support order-1 folios in the page cache	2024-11-17 15:08:59 +01:00
folio-compat.c	filemap: Add fgf_t typedef	2023-07-24 18:04:30 -04:00
gup.c	mm: gup: stop abusing try_grab_folio	2024-08-19 06:04:24 +02:00
gup_test.c	Merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes.	2023-06-23 16:58:19 -07:00
gup_test.h	mm/gup_test: start/stop/read functionality for PIN LONGTERM test	2022-11-08 17:37:15 -08:00
highmem.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
hmm.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
huge_memory.c	mm/thp: fix deferred split unqueue naming and locking	2024-11-17 15:08:59 +01:00
hugetlb.c	mm: always initialise folio->_deferred_list	2024-11-17 15:08:59 +01:00
hugetlb_cgroup.c	mm/hugetlb: increase use of folios in alloc_huge_page()	2023-02-13 15:54:27 -08:00
hugetlb_vmemmap.c	mm: hugetlb_vmemmap: fix a race between vmemmap pmd split	2023-08-18 10:12:14 -07:00
hugetlb_vmemmap.h	mm: hugetlb_vmemmap: improve hugetlb_vmemmap code readability	2022-08-08 18:06:43 -07:00
hwpoison-inject.c	mm/hwpoison: add __init/__exit annotations to module init/exit funcs	2022-10-03 14:03:05 -07:00
init-mm.c	mm: move dummy_vm_ops out of a header	2023-08-21 13:37:46 -07:00
internal.h	mm/thp: fix deferred split unqueue naming and locking	2024-11-17 15:08:59 +01:00
interval_tree.c
io-mapping.c
ioremap.c	mm: ioremap: remove unneeded ioremap_allowed and iounmap_allowed	2023-08-18 10:12:36 -07:00
Kconfig	mm: z3fold: deprecate CONFIG_Z3FOLD	2024-10-10 11:58:02 +02:00
Kconfig.debug	mm: page_table_check: Make it dependent on EXCLUSIVE_SYSTEM_RAM	2023-05-29 16:14:28 +01:00
khugepaged.c	mm: khugepaged: fix the arguments order in khugepaged_collapse_file trace point	2024-11-01 01:58:26 +01:00
kmemleak.c	mm/kmemleak: move up cond_resched() call in page scanning loop	2023-09-02 15:17:34 -07:00
ksm.c	mm/ksm: fix ksm_zero_pages accounting	2024-06-16 13:47:41 +02:00
list_lru.c	mm: kmem: make mem_cgroup_from_obj() vmalloc()-safe	2022-06-16 19:48:31 -07:00
maccess.c	mm: Fix copy_from_user_nofault().	2023-04-12 17:36:23 -07:00
madvise.c	mm/madvise: make MADV_POPULATE_(READ|WRITE) handle VM_FAULT_RETRY properly	2024-05-02 16:32:40 +02:00
Makefile	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
mapping_dirty_helpers.c	mm: fix clean_record_shared_mapping_range kernel-doc	2023-08-24 16:20:30 -07:00
memblock.c	x86/numa: Fix the address overlap check in numa_fill_memblks()	2024-03-01 13:35:06 +01:00
memcontrol.c	mm/thp: fix deferred split unqueue naming and locking	2024-11-17 15:08:59 +01:00
memfd.c	revert "memfd: improve userspace warnings for missing exec-related flags".	2023-09-05 11:11:52 -07:00
memory-failure.c	mm/memory-failure: use raw_spinlock_t in struct memory_failure_cpu	2024-08-29 17:33:15 +02:00
memory-tiers.c	memory tier: use helper macro __ATTR_RW()	2023-08-18 10:12:38 -07:00
memory.c	mm: don't install PMD mappings when THPs are disabled by the hw/process/vma	2024-11-08 16:28:27 +01:00
memory_hotplug.c	x86/kaslr: Expose and use the end of the physical memory address space	2024-09-12 11:11:25 +02:00
mempolicy.c	mm: add page_rmappable_folio() wrapper	2024-11-17 15:08:58 +01:00
mempool.c	mempool: do not use ksize() for poisoning	2022-11-30 15:58:41 -08:00
memremap.c	mm/memremap.c: fix outdated comment in devm_memremap_pages	2023-02-09 16:51:46 -08:00
memtest.c	memtest: use {READ,WRITE}_ONCE in memory scanning	2024-04-03 15:28:33 +02:00
migrate.c	vmscan,migrate: fix page count imbalance on node stats when demoting pages	2024-11-08 16:28:26 +01:00
migrate_device.c	Add x86 shadow stack support	2023-08-31 12:20:12 -07:00
mincore.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
mlock.c	merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes	2023-08-21 14:26:20 -07:00
mm_init.c	efi: disable mirror feature during crashkernel	2024-01-31 16:18:56 -08:00
mm_slot.h	mm: introduce common struct mm_slot	2022-10-03 14:02:43 -07:00
mmap.c	mm: call the security_mmap_file() LSM hook in remap_file_pages()	2024-10-04 16:29:43 +02:00
mmap_lock.c	mm: mmap_lock: replace get_memcg_path_buf() with on-stack buffer	2024-08-03 08:54:12 +02:00
mmu_gather.c	mm: fix kernel-doc warning from tlb_flush_rmaps()	2023-08-24 16:20:30 -07:00
mmu_notifier.c	mmu_notifiers: rename invalidate_range notifier	2023-08-18 10:12:41 -07:00
mmzone.c	mm: multi-gen LRU: groundwork	2022-09-26 19:46:09 -07:00
mprotect.c	Add x86 shadow stack support	2023-08-31 12:20:12 -07:00
mremap.c	mm/mremap: fix move_normal_pmd/retract_page_tables race	2024-10-22 15:46:21 +02:00
msync.c	mm/msync: use vma_find() instead of vma linked list	2022-09-26 19:46:25 -07:00
nommu.c	nommu: pass NULL argument to vma_iter_prealloc()	2024-11-22 15:38:34 +01:00
oom_kill.c	mm: remove redundant K() macro definition	2023-08-21 13:37:44 -07:00
page-writeback.c	Revert "mm/writeback: fix possible divide-by-zero in wb_dirty_limits(), again"	2024-07-11 12:49:16 +02:00
page_alloc.c	mm: fix NULL pointer dereference in alloc_pages_bulk_noprof	2024-11-22 15:38:33 +01:00
page_counter.c	mm: page_counter: remove unneeded atomic ops for low/min	2022-09-11 20:26:01 -07:00
page_ext.c	mm/page_ext: move functions around for minor cleanups to page_ext	2023-08-18 10:12:31 -07:00
page_idle.c	mm: page_idle: convert page idle to use a folio	2023-01-18 17:12:52 -08:00
page_io.c	zswap: make zswap_load() take a folio	2023-08-21 13:37:27 -07:00
page_isolation.c	mm/hugetlb: get rid of page_hstate()	2023-08-18 10:12:39 -07:00
page_owner.c	mm/page_ext: use page_ext_data helper in page_owner	2023-08-21 13:37:27 -07:00
page_poison.c	mm/page_poison: remove unused page_ext.h from page_poison	2023-08-21 13:37:30 -07:00
page_reporting.c	mm, treewide: introduce NR_PAGE_ORDERS	2024-05-02 16:32:41 +02:00
page_reporting.h
page_table_check.c	mm/page_table_check: support userfault wr-protect entries	2024-08-19 06:04:29 +02:00
page_vma_mapped.c	mm: correct stale comment of function check_pte	2023-08-18 10:12:13 -07:00
pagewalk.c	mm/pagewalk: fix bootstopping regression from extra pte_unmap()	2023-09-02 08:39:21 -07:00
percpu-internal.h	percpu-internal/pcpu_chunk: re-layout pcpu_chunk structure to reduce false sharing	2023-06-19 16:19:29 -07:00
percpu-km.c
percpu-stats.c
percpu-vm.c
percpu.c	mm: Introduce flush_cache_vmap_early()	2024-02-16 19:10:52 +01:00
pgalloc-track.h
pgtable-generic.c	mm: fix race between __split_huge_pmd_locked() and GUP-fast	2024-06-16 13:47:40 +02:00
process_vm_access.c	mm/gup: remove unused vmas parameter from pin_user_pages_remote()	2023-06-09 16:25:25 -07:00
ptdump.c	mm: ptdump should use ptep_get_lockless()	2023-06-19 16:19:24 -07:00
readahead.c	mm: support order-1 folios in the page cache	2024-11-17 15:08:59 +01:00
rmap.c	mm: hugetlb: add huge page size param to set_huge_pte_at()	2023-09-29 17:20:47 -07:00
rodata_test.c	mm/rodata_test: use PAGE_ALIGNED() helper	2022-10-03 14:03:05 -07:00
secretmem.c	secretmem: disable memfd_secret() if arch cannot set direct map	2024-10-17 15:24:37 +02:00
shmem.c	mm: revert "mm: shmem: fix data-race in shmem_getattr()"	2024-11-22 15:38:33 +01:00
shmem_quota.c	tmpfs: fix race on handling dquot rbtree	2024-04-03 15:28:54 +02:00
show_mem.c	mm, treewide: introduce NR_PAGE_ORDERS	2024-05-02 16:32:41 +02:00
shrinker_debug.c	Revert "mm: shrinkers: make count and scan in shrinker debugfs lockless"	2023-06-19 13:19:34 -07:00
shuffle.c	mm/shuffle: convert module_param_call to module_param_cb	2022-10-03 14:03:07 -07:00
shuffle.h	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
slab.c	Randomized slab caches for kmalloc()	2023-07-18 10:07:47 +02:00
slab.h	Randomized slab caches for kmalloc()	2023-07-18 10:07:47 +02:00
slab_common.c	mm: krealloc: Fix MTE false alarm in __do_krealloc	2024-11-17 15:08:58 +01:00
slub.c	mm/slub: remove freelist_dereference()	2023-07-14 09:57:21 +02:00
sparse-vmemmap.c	mm/vmemmap: allow architectures to override how vmemmap optimization works	2023-08-18 10:12:53 -07:00
sparse.c	x86/kaslr: Expose and use the end of the physical memory address space	2024-09-12 11:11:25 +02:00
swap.c	mm: remove references to pagevec	2023-06-23 16:59:30 -07:00
swap.h	mm/swap: fix race when skipping swapcache	2024-03-01 13:35:00 +01:00
swap_cgroup.c	mm: memcontrol: don't allocate cgroup swap arrays when memcg is disabled	2022-10-03 14:03:36 -07:00
swap_slots.c	mm/swap: convert put_swap_page() to put_swap_folio()	2022-10-03 14:02:46 -07:00
swap_state.c	mm/swap: inline folio_set_swap_entry() and folio_swap_entry()	2023-08-24 16:20:28 -07:00
swapfile.c	mm/swapfile: skip HugeTLB pages for unuse_vma	2024-10-22 15:46:21 +02:00
truncate.c	mm: Fix missing folio invalidation calls during truncation	2024-09-04 13:28:23 +02:00
usercopy.c	mm: Fix copy_from_user_nofault().	2023-04-12 17:36:23 -07:00
userfaultfd.c	userfaultfd: fix checks for huge PMDs	2024-09-12 11:11:27 +02:00
util.c	mm: only enforce minimum stack gap size if it's sensible	2024-10-04 16:30:02 +02:00
vmalloc.c	mm: vmalloc: ensure vmap_block is initialised before adding to queue	2024-09-12 11:11:27 +02:00
vmpressure.c	net-memcg: Fix scope of sockmem pressure indicators	2023-08-16 12:21:32 +01:00
vmscan.c	mm/mglru: only clear kswapd_failures if reclaimable	2024-10-22 15:46:21 +02:00
vmstat.c	mm, treewide: introduce NR_PAGE_ORDERS	2024-05-02 16:32:41 +02:00
workingset.c	mm: ratelimit stat flush from workingset shrinker	2024-06-16 13:47:31 +02:00
z3fold.c	mm/z3fold: remove obsolete comment for struct z3fold_pool	2023-08-21 13:37:51 -07:00
zbud.c	mm: zswap: remove shrink from zpool interface	2023-06-19 16:19:27 -07:00
zpool.c	mm: zswap: remove shrink from zpool interface	2023-06-19 16:19:27 -07:00
zsmalloc.c	merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes	2023-08-21 14:26:20 -07:00
zswap.c	mm: zswap: fix missing folio cleanup in writeback race path	2024-03-01 13:35:10 +01:00