bianbu-repo-mirror/bianbu-linux-6.6
1
0
Fork 0
mirror of https://gitee.com/bianbu-linux/linux-6.6 synced 2025-07-24 01:54:03 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
bianbu-linux-6.6/drivers/net/wireless/realtek/rtlwifi/rtl8723be
History
Ping-Ke Shih af8a41cccf rtlwifi: cleanup 8723be ant_sel definition 
Some HP laptops have only a single wifi antenna. This would not be a
problem except that they were shipped with an incorrectly encoded
EFUSE. It should have been possible to open the computer and transfer
the antenna connection to the other terminal except that such action
might void the warranty, and moving the antenna broke the Windows
driver. The fix was to add a module option that would override the
EFUSE encoding. That was done with commit c18d8f5095 ("rtlwifi:
rtl8723be: Add antenna select module parameter"). There was still a
problem with Bluetooth coexistence, which was addressed with commit
baa1702290 ("rtlwifi: btcoexist: Implement antenna selection").
There were still problems, thus there were commit 0ff78adeef
("rtlwifi: rtl8723be: fix ant_sel code") and commit 6d62269283
("rtlwifi: btcoexist: Fix antenna selection code"). Despite all these
attempts at fixing the problem, the code is not yet right. A proper
fix is important as there are now instances of laptops having
RTL8723DE chips with the same problem.

The module parameter ant_sel is used to control antenna number and path.
At present enum ANT_{X2,X1} is used to define the antenna number, but
this choice is not intuitive, thus change to a new enum ANT_{MAIN,AUX}
to make it more readable. This change showed examples where incorrect
values were used. It was also possible to remove a workaround in
halbtcoutsrc.c.

The experimental results with single antenna connected to specific path
are now as follows:
  ant_sel  ANT_MAIN(#1)  ANT_AUX(#2)
     0        -8            -62
     1        -62           -10
     2        -6            -60

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Fixes: c18d8f5095 ("rtlwifi: rtl8723be: Add antenna select module parameter")
Fixes: baa1702290 ("rtlwifi: btcoexist: Implement antenna selection")
Fixes: 0ff78adeef ("rtlwifi: rtl8723be: fix ant_sel code")
Fixes: 6d62269283 ("rtlwifi: btcoexist: Fix antenna selection code")
Cc: Stable <stable@vger.kernel.org> # 4.7+
Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2018-04-24 13:15:08 +03:00
..
def.h
dm.c rtlwifi: Add bw_update parameter for RA mask update. 2017-10-13 12:43:41 +03:00
dm.h
fw.c rtlwifi: Add BT_MP_INFO to c2h handler. 2017-07-28 18:16:35 +03:00
fw.h rtlwifi: Add btcoex record_pwr_mode 2017-06-21 18:28:05 +03:00
hw.c rtlwifi: cleanup 8723be ant_sel definition 2018-04-24 13:15:08 +03:00
hw.h rtlwifi: Convert individual interrupt results to struct 2017-12-07 15:13:32 +02:00
led.c rtlwifi: Move items out of rtl_pci_priv and rtl_usb_priv 2017-02-08 17:24:42 +02:00
led.h
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
phy.c wireless: use ARRAY_SIZE 2017-12-08 15:19:46 +02:00
phy.h
pwrseq.c
pwrseq.h rtlwifi: correct comment 2018-03-27 12:02:17 +03:00
reg.h rtlwifi: fix REG_USTIME_TSF register definition 2017-06-21 18:23:43 +03:00
rf.c rtlwifi: rtl8723be: Remove all instances of DBG_EMERG 2016-12-30 15:54:21 +02:00
rf.h
sw.c rtlwifi: Add module parameter ASPM 2017-10-13 12:43:42 +03:00
sw.h
table.c wireless: use ARRAY_SIZE 2017-12-08 15:19:46 +02:00
table.h rtlwifi: Update 8723be new phy parameters and its parser. 2017-07-28 18:16:36 +03:00
trx.c rtlwifi: rtl8192ee: Make driver support 64bits DMA. 2017-10-13 12:43:38 +03:00
trx.h rtlwifi: rtl8192ee: Make driver support 64bits DMA. 2017-10-13 12:43:38 +03:00