mirror of
https://gitee.com/bianbu-linux/linux-6.6
synced 2025-07-20 01:33:37 -04:00
Userspace can disable links and create pipelines that do not start with a source entity. Trying to stream from such a pipeline should fail with -EPIPE currently this is not handled and cause kernel crash. Reproducing the crash: media-ctl -d0 -l "5:1->21:0[0]" -v v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=1920,height=1440 v4l2-ctl --stream-mmap --stream-count=100 -d /dev/video2 Panic message: [ 39.078841][ T248] BUG: kernel NULL pointer dereference, address: 0000000000000000 [ 39.079338][ T248] #PF: supervisor read access in kernel mode [ 39.079704][ T248] #PF: error_code(0x0000) - not-present page [ 39.080071][ T248] PGD 0 P4D 0 [ 39.080279][ T248] Oops: 0000 [#1] SMP PTI [ 39.080546][ T248] CPU: 0 PID: 248 Comm: vimc-streamer t Not tainted 5.4.0-rc1+ #17 [ 39.081030][ T248] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org 04/01/2014 [ 39.081779][ T248] RIP: 0010:vimc_sca_process_frame+0xdb/0x210 [vimc] [ 39.082191][ T248] Code: 44 8d 0c 28 8b 93 a4 01 00 00 48 8b 8b 98 01 00 00 85 d2 74 40 48 8b 74 24 10 8d 7a ff 4c 01 c9 31 d2 4c 01 fe eb 03 4c 89 c2 <44> 0f b6 04 16 44 88 04 11 4c 8d 42 01 48 39 fa 75 eb 8b 93 a4 01 [ 39.083436][ T248] RSP: 0018:ffffb15a005abe90 EFLAGS: 00010246 [ 39.083808][ T248] RAX: 0000000000000000 RBX: ffffa3fdc46d2e00 RCX: ffffb15a02579000 [ 39.084298][ T248] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000002 [ 39.084792][ T248] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 [ 39.085280][ T248] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000 [ 39.085770][ T248] R13: ffffa3fdc46d2ee0 R14: 0000000000000000 R15: 0000000000000000 [ 39.086258][ T248] FS: 0000000000000000(0000) GS:ffffa3fdc7800000(0000) knlGS:0000000000000000 [ 39.086806][ T248] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 39.087217][ T248] CR2: 0000000000000000 CR3: 0000000003c92005 CR4: 0000000000360ef0 [ 39.087706][ T248] Call Trace: [ 39.087909][ T248] ? vimc_streamer_pipeline_terminate+0x90/0x90 [vimc] [ 39.088318][ T248] vimc_streamer_thread+0x7c/0xe0 [vimc] [ 39.088663][ T248] kthread+0x10d/0x130 [ 39.088919][ T248] ? kthread_park+0x80/0x80 [ 39.089205][ T248] ret_from_fork+0x35/0x40 [ 39.089475][ T248] Modules linked in: vimc videobuf2_vmalloc videobuf2_memops v4l2_tpg videobuf2_v4l2 videobuf2_common videodev mc [ 39.090208][ T248] CR2: 0000000000000000 [ 39.090463][ T248] ---[ end trace 697650fefbf78bee ]--- [ 39.090796][ T248] RIP: 0010:vimc_sca_process_frame+0xdb/0x210 [vimc] [ 39.091209][ T248] Code: 44 8d 0c 28 8b 93 a4 01 00 00 48 8b 8b 98 01 00 00 85 d2 74 40 48 8b 74 24 10 8d 7a ff 4c 01 c9 31 d2 4c 01 fe eb 03 4c 89 c2 <44> 0f b6 04 16 44 88 04 11 4c 8d 42 01 48 39 fa 75 eb 8b 93 a4 01 [ 39.092417][ T248] RSP: 0018:ffffb15a005abe90 EFLAGS: 00010246 [ 39.092789][ T248] RAX: 0000000000000000 RBX: ffffa3fdc46d2e00 RCX: ffffb15a02579000 [ 39.093278][ T248] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000002 [ 39.093766][ T248] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 [ 39.094254][ T248] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000 [ 39.094742][ T248] R13: ffffa3fdc46d2ee0 R14: 0000000000000000 R15: 0000000000000000 [ 39.095309][ T248] FS: 0000000000000000(0000) GS:ffffa3fdc7800000(0000) knlGS:0000000000000000 [ 39.095974][ T248] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 39.096372][ T248] CR2: 0000000000000000 CR3: 0000000003c92005 CR4: 0000000000360ef0 Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
227 lines
5.7 KiB
C
227 lines
5.7 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* vimc-streamer.c Virtual Media Controller Driver
|
|
*
|
|
* Copyright (C) 2018 Lucas A. M. Magalhães <lucmaga@gmail.com>
|
|
*
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/freezer.h>
|
|
#include <linux/kthread.h>
|
|
|
|
#include "vimc-streamer.h"
|
|
|
|
/**
|
|
* vimc_get_source_entity - get the entity connected with the first sink pad
|
|
*
|
|
* @ent: reference media_entity
|
|
*
|
|
* Helper function that returns the media entity containing the source pad
|
|
* linked with the first sink pad from the given media entity pad list.
|
|
*
|
|
* Return: The source pad or NULL, if it wasn't found.
|
|
*/
|
|
static struct media_entity *vimc_get_source_entity(struct media_entity *ent)
|
|
{
|
|
struct media_pad *pad;
|
|
int i;
|
|
|
|
for (i = 0; i < ent->num_pads; i++) {
|
|
if (ent->pads[i].flags & MEDIA_PAD_FL_SOURCE)
|
|
continue;
|
|
pad = media_entity_remote_pad(&ent->pads[i]);
|
|
return pad ? pad->entity : NULL;
|
|
}
|
|
return NULL;
|
|
}
|
|
|
|
/**
|
|
* vimc_streamer_pipeline_terminate - Disable stream in all ved in stream
|
|
*
|
|
* @stream: the pointer to the stream structure with the pipeline to be
|
|
* disabled.
|
|
*
|
|
* Calls s_stream to disable the stream in each entity of the pipeline
|
|
*
|
|
*/
|
|
static void vimc_streamer_pipeline_terminate(struct vimc_stream *stream)
|
|
{
|
|
struct vimc_ent_device *ved;
|
|
struct v4l2_subdev *sd;
|
|
|
|
while (stream->pipe_size) {
|
|
stream->pipe_size--;
|
|
ved = stream->ved_pipeline[stream->pipe_size];
|
|
stream->ved_pipeline[stream->pipe_size] = NULL;
|
|
|
|
if (!is_media_entity_v4l2_subdev(ved->ent))
|
|
continue;
|
|
|
|
sd = media_entity_to_v4l2_subdev(ved->ent);
|
|
v4l2_subdev_call(sd, video, s_stream, 0);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* vimc_streamer_pipeline_init - Initializes the stream structure
|
|
*
|
|
* @stream: the pointer to the stream structure to be initialized
|
|
* @ved: the pointer to the vimc entity initializing the stream
|
|
*
|
|
* Initializes the stream structure. Walks through the entity graph to
|
|
* construct the pipeline used later on the streamer thread.
|
|
* Calls vimc_streamer_s_stream() to enable stream in all entities of
|
|
* the pipeline.
|
|
*
|
|
* Return: 0 if success, error code otherwise.
|
|
*/
|
|
static int vimc_streamer_pipeline_init(struct vimc_stream *stream,
|
|
struct vimc_ent_device *ved)
|
|
{
|
|
struct media_entity *entity;
|
|
struct video_device *vdev;
|
|
struct v4l2_subdev *sd;
|
|
int ret = 0;
|
|
|
|
stream->pipe_size = 0;
|
|
while (stream->pipe_size < VIMC_STREAMER_PIPELINE_MAX_SIZE) {
|
|
if (!ved) {
|
|
vimc_streamer_pipeline_terminate(stream);
|
|
return -EINVAL;
|
|
}
|
|
stream->ved_pipeline[stream->pipe_size++] = ved;
|
|
|
|
if (is_media_entity_v4l2_subdev(ved->ent)) {
|
|
sd = media_entity_to_v4l2_subdev(ved->ent);
|
|
ret = v4l2_subdev_call(sd, video, s_stream, 1);
|
|
if (ret && ret != -ENOIOCTLCMD) {
|
|
dev_err(ved->dev, "subdev_call error %s\n",
|
|
ved->ent->name);
|
|
vimc_streamer_pipeline_terminate(stream);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
entity = vimc_get_source_entity(ved->ent);
|
|
/* Check if the end of the pipeline was reached */
|
|
if (!entity) {
|
|
/* the first entity of the pipe should be source only */
|
|
if (!vimc_is_source(ved->ent)) {
|
|
dev_err(ved->dev,
|
|
"first entity in the pipe '%s' is not a source\n",
|
|
ved->ent->name);
|
|
vimc_streamer_pipeline_terminate(stream);
|
|
return -EPIPE;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/* Get the next device in the pipeline */
|
|
if (is_media_entity_v4l2_subdev(entity)) {
|
|
sd = media_entity_to_v4l2_subdev(entity);
|
|
ved = v4l2_get_subdevdata(sd);
|
|
} else {
|
|
vdev = container_of(entity,
|
|
struct video_device,
|
|
entity);
|
|
ved = video_get_drvdata(vdev);
|
|
}
|
|
}
|
|
|
|
vimc_streamer_pipeline_terminate(stream);
|
|
return -EINVAL;
|
|
}
|
|
|
|
/**
|
|
* vimc_streamer_thread - Process frames through the pipeline
|
|
*
|
|
* @data: vimc_stream struct of the current stream
|
|
*
|
|
* From the source to the sink, gets a frame from each subdevice and send to
|
|
* the next one of the pipeline at a fixed framerate.
|
|
*
|
|
* Return:
|
|
* Always zero (created as ``int`` instead of ``void`` to comply with
|
|
* kthread API).
|
|
*/
|
|
static int vimc_streamer_thread(void *data)
|
|
{
|
|
struct vimc_stream *stream = data;
|
|
u8 *frame = NULL;
|
|
int i;
|
|
|
|
set_freezable();
|
|
|
|
for (;;) {
|
|
try_to_freeze();
|
|
if (kthread_should_stop())
|
|
break;
|
|
|
|
for (i = stream->pipe_size - 1; i >= 0; i--) {
|
|
frame = stream->ved_pipeline[i]->process_frame(
|
|
stream->ved_pipeline[i], frame);
|
|
if (!frame || IS_ERR(frame))
|
|
break;
|
|
}
|
|
//wait for 60hz
|
|
set_current_state(TASK_UNINTERRUPTIBLE);
|
|
schedule_timeout(HZ / 60);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* vimc_streamer_s_stream - Start/stop the streaming on the media pipeline
|
|
*
|
|
* @stream: the pointer to the stream structure of the current stream
|
|
* @ved: pointer to the vimc entity of the entity of the stream
|
|
* @enable: flag to determine if stream should start/stop
|
|
*
|
|
* When starting, check if there is no ``stream->kthread`` allocated. This
|
|
* should indicate that a stream is already running. Then, it initializes the
|
|
* pipeline, creates and runs a kthread to consume buffers through the pipeline.
|
|
* When stopping, analogously check if there is a stream running, stop the
|
|
* thread and terminates the pipeline.
|
|
*
|
|
* Return: 0 if success, error code otherwise.
|
|
*/
|
|
int vimc_streamer_s_stream(struct vimc_stream *stream,
|
|
struct vimc_ent_device *ved,
|
|
int enable)
|
|
{
|
|
int ret;
|
|
|
|
if (!stream || !ved)
|
|
return -EINVAL;
|
|
|
|
if (enable) {
|
|
if (stream->kthread)
|
|
return 0;
|
|
|
|
ret = vimc_streamer_pipeline_init(stream, ved);
|
|
if (ret)
|
|
return ret;
|
|
|
|
stream->kthread = kthread_run(vimc_streamer_thread, stream,
|
|
"vimc-streamer thread");
|
|
|
|
if (IS_ERR(stream->kthread))
|
|
return PTR_ERR(stream->kthread);
|
|
|
|
} else {
|
|
if (!stream->kthread)
|
|
return 0;
|
|
|
|
ret = kthread_stop(stream->kthread);
|
|
if (ret)
|
|
return ret;
|
|
|
|
stream->kthread = NULL;
|
|
|
|
vimc_streamer_pipeline_terminate(stream);
|
|
}
|
|
|
|
return 0;
|
|
}
|