mirror of
https://gitee.com/bianbu-linux/linux-6.6
synced 2025-04-24 14:07:52 -04:00
[ Upstream commit a1af6a2bfa0cb46d70b7df5352993e750da6c79b ] Commit2810c1e998
("kunit: Fix wild-memory-access bug in kunit_free_suite_set()") fixed a wild-memory-access bug that could have happened during the loading phase of test suites built and executed as loadable modules. However, it also introduced a problematic side effect that causes test suites modules to crash when they attempt to register fake devices. When a module is loaded, it traverses the MODULE_STATE_UNFORMED and MODULE_STATE_COMING states before reaching the normal operating state MODULE_STATE_LIVE. Finally, when the module is removed, it moves to MODULE_STATE_GOING before being released. However, if the loading function load_module() fails between complete_formation() and do_init_module(), the module goes directly from MODULE_STATE_COMING to MODULE_STATE_GOING without passing through MODULE_STATE_LIVE. This behavior was causing kunit_module_exit() to be called without having first executed kunit_module_init(). Since kunit_module_exit() is responsible for freeing the memory allocated by kunit_module_init() through kunit_filter_suites(), this behavior was resulting in a wild-memory-access bug. Commit2810c1e998
("kunit: Fix wild-memory-access bug in kunit_free_suite_set()") fixed this issue by running the tests when the module is still in MODULE_STATE_COMING. However, modules in that state are not fully initialized, lacking sysfs kobjects. Therefore, if a test module attempts to register a fake device, it will inevitably crash. This patch proposes a different approach to fix the original wild-memory-access bug while restoring the normal module execution flow by making kunit_module_exit() able to detect if kunit_module_init() has previously initialized the tests suite set. In this way, test modules can once again register fake devices without crashing. This behavior is achieved by checking whether mod->kunit_suites is a virtual or direct mapping address. If it is a virtual address, then kunit_module_init() has allocated the suite_set in kunit_filter_suites() using kmalloc_array(). On the contrary, if mod->kunit_suites is still pointing to the original address that was set when looking up the .kunit_test_suites section of the module, then the loading phase has failed and there's no memory to be freed. v4: - rebased on 6.8 - noted that kunit_filter_suites() must return a virtual address v3: - add a comment to clarify why the start address is checked v2: - add include <linux/mm.h> Fixes:2810c1e998
("kunit: Fix wild-memory-access bug in kunit_free_suite_set()") Reviewed-by: David Gow <davidgow@google.com> Tested-by: Rae Moar <rmoar@google.com> Tested-by: Richard Fitzgerald <rf@opensource.cirrus.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Signed-off-by: Marco Pagani <marpagan@redhat.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
360 lines
9 KiB
C
360 lines
9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#include <linux/reboot.h>
|
|
#include <kunit/test.h>
|
|
#include <kunit/attributes.h>
|
|
#include <linux/glob.h>
|
|
#include <linux/moduleparam.h>
|
|
|
|
/*
|
|
* These symbols point to the .kunit_test_suites section and are defined in
|
|
* include/asm-generic/vmlinux.lds.h, and consequently must be extern.
|
|
*/
|
|
extern struct kunit_suite * const __kunit_suites_start[];
|
|
extern struct kunit_suite * const __kunit_suites_end[];
|
|
|
|
static char *action_param;
|
|
|
|
module_param_named(action, action_param, charp, 0400);
|
|
MODULE_PARM_DESC(action,
|
|
"Changes KUnit executor behavior, valid values are:\n"
|
|
"<none>: run the tests like normal\n"
|
|
"'list' to list test names instead of running them.\n"
|
|
"'list_attr' to list test names and attributes instead of running them.\n");
|
|
|
|
const char *kunit_action(void)
|
|
{
|
|
return action_param;
|
|
}
|
|
|
|
static char *filter_glob_param;
|
|
static char *filter_param;
|
|
static char *filter_action_param;
|
|
|
|
module_param_named(filter_glob, filter_glob_param, charp, 0400);
|
|
MODULE_PARM_DESC(filter_glob,
|
|
"Filter which KUnit test suites/tests run at boot-time, e.g. list* or list*.*del_test");
|
|
module_param_named(filter, filter_param, charp, 0400);
|
|
MODULE_PARM_DESC(filter,
|
|
"Filter which KUnit test suites/tests run at boot-time using attributes, e.g. speed>slow");
|
|
module_param_named(filter_action, filter_action_param, charp, 0400);
|
|
MODULE_PARM_DESC(filter_action,
|
|
"Changes behavior of filtered tests using attributes, valid values are:\n"
|
|
"<none>: do not run filtered tests as normal\n"
|
|
"'skip': skip all filtered tests instead so tests will appear in output\n");
|
|
|
|
const char *kunit_filter_glob(void)
|
|
{
|
|
return filter_glob_param;
|
|
}
|
|
|
|
char *kunit_filter(void)
|
|
{
|
|
return filter_param;
|
|
}
|
|
|
|
char *kunit_filter_action(void)
|
|
{
|
|
return filter_action_param;
|
|
}
|
|
|
|
/* glob_match() needs NULL terminated strings, so we need a copy of filter_glob_param. */
|
|
struct kunit_glob_filter {
|
|
char *suite_glob;
|
|
char *test_glob;
|
|
};
|
|
|
|
/* Split "suite_glob.test_glob" into two. Assumes filter_glob is not empty. */
|
|
static int kunit_parse_glob_filter(struct kunit_glob_filter *parsed,
|
|
const char *filter_glob)
|
|
{
|
|
const int len = strlen(filter_glob);
|
|
const char *period = strchr(filter_glob, '.');
|
|
|
|
if (!period) {
|
|
parsed->suite_glob = kzalloc(len + 1, GFP_KERNEL);
|
|
if (!parsed->suite_glob)
|
|
return -ENOMEM;
|
|
|
|
parsed->test_glob = NULL;
|
|
strcpy(parsed->suite_glob, filter_glob);
|
|
return 0;
|
|
}
|
|
|
|
parsed->suite_glob = kzalloc(period - filter_glob + 1, GFP_KERNEL);
|
|
if (!parsed->suite_glob)
|
|
return -ENOMEM;
|
|
|
|
parsed->test_glob = kzalloc(len - (period - filter_glob) + 1, GFP_KERNEL);
|
|
if (!parsed->test_glob) {
|
|
kfree(parsed->suite_glob);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
strncpy(parsed->suite_glob, filter_glob, period - filter_glob);
|
|
strncpy(parsed->test_glob, period + 1, len - (period - filter_glob));
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Create a copy of suite with only tests that match test_glob. */
|
|
static struct kunit_suite *
|
|
kunit_filter_glob_tests(const struct kunit_suite *const suite, const char *test_glob)
|
|
{
|
|
int n = 0;
|
|
struct kunit_case *filtered, *test_case;
|
|
struct kunit_suite *copy;
|
|
|
|
kunit_suite_for_each_test_case(suite, test_case) {
|
|
if (!test_glob || glob_match(test_glob, test_case->name))
|
|
++n;
|
|
}
|
|
|
|
if (n == 0)
|
|
return NULL;
|
|
|
|
copy = kmemdup(suite, sizeof(*copy), GFP_KERNEL);
|
|
if (!copy)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
filtered = kcalloc(n + 1, sizeof(*filtered), GFP_KERNEL);
|
|
if (!filtered) {
|
|
kfree(copy);
|
|
return ERR_PTR(-ENOMEM);
|
|
}
|
|
|
|
n = 0;
|
|
kunit_suite_for_each_test_case(suite, test_case) {
|
|
if (!test_glob || glob_match(test_glob, test_case->name))
|
|
filtered[n++] = *test_case;
|
|
}
|
|
|
|
copy->test_cases = filtered;
|
|
return copy;
|
|
}
|
|
|
|
void kunit_free_suite_set(struct kunit_suite_set suite_set)
|
|
{
|
|
struct kunit_suite * const *suites;
|
|
|
|
for (suites = suite_set.start; suites < suite_set.end; suites++) {
|
|
kfree((*suites)->test_cases);
|
|
kfree(*suites);
|
|
}
|
|
kfree(suite_set.start);
|
|
}
|
|
|
|
/*
|
|
* Filter and reallocate test suites. Must return the filtered test suites set
|
|
* allocated at a valid virtual address or NULL in case of error.
|
|
*/
|
|
struct kunit_suite_set
|
|
kunit_filter_suites(const struct kunit_suite_set *suite_set,
|
|
const char *filter_glob,
|
|
char *filters,
|
|
char *filter_action,
|
|
int *err)
|
|
{
|
|
int i, j, k;
|
|
int filter_count = 0;
|
|
struct kunit_suite **copy, **copy_start, *filtered_suite, *new_filtered_suite;
|
|
struct kunit_suite_set filtered = {NULL, NULL};
|
|
struct kunit_glob_filter parsed_glob;
|
|
struct kunit_attr_filter *parsed_filters = NULL;
|
|
struct kunit_suite * const *suites;
|
|
|
|
const size_t max = suite_set->end - suite_set->start;
|
|
|
|
copy = kcalloc(max, sizeof(*filtered.start), GFP_KERNEL);
|
|
if (!copy) { /* won't be able to run anything, return an empty set */
|
|
return filtered;
|
|
}
|
|
copy_start = copy;
|
|
|
|
if (filter_glob) {
|
|
*err = kunit_parse_glob_filter(&parsed_glob, filter_glob);
|
|
if (*err)
|
|
goto free_copy;
|
|
}
|
|
|
|
/* Parse attribute filters */
|
|
if (filters) {
|
|
filter_count = kunit_get_filter_count(filters);
|
|
parsed_filters = kcalloc(filter_count, sizeof(*parsed_filters), GFP_KERNEL);
|
|
if (!parsed_filters) {
|
|
*err = -ENOMEM;
|
|
goto free_parsed_glob;
|
|
}
|
|
for (j = 0; j < filter_count; j++)
|
|
parsed_filters[j] = kunit_next_attr_filter(&filters, err);
|
|
if (*err)
|
|
goto free_parsed_filters;
|
|
}
|
|
|
|
for (i = 0; &suite_set->start[i] != suite_set->end; i++) {
|
|
filtered_suite = suite_set->start[i];
|
|
if (filter_glob) {
|
|
if (!glob_match(parsed_glob.suite_glob, filtered_suite->name))
|
|
continue;
|
|
filtered_suite = kunit_filter_glob_tests(filtered_suite,
|
|
parsed_glob.test_glob);
|
|
if (IS_ERR(filtered_suite)) {
|
|
*err = PTR_ERR(filtered_suite);
|
|
goto free_filtered_suite;
|
|
}
|
|
}
|
|
if (filter_count > 0 && parsed_filters != NULL) {
|
|
for (k = 0; k < filter_count; k++) {
|
|
new_filtered_suite = kunit_filter_attr_tests(filtered_suite,
|
|
parsed_filters[k], filter_action, err);
|
|
|
|
/* Free previous copy of suite */
|
|
if (k > 0 || filter_glob) {
|
|
kfree(filtered_suite->test_cases);
|
|
kfree(filtered_suite);
|
|
}
|
|
|
|
filtered_suite = new_filtered_suite;
|
|
|
|
if (*err)
|
|
goto free_filtered_suite;
|
|
|
|
if (IS_ERR(filtered_suite)) {
|
|
*err = PTR_ERR(filtered_suite);
|
|
goto free_filtered_suite;
|
|
}
|
|
if (!filtered_suite)
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (!filtered_suite)
|
|
continue;
|
|
|
|
*copy++ = filtered_suite;
|
|
}
|
|
filtered.start = copy_start;
|
|
filtered.end = copy;
|
|
|
|
free_filtered_suite:
|
|
if (*err) {
|
|
for (suites = copy_start; suites < copy; suites++) {
|
|
kfree((*suites)->test_cases);
|
|
kfree(*suites);
|
|
}
|
|
}
|
|
|
|
free_parsed_filters:
|
|
if (filter_count)
|
|
kfree(parsed_filters);
|
|
|
|
free_parsed_glob:
|
|
if (filter_glob) {
|
|
kfree(parsed_glob.suite_glob);
|
|
kfree(parsed_glob.test_glob);
|
|
}
|
|
|
|
free_copy:
|
|
if (*err)
|
|
kfree(copy_start);
|
|
|
|
return filtered;
|
|
}
|
|
|
|
void kunit_exec_run_tests(struct kunit_suite_set *suite_set, bool builtin)
|
|
{
|
|
size_t num_suites = suite_set->end - suite_set->start;
|
|
|
|
if (builtin || num_suites) {
|
|
pr_info("KTAP version 1\n");
|
|
pr_info("1..%zu\n", num_suites);
|
|
}
|
|
|
|
__kunit_test_suites_init(suite_set->start, num_suites);
|
|
}
|
|
|
|
void kunit_exec_list_tests(struct kunit_suite_set *suite_set, bool include_attr)
|
|
{
|
|
struct kunit_suite * const *suites;
|
|
struct kunit_case *test_case;
|
|
|
|
/* Hack: print a ktap header so kunit.py can find the start of KUnit output. */
|
|
pr_info("KTAP version 1\n");
|
|
|
|
for (suites = suite_set->start; suites < suite_set->end; suites++) {
|
|
/* Print suite name and suite attributes */
|
|
pr_info("%s\n", (*suites)->name);
|
|
if (include_attr)
|
|
kunit_print_attr((void *)(*suites), false, 0);
|
|
|
|
/* Print test case name and attributes in suite */
|
|
kunit_suite_for_each_test_case((*suites), test_case) {
|
|
pr_info("%s.%s\n", (*suites)->name, test_case->name);
|
|
if (include_attr)
|
|
kunit_print_attr((void *)test_case, true, 0);
|
|
}
|
|
}
|
|
}
|
|
|
|
#if IS_BUILTIN(CONFIG_KUNIT)
|
|
|
|
static char *kunit_shutdown;
|
|
core_param(kunit_shutdown, kunit_shutdown, charp, 0644);
|
|
|
|
static void kunit_handle_shutdown(void)
|
|
{
|
|
if (!kunit_shutdown)
|
|
return;
|
|
|
|
if (!strcmp(kunit_shutdown, "poweroff"))
|
|
kernel_power_off();
|
|
else if (!strcmp(kunit_shutdown, "halt"))
|
|
kernel_halt();
|
|
else if (!strcmp(kunit_shutdown, "reboot"))
|
|
kernel_restart(NULL);
|
|
|
|
}
|
|
|
|
int kunit_run_all_tests(void)
|
|
{
|
|
struct kunit_suite_set suite_set = {
|
|
__kunit_suites_start, __kunit_suites_end,
|
|
};
|
|
int err = 0;
|
|
if (!kunit_enabled()) {
|
|
pr_info("kunit: disabled\n");
|
|
goto out;
|
|
}
|
|
|
|
if (filter_glob_param || filter_param) {
|
|
suite_set = kunit_filter_suites(&suite_set, filter_glob_param,
|
|
filter_param, filter_action_param, &err);
|
|
if (err) {
|
|
pr_err("kunit executor: error filtering suites: %d\n", err);
|
|
goto out;
|
|
}
|
|
}
|
|
|
|
if (!action_param)
|
|
kunit_exec_run_tests(&suite_set, true);
|
|
else if (strcmp(action_param, "list") == 0)
|
|
kunit_exec_list_tests(&suite_set, false);
|
|
else if (strcmp(action_param, "list_attr") == 0)
|
|
kunit_exec_list_tests(&suite_set, true);
|
|
else
|
|
pr_err("kunit executor: unknown action '%s'\n", action_param);
|
|
|
|
if (filter_glob_param || filter_param) { /* a copy was made of each suite */
|
|
kunit_free_suite_set(suite_set);
|
|
}
|
|
|
|
out:
|
|
kunit_handle_shutdown();
|
|
return err;
|
|
}
|
|
|
|
#if IS_BUILTIN(CONFIG_KUNIT_TEST)
|
|
#include "executor_test.c"
|
|
#endif
|
|
|
|
#endif /* IS_BUILTIN(CONFIG_KUNIT) */
|