mirror of
https://gitee.com/bianbu-linux/linux-6.6
synced 2025-07-22 01:43:37 -04:00
9fe1c98ac9
When MTU is changed from 9000 to 1500 while there is burst of inbound 9000 bytes packets, adaptor sometimes delivers 9000 bytes packets to 1500 bytes buffers. This causes memory corruption and sometimes crash. This is because of a race condition in adaptor between "RQ disable" clearing descriptor mini-cache and mini-cache valid bit being set by completion of descriptor fetch. This can result in stale RQ desc being cached and used when packets arrive. In this case, the stale descriptor have old MTU value. Solution is to write RQ->disable twice. The first write will stop any further desc fetches, allowing the second disable to clear the mini-cache valid bit without danger of a race. Also, the check for rq->running becoming 0 after writing rq->enable to 0 is not done properly. When incoming packets are flooding the interface, rq->running will pulse high for each dropped packet. Since the driver was waiting for 10us between each poll, it is possible to see rq->running = 1 1000 times in a row, even though it is not actually stuck running. This results in false failure of vnic_rq_disable(). Fix is to try more than 1000 time without delay between polls to ensure we do not miss when running goes low. In old adaptors rq->enable needs to be re-written to 0 when posted_index is reset in vnic_rq_clean() in order to keep rq->prefetch_index in sync. Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
|---|---|---|
| .. | ||
| cq_desc.h | ||
| cq_enet_desc.h | ||
| enic.h | ||
| enic_api.c | ||
| enic_api.h | ||
| enic_clsf.c | ||
| enic_clsf.h | ||
| enic_dev.c | ||
| enic_dev.h | ||
| enic_ethtool.c | ||
| enic_main.c | ||
| enic_pp.c | ||
| enic_pp.h | ||
| enic_res.c | ||
| enic_res.h | ||
| Kconfig | ||
| Makefile | ||
| rq_enet_desc.h | ||
| vnic_cq.c | ||
| vnic_cq.h | ||
| vnic_dev.c | ||
| vnic_dev.h | ||
| vnic_devcmd.h | ||
| vnic_enet.h | ||
| vnic_intr.c | ||
| vnic_intr.h | ||
| vnic_nic.h | ||
| vnic_resource.h | ||
| vnic_rq.c | ||
| vnic_rq.h | ||
| vnic_rss.h | ||
| vnic_stats.h | ||
| vnic_vic.c | ||
| vnic_vic.h | ||
| vnic_wq.c | ||
| vnic_wq.h | ||
| wq_enet_desc.h | ||