Sahil Siddiq f92aebf170 bpftool: Mount bpffs on provided dir instead of parent dir ... [ Upstream commit 478a535ae54ad3831371904d93b5dfc403222e17 ] When pinning programs/objects under PATH (eg: during "bpftool prog loadall") the bpffs is mounted on the parent dir of PATH in the following situations: - the given dir exists but it is not bpffs. - the given dir doesn't exist and the parent dir is not bpffs. Mounting on the parent dir can also have the unintentional side- effect of hiding other files located under the parent dir. If the given dir exists but is not bpffs, then the bpffs should be mounted on the given dir and not its parent dir. Similarly, if the given dir doesn't exist and its parent dir is not bpffs, then the given dir should be created and the bpffs should be mounted on this new dir. Fixes: 2a36c26fe3 ("bpftool: Support bpffs mountpoint as pin path for prog loadall") Signed-off-by: Sahil Siddiq <icegambit91@gmail.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/bpf/2da44d24-74ae-a564-1764-afccf395eeec@isovalent.com/T/#t Link: https://lore.kernel.org/bpf/20240404192219.52373-1-icegambit91@gmail.com Closes: https://github.com/libbpf/bpftool/issues/100 Changes since v1: - Split "mount_bpffs_for_pin" into two functions. This is done to improve maintainability and readability. Changes since v2: - mount_bpffs_for_pin: rename to "create_and_mount_bpffs_dir". - mount_bpffs_given_file: rename to "mount_bpffs_given_file". - create_and_mount_bpffs_dir: - introduce "dir_exists" boolean. - remove new dir if "mnt_fs" fails. - improve error handling and error messages. Changes since v3: - Rectify function name. - Improve error messages and formatting. - mount_bpffs_for_file: - Check if dir exists before block_mount check. Changes since v4: - Use strdup instead of strcpy. - create_and_mount_bpffs_dir: - Use S_IRWXU instead of 0700. - Improve error handling and formatting. Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-06-12 11:11:38 +02:00
..
bpftool	bpftool: Mount bpffs on provided dir instead of parent dir	2024-06-12 11:11:38 +02:00
resolve_btfids	tools/resolve_btfids: Fix cross-compilation to non-host endianness	2024-03-26 18:19:27 -04:00
runqslower	bpf: Replace deprecated -target with --target= for Clang	2023-06-29 15:46:17 +02:00
.gitignore	.gitignore: add SPDX License Identifier	2020-03-25 11:50:48 +01:00
bpf_asm.c	docs: networking: convert filter.txt to ReST	2020-04-28 14:39:46 -07:00
bpf_dbg.c	bpf: Simplify the calculation of variables	2021-03-04 19:24:53 -08:00
bpf_exp.l	bpf: fix cbpf parser bug for octal numbers	2018-06-03 07:46:55 -07:00
bpf_exp.y	tools, bpf_asm: Exit non-zero on errors	2021-02-26 22:53:50 +01:00
bpf_jit_disasm.c	tools bpf_jit_disasm: Fix compilation error with new binutils	2022-08-01 15:30:48 -03:00
Makefile	tools bpf_jit_disasm: Don't display disassembler-four-args feature test	2022-08-01 15:31:51 -03:00