mirror of
https://gitee.com/bianbu-linux/linux-6.6
synced 2025-07-22 01:43:37 -04:00
1259055170
Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. Older firmwares were only generating 802.11f frames. Newer ones like: 1) 10.10 (TOB) (r663589) 2) 10.10.122.20 (r683106) for 4366b1 and 4366c0 respectively seem to also /respect/ 802.11f frames in the Tx path by performing a STA disassociation. This obsoleted standard and its implementation is something that: 1) Most people don't need / want to use 2) Can allow local DoS attacks 3) Breaks AP interfaces in some specific bridge setups To solve issues it can cause this commit modifies brcmfmac to drop IAPP packets. If affects: 1) Rx path: driver won't be sending these unwanted packets up. 2) Tx path: driver will reject packets that would trigger STA disassociation perfromed by a firmware (possible local DoS attack). It appears there are some Broadcom's clients/users who care about this feature despite the drawbacks. They can switch it on using a new module param. This change results in only two more comparisons (check for module param and check for Ethernet packet length) for 99.9% of packets. Its overhead should be very minimal. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
79 lines
2.7 KiB
C
79 lines
2.7 KiB
C
/* Copyright (c) 2014 Broadcom Corporation
|
|
*
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
* SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
|
|
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
|
|
* CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
#ifndef BRCMFMAC_COMMON_H
|
|
#define BRCMFMAC_COMMON_H
|
|
|
|
#include <linux/platform_device.h>
|
|
#include <linux/platform_data/brcmfmac.h>
|
|
#include "fwil_types.h"
|
|
|
|
extern const u8 ALLFFMAC[ETH_ALEN];
|
|
|
|
#define BRCMF_FW_ALTPATH_LEN 256
|
|
|
|
/* Definitions for the module global and device specific settings are defined
|
|
* here. Two structs are used for them. brcmf_mp_global_t and brcmf_mp_device.
|
|
* The mp_global is instantiated once in a global struct and gets initialized
|
|
* by the common_attach function which should be called before any other
|
|
* (module) initiliazation takes place. The device specific settings is part
|
|
* of the drvr struct and should be initialized on every brcmf_attach.
|
|
*/
|
|
|
|
/**
|
|
* struct brcmf_mp_global_t - Global module paramaters.
|
|
*
|
|
* @firmware_path: Alternative firmware path.
|
|
*/
|
|
struct brcmf_mp_global_t {
|
|
char firmware_path[BRCMF_FW_ALTPATH_LEN];
|
|
};
|
|
|
|
extern struct brcmf_mp_global_t brcmf_mp_global;
|
|
|
|
/**
|
|
* struct brcmf_mp_device - Device module paramaters.
|
|
*
|
|
* @p2p_enable: Legacy P2P0 enable (old wpa_supplicant).
|
|
* @feature_disable: Feature_disable bitmask.
|
|
* @fcmode: FWS flow control.
|
|
* @roamoff: Firmware roaming off?
|
|
* @ignore_probe_fail: Ignore probe failure.
|
|
* @country_codes: If available, pointer to struct for translating country codes
|
|
* @bus: Bus specific platform data. Only SDIO at the mmoment.
|
|
*/
|
|
struct brcmf_mp_device {
|
|
bool p2p_enable;
|
|
unsigned int feature_disable;
|
|
int fcmode;
|
|
bool roamoff;
|
|
bool iapp;
|
|
bool ignore_probe_fail;
|
|
struct brcmfmac_pd_cc *country_codes;
|
|
union {
|
|
struct brcmfmac_sdio_pd sdio;
|
|
} bus;
|
|
};
|
|
|
|
void brcmf_c_set_joinpref_default(struct brcmf_if *ifp);
|
|
|
|
struct brcmf_mp_device *brcmf_get_module_param(struct device *dev,
|
|
enum brcmf_bus_type bus_type,
|
|
u32 chip, u32 chiprev);
|
|
void brcmf_release_module_param(struct brcmf_mp_device *module_param);
|
|
|
|
/* Sets dongle media info (drv_version, mac address). */
|
|
int brcmf_c_preinit_dcmds(struct brcmf_if *ifp);
|
|
|
|
#endif /* BRCMFMAC_COMMON_H */
|