Menagerie/Lynx
3
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

Replaced UI State Objects #4

Merged
blizzardfinnegan merged 3 commits from Code-Clean into master 2025-10-30 18:22:01 -06:00
Conversation 2 Commits 3 Files changed 22 +671 -873
Azea_Avenbright commented 2025-10-27 09:35:48 -06:00
Owner
Copy link

Added a new UIBaseState.kt that handles the loading/idle/success/error states of screens as well as monitoring the launched effects.
User facing screens have had their launched effects replaced with a small composable that handles the effect logic uniformly across screens.

Added a new UIBaseState.kt that handles the loading/idle/success/error states of screens as well as monitoring the launched effects. User facing screens have had their launched effects replaced with a small composable that handles the effect logic uniformly across screens.
blizzardfinnegan reviewed 2025-10-30 17:54:44 -06:00
composeApp/src/androidMain/kotlin/org/menagerie/lynx/ui/screens/createaccount/CreateAccountScreen.kt
blizzardfinnegan commented 2025-10-30 17:54:44 -06:00
Owner
Copy link

Documentation comment is out-of-date and/or misplaced.

Documentation comment is out-of-date and/or misplaced.
blizzardfinnegan marked this conversation as resolved
blizzardfinnegan approved these changes 2025-10-30 18:14:45 -06:00
blizzardfinnegan left a comment
Owner
Copy link

All other changes look well-structured; I might consider further condensing requests and responses to be near each other in a singular file for further reference.

All other changes look well-structured; I might consider further condensing requests and responses to be near each other in a singular file for further reference.
blizzardfinnegan deleted branch Code-Clean 2025-10-30 19:54:12 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
blizzardfinnegan
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Menagerie/Lynx!4
No description provided.