mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2025-04-24 22:57:12 -04:00
fix: grid property list bugs
This commit is contained in:
parent
917e15a1b7
commit
13e8c62988
6 changed files with 40 additions and 30 deletions
|
@ -17,7 +17,6 @@ import 'package:app_flowy/user/presentation/router.dart';
|
||||||
import 'package:app_flowy/workspace/presentation/home/home_stack.dart';
|
import 'package:app_flowy/workspace/presentation/home/home_stack.dart';
|
||||||
import 'package:flowy_sdk/protobuf/flowy-folder-data-model/app.pb.dart';
|
import 'package:flowy_sdk/protobuf/flowy-folder-data-model/app.pb.dart';
|
||||||
import 'package:flowy_sdk/protobuf/flowy-folder-data-model/view.pb.dart';
|
import 'package:flowy_sdk/protobuf/flowy-folder-data-model/view.pb.dart';
|
||||||
import 'package:flowy_sdk/protobuf/flowy-grid-data-model/grid.pb.dart';
|
|
||||||
import 'package:flowy_sdk/protobuf/flowy-grid/date_type_option.pb.dart';
|
import 'package:flowy_sdk/protobuf/flowy-grid/date_type_option.pb.dart';
|
||||||
import 'package:flowy_sdk/protobuf/flowy-grid/number_type_option.pb.dart';
|
import 'package:flowy_sdk/protobuf/flowy-grid/number_type_option.pb.dart';
|
||||||
import 'package:flowy_sdk/protobuf/flowy-grid/selection_type_option.pb.dart';
|
import 'package:flowy_sdk/protobuf/flowy-grid/selection_type_option.pb.dart';
|
||||||
|
@ -223,7 +222,7 @@ void _resolveGridDeps(GetIt getIt) {
|
||||||
(typeOption, _) => NumberTypeOptionBloc(typeOption: typeOption),
|
(typeOption, _) => NumberTypeOptionBloc(typeOption: typeOption),
|
||||||
);
|
);
|
||||||
|
|
||||||
getIt.registerFactoryParam<GridPropertyBloc, String, List<Field>>(
|
getIt.registerFactoryParam<GridPropertyBloc, String, GridFieldCache>(
|
||||||
(gridId, fields) => GridPropertyBloc(gridId: gridId, fields: fields),
|
(gridId, cache) => GridPropertyBloc(gridId: gridId, fieldCache: cache),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
|
@ -11,11 +11,12 @@ part 'property_bloc.freezed.dart';
|
||||||
class GridPropertyBloc extends Bloc<GridPropertyEvent, GridPropertyState> {
|
class GridPropertyBloc extends Bloc<GridPropertyEvent, GridPropertyState> {
|
||||||
final FieldService _service;
|
final FieldService _service;
|
||||||
final GridFieldCache _fieldCache;
|
final GridFieldCache _fieldCache;
|
||||||
|
Function()? _listenFieldCallback;
|
||||||
|
|
||||||
GridPropertyBloc({required String gridId, required List<Field> fields})
|
GridPropertyBloc({required String gridId, required GridFieldCache fieldCache})
|
||||||
: _service = FieldService(gridId: gridId),
|
: _service = FieldService(gridId: gridId),
|
||||||
_fieldCache = GridFieldCache(gridId: gridId),
|
_fieldCache = fieldCache,
|
||||||
super(GridPropertyState.initial(gridId, fields)) {
|
super(GridPropertyState.initial(gridId, fieldCache.clonedFields)) {
|
||||||
on<GridPropertyEvent>(
|
on<GridPropertyEvent>(
|
||||||
(event, emit) async {
|
(event, emit) async {
|
||||||
await event.map(
|
await event.map(
|
||||||
|
@ -42,13 +43,15 @@ class GridPropertyBloc extends Bloc<GridPropertyEvent, GridPropertyState> {
|
||||||
|
|
||||||
@override
|
@override
|
||||||
Future<void> close() async {
|
Future<void> close() async {
|
||||||
await _fieldCache.dispose();
|
if (_listenFieldCallback != null) {
|
||||||
|
_fieldCache.removeListener(_listenFieldCallback!);
|
||||||
|
}
|
||||||
return super.close();
|
return super.close();
|
||||||
}
|
}
|
||||||
|
|
||||||
void _startListening() {
|
void _startListening() {
|
||||||
_fieldCache.addListener(
|
_listenFieldCallback = _fieldCache.addListener(
|
||||||
onChanged: (fields) => add(GridPropertyEvent.didReceiveFieldUpdate(_fieldCache.clonedFields)),
|
onChanged: (fields) => add(GridPropertyEvent.didReceiveFieldUpdate(fields)),
|
||||||
listenWhen: () => !isClosed,
|
listenWhen: () => !isClosed,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
|
@ -164,9 +164,10 @@ class _GridToolbarAdaptor extends StatelessWidget {
|
||||||
Widget build(BuildContext context) {
|
Widget build(BuildContext context) {
|
||||||
return BlocSelector<GridBloc, GridState, GridToolbarContext>(
|
return BlocSelector<GridBloc, GridState, GridToolbarContext>(
|
||||||
selector: (state) {
|
selector: (state) {
|
||||||
|
final fieldCache = context.read<GridBloc>().fieldCache;
|
||||||
return GridToolbarContext(
|
return GridToolbarContext(
|
||||||
gridId: state.gridId,
|
gridId: state.gridId,
|
||||||
fields: state.fields,
|
fieldCache: fieldCache,
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
builder: (context, toolbarContext) {
|
builder: (context, toolbarContext) {
|
||||||
|
|
|
@ -1,5 +1,6 @@
|
||||||
import 'package:app_flowy/startup/startup.dart';
|
import 'package:app_flowy/startup/startup.dart';
|
||||||
import 'package:app_flowy/workspace/application/grid/field/field_service.dart';
|
import 'package:app_flowy/workspace/application/grid/field/field_service.dart';
|
||||||
|
import 'package:app_flowy/workspace/application/grid/grid_service.dart';
|
||||||
import 'package:app_flowy/workspace/application/grid/setting/property_bloc.dart';
|
import 'package:app_flowy/workspace/application/grid/setting/property_bloc.dart';
|
||||||
import 'package:app_flowy/workspace/presentation/plugins/grid/src/layout/sizes.dart';
|
import 'package:app_flowy/workspace/presentation/plugins/grid/src/layout/sizes.dart';
|
||||||
import 'package:app_flowy/workspace/presentation/plugins/grid/src/widgets/header/field_editor.dart';
|
import 'package:app_flowy/workspace/presentation/plugins/grid/src/widgets/header/field_editor.dart';
|
||||||
|
@ -18,10 +19,10 @@ import 'package:styled_widget/styled_widget.dart';
|
||||||
|
|
||||||
class GridPropertyList extends StatelessWidget with FlowyOverlayDelegate {
|
class GridPropertyList extends StatelessWidget with FlowyOverlayDelegate {
|
||||||
final String gridId;
|
final String gridId;
|
||||||
final List<Field> fields;
|
final GridFieldCache fieldCache;
|
||||||
const GridPropertyList({
|
const GridPropertyList({
|
||||||
required this.gridId,
|
required this.gridId,
|
||||||
required this.fields,
|
required this.fieldCache,
|
||||||
Key? key,
|
Key? key,
|
||||||
}) : super(key: key);
|
}) : super(key: key);
|
||||||
|
|
||||||
|
@ -43,7 +44,7 @@ class GridPropertyList extends StatelessWidget with FlowyOverlayDelegate {
|
||||||
Widget build(BuildContext context) {
|
Widget build(BuildContext context) {
|
||||||
return BlocProvider(
|
return BlocProvider(
|
||||||
create: (context) =>
|
create: (context) =>
|
||||||
getIt<GridPropertyBloc>(param1: gridId, param2: fields)..add(const GridPropertyEvent.initial()),
|
getIt<GridPropertyBloc>(param1: gridId, param2: fieldCache)..add(const GridPropertyEvent.initial()),
|
||||||
child: BlocBuilder<GridPropertyBloc, GridPropertyState>(
|
child: BlocBuilder<GridPropertyBloc, GridPropertyState>(
|
||||||
builder: (context, state) {
|
builder: (context, state) {
|
||||||
final cells = state.fields.map((field) {
|
final cells = state.fields.map((field) {
|
||||||
|
@ -91,17 +92,7 @@ class _GridPropertyCell extends StatelessWidget {
|
||||||
Expanded(
|
Expanded(
|
||||||
child: SizedBox(
|
child: SizedBox(
|
||||||
height: GridSize.typeOptionItemHeight,
|
height: GridSize.typeOptionItemHeight,
|
||||||
child: FlowyButton(
|
child: _editFieldButton(theme, context),
|
||||||
text: FlowyText.medium(field.name, fontSize: 12),
|
|
||||||
hoverColor: theme.hover,
|
|
||||||
leftIcon: svgWidget(field.fieldType.iconName(), color: theme.iconColor),
|
|
||||||
onTap: () {
|
|
||||||
FieldEditor(
|
|
||||||
gridId: gridId,
|
|
||||||
fieldContextLoader: FieldContextLoaderAdaptor(gridId: gridId, field: field),
|
|
||||||
).show(context, anchorDirection: AnchorDirection.bottomRight);
|
|
||||||
},
|
|
||||||
),
|
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
FlowyIconButton(
|
FlowyIconButton(
|
||||||
|
@ -115,4 +106,18 @@ class _GridPropertyCell extends StatelessWidget {
|
||||||
],
|
],
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
FlowyButton _editFieldButton(AppTheme theme, BuildContext context) {
|
||||||
|
return FlowyButton(
|
||||||
|
text: FlowyText.medium(field.name, fontSize: 12),
|
||||||
|
hoverColor: theme.hover,
|
||||||
|
leftIcon: svgWidget(field.fieldType.iconName(), color: theme.iconColor),
|
||||||
|
onTap: () {
|
||||||
|
FieldEditor(
|
||||||
|
gridId: gridId,
|
||||||
|
fieldContextLoader: FieldContextLoaderAdaptor(gridId: gridId, field: field),
|
||||||
|
).show(context, anchorDirection: AnchorDirection.bottomRight);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,3 +1,4 @@
|
||||||
|
import 'package:app_flowy/workspace/application/grid/grid_service.dart';
|
||||||
import 'package:app_flowy/workspace/application/grid/setting/setting_bloc.dart';
|
import 'package:app_flowy/workspace/application/grid/setting/setting_bloc.dart';
|
||||||
import 'package:easy_localization/easy_localization.dart';
|
import 'package:easy_localization/easy_localization.dart';
|
||||||
import 'package:flowy_infra/image.dart';
|
import 'package:flowy_infra/image.dart';
|
||||||
|
@ -18,11 +19,11 @@ import 'grid_property.dart';
|
||||||
|
|
||||||
class GridSettingContext {
|
class GridSettingContext {
|
||||||
final String gridId;
|
final String gridId;
|
||||||
final List<Field> fields;
|
final GridFieldCache fieldCache;
|
||||||
|
|
||||||
GridSettingContext({
|
GridSettingContext({
|
||||||
required this.gridId,
|
required this.gridId,
|
||||||
required this.fields,
|
required this.fieldCache,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -41,7 +42,7 @@ class GridSettingList extends StatelessWidget {
|
||||||
case GridSettingAction.sortBy:
|
case GridSettingAction.sortBy:
|
||||||
break;
|
break;
|
||||||
case GridSettingAction.properties:
|
case GridSettingAction.properties:
|
||||||
GridPropertyList(gridId: settingContext.gridId, fields: settingContext.fields).show(context);
|
GridPropertyList(gridId: settingContext.gridId, fieldCache: settingContext.fieldCache).show(context);
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
|
@ -1,3 +1,4 @@
|
||||||
|
import 'package:app_flowy/workspace/application/grid/grid_service.dart';
|
||||||
import 'package:flowy_infra/image.dart';
|
import 'package:flowy_infra/image.dart';
|
||||||
import 'package:flowy_infra/theme.dart';
|
import 'package:flowy_infra/theme.dart';
|
||||||
import 'package:flowy_infra_ui/style_widget/extension.dart';
|
import 'package:flowy_infra_ui/style_widget/extension.dart';
|
||||||
|
@ -12,10 +13,10 @@ import 'grid_setting.dart';
|
||||||
|
|
||||||
class GridToolbarContext {
|
class GridToolbarContext {
|
||||||
final String gridId;
|
final String gridId;
|
||||||
final List<Field> fields;
|
final GridFieldCache fieldCache;
|
||||||
GridToolbarContext({
|
GridToolbarContext({
|
||||||
required this.gridId,
|
required this.gridId,
|
||||||
required this.fields,
|
required this.fieldCache,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -27,7 +28,7 @@ class GridToolbar extends StatelessWidget {
|
||||||
Widget build(BuildContext context) {
|
Widget build(BuildContext context) {
|
||||||
final settingContext = GridSettingContext(
|
final settingContext = GridSettingContext(
|
||||||
gridId: toolbarContext.gridId,
|
gridId: toolbarContext.gridId,
|
||||||
fields: toolbarContext.fields,
|
fieldCache: toolbarContext.fieldCache,
|
||||||
);
|
);
|
||||||
return SizedBox(
|
return SizedBox(
|
||||||
height: 40,
|
height: 40,
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue