github-mirrors/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2025-04-25 15:17:28 -04:00
Code Issues Projects Releases Packages Wiki Activity

feat: scroll to block after selecting notification item (#6667)

Browse source 
* fix: scrollbar's ScrollController has no ScrollPosition attached

* feat: support scrolling to block after selecting notification item

* chore: remove debug print

* fix: unable to cancel block selection
This commit is contained in:
Lucas 2024-10-31 10:29:34 +08:00 • committed by GitHub
parent af6736d352
commit 873ab6cdc7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 83 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

11
frontend/appflowy_flutter/lib/plugins/document/document_page.dart
View file

@ -46,6 +46,7 @@ class DocumentPage extends StatefulWidget {
class _DocumentPageState extends State<DocumentPage>
with WidgetsBindingObserver {
EditorState? editorState;
Selection? initialSelection;
late final documentBloc = DocumentBloc(documentId: widget.view.id)
..add(const DocumentEvent.initial());
@ -120,6 +121,9 @@ class _DocumentPageState extends State<DocumentPage>
final width = context.read<DocumentAppearanceCubit>().state.width;
// avoid the initial selection calculation change when the editorState is not changed
initialSelection ??= _calculateInitialSelection(editorState);
final Widget child;
if (UniversalPlatform.isMobile) {
child = BlocBuilder<DocumentPageStyleBloc, DocumentPageStyleState>(
@ -133,7 +137,7 @@ class _DocumentPageState extends State<DocumentPage>
padding: EditorStyleCustomizer.documentPadding,
),
header: buildCoverAndIcon(context, state),
initialSelection: widget.initialSelection,
initialSelection: initialSelection,
),
);
} else {
@ -151,7 +155,7 @@ class _DocumentPageState extends State<DocumentPage>
padding: EditorStyleCustomizer.documentPadding,
),
header: buildCoverAndIcon(context, state),
initialSelection: _calculateInitialSelection(editorState),
initialSelection: initialSelection,
),
);
}
@ -299,6 +303,9 @@ class _DocumentPageState extends State<DocumentPage>
final path = _findNodePathByBlockId(editorState, widget.initialBlockId!);
if (path != null) {
editorState.selectionType = SelectionType.block;
editorState.selectionExtraInfo = {
selectionExtraInfoDoNotAttachTextService: true,
};
return Selection.collapsed(
Position(
path: path,