update node-ical to v0.17.1 (and other deps) (#3309)

- update `node-ical` to `v0.17.1` (and other deps)
- remove `luxon` (not needed anymore with new `node-ical` version)
- fix `navigator is not defined` errors in e2e tests when running with
Node `v20`

CHANGELOG.md

@@ -32,6 +32,7 @@ _This release is scheduled to be released on 2024-01-01._
 - Clock module: optionally display current moon phase in addition to rise/set times
 - electron is now per default started without gpu, if needed it must be enabled with new env var `ELECTRON_ENABLE_GPU=1` on startup (#3226)
 - Replace prettier by stylistic in ESLint config to lint JavaScript (and disable some rules for `config/config.js*` files)
+- Update node-ical to v0.17.1 and fix tests
 
 ### Fixed
 

package.json

@@ -62,13 +62,13 @@
 		"playwright": "^1.40.1",
 		"prettier": "^3.1.1",
 		"sinon": "^17.0.1",
-		"stylelint": "^16.0.2",
-		"stylelint-config-standard": "^35.0.0",
+		"stylelint": "^16.1.0",
+		"stylelint-config-standard": "^36.0.0",
 		"stylelint-prettier": "^5.0.0",
 		"suncalc": "^1.9.0"
 	},
 	"optionalDependencies": {
-		"electron": "^27.1.3"
+		"electron": "^27.2.0"
 	},
 	"dependencies": {
 		"colors": "^1.4.0",
@@ -82,10 +82,9 @@
 		"helmet": "^7.1.0",
 		"html-to-text": "^9.0.5",
 		"iconv-lite": "^0.6.3",
-		"luxon": "^1.28.1",
 		"module-alias": "^2.2.3",
-		"moment": "^2.29.4",
-		"node-ical": "0.16.1",
+		"moment": "^2.30.1",
+		"node-ical": "^0.17.1",
 		"socket.io": "^4.7.2"
 	},
 	"lint-staged": {

tests/e2e/helpers/global-setup.js

@@ -31,6 +31,11 @@ exports.getDocument = () => {
 		jsdom.JSDOM.fromURL(url, { resources: "usable", runScripts: "dangerously" }).then((dom) => {
 			dom.window.name = "jsdom";
 			global.window = dom.window;
+			// Following fixes `navigator is not defined` errors in e2e tests, found here
+			// https://www.appsloveworld.com/reactjs/100/37/mocha-react-navigator-is-not-defined
+			global.navigator = {
+				useragent: "node.js"
+			};
 			dom.window.fetch = fetch;
 			dom.window.onload = () => {
 				global.document = dom.window.document;

vendor/package-lock.json

@@ -9,7 +9,7 @@
 			"dependencies": {
 				"@fortawesome/fontawesome-free": "^6.5.1",
 				"animate.css": "^4.1.1",
-				"moment": "^2.29.4",
+				"moment": "^2.30.1",
 				"moment-timezone": "^0.5.43",
 				"nunjucks": "^3.2.4",
 				"suncalc": "^1.9.0",
@@ -49,9 +49,9 @@
 			}
 		},
 		"node_modules/moment": {
-			"version": "2.29.4",
-			"resolved": "https://registry.npmjs.org/moment/-/moment-2.29.4.tgz",
-			"integrity": "sha512-5LC9SOxjSc2HF6vO2CyuTDNivEdoz2IvyJJGj6X8DJ0eFyfszE0QiEd+iXmBvUP3WHxSjFH/vIsA0EN00cgr8w==",
+			"version": "2.30.1",
+			"resolved": "https://registry.npmjs.org/moment/-/moment-2.30.1.tgz",
+			"integrity": "sha512-uEmtNhbDOrWPFS+hdjFCBfy9f2YoyzRpwcl+DqpC6taX21FzsTLQVbMV/W7PzNSX6x/bhC1zA3c2UQ5NzH6how==",
 			"engines": {
 				"node": "*"
 			}

vendor/package.json

@@ -12,7 +12,7 @@
 	"dependencies": {
 		"@fortawesome/fontawesome-free": "^6.5.1",
 		"animate.css": "^4.1.1",
-		"moment": "^2.29.4",
+		"moment": "^2.30.1",
 		"moment-timezone": "^0.5.43",
 		"nunjucks": "^3.2.4",
 		"suncalc": "^1.9.0",