github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-06-28 17:34:17 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix ignores malformed testcase (#125337)

Browse source 
Fix and unmute testSynthesizeArrayRandomIgnoresMalformed
This commit is contained in:
Jordan Powers 2025-03-20 15:31:38 -07:00 • committed by GitHub
parent e9c4b267c2
commit 2ff03acf51
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
muted-tests.yml
View file

@ -393,9 +393,6 @@ tests:
- class: org.elasticsearch.reservedstate.service.ReservedClusterStateServiceTests - class: org.elasticsearch.reservedstate.service.ReservedClusterStateServiceTests
method: testProcessMultipleChunks method: testProcessMultipleChunks
issue: https://github.com/elastic/elasticsearch/issues/125305 issue: https://github.com/elastic/elasticsearch/issues/125305
- class: org.elasticsearch.index.mapper.NativeArrayIntegrationTestCase
method: testSynthesizeArrayRandomIgnoresMalformed
issue: https://github.com/elastic/elasticsearch/issues/125319
# Examples: # Examples:
# #

8
server/src/test/java/org/elasticsearch/index/mapper/NativeArrayIntegrationTestCase.java
View file

@ -83,10 +83,10 @@ public abstract class NativeArrayIntegrationTestCase extends ESSingleNodeTestCas
var expectedDocument = jsonBuilder().startObject(); var expectedDocument = jsonBuilder().startObject();
var inputDocument = jsonBuilder().startObject(); var inputDocument = jsonBuilder().startObject();
boolean expectedContainsArray = values.length > 0 || malformed.length > 1; boolean expectedIsArray = values.length != 0 || malformed.length != 1;
if (expectedContainsArray) { if (expectedIsArray) {
expectedDocument.startArray("field"); expectedDocument.startArray("field");
} else if (malformed.length > 0) { } else {
expectedDocument.field("field"); expectedDocument.field("field");
} }
inputDocument.startArray("field"); inputDocument.startArray("field");
@ -113,7 +113,7 @@ public abstract class NativeArrayIntegrationTestCase extends ESSingleNodeTestCas
} }
} }
if (expectedContainsArray) { if (expectedIsArray) {
expectedDocument.endArray(); expectedDocument.endArray();
} }
expectedDocument.endObject(); expectedDocument.endObject();