github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-06-28 17:34:17 -04:00
Code Issues Projects Releases Packages Wiki Activity

Validate alias names the same as index names

Browse source 
Applied (almost) the same rules we use to validate index names
to new alias names. The only rule not applies it "must be lowercase".
We have tests that don't follow that rule and I except there are lots
of examples of camelCase alias names in the wild. We can add that
validation but I'm not sure it is worth it.

Closes #20748

Adds an alias that starts with `#` to the BWC index and validates
that you can read from it and remove it. Starting with `#` isn't
allowed after 5.1.0/6.0.0 so we don't create the alias or check it
after those versions.
This commit is contained in:
Nik Everett 2016-10-05 16:24:22 -04:00
parent cc2743743c
commit 3787ea27bf
50 changed files with 144 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
dev-tools/create_bwc_index.py
View file

@ -103,7 +103,7 @@ def delete_by_query(es, version, index_name, doc_type):
return
deleted_count = es.count(index=index_name, doc_type=doc_type, body=query)['count']
result = es.delete_by_query(index=index_name,
doc_type=doc_type,
body=query)
@ -113,9 +113,13 @@ def delete_by_query(es, version, index_name, doc_type):
logging.info('Deleted %d docs' % deleted_count)
def run_basic_asserts(es, index_name, type, num_docs):
def run_basic_asserts(es, version, index_name, type, num_docs):
count = es.count(index=index_name)['count']
assert count == num_docs, 'Expected %r but got %r documents' % (num_docs, count)
if parse_version(version) < parse_version('5.1.0'):
# This alias isn't allowed to be created after 5.1 so we can verify that we can still use it
count = es.count(index='#' + index_name)['count']
assert count == num_docs, 'Expected %r but got %r documents' % (num_docs, count)
for _ in range(0, num_docs):
random_doc_id = random.randint(0, num_docs-1)
doc = es.get(index=index_name, doc_type=type, id=random_doc_id)
@ -360,8 +364,11 @@ def generate_index(client, version, index_name):
# see https://github.com/elastic/elasticsearch/issues/5817
num_docs = int(num_docs / 10)
index_documents(client, index_name, 'doc', num_docs, supports_dots_in_field_names)
if parse_version(version) < parse_version('5.1.0'):
logging.info("Adding a alias that can't be created in 5.1+ so we can assert that we can still use it")
client.indices.put_alias(index=index_name, name='#' + index_name)
logging.info('Running basic asserts on the data added')
run_basic_asserts(client, index_name, 'doc', num_docs)
run_basic_asserts(client, version, index_name, 'doc', num_docs)
return num_docs, supports_dots_in_field_names
def snapshot_index(client, version, repo_dir):
@ -494,7 +501,7 @@ def create_bwc_index(cfg, version):
if node is not None:
# This only happens if we've hit an exception:
shutdown_node(node)
shutil.rmtree(tmp_dir)
def shutdown_node(node):
@ -533,4 +540,3 @@ if __name__ == '__main__':
main()
except KeyboardInterrupt:
print('Caught keyboard interrupt, exiting...')