Tests: only build the IndexMetadata once

This commit is contained in:
Andrei Dan 2020-04-06 21:35:27 +01:00
parent a114549697
commit 48cbca1de4
2 changed files with 6 additions and 4 deletions

View file

@ -65,14 +65,15 @@ public class CopySettingsStepTests extends AbstractStepTestCase<CopySettingsStep
IndexMetadata.Builder targetIndexMetadataBuilder = IndexMetadata.builder(targetIndex).settings(settings(Version.CURRENT)) IndexMetadata.Builder targetIndexMetadataBuilder = IndexMetadata.builder(targetIndex).settings(settings(Version.CURRENT))
.numberOfShards(randomIntBetween(1, 5)).numberOfReplicas(randomIntBetween(0, 5)); .numberOfShards(randomIntBetween(1, 5)).numberOfReplicas(randomIntBetween(0, 5));
IndexMetadata sourceIndexMetadata = sourceIndexMetadataBuilder.build();
ClusterState clusterState = ClusterState.builder(emptyClusterState()).metadata( ClusterState clusterState = ClusterState.builder(emptyClusterState()).metadata(
Metadata.builder().put(sourceIndexMetadataBuilder).put(targetIndexMetadataBuilder).build() Metadata.builder().put(sourceIndexMetadata, true).put(targetIndexMetadataBuilder).build()
).build(); ).build();
CopySettingsStep copySettingsStep = new CopySettingsStep(randomStepKey(), randomStepKey(), indexPrefix, CopySettingsStep copySettingsStep = new CopySettingsStep(randomStepKey(), randomStepKey(), indexPrefix,
LifecycleSettings.LIFECYCLE_NAME); LifecycleSettings.LIFECYCLE_NAME);
ClusterState newClusterState = copySettingsStep.performAction(sourceIndexMetadataBuilder.build().getIndex(), clusterState); ClusterState newClusterState = copySettingsStep.performAction(sourceIndexMetadata.getIndex(), clusterState);
IndexMetadata newTargetIndexMetadata = newClusterState.metadata().index(targetIndex); IndexMetadata newTargetIndexMetadata = newClusterState.metadata().index(targetIndex);
assertThat(newTargetIndexMetadata.getSettings().get(LifecycleSettings.LIFECYCLE_NAME), is(policyName)); assertThat(newTargetIndexMetadata.getSettings().get(LifecycleSettings.LIFECYCLE_NAME), is(policyName));
} }

View file

@ -64,11 +64,12 @@ public class GenerateSnapshotNameStepTests extends AbstractStepTestCase<Generate
IndexMetadata.builder(indexName).settings(settings(Version.CURRENT).put(LifecycleSettings.LIFECYCLE_NAME, policyName)) IndexMetadata.builder(indexName).settings(settings(Version.CURRENT).put(LifecycleSettings.LIFECYCLE_NAME, policyName))
.numberOfShards(randomIntBetween(1, 5)).numberOfReplicas(randomIntBetween(0, 5)); .numberOfShards(randomIntBetween(1, 5)).numberOfReplicas(randomIntBetween(0, 5));
IndexMetadata indexMetadata = indexMetadataBuilder.build();
ClusterState clusterState = ClusterState clusterState =
ClusterState.builder(emptyClusterState()).metadata(Metadata.builder().put(indexMetadataBuilder).build()).build(); ClusterState.builder(emptyClusterState()).metadata(Metadata.builder().put(indexMetadata, true).build()).build();
GenerateSnapshotNameStep generateSnapshotNameStep = createRandomInstance(); GenerateSnapshotNameStep generateSnapshotNameStep = createRandomInstance();
ClusterState newClusterState = generateSnapshotNameStep.performAction(indexMetadataBuilder.build().getIndex(), clusterState); ClusterState newClusterState = generateSnapshotNameStep.performAction(indexMetadata.getIndex(), clusterState);
LifecycleExecutionState executionState = LifecycleExecutionState.fromIndexMetadata(newClusterState.metadata().index(indexName)); LifecycleExecutionState executionState = LifecycleExecutionState.fromIndexMetadata(newClusterState.metadata().index(indexName));
assertThat("the " + GenerateSnapshotNameStep.NAME + " step must generate a snapshot name", executionState.getSnapshotName(), assertThat("the " + GenerateSnapshotNameStep.NAME + " step must generate a snapshot name", executionState.getSnapshotName(),