github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-06-28 17:34:17 -04:00
Code Issues Projects Releases Packages Wiki Activity

Reenable TestingConventionsPrecommitPluginFuncTest on windows (#88240)

Browse source 
Addressing #87913 by fixing LocalRepositoryFixture on windows
This commit is contained in:
Rene Groeschke 2022-07-04 13:58:53 +02:00 • committed by GitHub
parent 40de25b12e
commit 4c7ed5fc9f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/fixtures/LocalRepositoryFixture.groovy
View file

@ -56,7 +56,7 @@ class LocalRepositoryFixture extends ExternalResource{
repositories { repositories {
maven { maven {
name = "local-test" name = "local-test"
url = "${getRepoDir()}" url = "${getRepoDir().toURI()}"
metadataSources { metadataSources {
artifact() artifact()
} }

4
build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/precommit/TestingConventionsPrecommitPluginFuncTest.groovy
View file

@ -13,13 +13,9 @@ import org.elasticsearch.gradle.fixtures.LocalRepositoryFixture
import org.elasticsearch.gradle.internal.conventions.precommit.PrecommitPlugin import org.elasticsearch.gradle.internal.conventions.precommit.PrecommitPlugin
import org.gradle.testkit.runner.TaskOutcome import org.gradle.testkit.runner.TaskOutcome
import org.junit.ClassRule import org.junit.ClassRule
import org.junit.rules.TemporaryFolder
import spock.lang.IgnoreIf
import spock.lang.Shared import spock.lang.Shared
import spock.lang.Unroll import spock.lang.Unroll
// see https://github.com/elastic/elasticsearch/issues/87913
@IgnoreIf({ os.windows })
class TestingConventionsPrecommitPluginFuncTest extends AbstractGradleInternalPluginFuncTest { class TestingConventionsPrecommitPluginFuncTest extends AbstractGradleInternalPluginFuncTest {
Class<? extends PrecommitPlugin> pluginClassUnderTest = TestingConventionsPrecommitPlugin.class Class<? extends PrecommitPlugin> pluginClassUnderTest = TestingConventionsPrecommitPlugin.class