github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-06-28 17:34:17 -04:00
Code Issues Projects Releases Packages Wiki Activity

Send error_trace by default when testing (#22195)

Browse source 
Sends the `error_trace` parameter with all requests sent by the
yaml test framework, including the doc snippet tests. This can be
overridden by settings `error_trace: false`. While this drift's
core's handling of the yaml tests from the client's slightly this
should only be a problem for tests that rely on the default value,
both of which I've fixed by setting the value explicitly.

This also escapes `\n` and `\t` in the `Stash dump on failure` so
the `stack_trace` is more readable.

Also fixes `RestUpdateSettingsAction` to not think of the `error_trace`
parameter as a setting.
This commit is contained in:
Nik Everett 2016-12-15 13:35:14 -05:00 • committed by GitHub
parent df43c268da
commit 61597f2c20
7 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
docs/reference/modules/scripting/painless-debugging.asciidoc
View file

@ -33,7 +33,9 @@ POST /hockey/player/1/_explain
}
---------------------------------------------------------
// CONSOLE
// TEST[catch:/painless_explain_error/]
// TEST[s/_explain/_explain?error_trace=false/ catch:/painless_explain_error/]
// The test system sends error_trace=true by default for easier debugging so
// we have to override it to get a normal shaped response
Which shows that the class of `doc.first` is
`org.elasticsearch.index.fielddata.ScriptDocValues$Longs` by responding with:
@ -63,7 +65,7 @@ POST /hockey/player/1/_update
}
---------------------------------------------------------
// CONSOLE
// TEST[continued catch:/painless_explain_error/]
// TEST[continued s/_update/_update?error_trace=false/ catch:/painless_explain_error/]
The response looks like: