github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-04-19 04:45:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

FileWatchingService should not throw for missing file (#126264)

Browse source 
Missing file is a valid state for FileWatchingService so that the
exception should be suppressed.
This commit is contained in:
Yang Wang 2025-04-08 09:56:35 +10:00 • committed by GitHub
parent 991e80d56e
commit 997a7b8fab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
docs/changelog/126264.yaml Normal file
View file

@ -0,0 +1,5 @@
pr: 126264
summary: '`FileWatchingService` shoudld not throw for missing file'
area: Infra/Settings
type: enhancement
issues: []

6
server/src/main/java/org/elasticsearch/common/file/AbstractFileWatchingService.java
View file

@ -116,15 +116,13 @@ public abstract class AbstractFileWatchingService extends AbstractLifecycleCompo
} }
private FileUpdateState readFileUpdateState(Path path) throws IOException { private FileUpdateState readFileUpdateState(Path path) throws IOException {
BasicFileAttributes attr;
try { try {
attr = filesReadAttributes(path, BasicFileAttributes.class); BasicFileAttributes attr = filesReadAttributes(path, BasicFileAttributes.class);
return new FileUpdateState(attr.lastModifiedTime().toMillis(), path.toRealPath().toString(), attr.fileKey());
} catch (NoSuchFileException e) { } catch (NoSuchFileException e) {
// file doesn't exist anymore // file doesn't exist anymore
return null; return null;
} }
return new FileUpdateState(attr.lastModifiedTime().toMillis(), path.toRealPath().toString(), attr.fileKey());
} }
// platform independent way to tell if a file changed // platform independent way to tell if a file changed