github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-06-28 09:28:55 -04:00
Code Issues Projects Releases Packages Wiki Activity

Check REST test nodes LeakTracker like we check Netty's LeakDetector (#108540)

Browse source 
We should make sure to find leaks reported by both of these, these days
our `LeakTracker` will likely be more sensitive that Netty's in some
cases since our objects refer to Netty objects and thus get collected
first.
This commit is contained in:
Armin Braun 2024-05-14 21:13:52 +02:00 • committed by GitHub
parent b0f205fa74
commit c2f528e5a4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
View file

@ -1107,11 +1107,11 @@ public class ElasticsearchNode implements TestClusterConfiguration {
return; return;
} }
boolean foundNettyLeaks = false; boolean foundLeaks = false;
for (String logLine : errorsAndWarnings.keySet()) { for (String logLine : errorsAndWarnings.keySet()) {
if (logLine.contains("ResourceLeakDetector]")) { if (logLine.contains("ResourceLeakDetector") || logLine.contains("LeakTracker")) {
tailLogs = true; tailLogs = true;
foundNettyLeaks = true; foundLeaks = true;
break; break;
} }
} }
@ -1140,8 +1140,8 @@ public class ElasticsearchNode implements TestClusterConfiguration {
}); });
} }
} }
if (foundNettyLeaks) { if (foundLeaks) {
throw new TestClustersException("Found Netty ByteBuf leaks in node logs."); throw new TestClustersException("Found resource leaks in node logs.");
} }
} }