github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-06-28 09:28:55 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ES|QL] Change rounding mode in tests to HALF_DOWN (#129895)

Browse source 
The current rounding mode in some of the tests in ESQL uses DOWN which
truncates more than rounds and can result in some tests failing with
errors like `row 0 column 0:0: expected <0.05235999> but was <0.05236>`
HALF_DOWN would round this up
This commit is contained in:
Larisa Motova 2025-06-23 21:22:36 -10:00 • committed by GitHub
parent d3049e03e1
commit c94bd1cf24
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java
View file

@ -371,9 +371,9 @@ public abstract class EsqlSpecTestCase extends ESRestTestCase {
}
return values;
} else if (value instanceof Double d) {
return new BigDecimal(d).round(new MathContext(7, RoundingMode.DOWN)).doubleValue();
return new BigDecimal(d).round(new MathContext(7, RoundingMode.HALF_DOWN)).doubleValue();
} else if (value instanceof String s) {
return new BigDecimal(s).round(new MathContext(7, RoundingMode.DOWN)).doubleValue();
return new BigDecimal(s).round(new MathContext(7, RoundingMode.HALF_DOWN)).doubleValue();
}
}
if (type == CsvTestUtils.Type.TEXT || type == CsvTestUtils.Type.KEYWORD || type == CsvTestUtils.Type.SEMANTIC_TEXT) {