github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-06-27 17:10:22 -04:00
Code Issues Projects Releases Packages Wiki Activity

Restore TextSimilarityRankBuilder XContent output (#124564)

Browse source
This commit is contained in:
Simon Cooper 2025-03-11 16:03:04 +00:00 • committed by GitHub
parent 2187c252b5
commit d8e889acb6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
docs/changelog/124564.yaml Normal file
View file

@ -0,0 +1,5 @@
pr: 124564
summary: Restore `TextSimilarityRankBuilder` XContent output
area: Ranking
type: bug
issues: []

18
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/rank/textsimilarity/TextSimilarityRankBuilder.java
View file

@ -30,6 +30,12 @@ import java.io.IOException;
import java.util.List;
import java.util.Objects;
import static org.elasticsearch.xpack.inference.rank.textsimilarity.TextSimilarityRankRetrieverBuilder.FAILURES_ALLOWED_FIELD;
import static org.elasticsearch.xpack.inference.rank.textsimilarity.TextSimilarityRankRetrieverBuilder.FIELD_FIELD;
import static org.elasticsearch.xpack.inference.rank.textsimilarity.TextSimilarityRankRetrieverBuilder.INFERENCE_ID_FIELD;
import static org.elasticsearch.xpack.inference.rank.textsimilarity.TextSimilarityRankRetrieverBuilder.INFERENCE_TEXT_FIELD;
import static org.elasticsearch.xpack.inference.rank.textsimilarity.TextSimilarityRankRetrieverBuilder.MIN_SCORE_FIELD;
/**
* A {@code RankBuilder} that enables ranking with text similarity model inference. Supports parameters for configuring the inference call.
*/
@ -103,7 +109,17 @@ public class TextSimilarityRankBuilder extends RankBuilder {
@Override
public void doXContent(XContentBuilder builder, Params params) throws IOException {
throw new UnsupportedOperationException("This should not be XContent serialized");
// this object is not parsed, but it sometimes needs to be output as xcontent
// rankWindowSize serialization is handled by the parent class RankBuilder
builder.field(INFERENCE_ID_FIELD.getPreferredName(), inferenceId);
builder.field(INFERENCE_TEXT_FIELD.getPreferredName(), inferenceText);
builder.field(FIELD_FIELD.getPreferredName(), field);
if (minScore != null) {
builder.field(MIN_SCORE_FIELD.getPreferredName(), minScore);
}
if (failuresAllowed) {
builder.field(FAILURES_ALLOWED_FIELD.getPreferredName(), true);
}
}
@Override