Fix resource leak in CrossClusterSearchUnavailableClusterIT (#124880)

Fixes https://github.com/elastic/elasticsearch/issues/123814
This commit is contained in:
Michael Peterson 2025-03-14 13:53:32 -04:00 committed by GitHub
parent b76048ddd2
commit eee890a783
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -91,7 +91,12 @@ public class CrossClusterSearchUnavailableClusterIT extends ESRestTestCase {
EsExecutors.DIRECT_EXECUTOR_SERVICE, EsExecutors.DIRECT_EXECUTOR_SERVICE,
SearchShardsRequest::new, SearchShardsRequest::new,
(request, channel, task) -> { (request, channel, task) -> {
channel.sendResponse(new SearchShardsResponse(List.of(), List.of(), Collections.emptyMap())); var searchShardsResponse = new SearchShardsResponse(List.of(), List.of(), Collections.emptyMap());
try {
channel.sendResponse(searchShardsResponse);
} finally {
searchShardsResponse.decRef();
}
} }
); );
newService.registerRequestHandler( newService.registerRequestHandler(
@ -119,7 +124,12 @@ public class CrossClusterSearchUnavailableClusterIT extends ESRestTestCase {
builder.add(node); builder.add(node);
} }
ClusterState build = ClusterState.builder(clusterName).nodes(builder.build()).build(); ClusterState build = ClusterState.builder(clusterName).nodes(builder.build()).build();
channel.sendResponse(new ClusterStateResponse(clusterName, build, false)); var clusterStateResponse = new ClusterStateResponse(clusterName, build, false);
try {
channel.sendResponse(clusterStateResponse);
} finally {
clusterStateResponse.decRef();
}
} }
); );
newService.start(); newService.start();